All of lore.kernel.org
 help / color / mirror / Atom feed
* 5.10.y Kernel Panic while poweroff and reboot - Null Pointer Exception - with TPM-Module SLB 9670
       [not found] <20210322205720.12F8CC061756@lindbergh.monkeyblade.net>
@ 2021-03-22 21:01 ` Paul Enuta
  2021-03-23  2:09   ` Jarkko Sakkinen
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Enuta @ 2021-03-22 21:01 UTC (permalink / raw)
  To: linux-integrity

Dear all,

As described in the issue here:
 https://github.com/raspberrypi/linux/issues/4228
and here:
 https://www.raspberrypi.org/forums/viewtopic.php?f=75&t=303564&p=1817702#p1839351
starting with kernel 5.10.XX we encounter a system hang with kernel
panic at poweroff or reboot if we have dtoverlay=tpm-slb9670 loaded.
Applying the patch proposed here:
https://github.com/raspberrypi/linux/issues/4228#issuecomment-804081079
and rebuilding the kernel solves the issue.

Please review the issue and provide guidance finding the cause and solving.

Kind regards,
Paul Enuta

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 5.10.y Kernel Panic while poweroff and reboot - Null Pointer Exception - with TPM-Module SLB 9670
  2021-03-22 21:01 ` 5.10.y Kernel Panic while poweroff and reboot - Null Pointer Exception - with TPM-Module SLB 9670 Paul Enuta
@ 2021-03-23  2:09   ` Jarkko Sakkinen
  2021-03-23  5:51     ` Paul Enuta
  0 siblings, 1 reply; 6+ messages in thread
From: Jarkko Sakkinen @ 2021-03-23  2:09 UTC (permalink / raw)
  To: Paul Enuta; +Cc: linux-integrity

On Mon, Mar 22, 2021 at 11:01:09PM +0200, Paul Enuta wrote:
> Dear all,
> 
> As described in the issue here:
>  https://github.com/raspberrypi/linux/issues/4228
> and here:
>  https://www.raspberrypi.org/forums/viewtopic.php?f=75&t=303564&p=1817702#p1839351
> starting with kernel 5.10.XX we encounter a system hang with kernel
> panic at poweroff or reboot if we have dtoverlay=tpm-slb9670 loaded.
> Applying the patch proposed here:
> https://github.com/raspberrypi/linux/issues/4228#issuecomment-804081079
> and rebuilding the kernel solves the issue.
> 
> Please review the issue and provide guidance finding the cause and solving.
> 
> Kind regards,
> Paul Enuta


So does this happen with the latest mainline? Patched kernels are not our
concern.


/Jarkko

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 5.10.y Kernel Panic while poweroff and reboot - Null Pointer Exception - with TPM-Module SLB 9670
  2021-03-23  2:09   ` Jarkko Sakkinen
@ 2021-03-23  5:51     ` Paul Enuta
  2021-03-23  7:04       ` Paul Enuta
  2021-03-23 16:25       ` Jarkko Sakkinen
  0 siblings, 2 replies; 6+ messages in thread
From: Paul Enuta @ 2021-03-23  5:51 UTC (permalink / raw)
  To: Jarkko Sakkinen; +Cc: linux-integrity

Hi,
it happens with 5.10.25-v7l (latest mainline in Raspberry PI OS) and
in my test it started with 5.10.0-v7+.
5.4.83-v7+ was OK.
Problems occur on fresh and clean installs with kernel versions above 5.10.
This quick fix solves:
--- tpm-chip.c.orig 2021-03-22 17:43:05.433433496 +0000
+++ tpm-chip.c 2021-03-22 18:22:52.000000000 +0000
@@ -101,6 +101,11 @@
 {
  int ret;

+    if (!chip->ops) {
+            pr_err("%s: Avoiding NULL ops pointer\n", __func__);
+            return -EIO;
+    }
+
  tpm_clk_enable(chip);

  if (chip->locality == -1) {

On Tue, Mar 23, 2021 at 4:09 AM Jarkko Sakkinen <jarkko@kernel.org> wrote:
>
> On Mon, Mar 22, 2021 at 11:01:09PM +0200, Paul Enuta wrote:
> > Dear all,
> >
> > As described in the issue here:
> >  https://github.com/raspberrypi/linux/issues/4228
> > and here:
> >  https://www.raspberrypi.org/forums/viewtopic.php?f=75&t=303564&p=1817702#p1839351
> > starting with kernel 5.10.XX we encounter a system hang with kernel
> > panic at poweroff or reboot if we have dtoverlay=tpm-slb9670 loaded.
> > Applying the patch proposed here:
> > https://github.com/raspberrypi/linux/issues/4228#issuecomment-804081079
> > and rebuilding the kernel solves the issue.
> >
> > Please review the issue and provide guidance finding the cause and solving.
> >
> > Kind regards,
> > Paul Enuta
>
>
> So does this happen with the latest mainline? Patched kernels are not our
> concern.
>
>
> /Jarkko

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 5.10.y Kernel Panic while poweroff and reboot - Null Pointer Exception - with TPM-Module SLB 9670
  2021-03-23  5:51     ` Paul Enuta
@ 2021-03-23  7:04       ` Paul Enuta
  2021-03-23 16:25       ` Jarkko Sakkinen
  1 sibling, 0 replies; 6+ messages in thread
From: Paul Enuta @ 2021-03-23  7:04 UTC (permalink / raw)
  To: Jarkko Sakkinen; +Cc: linux-integrity

I only found this commit
https://github.com/raspberrypi/linux/commit/1e5ac6300a07ceecfc70a893ebef3352be21e6f8#
related to the problem.

BR,
Paul

On Tue, Mar 23, 2021 at 7:51 AM Paul Enuta <paulenuta@gmail.com> wrote:
>
> Hi,
> it happens with 5.10.25-v7l (latest mainline in Raspberry PI OS) and
> in my test it started with 5.10.0-v7+.
> 5.4.83-v7+ was OK.
> Problems occur on fresh and clean installs with kernel versions above 5.10.
> This quick fix solves:
> --- tpm-chip.c.orig 2021-03-22 17:43:05.433433496 +0000
> +++ tpm-chip.c 2021-03-22 18:22:52.000000000 +0000
> @@ -101,6 +101,11 @@
>  {
>   int ret;
>
> +    if (!chip->ops) {
> +            pr_err("%s: Avoiding NULL ops pointer\n", __func__);
> +            return -EIO;
> +    }
> +
>   tpm_clk_enable(chip);
>
>   if (chip->locality == -1) {
>
> On Tue, Mar 23, 2021 at 4:09 AM Jarkko Sakkinen <jarkko@kernel.org> wrote:
> >
> > On Mon, Mar 22, 2021 at 11:01:09PM +0200, Paul Enuta wrote:
> > > Dear all,
> > >
> > > As described in the issue here:
> > >  https://github.com/raspberrypi/linux/issues/4228
> > > and here:
> > >  https://www.raspberrypi.org/forums/viewtopic.php?f=75&t=303564&p=1817702#p1839351
> > > starting with kernel 5.10.XX we encounter a system hang with kernel
> > > panic at poweroff or reboot if we have dtoverlay=tpm-slb9670 loaded.
> > > Applying the patch proposed here:
> > > https://github.com/raspberrypi/linux/issues/4228#issuecomment-804081079
> > > and rebuilding the kernel solves the issue.
> > >
> > > Please review the issue and provide guidance finding the cause and solving.
> > >
> > > Kind regards,
> > > Paul Enuta
> >
> >
> > So does this happen with the latest mainline? Patched kernels are not our
> > concern.
> >
> >
> > /Jarkko

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 5.10.y Kernel Panic while poweroff and reboot - Null Pointer Exception - with TPM-Module SLB 9670
  2021-03-23  5:51     ` Paul Enuta
  2021-03-23  7:04       ` Paul Enuta
@ 2021-03-23 16:25       ` Jarkko Sakkinen
  2021-03-23 16:37         ` Jarkko Sakkinen
  1 sibling, 1 reply; 6+ messages in thread
From: Jarkko Sakkinen @ 2021-03-23 16:25 UTC (permalink / raw)
  To: Paul Enuta; +Cc: linux-integrity

On Tue, Mar 23, 2021 at 07:51:53AM +0200, Paul Enuta wrote:
> Hi,
> it happens with 5.10.25-v7l (latest mainline in Raspberry PI OS) and
> in my test it started with 5.10.0-v7+.
> 5.4.83-v7+ was OK.
> Problems occur on fresh and clean installs with kernel versions above 5.10.
> This quick fix solves:
> --- tpm-chip.c.orig 2021-03-22 17:43:05.433433496 +0000
> +++ tpm-chip.c 2021-03-22 18:22:52.000000000 +0000
> @@ -101,6 +101,11 @@
>  {
>   int ret;
> 
> +    if (!chip->ops) {
> +            pr_err("%s: Avoiding NULL ops pointer\n", __func__);
> +            return -EIO;
> +    }
> +
>   tpm_clk_enable(chip);
> 
>   if (chip->locality == -1) {
> 

Please try with the actual mainline. We don't care about RPi kernel.

> On Tue, Mar 23, 2021 at 4:09 AM Jarkko Sakkinen <jarkko@kernel.org> wrote:
> >
> > On Mon, Mar 22, 2021 at 11:01:09PM +0200, Paul Enuta wrote:
> > > Dear all,
> > >
> > > As described in the issue here:
> > >  https://github.com/raspberrypi/linux/issues/4228
> > > and here:
> > >  https://www.raspberrypi.org/forums/viewtopic.php?f=75&t=303564&p=1817702#p1839351
> > > starting with kernel 5.10.XX we encounter a system hang with kernel
> > > panic at poweroff or reboot if we have dtoverlay=tpm-slb9670 loaded.
> > > Applying the patch proposed here:
> > > https://github.com/raspberrypi/linux/issues/4228#issuecomment-804081079
> > > and rebuilding the kernel solves the issue.
> > >
> > > Please review the issue and provide guidance finding the cause and solving.
> > >
> > > Kind regards,
> > > Paul Enuta
> >
> >
> > So does this happen with the latest mainline? Patched kernels are not our
> > concern.
> >
> >
> > /Jarkko
> 

/Jarkko

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 5.10.y Kernel Panic while poweroff and reboot - Null Pointer Exception - with TPM-Module SLB 9670
  2021-03-23 16:25       ` Jarkko Sakkinen
@ 2021-03-23 16:37         ` Jarkko Sakkinen
  0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2021-03-23 16:37 UTC (permalink / raw)
  To: Paul Enuta; +Cc: linux-integrity

On Tue, Mar 23, 2021 at 06:25:59PM +0200, Jarkko Sakkinen wrote:
> On Tue, Mar 23, 2021 at 07:51:53AM +0200, Paul Enuta wrote:
> > Hi,
> > it happens with 5.10.25-v7l (latest mainline in Raspberry PI OS) and
> > in my test it started with 5.10.0-v7+.
> > 5.4.83-v7+ was OK.
> > Problems occur on fresh and clean installs with kernel versions above 5.10.
> > This quick fix solves:
> > --- tpm-chip.c.orig 2021-03-22 17:43:05.433433496 +0000
> > +++ tpm-chip.c 2021-03-22 18:22:52.000000000 +0000
> > @@ -101,6 +101,11 @@
> >  {
> >   int ret;
> > 
> > +    if (!chip->ops) {
> > +            pr_err("%s: Avoiding NULL ops pointer\n", __func__);
> > +            return -EIO;
> > +    }
> > +
> >   tpm_clk_enable(chip);
> > 
> >   if (chip->locality == -1) {
> > 
> 
> Please try with the actual mainline. We don't care about RPi kernel.

AFAIK you can compile BuildRoot for RPi and try vanilla mainline with that.
I cannot provide any support for that but at least it is a build target.

/Jarkko

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-03-23 16:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210322205720.12F8CC061756@lindbergh.monkeyblade.net>
2021-03-22 21:01 ` 5.10.y Kernel Panic while poweroff and reboot - Null Pointer Exception - with TPM-Module SLB 9670 Paul Enuta
2021-03-23  2:09   ` Jarkko Sakkinen
2021-03-23  5:51     ` Paul Enuta
2021-03-23  7:04       ` Paul Enuta
2021-03-23 16:25       ` Jarkko Sakkinen
2021-03-23 16:37         ` Jarkko Sakkinen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.