* PR 193 sitting for uClibC fix @ 2020-03-26 16:21 William Roberts 2020-03-26 16:45 ` Stephen Smalley 0 siblings, 1 reply; 6+ messages in thread From: William Roberts @ 2020-03-26 16:21 UTC (permalink / raw) To: SElinux list This PR: https://github.com/SELinuxProject/selinux/pull/193 Has been sitting forever. I looked through the mailing list and didn't see any patches hit the list, we should either close it, or merge it. Thoughts? If we need it to hit the list, can I grab it and sign-off on it and post it? Bill ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PR 193 sitting for uClibC fix 2020-03-26 16:21 PR 193 sitting for uClibC fix William Roberts @ 2020-03-26 16:45 ` Stephen Smalley 2020-03-26 16:46 ` William Roberts 0 siblings, 1 reply; 6+ messages in thread From: Stephen Smalley @ 2020-03-26 16:45 UTC (permalink / raw) To: William Roberts; +Cc: SElinux list On Thu, Mar 26, 2020 at 12:22 PM William Roberts <bill.c.roberts@gmail.com> wrote: > > This PR: > https://github.com/SELinuxProject/selinux/pull/193 > > Has been sitting forever. I looked through the mailing list and didn't > see any patches hit the list, > we should either close it, or merge it. > > Thoughts? If we need it to hit the list, can I grab it and sign-off on > it and post it? You can't sign-off on someone else's patch without them first signing off on it or otherwise certifying to you that it falls under clauses (a), (b), or (c) of the DCO. You could create your own patch to achieve the same end, especially since this one is trivial and seems to be modeled after an existing commit, ab0e27003ef245f20512d1808b1dfee662ab8f41, so it seems like it is relatively safe. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PR 193 sitting for uClibC fix 2020-03-26 16:45 ` Stephen Smalley @ 2020-03-26 16:46 ` William Roberts 2020-03-26 16:52 ` Stephen Smalley 0 siblings, 1 reply; 6+ messages in thread From: William Roberts @ 2020-03-26 16:46 UTC (permalink / raw) To: Stephen Smalley; +Cc: SElinux list On Thu, Mar 26, 2020 at 11:44 AM Stephen Smalley <stephen.smalley.work@gmail.com> wrote: > > On Thu, Mar 26, 2020 at 12:22 PM William Roberts > <bill.c.roberts@gmail.com> wrote: > > > > This PR: > > https://github.com/SELinuxProject/selinux/pull/193 > > > > Has been sitting forever. I looked through the mailing list and didn't > > see any patches hit the list, > > we should either close it, or merge it. > > > > Thoughts? If we need it to hit the list, can I grab it and sign-off on > > it and post it? > > You can't sign-off on someone else's patch without them first signing off on it > or otherwise certifying to you that it falls under clauses (a), (b), > or (c) of the DCO. For some reason I just assumed it had a signed-off line, it doesn't though. > You could create your own patch to achieve the same end, especially > since this one is trivial and seems > to be modeled after an existing commit, > ab0e27003ef245f20512d1808b1dfee662ab8f41, so it > seems like it is relatively safe. I thought about creating it, but it's like how do I create such a trivial patch and not get hit with I copied it. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PR 193 sitting for uClibC fix 2020-03-26 16:46 ` William Roberts @ 2020-03-26 16:52 ` Stephen Smalley 2020-03-26 16:58 ` Stephen Smalley 0 siblings, 1 reply; 6+ messages in thread From: Stephen Smalley @ 2020-03-26 16:52 UTC (permalink / raw) To: William Roberts; +Cc: SElinux list On Thu, Mar 26, 2020 at 12:46 PM William Roberts <bill.c.roberts@gmail.com> wrote: > > On Thu, Mar 26, 2020 at 11:44 AM Stephen Smalley > <stephen.smalley.work@gmail.com> wrote: > > > > On Thu, Mar 26, 2020 at 12:22 PM William Roberts > > <bill.c.roberts@gmail.com> wrote: > > > > > > This PR: > > > https://github.com/SELinuxProject/selinux/pull/193 > > > > > > Has been sitting forever. I looked through the mailing list and didn't > > > see any patches hit the list, > > > we should either close it, or merge it. > > > > > > Thoughts? If we need it to hit the list, can I grab it and sign-off on > > > it and post it? > > > > You can't sign-off on someone else's patch without them first signing off on it > > or otherwise certifying to you that it falls under clauses (a), (b), > > or (c) of the DCO. > > For some reason I just assumed it had a signed-off line, it doesn't though. > > > You could create your own patch to achieve the same end, especially > > since this one is trivial and seems > > to be modeled after an existing commit, > > ab0e27003ef245f20512d1808b1dfee662ab8f41, so it > > seems like it is relatively safe. > > I thought about creating it, but it's like how do I create such a trivial patch > and not get hit with I copied it. IANAL, but IIUC when something can only be done one way, it isn't copyrightable. Other possible ways to differentiate: - libselinux/src/Makefile provides a FTS_LDLIBS ?= definition, which was missing from their patch. Not sure that matters. - Instead of adding it LDLIBS for everything, could just add it where needed, similar to PCRE_LDLIBS. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PR 193 sitting for uClibC fix 2020-03-26 16:52 ` Stephen Smalley @ 2020-03-26 16:58 ` Stephen Smalley 2020-03-26 17:02 ` William Roberts 0 siblings, 1 reply; 6+ messages in thread From: Stephen Smalley @ 2020-03-26 16:58 UTC (permalink / raw) To: William Roberts; +Cc: SElinux list On Thu, Mar 26, 2020 at 12:52 PM Stephen Smalley <stephen.smalley.work@gmail.com> wrote: > > On Thu, Mar 26, 2020 at 12:46 PM William Roberts > <bill.c.roberts@gmail.com> wrote: > > > > On Thu, Mar 26, 2020 at 11:44 AM Stephen Smalley > > <stephen.smalley.work@gmail.com> wrote: > > > > > > On Thu, Mar 26, 2020 at 12:22 PM William Roberts > > > <bill.c.roberts@gmail.com> wrote: > > > > > > > > This PR: > > > > https://github.com/SELinuxProject/selinux/pull/193 > > > > > > > > Has been sitting forever. I looked through the mailing list and didn't > > > > see any patches hit the list, > > > > we should either close it, or merge it. > > > > > > > > Thoughts? If we need it to hit the list, can I grab it and sign-off on > > > > it and post it? > > > > > > You can't sign-off on someone else's patch without them first signing off on it > > > or otherwise certifying to you that it falls under clauses (a), (b), > > > or (c) of the DCO. > > > > For some reason I just assumed it had a signed-off line, it doesn't though. > > > > > You could create your own patch to achieve the same end, especially > > > since this one is trivial and seems > > > to be modeled after an existing commit, > > > ab0e27003ef245f20512d1808b1dfee662ab8f41, so it > > > seems like it is relatively safe. > > > > I thought about creating it, but it's like how do I create such a trivial patch > > and not get hit with I copied it. > > IANAL, but IIUC when something can only be done one way, it isn't copyrightable. > Other possible ways to differentiate: > - libselinux/src/Makefile provides a FTS_LDLIBS ?= definition, which > was missing from their patch. > Not sure that matters. > - Instead of adding it LDLIBS for everything, could just add it where > needed, similar to PCRE_LDLIBS. Or you could just ping them on the github issue and ask if they will at least certify to the DCO as a github comment (or better, push a revised commit with sign-off) and then you can take it from there. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PR 193 sitting for uClibC fix 2020-03-26 16:58 ` Stephen Smalley @ 2020-03-26 17:02 ` William Roberts 0 siblings, 0 replies; 6+ messages in thread From: William Roberts @ 2020-03-26 17:02 UTC (permalink / raw) To: Stephen Smalley; +Cc: SElinux list On Thu, Mar 26, 2020 at 11:57 AM Stephen Smalley <stephen.smalley.work@gmail.com> wrote: > > On Thu, Mar 26, 2020 at 12:52 PM Stephen Smalley > <stephen.smalley.work@gmail.com> wrote: > > > > On Thu, Mar 26, 2020 at 12:46 PM William Roberts > > <bill.c.roberts@gmail.com> wrote: > > > > > > On Thu, Mar 26, 2020 at 11:44 AM Stephen Smalley > > > <stephen.smalley.work@gmail.com> wrote: > > > > > > > > On Thu, Mar 26, 2020 at 12:22 PM William Roberts > > > > <bill.c.roberts@gmail.com> wrote: > > > > > > > > > > This PR: > > > > > https://github.com/SELinuxProject/selinux/pull/193 > > > > > > > > > > Has been sitting forever. I looked through the mailing list and didn't > > > > > see any patches hit the list, > > > > > we should either close it, or merge it. > > > > > > > > > > Thoughts? If we need it to hit the list, can I grab it and sign-off on > > > > > it and post it? > > > > > > > > You can't sign-off on someone else's patch without them first signing off on it > > > > or otherwise certifying to you that it falls under clauses (a), (b), > > > > or (c) of the DCO. > > > > > > For some reason I just assumed it had a signed-off line, it doesn't though. > > > > > > > You could create your own patch to achieve the same end, especially > > > > since this one is trivial and seems > > > > to be modeled after an existing commit, > > > > ab0e27003ef245f20512d1808b1dfee662ab8f41, so it > > > > seems like it is relatively safe. > > > > > > I thought about creating it, but it's like how do I create such a trivial patch > > > and not get hit with I copied it. > > > > IANAL, but IIUC when something can only be done one way, it isn't copyrightable. > > Other possible ways to differentiate: > > - libselinux/src/Makefile provides a FTS_LDLIBS ?= definition, which > > was missing from their patch. > > Not sure that matters. > > - Instead of adding it LDLIBS for everything, could just add it where > > needed, similar to PCRE_LDLIBS. > > Or you could just ping them on the github issue and ask if they will > at least certify > to the DCO as a github comment (or better, push a revised commit with sign-off) > and then you can take it from there. Already pinged once, I can try again and see. Give them to next week and if no response submit something like this: diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile index 361506384d08..32da04068b3c 100644 --- a/libselinux/utils/Makefile +++ b/libselinux/utils/Makefile @@ -10,6 +10,8 @@ else COMPILER ?= clang endif +FTS_LDLIBS ?= + ifeq ($(COMPILER), gcc) EXTRA_CFLAGS = -fipa-pure-const -Wpacked-bitfield-compat -Wsync-nand -Wcoverage-mismatch \ -Wcpp -Wformat-contains-nul -Wnormalized=nfc -Wsuggest-attribute=const \ @@ -45,7 +47,7 @@ endif override CFLAGS += -I../include -D_GNU_SOURCE $(DISABLE_FLAGS) $(PCRE_CFLAGS) override LDFLAGS += -L../src -override LDLIBS += -lselinux +override LDLIBS += -lselinux $(FTS_LDLIBS) PCRE_LDLIBS ?= -lpcre ifeq ($(ANDROID_HOST),y) ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-26 17:02 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-26 16:21 PR 193 sitting for uClibC fix William Roberts 2020-03-26 16:45 ` Stephen Smalley 2020-03-26 16:46 ` William Roberts 2020-03-26 16:52 ` Stephen Smalley 2020-03-26 16:58 ` Stephen Smalley 2020-03-26 17:02 ` William Roberts
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.