[PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

[PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

[Dmitry Torokhov]

The touchpad on Lenovo Carbon X1 Gen 5 (2017 - Kabylake) is accessible over
SMBUS/RMI, so let's activate it by default.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/mouse/synaptics.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 9a8d81efd329..248c7c9dcbaa 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -172,6 +172,7 @@ static const char * const smbus_pnp_ids[] = {
 	"LEN0048", /* X1 Carbon 3 */
 	"LEN0046", /* X250 */
 	"LEN004a", /* W541 */
+	"LEN0072", /* X1 Carbon Gen 5 (2017) */
 	"LEN200f", /* T450s */
 	NULL
 };
-- 
2.14.1.480.gb18f417b89-goog


-- 
Dmitry

My touchpad needs explicit kernel parameter "psmouse.synaptics_intertouch=1" (kernel 4.12.3)

[Teika Kazura]

Hi. Following dmesg's suggestion to report this issue:
"Your touchpad (PNP: SYN3221 PNP0f03) says it can support a different bus. If i2c-hid and hid-rmi are not used, you might want to try setting psmouse.synaptics_intertouch to 1 and report this to linux-input@vger.kernel.org"

My kernel config surely has:
  CONFIG_I2C_HID=y
  CONFIG_HID_RMI=y
  CONFIG_RMI4_***=y
but dmesg emits the above message without the kernel boot parameter.

dmesg has the following lines; w/o the boot parameter:
  psmouse serio1: synaptics: Touchpad model: 1, fw: 8.1, id: 0x1e2b1, caps: 0xf00123/0x840300/0x2e800/0x0, board id: 3127, fw id: 8526786

with the boot parameter:
  rmi4_smbus 4-002c: registering SMbus-connected sensor
  rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3127-001, fw id: 1819280

/proc/bus/input/devices, w/ the boot parameter:
------------------------------------------------------------------------
I: Bus=001d Vendor=06cb Product=0000 Version=0000
N: Name="Synaptics TM3127-001"
P: Phys=rmi4-00/input0
S: Sysfs=/devices/rmi4-00/input/input10
U: Uniq=
H: Handlers=mouse0 event8 
B: PROP=1
B: EV=b
B: KEY=e520 30000 0 0 0 0
B: ABS=6f3800001000003
------------------------------------------------------------------------

/proc/bus/input/devices, w/o the boot parameter
------------------------------------------------------------------------
I: Bus=0011 Vendor=0002 Product=0007 Version=01b1
N: Name="SynPS/2 Synaptics TouchPad"
P: Phys=isa0060/serio1/input0
S: Sysfs=/devices/platform/i8042/serio1/input/input4
U: Uniq=
H: Handlers=mouse0 event3 
B: PROP=1
B: EV=b
B: KEY=e520 30000 0 0 0 0
B: ABS=660800011000003
------------------------------------------------------------------------

Output of "$ hwinfo":
------------------------------------------------------------------------
55: PS/2 00.0: 10500 PS/2 Mouse
  [Created at input.249]
  Unique ID: AH6Q.ZHI3OT7LsxA
  Hardware Class: mouse
  Model: "SynPS/2 Synaptics TouchPad"
  Vendor: 0x0002
  Device: 0x0007 "SynPS/2 Synaptics TouchPad"
  Compatible to: int 0x0210 0x0002
  Device File: /dev/input/mice (/dev/input/mouse0)
  Device Files: /dev/input/mice, /dev/input/mouse0, /dev/input/event7, /dev/input/by-path/platform-i8042-serio-1-event-mouse, /dev/input/by-path/platform-i8042-serio-1-mouse
  Device Number: char 13:63 (char 13:32)
  Driver Info #0:
    Buttons: 2
    Wheels: 0
    XFree86 Protocol: explorerps/2
    GPM Protocol: exps2
  Config Status: cfg=new, avail=yes, need=no, active=unknown
------------------------------------------------------------------------

Xorg.log. Diff w/ and w/o psmouse.synaptics_intertouch=1
------------------------------------------------------------------------
--- Xorg.0.log.old	2017-07-29 07:51:29.602511165 +0900
+++ Xorg.0.log	2017-07-29 07:51:20.561510734 +0900
@@ -348,29 +348,29 @@
 (**) Option "xkb_model" "pc"
 (**) Option "xkb_layout" "hp"
 (**) Option "xkb_options" "terminate:ctrl_alt_bksp"
-(II) config/udev: Adding input device SynPS/2 Synaptics TouchPad (/dev/input/event8)
-(**) SynPS/2 Synaptics TouchPad: Applying InputClass "evdev touchpad catchall"
-(**) SynPS/2 Synaptics TouchPad: Applying InputClass "libinput touchpad catchall"
-(**) SynPS/2 Synaptics TouchPad: Applying InputClass "touchpad catchall"
-(**) SynPS/2 Synaptics TouchPad: Applying InputClass "Default clickpad buttons"
-(**) SynPS/2 Synaptics TouchPad: Applying InputClass "libinput touchpad catchall"
-(**) SynPS/2 Synaptics TouchPad: Applying InputClass "my config for: libinput synaptics"
-(**) SynPS/2 Synaptics TouchPad: Applying InputClass "Synaptics"
+(II) config/udev: Adding input device Synaptics TM3127-001 (/dev/input/event8)
+(**) Synaptics TM3127-001: Applying InputClass "libinput touchpad catchall"
+(**) Synaptics TM3127-001: Applying InputClass "Synaptics"
 (II) LoadModule: "synaptics"
 (II) Loading /usr/lib64/xorg/modules/input/synaptics_drv.so
 (II) Module synaptics: vendor="X.Org Foundation"
 	compiled for 1.19.2, module version = 1.9.0
 	Module class: X.Org XInput Driver
 	ABI class: X.Org XInput driver, version 24.1
-(II) Using input driver 'synaptics' for 'SynPS/2 Synaptics TouchPad'
-(**) SynPS/2 Synaptics TouchPad: always reports core events
+(II) Using input driver 'synaptics' for 'Synaptics TM3127-001'
+(**) Synaptics TM3127-001: always reports core events
 (**) Option "Device" "/dev/input/event8"
-(--) synaptics: SynPS/2 Synaptics TouchPad: x-axis range 1330 - 5652 (res 40)
-(--) synaptics: SynPS/2 Synaptics TouchPad: y-axis range 1094 - 4846 (res 89)
-(--) synaptics: SynPS/2 Synaptics TouchPad: pressure range 0 - 255
-(--) synaptics: SynPS/2 Synaptics TouchPad: finger width range 0 - 15
-(--) synaptics: SynPS/2 Synaptics TouchPad: buttons: left right double triple
-(--) synaptics: SynPS/2 Synaptics TouchPad: Vendor 0x2 Product 0x7
+(--) synaptics: Synaptics TM3127-001: x-axis range 0 - 2152 (res 20)
+(--) synaptics: Synaptics TM3127-001: y-axis range 0 - 842 (res 20)
+(--) synaptics: Synaptics TM3127-001: pressure range 0 - 255
+(II) synaptics: Synaptics TM3127-001: device does not report finger width.
+(--) synaptics: Synaptics TM3127-001: buttons: left right double triple
+(--) synaptics: Synaptics TM3127-001: Vendor 0x6cb Product 0
+(--) synaptics: Synaptics TM3127-001: invalid finger width range.  defaulting to 0 - 15
 (**) Option "VertTwoFingerScroll" "1"
 (**) Option "HorizTwoFingerScroll" "1"
 (**) Option "LockedDrags" "true"
@@ -378,20 +378,20 @@
 (**) Option "TapButton2" "3"
 (**) Option "TapButton3" "2"
 (**) Option "AccelFactor" "1.0"
-(--) synaptics: SynPS/2 Synaptics TouchPad: touchpad found
-(**) SynPS/2 Synaptics TouchPad: always reports core events
-(**) Option "config_info" "udev:/sys/devices/platform/i8042/serio1/input/input5/event8"
-(II) XINPUT: Adding extended input device "SynPS/2 Synaptics TouchPad" (type: TOUCHPAD, id 11)
-(**) synaptics: SynPS/2 Synaptics TouchPad: (accel) MinSpeed is now constant deceleration 2.5
-(**) synaptics: SynPS/2 Synaptics TouchPad: (accel) MaxSpeed is now 1.75
-(**) synaptics: SynPS/2 Synaptics TouchPad: (accel) AccelFactor is now 1.000
-(**) SynPS/2 Synaptics TouchPad: (accel) keeping acceleration scheme 1
-(**) SynPS/2 Synaptics TouchPad: (accel) acceleration profile 1
-(**) SynPS/2 Synaptics TouchPad: (accel) acceleration factor: 2.000
-(**) SynPS/2 Synaptics TouchPad: (accel) acceleration threshold: 4
-(--) synaptics: SynPS/2 Synaptics TouchPad: touchpad found
-(II) config/udev: Adding input device SynPS/2 Synaptics TouchPad (/dev/input/mouse0)
-(**) SynPS/2 Synaptics TouchPad: Ignoring device from InputClass "touchpad ignore duplicates"
+(--) synaptics: Synaptics TM3127-001: touchpad found
+(**) Synaptics TM3127-001: always reports core events
+(**) Option "config_info" "udev:/sys/devices/rmi4-00/input/input10/event8"
+(II) XINPUT: Adding extended input device "Synaptics TM3127-001" (type: TOUCHPAD, id 11)
+(**) synaptics: Synaptics TM3127-001: (accel) MinSpeed is now constant deceleration 2.5
+(**) synaptics: Synaptics TM3127-001: (accel) MaxSpeed is now 1.75
+(**) synaptics: Synaptics TM3127-001: (accel) AccelFactor is now 1.000
+(**) Synaptics TM3127-001: (accel) keeping acceleration scheme 1
+(**) Synaptics TM3127-001: (accel) acceleration profile 1
+(**) Synaptics TM3127-001: (accel) acceleration factor: 2.000
+(**) Synaptics TM3127-001: (accel) acceleration threshold: 4
+(--) synaptics: Synaptics TM3127-001: touchpad found
+(II) config/udev: Adding input device Synaptics TM3127-001 (/dev/input/mouse0)
+(**) Synaptics TM3127-001: Ignoring device from InputClass "touchpad ignore duplicates"
 (II) config/udev: Adding input device HP Wireless hotkeys (/dev/input/event4)
 (**) HP Wireless hotkeys: Applying InputClass "evdev keyboard catchall"
 (**) HP Wireless hotkeys: Applying InputClass "libinput keyboard catchall"
------------------------------------------------------------------------

Not sure what to report; sorry if this email is not sufficient. 

Thanks & best regards, linux-input.

Teika (Teika kazura)

Synaptiics RMI4 ID

[rosenp]

I've successfully tested my touchpad with
psmouse.synaptics_intertouch=1 . Obligatory info:

Your touchpad (PNP: SYN1219 PNP0f13) says it can support a different
bus.

synaptics: Touchpad model: 1, fw: 8.2, id: 0x1e2b1, caps:
0xf00123/0x840300/0x26800/0x0, board id: 3163, fw id: 1924066

/proc/bus/input/devices
I: Bus=001d Vendor=06cb Product=0000 Version=0000
N: Name="Synaptics TM3163-001"
P: Phys=rmi4-00/input0
S: Sysfs=/devices/rmi4-00/input/input27
U: Uniq=
H: Handlers=mouse0 event17 
B: PROP=1
B: EV=b
B: KEY=e520 30000 0 0 0 0
B: ABS=6f3800001000003

Synaptics: Missing pnpID for rmi-smbus

[Markus Kaindl]

[-- Attachment #1.1: Type: text/plain, Size: 667 bytes --]

Hi,

on my Thinkpad T460s my Kernel (4.12.8 built from gentoo-sources) told
me about my Touchpad supporting a different bus.
After building all the related modules, the message stayed, so I did as
the message told and set psmouse.synaptics_intertouch to 1, it then used
the rmi_smbus module.

Feel free to contact me, if you need more information.

Regards,
Markus

Aug 18 04:29:59 Lhotse kernel: psmouse serio1: synaptics: Your touchpad
(PNP: LEN004b PNP0f13) says it can support a different bus. If i2c-hid
and hid-rmi are not used, you might want to try setting
psmouse.synaptics_intertouch to 1 and report this to
linux-input@vger.kernel.org.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 866 bytes --]

successful intertouch support: PNP: LEN2014 PNP0f13

[Adam Goode]

Aug 17 23:36:24 localhost kernel: psmouse serio1: synaptics: Your
touchpad (PNP: LEN2014 PNP0f13) says it can support a different bus.
If i2c-hid and hid-rmi are not used, you might want to try setting
psmouse.synaptics_intertouch to 1 and report this to
linux-input@vger.kernel.org.

It does work with the kernel setting. Please add this to the whitelist.


Thanks,

Adam

rmi-smbus SYN1219 PNP0f13 not correctly detected

[Pablo Cholaky]

Guys,

As far I read on the kernel output, I tried to make anything match
with the touchpad and I didn't get a good solution, so I loaded
psmouse with synaptics_intertouch 1 to properly debug the device and
might be useful.

[ 1751.202901] psmouse serio2: synaptics: queried max coordinates: x
[..5654], y [..4716]
[ 1751.320068] psmouse serio2: synaptics: queried min coordinates: x
[1326..], y [1228..]
[ 1751.320073] psmouse serio2: synaptics: Your touchpad (PNP: SYN1219
PNP0f13) says it can support a different bus. If i2c-hid and hid-rmi
are not used, you might want to try setting
psmouse.synaptics_intertouch to 1 and report this to
linux-input@vger.kernel.org.
[ 1751.469029] psmouse serio2: synaptics: Touchpad model: 1, fw: 8.2,
id: 0x1e2b1, caps: 0xf00123/0x840300/0x26800/0x0, board id: 3163, fw
id: 1924066
[ 1751.509697] input: SynPS/2 Synaptics TouchPad as
/devices/platform/i8042/serio2/input/input48
[ 1778.905227] psmouse serio2: synaptics: queried max coordinates: x
[..5654], y [..4716]
[ 1779.020816] psmouse serio2: synaptics: queried min coordinates: x
[1326..], y [1228..]
[ 1779.020819] psmouse serio2: synaptics: Trying to set up SMBus access
[ 1779.109162] rmi4_smbus 0-002c: registering SMbus-connected sensor
[ 1779.163347] rmi4_f01 rmi4-01.fn01: found RMI device, manufacturer:
Synaptics, product: TM3163-001, fw id: 1924066
[ 1779.220800] input: Synaptics TM3163-001 as /devices/rmi4-01/input/input84

Question, there is something else I can provide you to identify this?
Currently I'm under kernel 4.12.2 using I2C 801, custom kernel.

Regards

-- 
Pablo Cholaky
Computer Science and TI Engineer
Gentoo Linux user and developer
Slash.cl Owner
Blablabla

InterTouch support for Clevo P651Rx

[jan.steffens]

Hi list,

My laptop is a Schenker H506 (rebrand of Clevo P651RG) and I got the
message about InterTouch support (PNP: SYN1219 PNP0f13). After booting
4.12.2 with psmouse.synaptics_intertouch=1, the rmi_smbus driver is
loaded and the touchpad continues to work.

rmi4_smbus 0-002c: registering SMbus-connected sensor
rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer: Synaptics, product: TM3163-001, fw id: 1924066
input: Synaptics TM3163-001 as /devices/rmi4-00/input/input15

Greetings,
Jan Steffens

RMI4 support for synaptics (users, please test patch)

[Teika Kazura]

CC-ed folks, your devices need "psmouse.synaptics_intertouch=1". Let me follow up. (I'm not a kernel developer, but in a similar situation as yours.) The patch should apply to 4.13.x and 4.12.x.

@Lukas Prettenthaler, rosenp, Pablo Cholaky, jan.steffens, Darrick J. Wong:
 Could you please test the patch below? Make sure to delete "psmouse.synaptics_intertouch=1" from your boot parameter. If the patch has the same effect as the above boot parameter, it seems ok.

@Kamil Iskra: Maybe add "SYN3054" to the patch, and try?

@Sibren Vasse: I know your patch works for you, but could you try dropping SYN0100, SYN0002 and PNP0f13 from your patch? (Typical dmesg is like: "Your touchpad (PNP: SYN3221 PNP0f03) says it can support a different bus", and adding only the first of two, "SYN3221", suffices.)

@Adam Goode: As you know, your issue (freeze after resuming) is yet to be fixed. I haven't included your model in my patch.

@Christopher Bachner: What's the status of your PC? I'm subscribing linux-input@vger.kernel.org, and found your issue browsing linux-input archive, but you don't read this list, right? I think you've tried this patch: https://marc.info/?l=linux-input&m=149854999528878&w=2 

Best regards. Thank you for reporting.

---
 drivers/input/mouse/synaptics.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 5af0b7d..bc02040 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -169,10 +169,16 @@ static const char * const topbuttonpad_pnp_ids[] = {
 
 static const char * const smbus_pnp_ids[] = {
 	/* all of the topbuttonpad_pnp_ids are valid, we just add some extras */
+	"DLL075b",
 	"LEN0048", /* X1 Carbon 3 */
 	"LEN0046", /* X250 */
 	"LEN004a", /* W541 */
+	"LEN004b", /* T460s */
+	"LEN006e", /* T470 */
 	"LEN200f", /* T450s */
+	/* "LEN2014", commented out, depending on resume bug fix */
+	"SYN1219", /* Used by many */
+	"SYN3221",
 	NULL
 };
 

Re: RMI4 support for synaptics (users, please test patch)

[Darrick J. Wong]

On Wed, Sep 20, 2017 at 09:22:18AM +0900, Teika Kazura wrote:
> CC-ed folks, your devices need "psmouse.synaptics_intertouch=1". Let me follow up. (I'm not a kernel developer, but in a similar situation as yours.) The patch should apply to 4.13.x and 4.12.x.
> 
> @Lukas Prettenthaler, rosenp, Pablo Cholaky, jan.steffens, Darrick J. Wong:
>  Could you please test the patch below? Make sure to delete "psmouse.synaptics_intertouch=1" from your boot parameter. If the patch has the same effect as the above boot parameter, it seems ok.

Seems to work (4.13.7), sorry it took so long to get back to you.

--D

> 
> @Kamil Iskra: Maybe add "SYN3054" to the patch, and try?
> 
> @Sibren Vasse: I know your patch works for you, but could you try dropping SYN0100, SYN0002 and PNP0f13 from your patch? (Typical dmesg is like: "Your touchpad (PNP: SYN3221 PNP0f03) says it can support a different bus", and adding only the first of two, "SYN3221", suffices.)
> 
> @Adam Goode: As you know, your issue (freeze after resuming) is yet to be fixed. I haven't included your model in my patch.
> 
> @Christopher Bachner: What's the status of your PC? I'm subscribing linux-input@vger.kernel.org, and found your issue browsing linux-input archive, but you don't read this list, right? I think you've tried this patch: https://marc.info/?l=linux-input&m=149854999528878&w=2 
> 
> Best regards. Thank you for reporting.
> 
> ---
>  drivers/input/mouse/synaptics.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 5af0b7d..bc02040 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -169,10 +169,16 @@ static const char * const topbuttonpad_pnp_ids[] = {
>  
>  static const char * const smbus_pnp_ids[] = {
>  	/* all of the topbuttonpad_pnp_ids are valid, we just add some extras */
> +	"DLL075b",
>  	"LEN0048", /* X1 Carbon 3 */
>  	"LEN0046", /* X250 */
>  	"LEN004a", /* W541 */
> +	"LEN004b", /* T460s */
> +	"LEN006e", /* T470 */
>  	"LEN200f", /* T450s */
> +	/* "LEN2014", commented out, depending on resume bug fix */
> +	"SYN1219", /* Used by many */
> +	"SYN3221",
>  	NULL
>  };
>  

Re: successful intertouch support: PNP: LEN2014 PNP0f13

[Adam Goode]

On Thu, Aug 17, 2017 at 11:55 PM, Adam Goode <adam@spicenitz.org> wrote:
> Aug 17 23:36:24 localhost kernel: psmouse serio1: synaptics: Your
> touchpad (PNP: LEN2014 PNP0f13) says it can support a different bus.
> If i2c-hid and hid-rmi are not used, you might want to try setting
> psmouse.synaptics_intertouch to 1 and report this to
> linux-input@vger.kernel.org.
>
> It does work with the kernel setting. Please add this to the whitelist.

This failed to resume from sleep. Neither the trackpad nor the
touchpoint work, and I cannot suspend again.


[ 3332.225906] rmi4_smbus 6-002c: failed to get SMBus version number!
[ 3332.225913] rmi4_physical rmi4-00: rmi_driver_reset_handler: Failed
to read current IRQ mask.
[ 3332.225922] rmi4_f01 rmi4-00.fn01: Failed to restore normal operation: -16.
[ 3332.225924] rmi4_f01 rmi4-00.fn01: Resume failed with code -16.
[ 3332.225927] rmi4_physical rmi4-00: Failed to suspend functions: -16
[ 3332.225929] rmi4_smbus 6-002c: Failed to resume device: -16
[ 3332.225945] rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to
write to F03 TX register (-16).
[ 3332.252105] rmi4_f03 rmi4-00.fn03: rmi_f03_pt_write: Failed to
write to F03 TX register (-16).

[ 3404.759232] rmi4_f01 rmi4-00.fn01: Failed to write sleep mode: -16.
[ 3404.759233] rmi4_f01 rmi4-00.fn01: Suspend failed with code -16.
[ 3404.759235] rmi4_physical rmi4-00: Failed to suspend functions: -16
[ 3404.759238] rmi4_smbus 6-002c: Failed to suspend device: -16
[ 3404.759243] dpm_run_callback(): rmi_smb_suspend+0x0/0x50
[rmi_smbus] returns -16
[ 3404.759245] PM: Device 6-002c failed to suspend: error -16
[ 3404.759246] PM: Some devices failed to suspend, or early wake event detected


>
>
> Thanks,
>
> Adam

Re: successful intertouch support: PNP: LEN2014 PNP0f13

[Teika Kazura]

From: Adam Goode <adam@spicenitz.org>
Subject: Re: successful intertouch support: PNP: LEN2014 PNP0f13
Date: Fri, 18 Aug 2017 08:59:19 -0400

> This failed to resume from sleep. Neither the trackpad nor the
> touchpoint work, and I cannot suspend again.

Maybe this recent thread is relevant? (From the archived linux-input@vger.kernel.org)
http://www.spinics.net/lists/linux-input/msg52384.html

(I'm not a kernel developer. I've just sent a report similar to yours.)

Teika (Teika kazura)

Re: successful intertouch support: PNP: LEN2014 PNP0f13

[Adam Goode]

On Fri, Aug 18, 2017 at 8:49 PM, Teika Kazura <teika@gmx.com> wrote:
>
> From: Adam Goode <adam@spicenitz.org>
> Subject: Re: successful intertouch support: PNP: LEN2014 PNP0f13
> Date: Fri, 18 Aug 2017 08:59:19 -0400
>
> > This failed to resume from sleep. Neither the trackpad nor the
> > touchpoint work, and I cannot suspend again.
>
> Maybe this recent thread is relevant? (From the archived linux-input@vger.kernel.org)
> http://www.spinics.net/lists/linux-input/msg52384.html
>
> (I'm not a kernel developer. I've just sent a report similar to yours.)
>

Oh, thank you for that link! It looks like a generic patch is indeed needed.

I do not see any such patch in any git tree, so I guess it still needs
to be written/accepted.
I looked at https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/log/


Thanks,

Adam

>
> Teika (Teika kazura)

Re: [PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

[Benjamin Tissoires]

On Aug 18 2017 or thereabouts, Dmitry Torokhov wrote:
> The touchpad on Lenovo Carbon X1 Gen 5 (2017 - Kabylake) is accessible over
> SMBUS/RMI, so let's activate it by default.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

>  drivers/input/mouse/synaptics.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 9a8d81efd329..248c7c9dcbaa 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -172,6 +172,7 @@ static const char * const smbus_pnp_ids[] = {
>  	"LEN0048", /* X1 Carbon 3 */
>  	"LEN0046", /* X250 */
>  	"LEN004a", /* W541 */
> +	"LEN0072", /* X1 Carbon Gen 5 (2017) */
>  	"LEN200f", /* T450s */
>  	NULL
>  };
> -- 
> 2.14.1.480.gb18f417b89-goog
> 
> 
> -- 
> Dmitry

Re: [PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

[Damjan Georgievski]

On 18 August 2017 at 21:34, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> The touchpad on Lenovo Carbon X1 Gen 5 (2017 - Kabylake) is accessible over
> SMBUS/RMI, so let's activate it by default.

the patch over latest Linus 4.13-rc5 makes the trackpoint device to
not appear after boot.

Sometimes it  spontaneuosly appears 100-200 seconds after boot.

It does appear after suspend/resume. And it does appear after `rmmod
psmouse; modprobe psmouse`.


Second issues is, trackpoint is reported as "ImPS/2 Generic Wheel
Mouse". Middle button scrolling is not enabled by default.

hardware is:
Lenovo ThinkPad X1 Carbon 5th, model 20HQS0LV00
DMI: LENOVO 20HQS0LV00/20HQS0LV00, BIOS N1MET37W (1.22 ) 07/04/2017


-- 
damjan

Re: [PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

[Dmitry Torokhov]

On Mon, Aug 21, 2017 at 10:52:11AM +0200, Damjan Georgievski wrote:
> On 18 August 2017 at 21:34, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > The touchpad on Lenovo Carbon X1 Gen 5 (2017 - Kabylake) is accessible over
> > SMBUS/RMI, so let's activate it by default.
> 
> the patch over latest Linus 4.13-rc5 makes the trackpoint device to
> not appear after boot.
> 
> Sometimes it  spontaneuosly appears 100-200 seconds after boot.
> 
> It does appear after suspend/resume. And it does appear after `rmmod
> psmouse; modprobe psmouse`.

Hmm, I do not observe this on:

Handle 0x000B, DMI type 0, 24 bytes
BIOS Information
        Vendor: LENOVO
        Version: N1MET37W (1.22 )
        Release Date: 07/04/2017
...
        BIOS Revision: 1.22
        Firmware Revision: 1.15

Handle 0x000C, DMI type 1, 27 bytes
System Information
        Manufacturer: LENOVO
        Product Name: 20HQS0EG02
        Version: ThinkPad X1 Carbon 5th
...
        SKU Number: LENOVO_MT_20HQ_BU_Think_FM_ThinkPad X1 Carbon 5th
        Family: ThinkPad X1 Carbon 5th

I wonder if we have different configs...

> 
> 
> Second issues is, trackpoint is reported as "ImPS/2 Generic Wheel
> Mouse". Middle button scrolling is not enabled by default.

I think this will be fixed by:

https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/patch/?id=ec667683c532c93fb41e100e5d61a518971060e2

> 
> hardware is:
> Lenovo ThinkPad X1 Carbon 5th, model 20HQS0LV00
> DMI: LENOVO 20HQS0LV00/20HQS0LV00, BIOS N1MET37W (1.22 ) 07/04/2017
> 

Thanks.

-- 
Dmitry

Re: [PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

[Damjan Georgievski]

> I wonder if we have different configs...
>
>>
>>
>> Second issues is, trackpoint is reported as "ImPS/2 Generic Wheel
>> Mouse". Middle button scrolling is not enabled by default.
>
> I think this will be fixed by:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/patch/?id=ec667683c532c93fb41e100e5d61a518971060e2
>

Interesting, with this patch, the trackpoint appeared sooner, but
still late (at the 44 second mark):

$ dmesg | grep -i -E '(mouse|syna)'
[    5.338111] input: PixArt Dell MS116 USB Optical Mouse as
/devices/pci0000:00/0000:00:1d.0/0000:06:00.0/0000:07:01.0/0000:09:00.0/0000:0a:00.0/0000:0b:00.0/usb3/3-3/3-3.2/3-3.2:1.0/0003:413C:301A.0005/input/input9
[    5.338221] hid-generic 0003:413C:301A.0005: input,hidraw4: USB HID
v1.11 Mouse [PixArt Dell MS116 USB Optical Mouse] on
usb-0000:0b:00.0-3.2/input0
[   11.442141] mousedev: PS/2 mouse device common for all mice
[   12.715385] psmouse serio1: synaptics: queried max coordinates: x
[..5676], y [..4760]
[   12.744807] psmouse serio1: synaptics: queried min coordinates: x
[1266..], y [1094..]
[   12.744810] psmouse serio1: synaptics: Trying to set up SMBus access
[   12.808775] rmi4_f01 rmi4-00.fn01: found RMI device, manufacturer:
Synaptics, product: TM3289-002, fw id: 2492434
[   12.871445] input: Synaptics TM3289-002 as /devices/rmi4-00/input/input22
[   43.941741] psmouse serio2: trackpoint: failed to get extended
button data, assuming 3 buttons
[   44.564540] psmouse serio2: trackpoint: IBM TrackPoint firmware:
0x01, buttons: 3/3
[   50.834012] psmouse serio2: TrackPoint at
synaptics-rmi4-pt/serio1/input0 lost synchronization, throwing 1 bytes
away.


ps. there's a human induced delay between 5.5 and 10.5 while I'm
entering my LUKS passphrase


$ xinput list
⎡ Virtual core pointer                          id=2    [master pointer  (3)]
⎜   ↳ Virtual core XTEST pointer                id=4    [slave  pointer  (2)]
⎜   ↳ PixArt Dell MS116 USB Optical Mouse       id=13   [slave  pointer  (2)]
⎜   ↳ Synaptics TM3289-002                      id=16   [slave  pointer  (2)]
⎜   ↳ TPPS/2 IBM TrackPoint                     id=17   [slave  pointer  (2)]


-- 
damjan

Re: [PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

[Damjan Georgievski]

On 21 August 2017 at 18:25, Damjan Georgievski <gdamjan@gmail.com> wrote:
>> I wonder if we have different configs...
>>
>>>
>>> Second issues is, trackpoint is reported as "ImPS/2 Generic Wheel
>>> Mouse". Middle button scrolling is not enabled by default.
>>
>> I think this will be fixed by:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/patch/?id=ec667683c532c93fb41e100e5d61a518971060e2
>>
>
> Interesting, with this patch, the trackpoint appeared sooner, but
> still late (at the 44 second mark):

but that seems sporadic. on second boot, it didn't show up until I
reloaded the psmouse module

any ideas how to debug this issue further? possibly before the change
goes upstream.

-- 
damjan

Re: [PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

[Dmitry Torokhov]

On Fri, Aug 25, 2017 at 12:55:29PM +0200, Damjan Georgievski wrote:
> On 21 August 2017 at 18:25, Damjan Georgievski <gdamjan@gmail.com> wrote:
> >> I wonder if we have different configs...
> >>
> >>>
> >>> Second issues is, trackpoint is reported as "ImPS/2 Generic Wheel
> >>> Mouse". Middle button scrolling is not enabled by default.
> >>
> >> I think this will be fixed by:
> >>
> >> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/patch/?id=ec667683c532c93fb41e100e5d61a518971060e2
> >>
> >
> > Interesting, with this patch, the trackpoint appeared sooner, but
> > still late (at the 44 second mark):
> 
> but that seems sporadic. on second boot, it didn't show up until I
> reloaded the psmouse module
> 
> any ideas how to debug this issue further? possibly before the change
> goes upstream.

Damjan,

Since my other patches seem to have fixed the trackpoint detection
issue, mind giving your "tested-by" to this patch so I can get it in?

Thanks.

-- 
Dmitry

Re: [PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

[Damjan Georgievski]

>> >>> Second issues is, trackpoint is reported as "ImPS/2 Generic Wheel
>> >>> Mouse". Middle button scrolling is not enabled by default.
>> >>
>> >> I think this will be fixed by:
>> >>
>> >> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/patch/?id=ec667683c532c93fb41e100e5d61a518971060e2
>> >>
>> >
>> > Interesting, with this patch, the trackpoint appeared sooner, but
>> > still late (at the 44 second mark):
>>
>> but that seems sporadic. on second boot, it didn't show up until I
>> reloaded the psmouse module
>>
>> any ideas how to debug this issue further? possibly before the change
>> goes upstream.
>
> Damjan,
>
> Since my other patches seem to have fixed the trackpoint detection
> issue, mind giving your "tested-by" to this patch so I can get it in?

let me just run some more tests and I'll get back to you soon.

I'm getting some weird clicks on the trackpad, I want to compare with
vanilla kernel.

Dimitry, what's best for testing, 4.15.1 + your patches or should I use 4.16rc1?


-- 
damjan

Re: [PATCH] Input: synaptics - Lenovo Carbon X1 Gen5 (2017) devices should use RMI

[Damjan Georgievski]

On 5 February 2018 at 12:56, Damjan Georgievski <gdamjan@gmail.com> wrote:
>>> >>> Second issues is, trackpoint is reported as "ImPS/2 Generic Wheel
>>> >>> Mouse". Middle button scrolling is not enabled by default.
>>> >>
>>> >> I think this will be fixed by:
>>> >>
>>> >> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/patch/?id=ec667683c532c93fb41e100e5d61a518971060e2
>>> >>
>>> >
>>> > Interesting, with this patch, the trackpoint appeared sooner, but
>>> > still late (at the 44 second mark):
>>>
>>> but that seems sporadic. on second boot, it didn't show up until I
>>> reloaded the psmouse module
>>>
>>> any ideas how to debug this issue further? possibly before the change
>>> goes upstream.
>>
>> Damjan,
>>
>> Since my other patches seem to have fixed the trackpoint detection
>> issue, mind giving your "tested-by" to this patch so I can get it in?
>
> let me just run some more tests and I'll get back to you soon.
>
> I'm getting some weird clicks on the trackpad, I want to compare with
> vanilla kernel.
>
> Dimitry, what's best for testing, 4.15.1 + your patches or should I use 4.16rc1?

The only difference I've noticed is these event that seems to be
repeated/stuck (BTN_LEFT 19.60)?:
$ sudo libinput debug-events --device /dev/input/event16
-event16  DEVICE_ADDED     Synaptics TM3289-002              seat0
default group1  cap:pg  size 102x56mm tap(dl off) left scroll-nat
scroll-2fg-edge click-buttonareas-clickfinger dwt-on
…
 event16  POINTER_BUTTON   +19.56s      BTN_LEFT (272) pressed, seat count: 1
 event16  POINTER_BUTTON   +19.58s      BTN_LEFT (272) released, seat count: 0
 event16  POINTER_BUTTON   +19.60s      BTN_LEFT (272) pressed, seat count: 1
 event16  POINTER_BUTTON   +19.66s      BTN_LEFT (272) released, seat count: 0
 event16  POINTER_BUTTON   +20.47s      BTN_MIDDLE (274) pressed, seat count: 1
 event16  POINTER_BUTTON   +19.60s      BTN_LEFT (272) pressed, seat count: 1
 event16  POINTER_BUTTON   +20.54s      BTN_MIDDLE (274) released, seat count: 0
 event16  POINTER_BUTTON   +20.57s      BTN_MIDDLE (274) pressed, seat count: 1
 event16  POINTER_BUTTON   +19.60s      BTN_LEFT (272) pressed, seat count: 1
 event16  POINTER_BUTTON   +20.57s      BTN_MIDDLE (274) released, seat count: 0
 event16  POINTER_BUTTON   +21.34s      BTN_MIDDLE (274) pressed, seat count: 1
 event16  POINTER_BUTTON   +19.60s      BTN_LEFT (272) pressed, seat count: 1
 event16  POINTER_BUTTON   +21.43s      BTN_MIDDLE (274) released, seat count: 0
 event16  POINTER_BUTTON   +21.94s      BTN_MIDDLE (274) pressed, seat count: 1
 event16  POINTER_BUTTON   +19.60s      BTN_LEFT (272) pressed, seat count: 1
 event16  POINTER_BUTTON   +22.02s      BTN_MIDDLE (274) released, seat count: 0

-- 
damjan