[PATCH] iio: sw-device: Fix config group initialization

[PATCH] iio: sw-device: Fix config group initialization

[Lars-Peter Clausen]

Use the IS_ENABLED() helper macro to ensure that the configfs group is
initialized either when configfs is built-in or when configfs is built as a
module. Otherwise software device creation will result in undefined
behaviour when configfs is built as a mdoule since the configfs group for
the device not properly initialized.

Similar to commit b2f0c09664b7 ("iio: sw-trigger: Fix config group
initialization").

Fixes: 0f3a8c3f34f7 ("iio: Add support for creating IIO devices via configfs")
Reported-by: Miguel Robles <miguel.robles@farole.net>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 include/linux/iio/sw_device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/iio/sw_device.h b/include/linux/iio/sw_device.h
index 23ca415..fa79319 100644
--- a/include/linux/iio/sw_device.h
+++ b/include/linux/iio/sw_device.h
@@ -62,7 +62,7 @@ void iio_swd_group_init_type_name(struct iio_sw_device *d,
 				  const char *name,
 				  struct config_item_type *type)
 {
-#ifdef CONFIG_CONFIGFS_FS
+#if IS_ENABLED(CONFIG_CONFIGFS_FS)
 	config_group_init_type_name(&d->group, name, type);
 #endif
 }
-- 
2.1.4

Re: [PATCH] iio: sw-device: Fix config group initialization

[Lars-Peter Clausen]

On 03/09/2017 05:20 PM, Lars-Peter Clausen wrote:
> Use the IS_ENABLED() helper macro to ensure that the configfs group is
> initialized either when configfs is built-in or when configfs is built as a
> module. Otherwise software device creation will result in undefined
> behaviour when configfs is built as a mdoule since the configfs group for

typo: module

> the device not properly initialized.

Re: [PATCH] iio: sw-device: Fix config group initialization

[Daniel Baluta]

On Thu, Mar 9, 2017 at 6:20 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> Use the IS_ENABLED() helper macro to ensure that the configfs group is
> initialized either when configfs is built-in or when configfs is built as a
> module. Otherwise software device creation will result in undefined
> behaviour when configfs is built as a mdoule since the configfs group for
> the device not properly initialized.
>
> Similar to commit b2f0c09664b7 ("iio: sw-trigger: Fix config group
> initialization").
>
> Fixes: 0f3a8c3f34f7 ("iio: Add support for creating IIO devices via configfs")
> Reported-by: Miguel Robles <miguel.robles@farole.net>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Acked-by: Daniel Baluta <daniel.baluta@gmail.com>

Re: [PATCH] iio: sw-device: Fix config group initialization

[Jonathan Cameron]

On 10/03/17 07:54, Daniel Baluta wrote:
> On Thu, Mar 9, 2017 at 6:20 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
>> Use the IS_ENABLED() helper macro to ensure that the configfs group is
>> initialized either when configfs is built-in or when configfs is built as a
>> module. Otherwise software device creation will result in undefined
>> behaviour when configfs is built as a mdoule since the configfs group for
>> the device not properly initialized.
>>
>> Similar to commit b2f0c09664b7 ("iio: sw-trigger: Fix config group
>> initialization").
>>
>> Fixes: 0f3a8c3f34f7 ("iio: Add support for creating IIO devices via configfs")
>> Reported-by: Miguel Robles <miguel.robles@farole.net>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> 
> Acked-by: Daniel Baluta <daniel.baluta@gmail.com>
Applied to the fixes-togreg branch of iio.git
with description typo fixed and marked for stable.

Thanks,

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>