[PATCH] Staging: rtl8712: Add blank line after declarations

[PATCH] Staging: rtl8712: Add blank line after declarations

[Yeliz Taneroglu]

The following patch fixes the checkpatch.pl warning:
drivers/staging/rtl8712/drv_types.h WARNING: Missing a blank line after declarations

Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
---
 drivers/staging/rtl8712/drv_types.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
index 3d0a98b..2522b59 100644
--- a/drivers/staging/rtl8712/drv_types.h
+++ b/drivers/staging/rtl8712/drv_types.h
@@ -129,6 +129,7 @@ struct dvobj_priv {
 	struct _adapter *padapter;
 	u32 nr_endpoint;
 	u8   ishighspeed;
+
 	uint(*inirp_init)(struct _adapter *adapter);
 	uint(*inirp_deinit)(struct _adapter *adapter);
 	struct usb_device *pusbdev;
@@ -165,7 +166,9 @@ struct _adapter {
 	struct task_struct *cmdThread;
 	 pid_t evtThread;
 	struct task_struct *xmitThread;
+
 	pid_t recvThread;
+
 	uint(*dvobj_init)(struct _adapter *adapter);
 	void (*dvobj_deinit)(struct _adapter *adapter);
 	struct net_device *pnetdev;
-- 
1.8.3.2

Re: [Outreachy kernel] [PATCH] Staging: rtl8712: Add blank line after declarations

[Daniel Baluta]

Hi Yeliz,

On Mon, Feb 23, 2015 at 1:32 PM, Yeliz Taneroglu
<yeliztaneroglu@gmail.com> wrote:
> The following patch fixes the checkpatch.pl warning:
> drivers/staging/rtl8712/drv_types.h WARNING: Missing a blank line after declarations
>
> Signed-off-by: Yeliz Taneroglu <yeliztaneroglu@gmail.com>
> ---
>  drivers/staging/rtl8712/drv_types.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 3d0a98b..2522b59 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -129,6 +129,7 @@ struct dvobj_priv {
>         struct _adapter *padapter;
>         u32 nr_endpoint;
>         u8   ishighspeed;
> +
>         uint(*inirp_init)(struct _adapter *adapter);
>         uint(*inirp_deinit)(struct _adapter *adapter);
>         struct usb_device *pusbdev;
> @@ -165,7 +166,9 @@ struct _adapter {
>         struct task_struct *cmdThread;
>          pid_t evtThread;
>         struct task_struct *xmitThread;
> +
>         pid_t recvThread;
> +
>         uint(*dvobj_init)(struct _adapter *adapter);
>         void (*dvobj_deinit)(struct _adapter *adapter);
>         struct net_device *pnetdev;


This are *all* false positives.

e.g:

 uint(*inirp_init)(struct _adapter *adapter);

Declares a pointer to a function which has one parameter
of type struct _adapter * and returns an uint.

Perhaps, we could fix checkpatch.pl to stop reporting this as warnings.

thanks,
Daniel.