[PATCH] staging: speakup: kobjects: Rearrange if statement

[PATCH] staging: speakup: kobjects: Rearrange if statement

[Tamara Diaconita]

Fixed the checkpath.pl issue:
CHECK: line over 80 characters.

Put a part of the if statement on a new line to have less than 80
characters.

Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
---
 drivers/staging/speakup/kobjects.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
index cd8eb12..a032932 100644
--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -106,7 +106,8 @@ static void report_char_chartab_status(int reset, int received, int used,
  * This is called when a user changes the characters or chartab parameters.
  */
 static ssize_t chars_chartab_store(struct kobject *kobj,
-				   struct kobj_attribute *attr, const char *buf, size_t count)
+				   struct kobj_attribute *attr,
+				   const char *buf, size_t count)
 {
 	char *cp = (char *)buf;
 	char *end = cp + count; /* the null at the end of the buffer */
@@ -404,7 +405,8 @@ static ssize_t synth_store(struct kobject *kobj, struct kobj_attribute *attr,
  * This is called when text is sent to the synth via the synth_direct file.
  */
 static ssize_t synth_direct_store(struct kobject *kobj,
-				  struct kobj_attribute *attr, const char *buf, size_t count)
+				  struct kobj_attribute *attr,
+				  const char *buf, size_t count)
 {
 	u_char tmp[256];
 	int len;
-- 
2.9.3

Re: [Outreachy kernel] [PATCH] staging: speakup: kobjects: Rearrange if statement

[Daniel Baluta]

On Tue, Mar 7, 2017 at 11:16 AM, Tamara Diaconita
<diaconitatamara@gmail.com> wrote:
> Fixed the checkpath.pl issue:
> CHECK: line over 80 characters.
>
> Put a part of the if statement on a new line to have less than 80
> characters.
>
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>

Hmm, there is no if in this patch.

> ---
>  drivers/staging/speakup/kobjects.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index cd8eb12..a032932 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -106,7 +106,8 @@ static void report_char_chartab_status(int reset, int received, int used,
>   * This is called when a user changes the characters or chartab parameters.
>   */
>  static ssize_t chars_chartab_store(struct kobject *kobj,
> -                                  struct kobj_attribute *attr, const char *buf, size_t count)
> +                                  struct kobj_attribute *attr,
> +                                  const char *buf, size_t count)
>  {
>         char *cp = (char *)buf;
>         char *end = cp + count; /* the null at the end of the buffer */
> @@ -404,7 +405,8 @@ static ssize_t synth_store(struct kobject *kobj, struct kobj_attribute *attr,
>   * This is called when text is sent to the synth via the synth_direct file.
>   */
>  static ssize_t synth_direct_store(struct kobject *kobj,
> -                                 struct kobj_attribute *attr, const char *buf, size_t count)
> +                                 struct kobj_attribute *attr,
> +                                 const char *buf, size_t count)
>  {
>         u_char tmp[256];
>         int len;
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170307091646.13717-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [Outreachy kernel] [PATCH] staging: speakup: kobjects: Rearrange if statement

[Julia Lawall]

On Tue, 7 Mar 2017, Tamara Diaconita wrote:

> Fixed the checkpath.pl issue:
> CHECK: line over 80 characters.
>
> Put a part of the if statement on a new line to have less than 80
> characters.
>
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
> ---
>  drivers/staging/speakup/kobjects.c | 6 ++++--

You have a bunch of patches on the same file.  In this case they need to
be in a series, even if they don't overlap. Otherwise, the recipient has
to spend time figuring out that they don't overlap.

julia

>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index cd8eb12..a032932 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -106,7 +106,8 @@ static void report_char_chartab_status(int reset, int received, int used,
>   * This is called when a user changes the characters or chartab parameters.
>   */
>  static ssize_t chars_chartab_store(struct kobject *kobj,
> -				   struct kobj_attribute *attr, const char *buf, size_t count)
> +				   struct kobj_attribute *attr,
> +				   const char *buf, size_t count)
>  {
>  	char *cp = (char *)buf;
>  	char *end = cp + count; /* the null at the end of the buffer */
> @@ -404,7 +405,8 @@ static ssize_t synth_store(struct kobject *kobj, struct kobj_attribute *attr,
>   * This is called when text is sent to the synth via the synth_direct file.
>   */
>  static ssize_t synth_direct_store(struct kobject *kobj,
> -				  struct kobj_attribute *attr, const char *buf, size_t count)
> +				  struct kobj_attribute *attr,
> +				  const char *buf, size_t count)
>  {
>  	u_char tmp[256];
>  	int len;
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170307091646.13717-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] staging: speakup: kobjects: Rearrange if statement

[Tamara Diaconita]

[-- Attachment #1.1: Type: text/plain, Size: 2819 bytes --]

Ok, I will put them in a set.

marți, 7 martie 2017, 18:11:01 UTC+2, Julia Lawall a scris:
>
>
> On Tue, 7 Mar 2017, Tamara Diaconita wrote: 
>
> > Fixed the checkpath.pl issue: 
> > CHECK: line over 80 characters. 
> > 
> > Put a part of the if statement on a new line to have less than 80 
> > characters. 
> > 
> > Signed-off-by: Tamara Diaconita <diaconit...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/speakup/kobjects.c | 6 ++++-- 
>
> You have a bunch of patches on the same file.  In this case they need to 
> be in a series, even if they don't overlap. Otherwise, the recipient has 
> to spend time figuring out that they don't overlap. 
>
> julia 
>
> >  1 file changed, 4 insertions(+), 2 deletions(-) 
> > 
> > diff --git a/drivers/staging/speakup/kobjects.c 
> b/drivers/staging/speakup/kobjects.c 
> > index cd8eb12..a032932 100644 
> > --- a/drivers/staging/speakup/kobjects.c 
> > +++ b/drivers/staging/speakup/kobjects.c 
> > @@ -106,7 +106,8 @@ static void report_char_chartab_status(int reset, 
> int received, int used, 
> >   * This is called when a user changes the characters or chartab 
> parameters. 
> >   */ 
> >  static ssize_t chars_chartab_store(struct kobject *kobj, 
> > -                                   struct kobj_attribute *attr, const 
> char *buf, size_t count) 
> > +                                   struct kobj_attribute *attr, 
> > +                                   const char *buf, size_t count) 
> >  { 
> >          char *cp = (char *)buf; 
> >          char *end = cp + count; /* the null at the end of the buffer */ 
> > @@ -404,7 +405,8 @@ static ssize_t synth_store(struct kobject *kobj, 
> struct kobj_attribute *attr, 
> >   * This is called when text is sent to the synth via the synth_direct 
> file. 
> >   */ 
> >  static ssize_t synth_direct_store(struct kobject *kobj, 
> > -                                  struct kobj_attribute *attr, const 
> char *buf, size_t count) 
> > +                                  struct kobj_attribute *attr, 
> > +                                  const char *buf, size_t count) 
> >  { 
> >          u_char tmp[256]; 
> >          int len; 
> > -- 
> > 2.9.3 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreachy-kern...@googlegroups.com <javascript:>. 
> > To post to this group, send email to outreach...@googlegroups.com 
> <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20170307091646.13717-1-diaconita.tamara%40gmail.com. 
>
> > For more options, visit https://groups.google.com/d/optout. 
> > 
>

[-- Attachment #1.2: Type: text/html, Size: 5145 bytes --]