checkpatch wrong error message

checkpatch wrong error message

[Daniel Baluta]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

Hi Joe,

Running ./scripts/checkpatch on the attached [1] patch i get the
following error:

ERROR: Please use 12 or more chars for the git commit ID like: 'commit
01234567890ab ("commit description")'
#6:
After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is

total: 1 errors, 0 warnings, 16 lines checked

0001-iio-kmx61-PM-Replace-CONFIG_PM_RUNTIME-with-CONFIG_P.patch has
style problems, please review.

As you can see b2b49ccbdd54 is exactly 12 chars so there shouldn't be
an error report.

Also example git ID is wrong 01234567890ab (13 chars) should be
0123456789ab (12 chars).

thanks,
Daniel.

[1] http://marc.info/?l=linux-iio&m=142079625602634&w=2

[-- Attachment #2: 0001-iio-kmx61-PM-Replace-CONFIG_PM_RUNTIME-with-CONFIG_P.patch --]
[-- Type: text/x-patch, Size: 1339 bytes --]

From 0f9fb78211d73484a4e919d3696f2358d20e9c2c Mon Sep 17 00:00:00 2001
From: Daniel Baluta <daniel.baluta@intel.com>
Date: Fri, 9 Jan 2015 11:17:27 +0200
Subject: [PATCH] iio kmx61 / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM

After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is
selected) PM_RUNTIME is always set if PM is set, so #ifdef blocks
depending on CONFIG_PM_RUNTIME may now be changed to depend on
CONFIG_PM.

Replace CONFIG_PM_RUNTIME with CONFIG_PM everywhere under
drivers/iio/imu/kmx61.c

Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
---
 drivers/iio/imu/kmx61.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
index 6178cea..a682dd1 100644
--- a/drivers/iio/imu/kmx61.c
+++ b/drivers/iio/imu/kmx61.c
@@ -735,7 +735,7 @@ static int kmx61_setup_any_motion_interrupt(struct kmx61_data *data,
  */
 static int kmx61_set_power_state(struct kmx61_data *data, bool on, u8 device)
 {
-#ifdef CONFIG_PM_RUNTIME
+#ifdef CONFIG_PM
 	int ret;
 
 	if (device & KMX61_ACC) {
@@ -1523,7 +1523,7 @@ static int kmx61_resume(struct device *dev)
 }
 #endif
 
-#ifdef CONFIG_PM_RUNTIME
+#ifdef CONFIG_PM
 static int kmx61_runtime_suspend(struct device *dev)
 {
 	struct kmx61_data *data = i2c_get_clientdata(to_i2c_client(dev));
-- 
1.9.1

Re: checkpatch wrong error message

[Joe Perches]

On Fri, 2015-01-09 at 13:57 +0200, Daniel Baluta wrote:
> Hi Joe,
> 
> Running ./scripts/checkpatch on the attached [1] patch i get the
> following error:
> 
> ERROR: Please use 12 or more chars for the git commit ID like: 'commit
> 01234567890ab ("commit description")'
> #6:
> After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is

checkpatch uses the same message for multiple forms.

There were some patches around to make this clearer.
https://lkml.org/lkml/2014/10/20/630

Your commit message does not have quotes around the text.

It should be:

After commit <2b49ccbdd54 ("PM: Kconfig: Set ...")

Re: checkpatch wrong error message

[Daniel Baluta]

On Fri, Jan 9, 2015 at 3:31 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2015-01-09 at 13:57 +0200, Daniel Baluta wrote:
>> Hi Joe,
>>
>> Running ./scripts/checkpatch on the attached [1] patch i get the
>> following error:
>>
>> ERROR: Please use 12 or more chars for the git commit ID like: 'commit
>> 01234567890ab ("commit description")'
>> #6:
>> After commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is
>
> checkpatch uses the same message for multiple forms.
>
> There were some patches around to make this clearer.
> https://lkml.org/lkml/2014/10/20/630
>
> Your commit message does not have quotes around the text.
>
> It should be:
>
> After commit <2b49ccbdd54 ("PM: Kconfig: Set ...")

:) I see, thanks!