[PATCH 1/3] Staging: wilc1000: Remove multiple blank lines

[PATCH 1/3] Staging: wilc1000: Remove multiple blank lines

[Aybuke Ozdemir]

Remove multiple blank lines. Problem found using checkpatch.pl
CHECK: Please don't use multiple blank lines.

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 3d45cc3..93f3c75 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -8,7 +8,6 @@
  *  @version	1.0
  */
 
-
 #include "coreconfigurator.h"
 #include "wilc_wlan_if.h"
 #include "wilc_wlan.h"
@@ -544,7 +543,6 @@ s32 ParseAssocRespInfo(u8 *pu8Buffer, u32 u32BufferLen,
 
 	*ppstrConnectRespInfo = pstrConnectRespInfo;
 
-
 	return s32Error;
 }
 
-- 
1.9.1

[PATCH 2/3] Staging: wilc1000: Remove unnecessary else after return

[Aybuke Ozdemir]

Problem found using checkpatch.pl:
WARNING: else is not generally useful after a break or return

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 93f3c75..cea7c6f 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -307,8 +307,7 @@ u8 *get_tim_elm(u8 *pu8msa, u16 u16RxLen, u16 u16TagParamOffset)
 	while (u16index < (u16RxLen - FCS_LEN)) {
 		if (pu8msa[u16index] == ITIM)
 			return &pu8msa[u16index];
-		else
-			u16index += (IE_HDR_LEN + pu8msa[u16index + 1]);
+		u16index += (IE_HDR_LEN + pu8msa[u16index + 1]);
 	}
 
 	return NULL;
@@ -324,9 +323,8 @@ u8 get_current_channel_802_11n(u8 *pu8msa, u16 u16RxLen)
 	while (index < (u16RxLen - FCS_LEN)) {
 		if (pu8msa[index] == IDSPARMS)
 			return pu8msa[index + 2];
-		else
-			/* Increment index by length information and header */
-			index += pu8msa[index + 1] + IE_HDR_LEN;
+		/* Increment index by length information and header */
+		index += pu8msa[index + 1] + IE_HDR_LEN;
 	}
 
 	/* Return current channel information from the MIB, if beacon/probe  */
-- 
1.9.1

[PATCH 3/3] Staging: wilc1000: Remove unnecessary parentheses

[Aybuke Ozdemir]

Problem found using checkpatch.pl:
CHECK: Unnecessary parentheses around pstrNetworkInfo->u8SsidLen

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
---
 drivers/staging/wilc1000/coreconfigurator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index cea7c6f..427adfd 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -422,7 +422,7 @@ s32 parse_network_info(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo)
 		pstrNetworkInfo->u64Tsf = u32Tsf_Lo | ((u64)u32Tsf_Hi << 32);
 
 		/* Get SSID */
-		get_ssid(pu8msa, pstrNetworkInfo->au8ssid, &(pstrNetworkInfo->u8SsidLen));
+		get_ssid(pu8msa, pstrNetworkInfo->au8ssid, &pstrNetworkInfo->u8SsidLen);
 
 		/* Get BSSID */
 		get_BSSID(pu8msa, pstrNetworkInfo->au8bssid);
-- 
1.9.1

Re: [Outreachy kernel] [PATCH 1/3] Staging: wilc1000: Remove multiple blank lines

[Daniel Baluta]

On Sat, Oct 17, 2015 at 3:25 PM, Aybuke Ozdemir <aybuke.147@gmail.com> wrote:
> Remove multiple blank lines. Problem found using checkpatch.pl
> CHECK: Please don't use multiple blank lines.
>
> Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>

Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>

> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 3d45cc3..93f3c75 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -8,7 +8,6 @@
>   *  @version   1.0
>   */
>
> -
>  #include "coreconfigurator.h"
>  #include "wilc_wlan_if.h"
>  #include "wilc_wlan.h"
> @@ -544,7 +543,6 @@ s32 ParseAssocRespInfo(u8 *pu8Buffer, u32 u32BufferLen,
>
>         *ppstrConnectRespInfo = pstrConnectRespInfo;
>
> -
>         return s32Error;
>  }
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1445084735-20133-1-git-send-email-aybuke.147%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [Outreachy kernel] [PATCH 3/3] Staging: wilc1000: Remove unnecessary parentheses

[Daniel Baluta]

On Sat, Oct 17, 2015 at 3:25 PM, Aybuke Ozdemir <aybuke.147@gmail.com> wrote:
> Problem found using checkpatch.pl:
> CHECK: Unnecessary parentheses around pstrNetworkInfo->u8SsidLen
>
> Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>

Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>

> ---
>  drivers/staging/wilc1000/coreconfigurator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index cea7c6f..427adfd 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -422,7 +422,7 @@ s32 parse_network_info(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo)
>                 pstrNetworkInfo->u64Tsf = u32Tsf_Lo | ((u64)u32Tsf_Hi << 32);
>
>                 /* Get SSID */
> -               get_ssid(pu8msa, pstrNetworkInfo->au8ssid, &(pstrNetworkInfo->u8SsidLen));
> +               get_ssid(pu8msa, pstrNetworkInfo->au8ssid, &pstrNetworkInfo->u8SsidLen);
>
>                 /* Get BSSID */
>                 get_BSSID(pu8msa, pstrNetworkInfo->au8bssid);
> --

Re: [Outreachy kernel] [PATCH 3/3] Staging: wilc1000: Remove unnecessary parentheses

[Daniel Baluta]

On Sun, Oct 18, 2015 at 8:12 PM, Daniel Baluta <daniel.baluta@gmail.com> wrote:
> On Sat, Oct 17, 2015 at 3:25 PM, Aybuke Ozdemir <aybuke.147@gmail.com> wrote:
>> Problem found using checkpatch.pl:
>> CHECK: Unnecessary parentheses around pstrNetworkInfo->u8SsidLen
>>
>> Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
>
> Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>

Ignore this, the patches are already applied.

Re: [Outreachy kernel] [PATCH 3/3] Staging: wilc1000: Remove unnecessary parentheses

[Greg KH]

On Sun, Oct 18, 2015 at 08:16:21PM +0300, Daniel Baluta wrote:
> On Sun, Oct 18, 2015 at 8:12 PM, Daniel Baluta <daniel.baluta@gmail.com> wrote:
> > On Sat, Oct 17, 2015 at 3:25 PM, Aybuke Ozdemir <aybuke.147@gmail.com> wrote:
> >> Problem found using checkpatch.pl:
> >> CHECK: Unnecessary parentheses around pstrNetworkInfo->u8SsidLen
> >>
> >> Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
> >
> > Reviewed-by: Daniel Baluta <daniel.baluta@intel.com>
> 
> Ignore this, the patches are already applied.

Sorry, was too fast :)