[PATCH 1/1 linux-next] configfs: unexport/make static config_item_init()

[PATCH 1/1 linux-next] configfs: unexport/make static config_item_init()

[Fabian Frederick]

config_item_init() is only used in item.c

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 fs/configfs/item.c       | 3 +--
 include/linux/configfs.h | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/configfs/item.c b/fs/configfs/item.c
index e65f9ff..4d6a30e 100644
--- a/fs/configfs/item.c
+++ b/fs/configfs/item.c
@@ -47,12 +47,11 @@ static void config_item_release(struct kref *kref);
  *	config_item_init - initialize item.
  *	@item:	item in question.
  */
-void config_item_init(struct config_item *item)
+static void config_item_init(struct config_item *item)
 {
 	kref_init(&item->ci_kref);
 	INIT_LIST_HEAD(&item->ci_entry);
 }
-EXPORT_SYMBOL(config_item_init);
 
 /**
  *	config_item_set_name - Set the name of an item
diff --git a/include/linux/configfs.h b/include/linux/configfs.h
index 34025df..c9e5c57 100644
--- a/include/linux/configfs.h
+++ b/include/linux/configfs.h
@@ -71,7 +71,6 @@ static inline char *config_item_name(struct config_item * item)
 	return item->ci_name;
 }
 
-extern void config_item_init(struct config_item *);
 extern void config_item_init_type_name(struct config_item *item,
 				       const char *name,
 				       struct config_item_type *type);
-- 
1.9.1

Re: [PATCH 1/1 linux-next] configfs: unexport/make static config_item_init()

[Daniel Baluta]

On Wed, Apr 29, 2015 at 8:01 PM, Fabian Frederick <fabf@skynet.be> wrote:
> config_item_init() is only used in item.c
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Nack! Have a look at drivers/usb/gadget/configfs.c
> ---
>  fs/configfs/item.c       | 3 +--
>  include/linux/configfs.h | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/configfs/item.c b/fs/configfs/item.c
> index e65f9ff..4d6a30e 100644
> --- a/fs/configfs/item.c
> +++ b/fs/configfs/item.c
> @@ -47,12 +47,11 @@ static void config_item_release(struct kref *kref);
>   *     config_item_init - initialize item.
>   *     @item:  item in question.
>   */
> -void config_item_init(struct config_item *item)
> +static void config_item_init(struct config_item *item)
>  {
>         kref_init(&item->ci_kref);
>         INIT_LIST_HEAD(&item->ci_entry);
>  }
> -EXPORT_SYMBOL(config_item_init);
>
>  /**
>   *     config_item_set_name - Set the name of an item
> diff --git a/include/linux/configfs.h b/include/linux/configfs.h
> index 34025df..c9e5c57 100644
> --- a/include/linux/configfs.h
> +++ b/include/linux/configfs.h
> @@ -71,7 +71,6 @@ static inline char *config_item_name(struct config_item * item)
>         return item->ci_name;
>  }
>
> -extern void config_item_init(struct config_item *);
>  extern void config_item_init_type_name(struct config_item *item,
>                                        const char *name,
>                                        struct config_item_type *type);
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1 linux-next] configfs: unexport/make static config_item_init()

[Fabian Frederick]

> On 14 May 2015 at 12:41 Daniel Baluta <daniel.baluta@gmail.com> wrote:
>
>
> On Wed, Apr 29, 2015 at 8:01 PM, Fabian Frederick <fabf@skynet.be> wrote:
> > config_item_init() is only used in item.c
> >
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
>
> Nack! Have a look at drivers/usb/gadget/configfs.c

That file only uses config_item_init_type_name() not config_item_init().

Re: [PATCH 1/1 linux-next] configfs: unexport/make static config_item_init()

[Daniel Baluta]

On Thu, May 14, 2015 at 10:14 PM, Fabian Frederick <fabf@skynet.be> wrote:
>
>
>> On 14 May 2015 at 12:41 Daniel Baluta <daniel.baluta@gmail.com> wrote:
>>
>>
>> On Wed, Apr 29, 2015 at 8:01 PM, Fabian Frederick <fabf@skynet.be> wrote:
>> > config_item_init() is only used in item.c
>> >
>> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
>>
>> Nack! Have a look at drivers/usb/gadget/configfs.c
>
> That file only uses config_item_init_type_name() not config_item_init().

Oh, that's right. My fault!