* [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
@ 2014-02-03 7:07 Taku Izumi
2014-02-12 0:49 ` Bjorn Helgaas
0 siblings, 1 reply; 16+ messages in thread
From: Taku Izumi @ 2014-02-03 7:07 UTC (permalink / raw)
To: linux-pci, bhelgaas, yinghai
I found the problem that the present bit does not be cleared
though the slot is empty.
Step to reproduce:
# cd /sys/bus/pci/slots/66
# cat adapter
0
--- (insert PCIe card on slot#66) ---
# cat adapter
1
# echo 1 > power
# echo 0 > power
--- (eject PCIe card on slot#66) ---
# cat adapter
1
==> should be 0.
According to git-bisect this is caused by:
2debd9289997fc5d1c0043b41201a8b40d5e11d0
PCI: pciehp: Disable/enable link during slot power off/on
is the first bad commit
By reverting the above patch, this bug can be solved.
And I also found this can be fixed by changing the timing of link-disable
during power off the slot.
So, this patch changes the timing of link-disable during power off.
Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
---
drivers/pci/hotplug/pciehp_hpc.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
index 14acfcc..163f0b4 100644
--- a/drivers/pci/hotplug/pciehp_hpc.c
+++ b/drivers/pci/hotplug/pciehp_hpc.c
@@ -508,7 +508,12 @@ void pciehp_power_off_slot(struct slot * slot)
{
struct controller *ctrl = slot->ctrl;
- /* Disable the link at first */
+ pcie_write_cmd(ctrl, PCI_EXP_SLTCTL_PWR_OFF, PCI_EXP_SLTCTL_PCC);
+ ctrl_dbg(ctrl, "%s: SLOTCTRL %x write cmd %x\n", __func__,
+ pci_pcie_cap(ctrl->pcie->port) + PCI_EXP_SLTCTL,
+ PCI_EXP_SLTCTL_PWR_OFF);
+
+ /* Disable the link */
pciehp_link_disable(ctrl);
/* wait the link is down */
if (ctrl->link_active_reporting)
@@ -516,10 +521,6 @@ void pciehp_power_off_slot(struct slot * slot)
else
msleep(1000);
- pcie_write_cmd(ctrl, PCI_EXP_SLTCTL_PWR_OFF, PCI_EXP_SLTCTL_PCC);
- ctrl_dbg(ctrl, "%s: SLOTCTRL %x write cmd %x\n", __func__,
- pci_pcie_cap(ctrl->pcie->port) + PCI_EXP_SLTCTL,
- PCI_EXP_SLTCTL_PWR_OFF);
}
static irqreturn_t pcie_isr(int irq, void *dev_id)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-03 7:07 [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty Taku Izumi
@ 2014-02-12 0:49 ` Bjorn Helgaas
2014-02-12 8:00 ` Izumi, Taku
0 siblings, 1 reply; 16+ messages in thread
From: Bjorn Helgaas @ 2014-02-12 0:49 UTC (permalink / raw)
To: Taku Izumi; +Cc: linux-pci, yinghai, Rajat Jain
[+cc Rajat]
On Mon, Feb 03, 2014 at 04:07:24PM +0900, Taku Izumi wrote:
>
> I found the problem that the present bit does not be cleared
> though the slot is empty.
>
> Step to reproduce:
>
> # cd /sys/bus/pci/slots/66
> # cat adapter
> 0
> --- (insert PCIe card on slot#66) ---
> # cat adapter
> 1
> # echo 1 > power
> # echo 0 > power
> --- (eject PCIe card on slot#66) ---
> # cat adapter
> 1
> ==> should be 0.
>
> According to git-bisect this is caused by:
> 2debd9289997fc5d1c0043b41201a8b40d5e11d0
> PCI: pciehp: Disable/enable link during slot power off/on
> is the first bad commit
>
> By reverting the above patch, this bug can be solved.
> And I also found this can be fixed by changing the timing of link-disable
> during power off the slot.
> So, this patch changes the timing of link-disable during power off.
Hi Taku,
Thanks a lot for finding and bisecting this problem. I recently merged
some patches from Rajat that partially revert 2debd9289997. Can you try
out my pci/pciehp branch and see whether it is enough to fix the problem
for you?
Here's the branch:
http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/pciehp
and the specific change Rajat made is:
http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/pciehp&id=b1811d2455f32754cc3d8725bf2e961c5eda2a72
Let me know if that isn't enough to fix the problem you're seeing, and we
can work on it some more.
Bjorn
>
> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
> ---
> drivers/pci/hotplug/pciehp_hpc.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
> index 14acfcc..163f0b4 100644
> --- a/drivers/pci/hotplug/pciehp_hpc.c
> +++ b/drivers/pci/hotplug/pciehp_hpc.c
> @@ -508,7 +508,12 @@ void pciehp_power_off_slot(struct slot * slot)
> {
> struct controller *ctrl = slot->ctrl;
>
> - /* Disable the link at first */
> + pcie_write_cmd(ctrl, PCI_EXP_SLTCTL_PWR_OFF, PCI_EXP_SLTCTL_PCC);
> + ctrl_dbg(ctrl, "%s: SLOTCTRL %x write cmd %x\n", __func__,
> + pci_pcie_cap(ctrl->pcie->port) + PCI_EXP_SLTCTL,
> + PCI_EXP_SLTCTL_PWR_OFF);
> +
> + /* Disable the link */
> pciehp_link_disable(ctrl);
> /* wait the link is down */
> if (ctrl->link_active_reporting)
> @@ -516,10 +521,6 @@ void pciehp_power_off_slot(struct slot * slot)
> else
> msleep(1000);
>
> - pcie_write_cmd(ctrl, PCI_EXP_SLTCTL_PWR_OFF, PCI_EXP_SLTCTL_PCC);
> - ctrl_dbg(ctrl, "%s: SLOTCTRL %x write cmd %x\n", __func__,
> - pci_pcie_cap(ctrl->pcie->port) + PCI_EXP_SLTCTL,
> - PCI_EXP_SLTCTL_PWR_OFF);
> }
>
> static irqreturn_t pcie_isr(int irq, void *dev_id)
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-12 0:49 ` Bjorn Helgaas
@ 2014-02-12 8:00 ` Izumi, Taku
2014-02-12 16:56 ` Bjorn Helgaas
0 siblings, 1 reply; 16+ messages in thread
From: Izumi, Taku @ 2014-02-12 8:00 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, yinghai, Rajat Jain
Hi Bjorn,
> Hi Taku,
>
> Thanks a lot for finding and bisecting this problem. I recently merged
> some patches from Rajat that partially revert 2debd9289997. Can you try
> out my pci/pciehp branch and see whether it is enough to fix the problem
> for you?
>
> Here's the branch:
> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/pciehp
>
> and the specific change Rajat made is:
> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/pciehp&id=b1811d2455f32754cc3d8725bf2e961c
> 5eda2a72
>
> Let me know if that isn't enough to fix the problem you're seeing, and we
> can work on it some more.
I tested the kernel checkouted from remotes/origin/pci/pciehp.
The original problem I reported was fixed.
However the sequence of hot-plug operation got changed.
The slot power becomes ON the moment when I insert PCIe card on the slot.
This behavior is unacceptable to me.
(before)
- hot-add
1. insert PCIe card
2. echo 1 > power
- hot-remove
1. echo 0 > power
2. eject PCIe card
(after)
- hot-add
1. insert PCIe card (and automatically power-on)
- hot-remove
1. echo 0 > power
2. eject PCIe card
Best regards,
Taku Izumi
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-12 8:00 ` Izumi, Taku
@ 2014-02-12 16:56 ` Bjorn Helgaas
2014-02-12 18:11 ` Rajat Jain
0 siblings, 1 reply; 16+ messages in thread
From: Bjorn Helgaas @ 2014-02-12 16:56 UTC (permalink / raw)
To: Izumi, Taku; +Cc: linux-pci, yinghai, Rajat Jain
On Wed, Feb 12, 2014 at 1:00 AM, Izumi, Taku <izumi.taku@jp.fujitsu.com> wrote:
> Hi Bjorn,
>
>> Hi Taku,
>>
>> Thanks a lot for finding and bisecting this problem. I recently merged
>> some patches from Rajat that partially revert 2debd9289997. Can you try
>> out my pci/pciehp branch and see whether it is enough to fix the problem
>> for you?
>>
>> Here's the branch:
>> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/pciehp
>>
>> and the specific change Rajat made is:
>> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/pciehp&id=b1811d2455f32754cc3d8725bf2e961c
>> 5eda2a72
>>
>> Let me know if that isn't enough to fix the problem you're seeing, and we
>> can work on it some more.
>
> I tested the kernel checkouted from remotes/origin/pci/pciehp.
> The original problem I reported was fixed.
> However the sequence of hot-plug operation got changed.
> The slot power becomes ON the moment when I insert PCIe card on the slot.
> This behavior is unacceptable to me.
>
> (before)
> - hot-add
> 1. insert PCIe card
> 2. echo 1 > power
> - hot-remove
> 1. echo 0 > power
> 2. eject PCIe card
>
> (after)
> - hot-add
> 1. insert PCIe card (and automatically power-on)
>
> - hot-remove
> 1. echo 0 > power
> 2. eject PCIe card
Huh, that doesn't sound good. Does your slot have an attention
button? Can you collect the "lspci -vvv" output for the Downstream
Port leading to this slot?
I think that for ExpressCard and similar devices, we want to turn on
the device and attach a driver as soon as the card is inserted. But
in your case, I assume we want a model like that in Table 2-7 of the
"PCI Standard Hot-Plug Controller and Subsystem Specification," rev
1.0, i.e., "Hot Insertion Initiated via Software UI." So there must
be some way to differentiate an ExpressCard slot from a slot like
yours.
Bjorn
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-12 16:56 ` Bjorn Helgaas
@ 2014-02-12 18:11 ` Rajat Jain
2014-02-13 8:00 ` Izumi, Taku
0 siblings, 1 reply; 16+ messages in thread
From: Rajat Jain @ 2014-02-12 18:11 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Izumi, Taku, linux-pci, yinghai, Rajat Jain, Guenter Roeck
Hello,
On Wed, Feb 12, 2014 at 8:56 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Wed, Feb 12, 2014 at 1:00 AM, Izumi, Taku <izumi.taku@jp.fujitsu.com> wrote:
>> Hi Bjorn,
>>
>>> Hi Taku,
>>>
>>> Thanks a lot for finding and bisecting this problem. I recently merged
>>> some patches from Rajat that partially revert 2debd9289997. Can you try
>>> out my pci/pciehp branch and see whether it is enough to fix the problem
>>> for you?
>>>
>>> Here's the branch:
>>> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/pciehp
>>>
>>> and the specific change Rajat made is:
>>> http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/pciehp&id=b1811d2455f32754cc3d8725bf2e961c
>>> 5eda2a72
>>>
>>> Let me know if that isn't enough to fix the problem you're seeing, and we
>>> can work on it some more.
>>
>> I tested the kernel checkouted from remotes/origin/pci/pciehp.
>> The original problem I reported was fixed.
>> However the sequence of hot-plug operation got changed.
>> The slot power becomes ON the moment when I insert PCIe card on the slot.
>> This behavior is unacceptable to me.
>>
>> (before)
>> - hot-add
>> 1. insert PCIe card
>> 2. echo 1 > power
>> - hot-remove
>> 1. echo 0 > power
>> 2. eject PCIe card
>>
>> (after)
>> - hot-add
>> 1. insert PCIe card (and automatically power-on)
>>
>> - hot-remove
>> 1. echo 0 > power
>> 2. eject PCIe card
>
> Huh, that doesn't sound good. Does your slot have an attention
> button? Can you collect the "lspci -vvv" output for the Downstream
> Port leading to this slot?
If there is no attention button, then the behavior seen, matches with
what I expected of the code.
Seemingly, the HW does not have a power controller (and attention
button), thus the power is automatically turned on (by HW) when card
is inserted and the link comes up. Thus prior to link state based
hot-plug, "echo 1 > power" used to do a little else than initiate a
rescan for this particular HW.
>
> I think that for ExpressCard and similar devices, we want to turn on
> the device and attach a driver as soon as the card is inserted. But
> in your case, I assume we want a model like that in Table 2-7 of the
> "PCI Standard Hot-Plug Controller and Subsystem Specification," rev
> 1.0, i.e., "Hot Insertion Initiated via Software UI." So there must
> be some way to differentiate an ExpressCard slot from a slot like
> yours.
Yes, that would help if there was some way.
Thanks,
Rajat
>
> Bjorn
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-12 18:11 ` Rajat Jain
@ 2014-02-13 8:00 ` Izumi, Taku
2014-02-13 16:03 ` Rajat Jain
0 siblings, 1 reply; 16+ messages in thread
From: Izumi, Taku @ 2014-02-13 8:00 UTC (permalink / raw)
To: rajatxjain, Bjorn Helgaas; +Cc: linux-pci, yinghai, Rajat Jain, Guenter Roeck
SGkgQmpvcm4sIFJhamF0LA0KDQo+ID4gSHVoLCB0aGF0IGRvZXNuJ3Qgc291bmQgZ29vZC4gIERv
ZXMgeW91ciBzbG90IGhhdmUgYW4gYXR0ZW50aW9uDQo+ID4gYnV0dG9uPyAgQ2FuIHlvdSBjb2xs
ZWN0IHRoZSAibHNwY2kgLXZ2diIgb3V0cHV0IGZvciB0aGUgRG93bnN0cmVhbQ0KPiA+IFBvcnQg
bGVhZGluZyB0byB0aGlzIHNsb3Q/DQoNCiAgIFRoZSBzbG90cyBoYXZlIG5vIEF0dGVudGlvbiBi
dXR0b24gYW5kIGFyZSBub3QgZm9yIEV4cHJlc3NDYXJkLg0KICAgbHNwY2kgLXZ2diBvdXRwdXQg
aXM6DQoNCiAgICAgICAgQ29udHJvbDogSS9PKyBNZW0rIEJ1c01hc3RlcisgU3BlY0N5Y2xlLSBN
ZW1XSU5WLSBWR0FTbm9vcC0gUGFyRXJyKyBTdGVwcGluZy0gU0VSUisgRmFzdEIyQi0gRGlzSU5U
eCsNCiAgICAgICAgU3RhdHVzOiBDYXArIDY2TUh6LSBVREYtIEZhc3RCMkItIFBhckVyci0gREVW
U0VMPWZhc3QgPlRBYm9ydC0gPFRBYm9ydC0gPE1BYm9ydC0gPlNFUlItIDxQRVJSLSBJTlR4LQ0K
ICAgICAgICBMYXRlbmN5OiAwDQogICAgICAgIEJ1czogcHJpbWFyeT0yYywgc2Vjb25kYXJ5PTJk
LCBzdWJvcmRpbmF0ZT0yZiwgc2VjLWxhdGVuY3k9MA0KICAgICAgICBJL08gYmVoaW5kIGJyaWRn
ZTogMDAwMGYwMDAtMDAwMDBmZmYNCiAgICAgICAgTWVtb3J5IGJlaGluZCBicmlkZ2U6IGIxODAw
MDAwLWIxZmZmZmZmDQogICAgICAgIFByZWZldGNoYWJsZSBtZW1vcnkgYmVoaW5kIGJyaWRnZTog
MDAwMDAwMDBhZTgwMDAwMC0wMDAwMDAwMGFlZmZmZmZmDQogICAgICAgIFNlY29uZGFyeSBzdGF0
dXM6IDY2TUh6LSBGYXN0QjJCLSBQYXJFcnItIERFVlNFTD1mYXN0ID5UQWJvcnQtIDxUQWJvcnQt
IDxNQWJvcnQtIDxTRVJSLSA8UEVSUi0NCiAgICAgICAgQnJpZGdlQ3RsOiBQYXJpdHktIFNFUlIr
IE5vSVNBLSBWR0EtIE1BYm9ydC0gPlJlc2V0LSBGYXN0QjJCLQ0KICAgICAgICAgICAgICAgIFBy
aURpc2NUbXItIFNlY0Rpc2NUbXItIERpc2NUbXJTdGF0LSBEaXNjVG1yU0VSUkVuLQ0KICAgICAg
ICBDYXBhYmlsaXRpZXM6IFs0MF0gUG93ZXIgTWFuYWdlbWVudCB2ZXJzaW9uIDMNCiAgICAgICAg
ICAgICAgICBGbGFnczogUE1FQ2xrLSBEU0ktIEQxLSBEMi0gQXV4Q3VycmVudD0wbUEgUE1FKEQw
KyxEMS0sRDItLEQzaG90KyxEM2NvbGQrKQ0KICAgICAgICAgICAgICAgIFN0YXR1czogRDAgTm9T
b2Z0UnN0KyBQTUUtRW5hYmxlLSBEU2VsPTAgRFNjYWxlPTAgUE1FLQ0KICAgICAgICBDYXBhYmls
aXRpZXM6IFs0OF0gTVNJOiBFbmFibGUrIENvdW50PTEvOCBNYXNrYWJsZSsgNjRiaXQrDQogICAg
ICAgICAgICAgICAgQWRkcmVzczogMDAwMDAwMDBmZWUwMDUxOCAgRGF0YTogMDAwMA0KICAgICAg
ICAgICAgICAgIE1hc2tpbmc6IDAwMDAwMGZlICBQZW5kaW5nOiAwMDAwMDAwMA0KICAgICAgICBD
YXBhYmlsaXRpZXM6IFs2OF0gRXhwcmVzcyAodjIpIERvd25zdHJlYW0gUG9ydCAoU2xvdCspLCBN
U0kgMDANCiAgICAgICAgICAgICAgICBEZXZDYXA6IE1heFBheWxvYWQgMjA0OCBieXRlcywgUGhh
bnRGdW5jIDAsIExhdGVuY3kgTDBzIDw2NG5zLCBMMSA8MXVzDQogICAgICAgICAgICAgICAgICAg
ICAgICBFeHRUYWctIFJCRSsgRkxSZXNldC0NCiAgICAgICAgICAgICAgICBEZXZDdGw6IFJlcG9y
dCBlcnJvcnM6IENvcnJlY3RhYmxlKyBOb24tRmF0YWwrIEZhdGFsKyBVbnN1cHBvcnRlZC0NCiAg
ICAgICAgICAgICAgICAgICAgICAgIFJseGRPcmQrIEV4dFRhZy0gUGhhbnRGdW5jLSBBdXhQd3It
IE5vU25vb3ArDQogICAgICAgICAgICAgICAgICAgICAgICBNYXhQYXlsb2FkIDEyOCBieXRlcywg
TWF4UmVhZFJlcSAxMjggYnl0ZXMNCiAgICAgICAgICAgICAgICBEZXZTdGE6IENvcnJFcnIrIFVu
Y29yckVyci0gRmF0YWxFcnItIFVuc3VwcFJlcSsgQXV4UHdyLSBUcmFuc1BlbmQtDQogICAgICAg
ICAgICAgICAgTG5rQ2FwOiBQb3J0ICMxLCBTcGVlZCA4R1QvcywgV2lkdGggeDgsIEFTUE0gTDEs
IExhdGVuY3kgTDAgPDR1cywgTDEgPDR1cw0KICAgICAgICAgICAgICAgICAgICAgICAgQ2xvY2tQ
TS0gU3VycHJpc2UrIExMQWN0UmVwKyBCd05vdCsNCiAgICAgICAgICAgICAgICBMbmtDdGw6IEFT
UE0gRGlzYWJsZWQ7IERpc2FibGVkLSBSZXRyYWluLSBDb21tQ2xrLQ0KICAgICAgICAgICAgICAg
ICAgICAgICAgRXh0U3luY2gtIENsb2NrUE0tIEF1dFdpZERpcy0gQldJbnQtIEF1dEJXSW50LQ0K
ICAgICAgICAgICAgICAgIExua1N0YTogU3BlZWQgMi41R1QvcywgV2lkdGggeDAsIFRyRXJyLSBU
cmFpbi0gU2xvdENsaysgRExBY3RpdmUtIEJXTWdtdC0gQUJXTWdtdC0NCiAgICAgICAgICAgICAg
ICBTbHRDYXA6IEF0dG5CdG4tIFB3ckN0cmwrIE1STCsgQXR0bkluZCsgUHdySW5kKyBIb3RQbHVn
KyBTdXJwcmlzZS0NCiAgICAgICAgICAgICAgICAgICAgICAgIFNsb3QgIzY3LCBQb3dlckxpbWl0
IDI1LjAwMFc7IEludGVybG9jay0gTm9Db21wbC0NCiAgICAgICAgICAgICAgICBTbHRDdGw6IEVu
YWJsZTogQXR0bkJ0bi0gUHdyRmx0LSBNUkwrIFByZXNEZXQrIENtZENwbHQrIEhQSXJxKyBMaW5r
Q2hnKw0KICAgICAgICAgICAgICAgICAgICAgICAgQ29udHJvbDogQXR0bkluZCBPZmYsIFB3cklu
ZCBPZmYsIFBvd2VyKyBJbnRlcmxvY2stDQogICAgICAgICAgICAgICAgU2x0U3RhOiBTdGF0dXM6
IEF0dG5CdG4tIFBvd2VyRmx0LSBNUkwtIENtZENwbHQtIFByZXNEZXQtIEludGVybG9jay0NCiAg
ICAgICAgICAgICAgICAgICAgICAgIENoYW5nZWQ6IE1STC0gUHJlc0RldC0gTGlua1N0YXRlLQ0K
ICAgICAgICAgICAgICAgIERldkNhcDI6IENvbXBsZXRpb24gVGltZW91dDogTm90IFN1cHBvcnRl
ZCwgVGltZW91dERpcy0sIExUUissIE9CRkYgVmlhIG1lc3NhZ2UgQVJJRndkKw0KICAgICAgICAg
ICAgICAgIERldkN0bDI6IENvbXBsZXRpb24gVGltZW91dDogNTB1cyB0byA1MG1zLCBUaW1lb3V0
RGlzLSwgTFRSLSwgT0JGRiBEaXNhYmxlZCBBUklGd2QtDQogICAgICAgICAgICAgICAgTG5rQ3Rs
MjogVGFyZ2V0IExpbmsgU3BlZWQ6IDhHVC9zLCBFbnRlckNvbXBsaWFuY2UtIFNwZWVkRGlzLSwg
U2VsZWN0YWJsZSBEZS1lbXBoYXNpczogLTZkQg0KICAgICAgICAgICAgICAgICAgICAgICAgIFRy
YW5zbWl0IE1hcmdpbjogTm9ybWFsIE9wZXJhdGluZyBSYW5nZSwgRW50ZXJNb2RpZmllZENvbXBs
aWFuY2UtIENvbXBsaWFuY2VTT1MtDQogICAgICAgICAgICAgICAgICAgICAgICAgQ29tcGxpYW5j
ZSBEZS1lbXBoYXNpczogLTZkQg0KICAgICAgICAgICAgICAgIExua1N0YTI6IEN1cnJlbnQgRGUt
ZW1waGFzaXMgTGV2ZWw6IC0zLjVkQiwgRXF1YWxpemF0aW9uQ29tcGxldGUtLCBFcXVhbGl6YXRp
b25QaGFzZTEtDQogICAgICAgICAgICAgICAgICAgICAgICAgRXF1YWxpemF0aW9uUGhhc2UyLSwg
RXF1YWxpemF0aW9uUGhhc2UzLSwgTGlua0VxdWFsaXphdGlvblJlcXVlc3QtDQogICAgICAgIENh
cGFiaWxpdGllczogW2E0XSBTdWJzeXN0ZW06IEZ1aml0c3UgTGltaXRlZC4gRGV2aWNlIDE4MDQN
CiAgICAgICAgQ2FwYWJpbGl0aWVzOiBbMTAwIHYxXSBEZXZpY2UgU2VyaWFsIE51bWJlciBhYS04
Ny0wMC0xMC1iNS1kZi0wZS0wMA0KICAgICAgICBDYXBhYmlsaXRpZXM6IFtmYjQgdjFdIEFkdmFu
Y2VkIEVycm9yIFJlcG9ydGluZw0KICAgICAgICAgICAgICAgIFVFU3RhOiAgRExQLSBTREVTLSBU
TFAtIEZDUC0gQ21wbHRUTy0gQ21wbHRBYnJ0LSBVbnhDbXBsdC0gUnhPRi0gTWFsZlRMUC0gRUNS
Qy0gVW5zdXBSZXEtIEFDU1Zpb2wtDQogICAgICAgICAgICAgICAgVUVNc2s6ICBETFAtIFNERVMt
IFRMUC0gRkNQLSBDbXBsdFRPLSBDbXBsdEFicnQtIFVueENtcGx0LSBSeE9GLSBNYWxmVExQLSBF
Q1JDKyBVbnN1cFJlcSsgQUNTVmlvbC0NCiAgICAgICAgICAgICAgICBVRVN2cnQ6IERMUCsgU0RF
UysgVExQKyBGQ1ArIENtcGx0VE8tIENtcGx0QWJydCsgVW54Q21wbHQrIFJ4T0YrIE1hbGZUTFAr
IEVDUkMrIFVuc3VwUmVxLSBBQ1NWaW9sKw0KICAgICAgICAgICAgICAgIENFU3RhOiAgUnhFcnIt
IEJhZFRMUC0gQmFkRExMUC0gUm9sbG92ZXItIFRpbWVvdXQtIE5vbkZhdGFsRXJyKw0KICAgICAg
ICAgICAgICAgIENFTXNrOiAgUnhFcnItIEJhZFRMUC0gQmFkRExMUC0gUm9sbG92ZXItIFRpbWVv
dXQtIE5vbkZhdGFsRXJyKw0KICAgICAgICAgICAgICAgIEFFUkNhcDogRmlyc3QgRXJyb3IgUG9p
bnRlcjogMWYsIEdlbkNhcCsgQ0dlbkVuLSBDaGtDYXArIENoa0VuLQ0KICAgICAgICBDYXBhYmls
aXRpZXM6IFsxMzggdjFdIFBvd2VyIEJ1ZGdldGluZyA8Pz4NCiAgICAgICAgQ2FwYWJpbGl0aWVz
OiBbMTBjIHYxXSAjMTkNCiAgICAgICAgQ2FwYWJpbGl0aWVzOiBbMTQ4IHYxXSBWaXJ0dWFsIENo
YW5uZWwNCiAgICAgICAgICAgICAgICBDYXBzOiAgIExQRVZDPTAgUmVmQ2xrPTEwMG5zIFBBVEVu
dHJ5Qml0cz0xDQogICAgICAgICAgICAgICAgQXJiOiAgICBGaXhlZC0gV1JSMzItIFdSUjY0LSBX
UlIxMjgtDQogICAgICAgICAgICAgICAgQ3RybDogICBBcmJTZWxlY3Q9Rml4ZWQNCiAgICAgICAg
ICAgICAgICBTdGF0dXM6IEluUHJvZ3Jlc3MtDQogICAgICAgICAgICAgICAgVkMwOiAgICBDYXBz
OiAgIFBBVE9mZnNldD0wMCBNYXhUaW1lU2xvdHM9MSBSZWpTbm9vcFRyYW5zLQ0KICAgICAgICAg
ICAgICAgICAgICAgICAgQXJiOiAgICBGaXhlZCsgV1JSMzItIFdSUjY0LSBXUlIxMjgtIFRXUlIx
MjgtIFdSUjI1Ni0NCiAgICAgICAgICAgICAgICAgICAgICAgIEN0cmw6ICAgRW5hYmxlKyBJRD0w
IEFyYlNlbGVjdD1GaXhlZCBUQy9WQz1mZg0KICAgICAgICAgICAgICAgICAgICAgICAgU3RhdHVz
OiBOZWdvUGVuZGluZysgSW5Qcm9ncmVzcy0NCiAgICAgICAgQ2FwYWJpbGl0aWVzOiBbZTAwIHYx
XSAjMTINCiAgICAgICAgQ2FwYWJpbGl0aWVzOiBbZjI0IHYxXSBBY2Nlc3MgQ29udHJvbCBTZXJ2
aWNlcw0KICAgICAgICAgICAgICAgIEFDU0NhcDogU3JjVmFsaWQrIFRyYW5zQmxrKyBSZXFSZWRp
cisgQ21wbHRSZWRpcisgVXBzdHJlYW1Gd2QrIEVncmVzc0N0cmwrIERpcmVjdFRyYW5zKw0KICAg
ICAgICAgICAgICAgIEFDU0N0bDogU3JjVmFsaWQtIFRyYW5zQmxrLSBSZXFSZWRpci0gQ21wbHRS
ZWRpci0gVXBzdHJlYW1Gd2QtIEVncmVzc0N0cmwtIERpcmVjdFRyYW5zLQ0KICAgICAgICBDYXBh
YmlsaXRpZXM6IFtiNzAgdjFdIFZlbmRvciBTcGVjaWZpYyBJbmZvcm1hdGlvbjogSUQ9MDAwMSBS
ZXY9MCBMZW49MDEwIDw/Pg0KICAgICAgICBLZXJuZWwgZHJpdmVyIGluIHVzZTogcGNpZXBvcnQN
Cg0KDQo+IElmIHRoZXJlIGlzIG5vIGF0dGVudGlvbiBidXR0b24sIHRoZW4gdGhlIGJlaGF2aW9y
IHNlZW4sIG1hdGNoZXMgd2l0aA0KPiB3aGF0IEkgZXhwZWN0ZWQgb2YgdGhlIGNvZGUuDQo+IA0K
PiBTZWVtaW5nbHksIHRoZSBIVyBkb2VzIG5vdCBoYXZlIGEgcG93ZXIgY29udHJvbGxlciAoYW5k
IGF0dGVudGlvbg0KPiBidXR0b24pLCB0aHVzIHRoZSBwb3dlciBpcyBhdXRvbWF0aWNhbGx5IHR1
cm5lZCBvbiAoYnkgSFcpIHdoZW4gY2FyZA0KPiBpcyBpbnNlcnRlZCBhbmQgdGhlIGxpbmsgY29t
ZXMgdXAuIFRodXMgcHJpb3IgdG8gbGluayBzdGF0ZSBiYXNlZA0KPiBob3QtcGx1ZywgImVjaG8g
MSA+IHBvd2VyIiB1c2VkIHRvIGRvIGEgbGl0dGxlIGVsc2UgdGhhbiBpbml0aWF0ZSBhDQo+IHJl
c2NhbiBmb3IgdGhpcyBwYXJ0aWN1bGFyIEhXLg0KDQo+IA0KPiA+DQo+ID4gSSB0aGluayB0aGF0
IGZvciBFeHByZXNzQ2FyZCBhbmQgc2ltaWxhciBkZXZpY2VzLCB3ZSB3YW50IHRvIHR1cm4gb24N
Cj4gPiB0aGUgZGV2aWNlIGFuZCBhdHRhY2ggYSBkcml2ZXIgYXMgc29vbiBhcyB0aGUgY2FyZCBp
cyBpbnNlcnRlZC4gIEJ1dA0KPiA+IGluIHlvdXIgY2FzZSwgSSBhc3N1bWUgd2Ugd2FudCBhIG1v
ZGVsIGxpa2UgdGhhdCBpbiBUYWJsZSAyLTcgb2YgdGhlDQo+ID4gIlBDSSBTdGFuZGFyZCBIb3Qt
UGx1ZyBDb250cm9sbGVyIGFuZCBTdWJzeXN0ZW0gU3BlY2lmaWNhdGlvbiwiIHJldg0KPiA+IDEu
MCwgaS5lLiwgIkhvdCBJbnNlcnRpb24gSW5pdGlhdGVkIHZpYSBTb2Z0d2FyZSBVSS4iICBTbyB0
aGVyZSBtdXN0DQo+ID4gYmUgc29tZSB3YXkgdG8gZGlmZmVyZW50aWF0ZSBhbiBFeHByZXNzQ2Fy
ZCBzbG90IGZyb20gYSBzbG90IGxpa2UNCj4gPiB5b3Vycy4NCj4gDQo+IFllcywgdGhhdCB3b3Vs
ZCBoZWxwIGlmIHRoZXJlIHdhcyBzb21lIHdheS4NCj4gDQoNCkJlc3QgcmVnYXJkcywNClRha3Ug
SXp1bWkNCg0K
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-13 8:00 ` Izumi, Taku
@ 2014-02-13 16:03 ` Rajat Jain
2014-02-13 16:37 ` Takashi Iwai
2014-02-14 7:21 ` Izumi, Taku
0 siblings, 2 replies; 16+ messages in thread
From: Rajat Jain @ 2014-02-13 16:03 UTC (permalink / raw)
To: Izumi, Taku, rajatxjain, Bjorn Helgaas
Cc: linux-pci, yinghai, Guenter Roeck, Takashi Iwai
WytUYWthc2hpXQ0KDQpIZWxsbywNCj4gDQo+ID4gPiBIdWgsIHRoYXQgZG9lc24ndCBzb3VuZCBn
b29kLiAgRG9lcyB5b3VyIHNsb3QgaGF2ZSBhbiBhdHRlbnRpb24NCj4gPiA+IGJ1dHRvbj8gIENh
biB5b3UgY29sbGVjdCB0aGUgImxzcGNpIC12dnYiIG91dHB1dCBmb3IgdGhlIERvd25zdHJlYW0N
Cj4gPiA+IFBvcnQgbGVhZGluZyB0byB0aGlzIHNsb3Q/DQo+IA0KPiAgICBUaGUgc2xvdHMgaGF2
ZSBubyBBdHRlbnRpb24gYnV0dG9uIGFuZCBhcmUgbm90IGZvciBFeHByZXNzQ2FyZC4NCj4gICAg
bHNwY2kgLXZ2diBvdXRwdXQgaXM6DQo+IA0KPiAgICAgICAgIENvbnRyb2w6IEkvTysgTWVtKyBC
dXNNYXN0ZXIrIFNwZWNDeWNsZS0gTWVtV0lOVi0gVkdBU25vb3AtDQo+IFBhckVycisgU3RlcHBp
bmctIFNFUlIrIEZhc3RCMkItIERpc0lOVHgrDQo+ICAgICAgICAgU3RhdHVzOiBDYXArIDY2TUh6
LSBVREYtIEZhc3RCMkItIFBhckVyci0gREVWU0VMPWZhc3QgPlRBYm9ydC0NCj4gPFRBYm9ydC0g
PE1BYm9ydC0gPlNFUlItIDxQRVJSLSBJTlR4LQ0KPiAgICAgICAgIExhdGVuY3k6IDANCj4gICAg
ICAgICBCdXM6IHByaW1hcnk9MmMsIHNlY29uZGFyeT0yZCwgc3Vib3JkaW5hdGU9MmYsIHNlYy1s
YXRlbmN5PTANCj4gICAgICAgICBJL08gYmVoaW5kIGJyaWRnZTogMDAwMGYwMDAtMDAwMDBmZmYN
Cj4gICAgICAgICBNZW1vcnkgYmVoaW5kIGJyaWRnZTogYjE4MDAwMDAtYjFmZmZmZmYNCj4gICAg
ICAgICBQcmVmZXRjaGFibGUgbWVtb3J5IGJlaGluZCBicmlkZ2U6IDAwMDAwMDAwYWU4MDAwMDAt
DQo+IDAwMDAwMDAwYWVmZmZmZmYNCj4gICAgICAgICBTZWNvbmRhcnkgc3RhdHVzOiA2Nk1Iei0g
RmFzdEIyQi0gUGFyRXJyLSBERVZTRUw9ZmFzdCA+VEFib3J0LQ0KPiA8VEFib3J0LSA8TUFib3J0
LSA8U0VSUi0gPFBFUlItDQo+ICAgICAgICAgQnJpZGdlQ3RsOiBQYXJpdHktIFNFUlIrIE5vSVNB
LSBWR0EtIE1BYm9ydC0gPlJlc2V0LSBGYXN0QjJCLQ0KPiAgICAgICAgICAgICAgICAgUHJpRGlz
Y1Rtci0gU2VjRGlzY1Rtci0gRGlzY1RtclN0YXQtIERpc2NUbXJTRVJSRW4tDQo+ICAgICAgICAg
Q2FwYWJpbGl0aWVzOiBbNDBdIFBvd2VyIE1hbmFnZW1lbnQgdmVyc2lvbiAzDQo+ICAgICAgICAg
ICAgICAgICBGbGFnczogUE1FQ2xrLSBEU0ktIEQxLSBEMi0gQXV4Q3VycmVudD0wbUEgUE1FKEQw
KyxEMS0NCj4gLEQyLSxEM2hvdCssRDNjb2xkKykNCj4gICAgICAgICAgICAgICAgIFN0YXR1czog
RDAgTm9Tb2Z0UnN0KyBQTUUtRW5hYmxlLSBEU2VsPTAgRFNjYWxlPTAgUE1FLQ0KPiAgICAgICAg
IENhcGFiaWxpdGllczogWzQ4XSBNU0k6IEVuYWJsZSsgQ291bnQ9MS84IE1hc2thYmxlKyA2NGJp
dCsNCj4gICAgICAgICAgICAgICAgIEFkZHJlc3M6IDAwMDAwMDAwZmVlMDA1MTggIERhdGE6IDAw
MDANCj4gICAgICAgICAgICAgICAgIE1hc2tpbmc6IDAwMDAwMGZlICBQZW5kaW5nOiAwMDAwMDAw
MA0KPiAgICAgICAgIENhcGFiaWxpdGllczogWzY4XSBFeHByZXNzICh2MikgRG93bnN0cmVhbSBQ
b3J0IChTbG90KyksIE1TSSAwMA0KPiAgICAgICAgICAgICAgICAgRGV2Q2FwOiBNYXhQYXlsb2Fk
IDIwNDggYnl0ZXMsIFBoYW50RnVuYyAwLCBMYXRlbmN5IEwwcw0KPiA8NjRucywgTDEgPDF1cw0K
PiAgICAgICAgICAgICAgICAgICAgICAgICBFeHRUYWctIFJCRSsgRkxSZXNldC0NCj4gICAgICAg
ICAgICAgICAgIERldkN0bDogUmVwb3J0IGVycm9yczogQ29ycmVjdGFibGUrIE5vbi1GYXRhbCsg
RmF0YWwrDQo+IFVuc3VwcG9ydGVkLQ0KPiAgICAgICAgICAgICAgICAgICAgICAgICBSbHhkT3Jk
KyBFeHRUYWctIFBoYW50RnVuYy0gQXV4UHdyLSBOb1Nub29wKw0KPiAgICAgICAgICAgICAgICAg
ICAgICAgICBNYXhQYXlsb2FkIDEyOCBieXRlcywgTWF4UmVhZFJlcSAxMjggYnl0ZXMNCj4gICAg
ICAgICAgICAgICAgIERldlN0YTogQ29yckVycisgVW5jb3JyRXJyLSBGYXRhbEVyci0gVW5zdXBw
UmVxKyBBdXhQd3ItDQo+IFRyYW5zUGVuZC0NCj4gICAgICAgICAgICAgICAgIExua0NhcDogUG9y
dCAjMSwgU3BlZWQgOEdUL3MsIFdpZHRoIHg4LCBBU1BNIEwxLCBMYXRlbmN5DQo+IEwwIDw0dXMs
IEwxIDw0dXMNCj4gICAgICAgICAgICAgICAgICAgICAgICAgQ2xvY2tQTS0gU3VycHJpc2UrIExM
QWN0UmVwKyBCd05vdCsNCj4gICAgICAgICAgICAgICAgIExua0N0bDogQVNQTSBEaXNhYmxlZDsg
RGlzYWJsZWQtIFJldHJhaW4tIENvbW1DbGstDQo+ICAgICAgICAgICAgICAgICAgICAgICAgIEV4
dFN5bmNoLSBDbG9ja1BNLSBBdXRXaWREaXMtIEJXSW50LSBBdXRCV0ludC0NCj4gICAgICAgICAg
ICAgICAgIExua1N0YTogU3BlZWQgMi41R1QvcywgV2lkdGggeDAsIFRyRXJyLSBUcmFpbi0gU2xv
dENsaysNCj4gRExBY3RpdmUtIEJXTWdtdC0gQUJXTWdtdC0NCj4gICAgICAgICAgICAgICAgIFNs
dENhcDogQXR0bkJ0bi0gUHdyQ3RybCsgTVJMKyBBdHRuSW5kKyBQd3JJbmQrIEhvdFBsdWcrDQo+
IFN1cnByaXNlLQ0KPiAgICAgICAgICAgICAgICAgICAgICAgICBTbG90ICM2NywgUG93ZXJMaW1p
dCAyNS4wMDBXOyBJbnRlcmxvY2stDQo+IE5vQ29tcGwtDQoNCkhtbS4uLiBJIHNlZSB0aGF0IHRo
ZSBTbG90IGhhcyBhIHBvd2VyIGNvbnRyb2xsZXIuIFdoaWNoIG1lYW5zIHRoYXQgdGhlIHBvd2Vy
IHRvIHRoZSBzbG90IHNoYWxsIG5vdCBiZSB0dXJuZWQgb24gYXV0b21hdGljYWxseSAoYnkgSFcp
IHdoZW4gdGhlIGNhcmQgaXMgcGx1Z2dlZCBpbi4gQWxzbyBtZWFuaW5nIHRoYXQgdGhlIGxpbmsg
d2lsbCBub3QgY29tZSB1cCBhdXRvbWF0aWNhbGx5IC0gc28gdGhpcyBkb2VzIG5vdCBzZWVtIGxp
a2UgdGhlIExpbmsgc3RhdGUgYmFzZWQgaG90cGx1ZyBraWNraW5nIGluLg0KDQpXaGF0IEkgc3Vz
cGVjdCBpcyB0aGlzIG9uZToNCg0KZjAyZDE4NDNkODNiICJQQ0k6IHBjaWVocDogUmVtb3ZlIHN1
cnByaXNlIGJpdCBjaGVja3MiDQoNClNpbmNlIHRoaXMgcGF0Y2ggcmVtb3ZlcyAqYWxsKiB0aGUg
c3VycHJpc2UgYml0IGNoZWNrcyBjYXVzaW5nIGFsbCB0aGUgcHJlc2VuY2UgZGV0ZWN0IGNoYW5n
ZXMgKGluY2x1ZGluZyAwLT4xKSB0byBiZSBpbml0aWF0ZSBob3RwbHVnLiBJIHRoaW5rIGl0IG1h
eSBiZSB3b3J0aHdoaWxlIHRvIHRyeSBpdCBvdXQgd2hpbGUgcmVtb3ZpbmcgdGhpcyBwYXJ0aWN1
bGFyIGh1bms6DQoNCkBAIC01MzUsOCArNTM1LDYgQEAgc3RhdGljIHZvaWQgaW50ZXJydXB0X2V2
ZW50X2hhbmRsZXIoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KIAkJYnJlYWs7DQogCWNhc2Ug
SU5UX1BSRVNFTkNFX09OOg0KIAljYXNlIElOVF9QUkVTRU5DRV9PRkY6DQotCQlpZiAoIUhQX1NV
UFJfUk0oY3RybCkpDQotCQkJYnJlYWs7DQogCQljdHJsX2RiZyhjdHJsLCAiU3VycHJpc2UgUmVt
b3ZhbFxuIik7DQogCQloYW5kbGVfc3VycHJpc2VfZXZlbnQocF9zbG90KTsNCiAJCWJyZWFrOw0K
DQpNYXkgYmUgd2Ugc2hvdWxkIHJlbW92ZSB0aGUgc3VycHJpc2UgY2hlY2sgZm9yIElOVF9QUkVT
RU5DRV9PRkYgb25seSAoYW5kIGxldCBpdCBzdGF5IGZvciBJTlRfUFJFU0VXTkNFX09OKT8NCg0K
VGhhbmtzLA0KDQpSYWphdA0KDQoNCg0KPiAgICAgICAgICAgICAgICAgU2x0Q3RsOiBFbmFibGU6
IEF0dG5CdG4tIFB3ckZsdC0gTVJMKyBQcmVzRGV0KyBDbWRDcGx0Kw0KPiBIUElycSsgTGlua0No
ZysNCj4gICAgICAgICAgICAgICAgICAgICAgICAgQ29udHJvbDogQXR0bkluZCBPZmYsIFB3cklu
ZCBPZmYsIFBvd2VyKw0KPiBJbnRlcmxvY2stDQo+ICAgICAgICAgICAgICAgICBTbHRTdGE6IFN0
YXR1czogQXR0bkJ0bi0gUG93ZXJGbHQtIE1STC0gQ21kQ3BsdC0NCj4gUHJlc0RldC0gSW50ZXJs
b2NrLQ0KPiAgICAgICAgICAgICAgICAgICAgICAgICBDaGFuZ2VkOiBNUkwtIFByZXNEZXQtIExp
bmtTdGF0ZS0NCj4gICAgICAgICAgICAgICAgIERldkNhcDI6IENvbXBsZXRpb24gVGltZW91dDog
Tm90IFN1cHBvcnRlZCwgVGltZW91dERpcy0sDQo+IExUUissIE9CRkYgVmlhIG1lc3NhZ2UgQVJJ
RndkKw0KPiAgICAgICAgICAgICAgICAgRGV2Q3RsMjogQ29tcGxldGlvbiBUaW1lb3V0OiA1MHVz
IHRvIDUwbXMsIFRpbWVvdXREaXMtLA0KPiBMVFItLCBPQkZGIERpc2FibGVkIEFSSUZ3ZC0NCj4g
ICAgICAgICAgICAgICAgIExua0N0bDI6IFRhcmdldCBMaW5rIFNwZWVkOiA4R1QvcywgRW50ZXJD
b21wbGlhbmNlLQ0KPiBTcGVlZERpcy0sIFNlbGVjdGFibGUgRGUtZW1waGFzaXM6IC02ZEINCj4g
ICAgICAgICAgICAgICAgICAgICAgICAgIFRyYW5zbWl0IE1hcmdpbjogTm9ybWFsIE9wZXJhdGlu
ZyBSYW5nZSwNCj4gRW50ZXJNb2RpZmllZENvbXBsaWFuY2UtIENvbXBsaWFuY2VTT1MtDQo+ICAg
ICAgICAgICAgICAgICAgICAgICAgICBDb21wbGlhbmNlIERlLWVtcGhhc2lzOiAtNmRCDQo+ICAg
ICAgICAgICAgICAgICBMbmtTdGEyOiBDdXJyZW50IERlLWVtcGhhc2lzIExldmVsOiAtMy41ZEIs
DQo+IEVxdWFsaXphdGlvbkNvbXBsZXRlLSwgRXF1YWxpemF0aW9uUGhhc2UxLQ0KPiAgICAgICAg
ICAgICAgICAgICAgICAgICAgRXF1YWxpemF0aW9uUGhhc2UyLSwgRXF1YWxpemF0aW9uUGhhc2Uz
LSwNCj4gTGlua0VxdWFsaXphdGlvblJlcXVlc3QtDQo+ICAgICAgICAgQ2FwYWJpbGl0aWVzOiBb
YTRdIFN1YnN5c3RlbTogRnVqaXRzdSBMaW1pdGVkLiBEZXZpY2UgMTgwNA0KPiAgICAgICAgIENh
cGFiaWxpdGllczogWzEwMCB2MV0gRGV2aWNlIFNlcmlhbCBOdW1iZXIgYWEtODctMDAtMTAtYjUt
ZGYtDQo+IDBlLTAwDQo+ICAgICAgICAgQ2FwYWJpbGl0aWVzOiBbZmI0IHYxXSBBZHZhbmNlZCBF
cnJvciBSZXBvcnRpbmcNCj4gICAgICAgICAgICAgICAgIFVFU3RhOiAgRExQLSBTREVTLSBUTFAt
IEZDUC0gQ21wbHRUTy0gQ21wbHRBYnJ0LQ0KPiBVbnhDbXBsdC0gUnhPRi0gTWFsZlRMUC0gRUNS
Qy0gVW5zdXBSZXEtIEFDU1Zpb2wtDQo+ICAgICAgICAgICAgICAgICBVRU1zazogIERMUC0gU0RF
Uy0gVExQLSBGQ1AtIENtcGx0VE8tIENtcGx0QWJydC0NCj4gVW54Q21wbHQtIFJ4T0YtIE1hbGZU
TFAtIEVDUkMrIFVuc3VwUmVxKyBBQ1NWaW9sLQ0KPiAgICAgICAgICAgICAgICAgVUVTdnJ0OiBE
TFArIFNERVMrIFRMUCsgRkNQKyBDbXBsdFRPLSBDbXBsdEFicnQrDQo+IFVueENtcGx0KyBSeE9G
KyBNYWxmVExQKyBFQ1JDKyBVbnN1cFJlcS0gQUNTVmlvbCsNCj4gICAgICAgICAgICAgICAgIENF
U3RhOiAgUnhFcnItIEJhZFRMUC0gQmFkRExMUC0gUm9sbG92ZXItIFRpbWVvdXQtDQo+IE5vbkZh
dGFsRXJyKw0KPiAgICAgICAgICAgICAgICAgQ0VNc2s6ICBSeEVyci0gQmFkVExQLSBCYWRETExQ
LSBSb2xsb3Zlci0gVGltZW91dC0NCj4gTm9uRmF0YWxFcnIrDQo+ICAgICAgICAgICAgICAgICBB
RVJDYXA6IEZpcnN0IEVycm9yIFBvaW50ZXI6IDFmLCBHZW5DYXArIENHZW5Fbi0gQ2hrQ2FwKw0K
PiBDaGtFbi0NCj4gICAgICAgICBDYXBhYmlsaXRpZXM6IFsxMzggdjFdIFBvd2VyIEJ1ZGdldGlu
ZyA8Pz4NCj4gICAgICAgICBDYXBhYmlsaXRpZXM6IFsxMGMgdjFdICMxOQ0KPiAgICAgICAgIENh
cGFiaWxpdGllczogWzE0OCB2MV0gVmlydHVhbCBDaGFubmVsDQo+ICAgICAgICAgICAgICAgICBD
YXBzOiAgIExQRVZDPTAgUmVmQ2xrPTEwMG5zIFBBVEVudHJ5Qml0cz0xDQo+ICAgICAgICAgICAg
ICAgICBBcmI6ICAgIEZpeGVkLSBXUlIzMi0gV1JSNjQtIFdSUjEyOC0NCj4gICAgICAgICAgICAg
ICAgIEN0cmw6ICAgQXJiU2VsZWN0PUZpeGVkDQo+ICAgICAgICAgICAgICAgICBTdGF0dXM6IElu
UHJvZ3Jlc3MtDQo+ICAgICAgICAgICAgICAgICBWQzA6ICAgIENhcHM6ICAgUEFUT2Zmc2V0PTAw
IE1heFRpbWVTbG90cz0xDQo+IFJlalNub29wVHJhbnMtDQo+ICAgICAgICAgICAgICAgICAgICAg
ICAgIEFyYjogICAgRml4ZWQrIFdSUjMyLSBXUlI2NC0gV1JSMTI4LSBUV1JSMTI4LQ0KPiBXUlIy
NTYtDQo+ICAgICAgICAgICAgICAgICAgICAgICAgIEN0cmw6ICAgRW5hYmxlKyBJRD0wIEFyYlNl
bGVjdD1GaXhlZCBUQy9WQz1mZg0KPiAgICAgICAgICAgICAgICAgICAgICAgICBTdGF0dXM6IE5l
Z29QZW5kaW5nKyBJblByb2dyZXNzLQ0KPiAgICAgICAgIENhcGFiaWxpdGllczogW2UwMCB2MV0g
IzEyDQo+ICAgICAgICAgQ2FwYWJpbGl0aWVzOiBbZjI0IHYxXSBBY2Nlc3MgQ29udHJvbCBTZXJ2
aWNlcw0KPiAgICAgICAgICAgICAgICAgQUNTQ2FwOiBTcmNWYWxpZCsgVHJhbnNCbGsrIFJlcVJl
ZGlyKyBDbXBsdFJlZGlyKw0KPiBVcHN0cmVhbUZ3ZCsgRWdyZXNzQ3RybCsgRGlyZWN0VHJhbnMr
DQo+ICAgICAgICAgICAgICAgICBBQ1NDdGw6IFNyY1ZhbGlkLSBUcmFuc0Jsay0gUmVxUmVkaXIt
IENtcGx0UmVkaXItDQo+IFVwc3RyZWFtRndkLSBFZ3Jlc3NDdHJsLSBEaXJlY3RUcmFucy0NCj4g
ICAgICAgICBDYXBhYmlsaXRpZXM6IFtiNzAgdjFdIFZlbmRvciBTcGVjaWZpYyBJbmZvcm1hdGlv
bjogSUQ9MDAwMQ0KPiBSZXY9MCBMZW49MDEwIDw/Pg0KPiAgICAgICAgIEtlcm5lbCBkcml2ZXIg
aW4gdXNlOiBwY2llcG9ydA0KPiANCj4gDQo+ID4gSWYgdGhlcmUgaXMgbm8gYXR0ZW50aW9uIGJ1
dHRvbiwgdGhlbiB0aGUgYmVoYXZpb3Igc2VlbiwgbWF0Y2hlcyB3aXRoDQo+ID4gd2hhdCBJIGV4
cGVjdGVkIG9mIHRoZSBjb2RlLg0KPiA+DQo+ID4gU2VlbWluZ2x5LCB0aGUgSFcgZG9lcyBub3Qg
aGF2ZSBhIHBvd2VyIGNvbnRyb2xsZXIgKGFuZCBhdHRlbnRpb24NCj4gPiBidXR0b24pLCB0aHVz
IHRoZSBwb3dlciBpcyBhdXRvbWF0aWNhbGx5IHR1cm5lZCBvbiAoYnkgSFcpIHdoZW4gY2FyZA0K
PiA+IGlzIGluc2VydGVkIGFuZCB0aGUgbGluayBjb21lcyB1cC4gVGh1cyBwcmlvciB0byBsaW5r
IHN0YXRlIGJhc2VkDQo+ID4gaG90LXBsdWcsICJlY2hvIDEgPiBwb3dlciIgdXNlZCB0byBkbyBh
IGxpdHRsZSBlbHNlIHRoYW4gaW5pdGlhdGUgYQ0KPiA+IHJlc2NhbiBmb3IgdGhpcyBwYXJ0aWN1
bGFyIEhXLg0KPiANCj4gPg0KPiA+ID4NCj4gPiA+IEkgdGhpbmsgdGhhdCBmb3IgRXhwcmVzc0Nh
cmQgYW5kIHNpbWlsYXIgZGV2aWNlcywgd2Ugd2FudCB0byB0dXJuIG9uDQo+ID4gPiB0aGUgZGV2
aWNlIGFuZCBhdHRhY2ggYSBkcml2ZXIgYXMgc29vbiBhcyB0aGUgY2FyZCBpcyBpbnNlcnRlZC4g
IEJ1dA0KPiA+ID4gaW4geW91ciBjYXNlLCBJIGFzc3VtZSB3ZSB3YW50IGEgbW9kZWwgbGlrZSB0
aGF0IGluIFRhYmxlIDItNyBvZiB0aGUNCj4gPiA+ICJQQ0kgU3RhbmRhcmQgSG90LVBsdWcgQ29u
dHJvbGxlciBhbmQgU3Vic3lzdGVtIFNwZWNpZmljYXRpb24sIiByZXYNCj4gPiA+IDEuMCwgaS5l
LiwgIkhvdCBJbnNlcnRpb24gSW5pdGlhdGVkIHZpYSBTb2Z0d2FyZSBVSS4iICBTbyB0aGVyZSBt
dXN0DQo+ID4gPiBiZSBzb21lIHdheSB0byBkaWZmZXJlbnRpYXRlIGFuIEV4cHJlc3NDYXJkIHNs
b3QgZnJvbSBhIHNsb3QgbGlrZQ0KPiA+ID4geW91cnMuDQo+ID4NCj4gPiBZZXMsIHRoYXQgd291
bGQgaGVscCBpZiB0aGVyZSB3YXMgc29tZSB3YXkuDQo+ID4NCj4gDQo+IEJlc3QgcmVnYXJkcywN
Cj4gVGFrdSBJenVtaQ0KDQo=
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-13 16:03 ` Rajat Jain
@ 2014-02-13 16:37 ` Takashi Iwai
2014-02-13 17:56 ` Rajat Jain
2014-02-14 7:21 ` Izumi, Taku
1 sibling, 1 reply; 16+ messages in thread
From: Takashi Iwai @ 2014-02-13 16:37 UTC (permalink / raw)
To: Rajat Jain
Cc: Izumi, Taku, rajatxjain, Bjorn Helgaas, linux-pci, yinghai,
Guenter Roeck
At Thu, 13 Feb 2014 16:03:30 +0000,
Rajat Jain wrote:
>
> [+Takashi]
>
> Hello,
> >
> > > > Huh, that doesn't sound good. Does your slot have an attention
> > > > button? Can you collect the "lspci -vvv" output for the Downstream
> > > > Port leading to this slot?
> >
> > The slots have no Attention button and are not for ExpressCard.
> > lspci -vvv output is:
> >
> > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
> > ParErr+ Stepping- SERR+ FastB2B- DisINTx+
> > Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> > <TAbort- <MAbort- >SERR- <PERR- INTx-
> > Latency: 0
> > Bus: primary=2c, secondary=2d, subordinate=2f, sec-latency=0
> > I/O behind bridge: 0000f000-00000fff
> > Memory behind bridge: b1800000-b1ffffff
> > Prefetchable memory behind bridge: 00000000ae800000-
> > 00000000aeffffff
> > Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort-
> > <TAbort- <MAbort- <SERR- <PERR-
> > BridgeCtl: Parity- SERR+ NoISA- VGA- MAbort- >Reset- FastB2B-
> > PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn-
> > Capabilities: [40] Power Management version 3
> > Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-
> > ,D2-,D3hot+,D3cold+)
> > Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
> > Capabilities: [48] MSI: Enable+ Count=1/8 Maskable+ 64bit+
> > Address: 00000000fee00518 Data: 0000
> > Masking: 000000fe Pending: 00000000
> > Capabilities: [68] Express (v2) Downstream Port (Slot+), MSI 00
> > DevCap: MaxPayload 2048 bytes, PhantFunc 0, Latency L0s
> > <64ns, L1 <1us
> > ExtTag- RBE+ FLReset-
> > DevCtl: Report errors: Correctable+ Non-Fatal+ Fatal+
> > Unsupported-
> > RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop+
> > MaxPayload 128 bytes, MaxReadReq 128 bytes
> > DevSta: CorrErr+ UncorrErr- FatalErr- UnsuppReq+ AuxPwr-
> > TransPend-
> > LnkCap: Port #1, Speed 8GT/s, Width x8, ASPM L1, Latency
> > L0 <4us, L1 <4us
> > ClockPM- Surprise+ LLActRep+ BwNot+
> > LnkCtl: ASPM Disabled; Disabled- Retrain- CommClk-
> > ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
> > LnkSta: Speed 2.5GT/s, Width x0, TrErr- Train- SlotClk+
> > DLActive- BWMgmt- ABWMgmt-
> > SltCap: AttnBtn- PwrCtrl+ MRL+ AttnInd+ PwrInd+ HotPlug+
> > Surprise-
> > Slot #67, PowerLimit 25.000W; Interlock-
> > NoCompl-
>
> Hmm... I see that the Slot has a power controller. Which means that the power to the slot shall not be turned on automatically (by HW) when the card is plugged in. Also meaning that the link will not come up automatically - so this does not seem like the Link state based hotplug kicking in.
>
> What I suspect is this one:
>
> f02d1843d83b "PCI: pciehp: Remove surprise bit checks"
>
> Since this patch removes *all* the surprise bit checks causing all the presence detect changes (including 0->1) to be initiate hotplug. I think it may be worthwhile to try it out while removing this particular hunk:
>
> @@ -535,8 +535,6 @@ static void interrupt_event_handler(struct work_struct *work)
> break;
> case INT_PRESENCE_ON:
> case INT_PRESENCE_OFF:
> - if (!HP_SUPR_RM(ctrl))
> - break;
> ctrl_dbg(ctrl, "Surprise Removal\n");
> handle_surprise_event(p_slot);
> break;
>
> May be we should remove the surprise check for INT_PRESENCE_OFF only (and let it stay for INT_PRESEWNCE_ON)?
I checked my test devices, and they seem to have no power controller
bit involved. So I double-checked the recent commits, and indeed
Rajat's recent work already fixed the detection (presumed that the
commit [e48f1b67: PCI: pciehp: Use link change notifications for
hot-plug and removal] does it) without fiddling with the surprise
bit.
That said, my patch can be reverted completely. Can anyone check
whether it cures?
thanks,
Takashi
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-13 16:37 ` Takashi Iwai
@ 2014-02-13 17:56 ` Rajat Jain
0 siblings, 0 replies; 16+ messages in thread
From: Rajat Jain @ 2014-02-13 17:56 UTC (permalink / raw)
To: Takashi Iwai
Cc: Izumi, Taku, rajatxjain, Bjorn Helgaas, linux-pci, yinghai,
Guenter Roeck
SGVsbG8sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogVGFrYXNoaSBJ
d2FpIFttYWlsdG86dGl3YWlAc3VzZS5kZV0NCj4gU2VudDogVGh1cnNkYXksIEZlYnJ1YXJ5IDEz
LCAyMDE0IDg6MzcgQU0NCj4gVG86IFJhamF0IEphaW4NCj4gQ2M6IEl6dW1pLCBUYWt1OyByYWph
dHhqYWluQGdtYWlsLmNvbTsgQmpvcm4gSGVsZ2FhczsgbGludXgtDQo+IHBjaUB2Z2VyLmtlcm5l
bC5vcmc7IHlpbmdoYWlAa2VybmVsLm9yZzsgR3VlbnRlciBSb2Vjaw0KPiBTdWJqZWN0OiBSZTog
W1BBVENIXSBQQ0k6IHBjaWVocDogRml4IHRoZSBwcm9ibGVtIHRoYXQgdGhlIHByZXNlbnQgYml0
DQo+IGlzIG5vdCBjbGVhcmVkIHRob3VnaCBzbG90IGlzIGVtcHR5DQo+IA0KPiBBdCBUaHUsIDEz
IEZlYiAyMDE0IDE2OjAzOjMwICswMDAwLA0KPiBSYWphdCBKYWluIHdyb3RlOg0KPiA+DQo+ID4g
WytUYWthc2hpXQ0KPiA+DQo+ID4gSGVsbG8sDQo+ID4gPg0KPiA+ID4gPiA+IEh1aCwgdGhhdCBk
b2Vzbid0IHNvdW5kIGdvb2QuICBEb2VzIHlvdXIgc2xvdCBoYXZlIGFuIGF0dGVudGlvbg0KPiA+
ID4gPiA+IGJ1dHRvbj8gIENhbiB5b3UgY29sbGVjdCB0aGUgImxzcGNpIC12dnYiIG91dHB1dCBm
b3IgdGhlDQo+ID4gPiA+ID4gRG93bnN0cmVhbSBQb3J0IGxlYWRpbmcgdG8gdGhpcyBzbG90Pw0K
PiA+ID4NCj4gPiA+ICAgIFRoZSBzbG90cyBoYXZlIG5vIEF0dGVudGlvbiBidXR0b24gYW5kIGFy
ZSBub3QgZm9yIEV4cHJlc3NDYXJkLg0KPiA+ID4gICAgbHNwY2kgLXZ2diBvdXRwdXQgaXM6DQo+
ID4gPg0KPiA+ID4gICAgICAgICBDb250cm9sOiBJL08rIE1lbSsgQnVzTWFzdGVyKyBTcGVjQ3lj
bGUtIE1lbVdJTlYtIFZHQVNub29wLQ0KPiA+ID4gUGFyRXJyKyBTdGVwcGluZy0gU0VSUisgRmFz
dEIyQi0gRGlzSU5UeCsNCj4gPiA+ICAgICAgICAgU3RhdHVzOiBDYXArIDY2TUh6LSBVREYtIEZh
c3RCMkItIFBhckVyci0gREVWU0VMPWZhc3QNCj4gPiA+ID5UQWJvcnQtDQo+ID4gPiA8VEFib3J0
LSA8TUFib3J0LSA+U0VSUi0gPFBFUlItIElOVHgtDQo+ID4gPiAgICAgICAgIExhdGVuY3k6IDAN
Cj4gPiA+ICAgICAgICAgQnVzOiBwcmltYXJ5PTJjLCBzZWNvbmRhcnk9MmQsIHN1Ym9yZGluYXRl
PTJmLCBzZWMtbGF0ZW5jeT0wDQo+ID4gPiAgICAgICAgIEkvTyBiZWhpbmQgYnJpZGdlOiAwMDAw
ZjAwMC0wMDAwMGZmZg0KPiA+ID4gICAgICAgICBNZW1vcnkgYmVoaW5kIGJyaWRnZTogYjE4MDAw
MDAtYjFmZmZmZmYNCj4gPiA+ICAgICAgICAgUHJlZmV0Y2hhYmxlIG1lbW9yeSBiZWhpbmQgYnJp
ZGdlOiAwMDAwMDAwMGFlODAwMDAwLQ0KPiA+ID4gMDAwMDAwMDBhZWZmZmZmZg0KPiA+ID4gICAg
ICAgICBTZWNvbmRhcnkgc3RhdHVzOiA2Nk1Iei0gRmFzdEIyQi0gUGFyRXJyLSBERVZTRUw9ZmFz
dA0KPiA+ID4gPlRBYm9ydC0NCj4gPiA+IDxUQWJvcnQtIDxNQWJvcnQtIDxTRVJSLSA8UEVSUi0N
Cj4gPiA+ICAgICAgICAgQnJpZGdlQ3RsOiBQYXJpdHktIFNFUlIrIE5vSVNBLSBWR0EtIE1BYm9y
dC0gPlJlc2V0LQ0KPiBGYXN0QjJCLQ0KPiA+ID4gICAgICAgICAgICAgICAgIFByaURpc2NUbXIt
IFNlY0Rpc2NUbXItIERpc2NUbXJTdGF0LSBEaXNjVG1yU0VSUkVuLQ0KPiA+ID4gICAgICAgICBD
YXBhYmlsaXRpZXM6IFs0MF0gUG93ZXIgTWFuYWdlbWVudCB2ZXJzaW9uIDMNCj4gPiA+ICAgICAg
ICAgICAgICAgICBGbGFnczogUE1FQ2xrLSBEU0ktIEQxLSBEMi0gQXV4Q3VycmVudD0wbUENCj4g
PiA+IFBNRShEMCssRDEtDQo+ID4gPiAsRDItLEQzaG90KyxEM2NvbGQrKQ0KPiA+ID4gICAgICAg
ICAgICAgICAgIFN0YXR1czogRDAgTm9Tb2Z0UnN0KyBQTUUtRW5hYmxlLSBEU2VsPTAgRFNjYWxl
PTANCj4gUE1FLQ0KPiA+ID4gICAgICAgICBDYXBhYmlsaXRpZXM6IFs0OF0gTVNJOiBFbmFibGUr
IENvdW50PTEvOCBNYXNrYWJsZSsgNjRiaXQrDQo+ID4gPiAgICAgICAgICAgICAgICAgQWRkcmVz
czogMDAwMDAwMDBmZWUwMDUxOCAgRGF0YTogMDAwMA0KPiA+ID4gICAgICAgICAgICAgICAgIE1h
c2tpbmc6IDAwMDAwMGZlICBQZW5kaW5nOiAwMDAwMDAwMA0KPiA+ID4gICAgICAgICBDYXBhYmls
aXRpZXM6IFs2OF0gRXhwcmVzcyAodjIpIERvd25zdHJlYW0gUG9ydCAoU2xvdCspLCBNU0kNCj4g
MDANCj4gPiA+ICAgICAgICAgICAgICAgICBEZXZDYXA6IE1heFBheWxvYWQgMjA0OCBieXRlcywg
UGhhbnRGdW5jIDAsIExhdGVuY3kNCj4gPiA+IEwwcyA8NjRucywgTDEgPDF1cw0KPiA+ID4gICAg
ICAgICAgICAgICAgICAgICAgICAgRXh0VGFnLSBSQkUrIEZMUmVzZXQtDQo+ID4gPiAgICAgICAg
ICAgICAgICAgRGV2Q3RsOiBSZXBvcnQgZXJyb3JzOiBDb3JyZWN0YWJsZSsgTm9uLUZhdGFsKw0K
PiA+ID4gRmF0YWwrDQo+ID4gPiBVbnN1cHBvcnRlZC0NCj4gPiA+ICAgICAgICAgICAgICAgICAg
ICAgICAgIFJseGRPcmQrIEV4dFRhZy0gUGhhbnRGdW5jLSBBdXhQd3ItIE5vU25vb3ArDQo+ID4g
PiAgICAgICAgICAgICAgICAgICAgICAgICBNYXhQYXlsb2FkIDEyOCBieXRlcywgTWF4UmVhZFJl
cSAxMjggYnl0ZXMNCj4gPiA+ICAgICAgICAgICAgICAgICBEZXZTdGE6IENvcnJFcnIrIFVuY29y
ckVyci0gRmF0YWxFcnItIFVuc3VwcFJlcSsNCj4gPiA+IEF1eFB3ci0NCj4gPiA+IFRyYW5zUGVu
ZC0NCj4gPiA+ICAgICAgICAgICAgICAgICBMbmtDYXA6IFBvcnQgIzEsIFNwZWVkIDhHVC9zLCBX
aWR0aCB4OCwgQVNQTSBMMSwNCj4gPiA+IExhdGVuY3kNCj4gPiA+IEwwIDw0dXMsIEwxIDw0dXMN
Cj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIENsb2NrUE0tIFN1cnByaXNlKyBMTEFjdFJl
cCsgQndOb3QrDQo+ID4gPiAgICAgICAgICAgICAgICAgTG5rQ3RsOiBBU1BNIERpc2FibGVkOyBE
aXNhYmxlZC0gUmV0cmFpbi0gQ29tbUNsay0NCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAg
IEV4dFN5bmNoLSBDbG9ja1BNLSBBdXRXaWREaXMtIEJXSW50LQ0KPiBBdXRCV0ludC0NCj4gPiA+
ICAgICAgICAgICAgICAgICBMbmtTdGE6IFNwZWVkIDIuNUdUL3MsIFdpZHRoIHgwLCBUckVyci0g
VHJhaW4tDQo+ID4gPiBTbG90Q2xrKw0KPiA+ID4gRExBY3RpdmUtIEJXTWdtdC0gQUJXTWdtdC0N
Cj4gPiA+ICAgICAgICAgICAgICAgICBTbHRDYXA6IEF0dG5CdG4tIFB3ckN0cmwrIE1STCsgQXR0
bkluZCsgUHdySW5kKw0KPiA+ID4gSG90UGx1ZysNCj4gPiA+IFN1cnByaXNlLQ0KPiA+ID4gICAg
ICAgICAgICAgICAgICAgICAgICAgU2xvdCAjNjcsIFBvd2VyTGltaXQgMjUuMDAwVzsgSW50ZXJs
b2NrLQ0KPiA+ID4gTm9Db21wbC0NCj4gPg0KPiA+IEhtbS4uLiBJIHNlZSB0aGF0IHRoZSBTbG90
IGhhcyBhIHBvd2VyIGNvbnRyb2xsZXIuIFdoaWNoIG1lYW5zIHRoYXQNCj4gdGhlIHBvd2VyIHRv
IHRoZSBzbG90IHNoYWxsIG5vdCBiZSB0dXJuZWQgb24gYXV0b21hdGljYWxseSAoYnkgSFcpIHdo
ZW4NCj4gdGhlIGNhcmQgaXMgcGx1Z2dlZCBpbi4gQWxzbyBtZWFuaW5nIHRoYXQgdGhlIGxpbmsg
d2lsbCBub3QgY29tZSB1cA0KPiBhdXRvbWF0aWNhbGx5IC0gc28gdGhpcyBkb2VzIG5vdCBzZWVt
IGxpa2UgdGhlIExpbmsgc3RhdGUgYmFzZWQgaG90cGx1Zw0KPiBraWNraW5nIGluLg0KPiA+DQo+
ID4gV2hhdCBJIHN1c3BlY3QgaXMgdGhpcyBvbmU6DQo+ID4NCj4gPiBmMDJkMTg0M2Q4M2IgIlBD
STogcGNpZWhwOiBSZW1vdmUgc3VycHJpc2UgYml0IGNoZWNrcyINCj4gPg0KPiA+IFNpbmNlIHRo
aXMgcGF0Y2ggcmVtb3ZlcyAqYWxsKiB0aGUgc3VycHJpc2UgYml0IGNoZWNrcyBjYXVzaW5nIGFs
bCB0aGUNCj4gcHJlc2VuY2UgZGV0ZWN0IGNoYW5nZXMgKGluY2x1ZGluZyAwLT4xKSB0byBiZSBp
bml0aWF0ZSBob3RwbHVnLiBJIHRoaW5rDQo+IGl0IG1heSBiZSB3b3J0aHdoaWxlIHRvIHRyeSBp
dCBvdXQgd2hpbGUgcmVtb3ZpbmcgdGhpcyBwYXJ0aWN1bGFyIGh1bms6DQo+ID4NCj4gPiBAQCAt
NTM1LDggKzUzNSw2IEBAIHN0YXRpYyB2b2lkIGludGVycnVwdF9ldmVudF9oYW5kbGVyKHN0cnVj
dA0KPiB3b3JrX3N0cnVjdCAqd29yaykNCj4gPiAgCQlicmVhazsNCj4gPiAgCWNhc2UgSU5UX1BS
RVNFTkNFX09OOg0KPiA+ICAJY2FzZSBJTlRfUFJFU0VOQ0VfT0ZGOg0KPiA+IC0JCWlmICghSFBf
U1VQUl9STShjdHJsKSkNCj4gPiAtCQkJYnJlYWs7DQo+ID4gIAkJY3RybF9kYmcoY3RybCwgIlN1
cnByaXNlIFJlbW92YWxcbiIpOw0KPiA+ICAJCWhhbmRsZV9zdXJwcmlzZV9ldmVudChwX3Nsb3Qp
Ow0KPiA+ICAJCWJyZWFrOw0KPiA+DQo+ID4gTWF5IGJlIHdlIHNob3VsZCByZW1vdmUgdGhlIHN1
cnByaXNlIGNoZWNrIGZvciBJTlRfUFJFU0VOQ0VfT0ZGIG9ubHkNCj4gKGFuZCBsZXQgaXQgc3Rh
eSBmb3IgSU5UX1BSRVNFV05DRV9PTik/DQo+IA0KPiBJIGNoZWNrZWQgbXkgdGVzdCBkZXZpY2Vz
LCBhbmQgdGhleSBzZWVtIHRvIGhhdmUgbm8gcG93ZXIgY29udHJvbGxlciBiaXQNCj4gaW52b2x2
ZWQuICBTbyBJIGRvdWJsZS1jaGVja2VkIHRoZSByZWNlbnQgY29tbWl0cywgYW5kIGluZGVlZCBS
YWphdCdzDQo+IHJlY2VudCB3b3JrIGFscmVhZHkgZml4ZWQgdGhlIGRldGVjdGlvbiAocHJlc3Vt
ZWQgdGhhdCB0aGUgY29tbWl0DQo+IFtlNDhmMWI2NzogUENJOiBwY2llaHA6IFVzZSBsaW5rIGNo
YW5nZSBub3RpZmljYXRpb25zIGZvciBob3QtcGx1ZyBhbmQNCj4gcmVtb3ZhbF0gZG9lcyBpdCkg
d2l0aG91dCBmaWRkbGluZyB3aXRoIHRoZSBzdXJwcmlzZSBiaXQuDQoNClRoYW5rcyBhIGxvdCBm
b3IgdGVzdGluZyENCg0KPiANCj4gVGhhdCBzYWlkLCBteSBwYXRjaCBjYW4gYmUgcmV2ZXJ0ZWQg
Y29tcGxldGVseS4gIENhbiBhbnlvbmUgY2hlY2sNCj4gd2hldGhlciBpdCBjdXJlcz8NCg0KSSBz
dGlsbCB0aGluayB0aGF0IHBhcnQgb2YgeW91ciBwYXRjaCBpcyBuZWVkZWQuIEF0IGxlYXN0IHRo
ZSBvbmUgdGhhdCByZW1vdmVzIHRoZSBzdXJwcmlzZSBiaXQgY2hlY2sgaWYgdGhlIGNhcmQgaXMg
c3VkZGVubHkgeWFua2VkIG91dC4NCg0KVGhhbmtzLA0KDQpSYWphdA0KDQo+IA0KPiANCj4gdGhh
bmtzLA0KPiANCj4gVGFrYXNoaQ0KPiANCg0K
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-13 16:03 ` Rajat Jain
2014-02-13 16:37 ` Takashi Iwai
@ 2014-02-14 7:21 ` Izumi, Taku
2014-02-14 7:26 ` Rajat Jain
2014-02-14 17:31 ` Bjorn Helgaas
1 sibling, 2 replies; 16+ messages in thread
From: Izumi, Taku @ 2014-02-14 7:21 UTC (permalink / raw)
To: Rajat Jain, rajatxjain, Bjorn Helgaas
Cc: linux-pci, yinghai, Guenter Roeck, Takashi Iwai
SGkgUmFqYXQsDQoNCj4gWytUYWthc2hpXQ0KPiANCj4gSGVsbG8sDQo+ID4NCj4gPiA+ID4gSHVo
LCB0aGF0IGRvZXNuJ3Qgc291bmQgZ29vZC4gIERvZXMgeW91ciBzbG90IGhhdmUgYW4gYXR0ZW50
aW9uDQo+ID4gPiA+IGJ1dHRvbj8gIENhbiB5b3UgY29sbGVjdCB0aGUgImxzcGNpIC12dnYiIG91
dHB1dCBmb3IgdGhlIERvd25zdHJlYW0NCj4gPiA+ID4gUG9ydCBsZWFkaW5nIHRvIHRoaXMgc2xv
dD8NCj4gPg0KPiA+ICAgIFRoZSBzbG90cyBoYXZlIG5vIEF0dGVudGlvbiBidXR0b24gYW5kIGFy
ZSBub3QgZm9yIEV4cHJlc3NDYXJkLg0KPiA+ICAgIGxzcGNpIC12dnYgb3V0cHV0IGlzOg0KPiA+
DQo+ID4gICAgICAgICBDb250cm9sOiBJL08rIE1lbSsgQnVzTWFzdGVyKyBTcGVjQ3ljbGUtIE1l
bVdJTlYtIFZHQVNub29wLQ0KPiA+IFBhckVycisgU3RlcHBpbmctIFNFUlIrIEZhc3RCMkItIERp
c0lOVHgrDQo+ID4gICAgICAgICBTdGF0dXM6IENhcCsgNjZNSHotIFVERi0gRmFzdEIyQi0gUGFy
RXJyLSBERVZTRUw9ZmFzdCA+VEFib3J0LQ0KPiA+IDxUQWJvcnQtIDxNQWJvcnQtID5TRVJSLSA8
UEVSUi0gSU5UeC0NCj4gPiAgICAgICAgIExhdGVuY3k6IDANCj4gPiAgICAgICAgIEJ1czogcHJp
bWFyeT0yYywgc2Vjb25kYXJ5PTJkLCBzdWJvcmRpbmF0ZT0yZiwgc2VjLWxhdGVuY3k9MA0KPiA+
ICAgICAgICAgSS9PIGJlaGluZCBicmlkZ2U6IDAwMDBmMDAwLTAwMDAwZmZmDQo+ID4gICAgICAg
ICBNZW1vcnkgYmVoaW5kIGJyaWRnZTogYjE4MDAwMDAtYjFmZmZmZmYNCj4gPiAgICAgICAgIFBy
ZWZldGNoYWJsZSBtZW1vcnkgYmVoaW5kIGJyaWRnZTogMDAwMDAwMDBhZTgwMDAwMC0NCj4gPiAw
MDAwMDAwMGFlZmZmZmZmDQo+ID4gICAgICAgICBTZWNvbmRhcnkgc3RhdHVzOiA2Nk1Iei0gRmFz
dEIyQi0gUGFyRXJyLSBERVZTRUw9ZmFzdCA+VEFib3J0LQ0KPiA+IDxUQWJvcnQtIDxNQWJvcnQt
IDxTRVJSLSA8UEVSUi0NCj4gPiAgICAgICAgIEJyaWRnZUN0bDogUGFyaXR5LSBTRVJSKyBOb0lT
QS0gVkdBLSBNQWJvcnQtID5SZXNldC0gRmFzdEIyQi0NCj4gPiAgICAgICAgICAgICAgICAgUHJp
RGlzY1Rtci0gU2VjRGlzY1Rtci0gRGlzY1RtclN0YXQtIERpc2NUbXJTRVJSRW4tDQo+ID4gICAg
ICAgICBDYXBhYmlsaXRpZXM6IFs0MF0gUG93ZXIgTWFuYWdlbWVudCB2ZXJzaW9uIDMNCj4gPiAg
ICAgICAgICAgICAgICAgRmxhZ3M6IFBNRUNsay0gRFNJLSBEMS0gRDItIEF1eEN1cnJlbnQ9MG1B
IFBNRShEMCssRDEtDQo+ID4gLEQyLSxEM2hvdCssRDNjb2xkKykNCj4gPiAgICAgICAgICAgICAg
ICAgU3RhdHVzOiBEMCBOb1NvZnRSc3QrIFBNRS1FbmFibGUtIERTZWw9MCBEU2NhbGU9MCBQTUUt
DQo+ID4gICAgICAgICBDYXBhYmlsaXRpZXM6IFs0OF0gTVNJOiBFbmFibGUrIENvdW50PTEvOCBN
YXNrYWJsZSsgNjRiaXQrDQo+ID4gICAgICAgICAgICAgICAgIEFkZHJlc3M6IDAwMDAwMDAwZmVl
MDA1MTggIERhdGE6IDAwMDANCj4gPiAgICAgICAgICAgICAgICAgTWFza2luZzogMDAwMDAwZmUg
IFBlbmRpbmc6IDAwMDAwMDAwDQo+ID4gICAgICAgICBDYXBhYmlsaXRpZXM6IFs2OF0gRXhwcmVz
cyAodjIpIERvd25zdHJlYW0gUG9ydCAoU2xvdCspLCBNU0kgMDANCj4gPiAgICAgICAgICAgICAg
ICAgRGV2Q2FwOiBNYXhQYXlsb2FkIDIwNDggYnl0ZXMsIFBoYW50RnVuYyAwLCBMYXRlbmN5IEww
cw0KPiA+IDw2NG5zLCBMMSA8MXVzDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgRXh0VGFn
LSBSQkUrIEZMUmVzZXQtDQo+ID4gICAgICAgICAgICAgICAgIERldkN0bDogUmVwb3J0IGVycm9y
czogQ29ycmVjdGFibGUrIE5vbi1GYXRhbCsgRmF0YWwrDQo+ID4gVW5zdXBwb3J0ZWQtDQo+ID4g
ICAgICAgICAgICAgICAgICAgICAgICAgUmx4ZE9yZCsgRXh0VGFnLSBQaGFudEZ1bmMtIEF1eFB3
ci0gTm9Tbm9vcCsNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBNYXhQYXlsb2FkIDEyOCBi
eXRlcywgTWF4UmVhZFJlcSAxMjggYnl0ZXMNCj4gPiAgICAgICAgICAgICAgICAgRGV2U3RhOiBD
b3JyRXJyKyBVbmNvcnJFcnItIEZhdGFsRXJyLSBVbnN1cHBSZXErIEF1eFB3ci0NCj4gPiBUcmFu
c1BlbmQtDQo+ID4gICAgICAgICAgICAgICAgIExua0NhcDogUG9ydCAjMSwgU3BlZWQgOEdUL3Ms
IFdpZHRoIHg4LCBBU1BNIEwxLCBMYXRlbmN5DQo+ID4gTDAgPDR1cywgTDEgPDR1cw0KPiA+ICAg
ICAgICAgICAgICAgICAgICAgICAgIENsb2NrUE0tIFN1cnByaXNlKyBMTEFjdFJlcCsgQndOb3Qr
DQo+ID4gICAgICAgICAgICAgICAgIExua0N0bDogQVNQTSBEaXNhYmxlZDsgRGlzYWJsZWQtIFJl
dHJhaW4tIENvbW1DbGstDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgRXh0U3luY2gtIENs
b2NrUE0tIEF1dFdpZERpcy0gQldJbnQtIEF1dEJXSW50LQ0KPiA+ICAgICAgICAgICAgICAgICBM
bmtTdGE6IFNwZWVkIDIuNUdUL3MsIFdpZHRoIHgwLCBUckVyci0gVHJhaW4tIFNsb3RDbGsrDQo+
ID4gRExBY3RpdmUtIEJXTWdtdC0gQUJXTWdtdC0NCj4gPiAgICAgICAgICAgICAgICAgU2x0Q2Fw
OiBBdHRuQnRuLSBQd3JDdHJsKyBNUkwrIEF0dG5JbmQrIFB3ckluZCsgSG90UGx1ZysNCj4gPiBT
dXJwcmlzZS0NCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBTbG90ICM2NywgUG93ZXJMaW1p
dCAyNS4wMDBXOyBJbnRlcmxvY2stDQo+ID4gTm9Db21wbC0NCj4gDQo+IEhtbS4uLiBJIHNlZSB0
aGF0IHRoZSBTbG90IGhhcyBhIHBvd2VyIGNvbnRyb2xsZXIuIFdoaWNoIG1lYW5zIHRoYXQgdGhl
IHBvd2VyIHRvIHRoZSBzbG90IHNoYWxsIG5vdCBiZSB0dXJuZWQgb24gYXV0b21hdGljYWxseQ0K
PiAoYnkgSFcpIHdoZW4gdGhlIGNhcmQgaXMgcGx1Z2dlZCBpbi4gQWxzbyBtZWFuaW5nIHRoYXQg
dGhlIGxpbmsgd2lsbCBub3QgY29tZSB1cCBhdXRvbWF0aWNhbGx5IC0gc28gdGhpcyBkb2VzIG5v
dCBzZWVtDQo+IGxpa2UgdGhlIExpbmsgc3RhdGUgYmFzZWQgaG90cGx1ZyBraWNraW5nIGluLg0K
PiANCj4gV2hhdCBJIHN1c3BlY3QgaXMgdGhpcyBvbmU6DQo+IA0KPiBmMDJkMTg0M2Q4M2IgIlBD
STogcGNpZWhwOiBSZW1vdmUgc3VycHJpc2UgYml0IGNoZWNrcyINCg0KICBZb3UgYXJlIHJpZ2h0
Lg0KICBJbiBjYXNlIG9mIG9taXR0aW5nIGNvbWl0LWYwMmQxODQzLCBpdCB3b3JrZWQgYXMgZXhw
ZWN0ZWQuDQogIFNsb3QgcG93ZXIgZG9lc24ndCBiZWNvbWUgT04gYXV0b21hdGljYWxseSB3aGVu
IFBDSWUgY2FyZCBpcyBpbnNlcnRlZC4NCiAgDQogIEJlc3QgcmVnYXJkcywNCiAgVGFrdSBJenVt
aQ0KDQo+IA0KPiBTaW5jZSB0aGlzIHBhdGNoIHJlbW92ZXMgKmFsbCogdGhlIHN1cnByaXNlIGJp
dCBjaGVja3MgY2F1c2luZyBhbGwgdGhlIHByZXNlbmNlIGRldGVjdCBjaGFuZ2VzIChpbmNsdWRp
bmcgMC0+MSkgdG8gYmUNCj4gaW5pdGlhdGUgaG90cGx1Zy4gSSB0aGluayBpdCBtYXkgYmUgd29y
dGh3aGlsZSB0byB0cnkgaXQgb3V0IHdoaWxlIHJlbW92aW5nIHRoaXMgcGFydGljdWxhciBodW5r
Og0KPiANCj4gQEAgLTUzNSw4ICs1MzUsNiBAQCBzdGF0aWMgdm9pZCBpbnRlcnJ1cHRfZXZlbnRf
aGFuZGxlcihzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspDQo+ICAJCWJyZWFrOw0KPiAgCWNhc2Ug
SU5UX1BSRVNFTkNFX09OOg0KPiAgCWNhc2UgSU5UX1BSRVNFTkNFX09GRjoNCj4gLQkJaWYgKCFI
UF9TVVBSX1JNKGN0cmwpKQ0KPiAtCQkJYnJlYWs7DQo+ICAJCWN0cmxfZGJnKGN0cmwsICJTdXJw
cmlzZSBSZW1vdmFsXG4iKTsNCj4gIAkJaGFuZGxlX3N1cnByaXNlX2V2ZW50KHBfc2xvdCk7DQo+
ICAJCWJyZWFrOw0KPiANCj4gTWF5IGJlIHdlIHNob3VsZCByZW1vdmUgdGhlIHN1cnByaXNlIGNo
ZWNrIGZvciBJTlRfUFJFU0VOQ0VfT0ZGIG9ubHkgKGFuZCBsZXQgaXQgc3RheSBmb3IgSU5UX1BS
RVNFV05DRV9PTik/DQo+IA0KPiBUaGFua3MsDQo+IA0KPiBSYWphdA0KPiANCj4gDQo+IA0KPiA+
ICAgICAgICAgICAgICAgICBTbHRDdGw6IEVuYWJsZTogQXR0bkJ0bi0gUHdyRmx0LSBNUkwrIFBy
ZXNEZXQrIENtZENwbHQrDQo+ID4gSFBJcnErIExpbmtDaGcrDQo+ID4gICAgICAgICAgICAgICAg
ICAgICAgICAgQ29udHJvbDogQXR0bkluZCBPZmYsIFB3ckluZCBPZmYsIFBvd2VyKw0KPiA+IElu
dGVybG9jay0NCj4gPiAgICAgICAgICAgICAgICAgU2x0U3RhOiBTdGF0dXM6IEF0dG5CdG4tIFBv
d2VyRmx0LSBNUkwtIENtZENwbHQtDQo+ID4gUHJlc0RldC0gSW50ZXJsb2NrLQ0KPiA+ICAgICAg
ICAgICAgICAgICAgICAgICAgIENoYW5nZWQ6IE1STC0gUHJlc0RldC0gTGlua1N0YXRlLQ0KPiA+
ICAgICAgICAgICAgICAgICBEZXZDYXAyOiBDb21wbGV0aW9uIFRpbWVvdXQ6IE5vdCBTdXBwb3J0
ZWQsIFRpbWVvdXREaXMtLA0KPiA+IExUUissIE9CRkYgVmlhIG1lc3NhZ2UgQVJJRndkKw0KPiA+
ICAgICAgICAgICAgICAgICBEZXZDdGwyOiBDb21wbGV0aW9uIFRpbWVvdXQ6IDUwdXMgdG8gNTBt
cywgVGltZW91dERpcy0sDQo+ID4gTFRSLSwgT0JGRiBEaXNhYmxlZCBBUklGd2QtDQo+ID4gICAg
ICAgICAgICAgICAgIExua0N0bDI6IFRhcmdldCBMaW5rIFNwZWVkOiA4R1QvcywgRW50ZXJDb21w
bGlhbmNlLQ0KPiA+IFNwZWVkRGlzLSwgU2VsZWN0YWJsZSBEZS1lbXBoYXNpczogLTZkQg0KPiA+
ICAgICAgICAgICAgICAgICAgICAgICAgICBUcmFuc21pdCBNYXJnaW46IE5vcm1hbCBPcGVyYXRp
bmcgUmFuZ2UsDQo+ID4gRW50ZXJNb2RpZmllZENvbXBsaWFuY2UtIENvbXBsaWFuY2VTT1MtDQo+
ID4gICAgICAgICAgICAgICAgICAgICAgICAgIENvbXBsaWFuY2UgRGUtZW1waGFzaXM6IC02ZEIN
Cj4gPiAgICAgICAgICAgICAgICAgTG5rU3RhMjogQ3VycmVudCBEZS1lbXBoYXNpcyBMZXZlbDog
LTMuNWRCLA0KPiA+IEVxdWFsaXphdGlvbkNvbXBsZXRlLSwgRXF1YWxpemF0aW9uUGhhc2UxLQ0K
PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICBFcXVhbGl6YXRpb25QaGFzZTItLCBFcXVhbGl6
YXRpb25QaGFzZTMtLA0KPiA+IExpbmtFcXVhbGl6YXRpb25SZXF1ZXN0LQ0KPiA+ICAgICAgICAg
Q2FwYWJpbGl0aWVzOiBbYTRdIFN1YnN5c3RlbTogRnVqaXRzdSBMaW1pdGVkLiBEZXZpY2UgMTgw
NA0KPiA+ICAgICAgICAgQ2FwYWJpbGl0aWVzOiBbMTAwIHYxXSBEZXZpY2UgU2VyaWFsIE51bWJl
ciBhYS04Ny0wMC0xMC1iNS1kZi0NCj4gPiAwZS0wMA0KPiA+ICAgICAgICAgQ2FwYWJpbGl0aWVz
OiBbZmI0IHYxXSBBZHZhbmNlZCBFcnJvciBSZXBvcnRpbmcNCj4gPiAgICAgICAgICAgICAgICAg
VUVTdGE6ICBETFAtIFNERVMtIFRMUC0gRkNQLSBDbXBsdFRPLSBDbXBsdEFicnQtDQo+ID4gVW54
Q21wbHQtIFJ4T0YtIE1hbGZUTFAtIEVDUkMtIFVuc3VwUmVxLSBBQ1NWaW9sLQ0KPiA+ICAgICAg
ICAgICAgICAgICBVRU1zazogIERMUC0gU0RFUy0gVExQLSBGQ1AtIENtcGx0VE8tIENtcGx0QWJy
dC0NCj4gPiBVbnhDbXBsdC0gUnhPRi0gTWFsZlRMUC0gRUNSQysgVW5zdXBSZXErIEFDU1Zpb2wt
DQo+ID4gICAgICAgICAgICAgICAgIFVFU3ZydDogRExQKyBTREVTKyBUTFArIEZDUCsgQ21wbHRU
Ty0gQ21wbHRBYnJ0Kw0KPiA+IFVueENtcGx0KyBSeE9GKyBNYWxmVExQKyBFQ1JDKyBVbnN1cFJl
cS0gQUNTVmlvbCsNCj4gPiAgICAgICAgICAgICAgICAgQ0VTdGE6ICBSeEVyci0gQmFkVExQLSBC
YWRETExQLSBSb2xsb3Zlci0gVGltZW91dC0NCj4gPiBOb25GYXRhbEVycisNCj4gPiAgICAgICAg
ICAgICAgICAgQ0VNc2s6ICBSeEVyci0gQmFkVExQLSBCYWRETExQLSBSb2xsb3Zlci0gVGltZW91
dC0NCj4gPiBOb25GYXRhbEVycisNCj4gPiAgICAgICAgICAgICAgICAgQUVSQ2FwOiBGaXJzdCBF
cnJvciBQb2ludGVyOiAxZiwgR2VuQ2FwKyBDR2VuRW4tIENoa0NhcCsNCj4gPiBDaGtFbi0NCj4g
PiAgICAgICAgIENhcGFiaWxpdGllczogWzEzOCB2MV0gUG93ZXIgQnVkZ2V0aW5nIDw/Pg0KPiA+
ICAgICAgICAgQ2FwYWJpbGl0aWVzOiBbMTBjIHYxXSAjMTkNCj4gPiAgICAgICAgIENhcGFiaWxp
dGllczogWzE0OCB2MV0gVmlydHVhbCBDaGFubmVsDQo+ID4gICAgICAgICAgICAgICAgIENhcHM6
ICAgTFBFVkM9MCBSZWZDbGs9MTAwbnMgUEFURW50cnlCaXRzPTENCj4gPiAgICAgICAgICAgICAg
ICAgQXJiOiAgICBGaXhlZC0gV1JSMzItIFdSUjY0LSBXUlIxMjgtDQo+ID4gICAgICAgICAgICAg
ICAgIEN0cmw6ICAgQXJiU2VsZWN0PUZpeGVkDQo+ID4gICAgICAgICAgICAgICAgIFN0YXR1czog
SW5Qcm9ncmVzcy0NCj4gPiAgICAgICAgICAgICAgICAgVkMwOiAgICBDYXBzOiAgIFBBVE9mZnNl
dD0wMCBNYXhUaW1lU2xvdHM9MQ0KPiA+IFJlalNub29wVHJhbnMtDQo+ID4gICAgICAgICAgICAg
ICAgICAgICAgICAgQXJiOiAgICBGaXhlZCsgV1JSMzItIFdSUjY0LSBXUlIxMjgtIFRXUlIxMjgt
DQo+ID4gV1JSMjU2LQ0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIEN0cmw6ICAgRW5hYmxl
KyBJRD0wIEFyYlNlbGVjdD1GaXhlZCBUQy9WQz1mZg0KPiA+ICAgICAgICAgICAgICAgICAgICAg
ICAgIFN0YXR1czogTmVnb1BlbmRpbmcrIEluUHJvZ3Jlc3MtDQo+ID4gICAgICAgICBDYXBhYmls
aXRpZXM6IFtlMDAgdjFdICMxMg0KPiA+ICAgICAgICAgQ2FwYWJpbGl0aWVzOiBbZjI0IHYxXSBB
Y2Nlc3MgQ29udHJvbCBTZXJ2aWNlcw0KPiA+ICAgICAgICAgICAgICAgICBBQ1NDYXA6IFNyY1Zh
bGlkKyBUcmFuc0JsaysgUmVxUmVkaXIrIENtcGx0UmVkaXIrDQo+ID4gVXBzdHJlYW1Gd2QrIEVn
cmVzc0N0cmwrIERpcmVjdFRyYW5zKw0KPiA+ICAgICAgICAgICAgICAgICBBQ1NDdGw6IFNyY1Zh
bGlkLSBUcmFuc0Jsay0gUmVxUmVkaXItIENtcGx0UmVkaXItDQo+ID4gVXBzdHJlYW1Gd2QtIEVn
cmVzc0N0cmwtIERpcmVjdFRyYW5zLQ0KPiA+ICAgICAgICAgQ2FwYWJpbGl0aWVzOiBbYjcwIHYx
XSBWZW5kb3IgU3BlY2lmaWMgSW5mb3JtYXRpb246IElEPTAwMDENCj4gPiBSZXY9MCBMZW49MDEw
IDw/Pg0KPiA+ICAgICAgICAgS2VybmVsIGRyaXZlciBpbiB1c2U6IHBjaWVwb3J0DQo+ID4NCj4g
Pg0KPiA+ID4gSWYgdGhlcmUgaXMgbm8gYXR0ZW50aW9uIGJ1dHRvbiwgdGhlbiB0aGUgYmVoYXZp
b3Igc2VlbiwgbWF0Y2hlcyB3aXRoDQo+ID4gPiB3aGF0IEkgZXhwZWN0ZWQgb2YgdGhlIGNvZGUu
DQo+ID4gPg0KPiA+ID4gU2VlbWluZ2x5LCB0aGUgSFcgZG9lcyBub3QgaGF2ZSBhIHBvd2VyIGNv
bnRyb2xsZXIgKGFuZCBhdHRlbnRpb24NCj4gPiA+IGJ1dHRvbiksIHRodXMgdGhlIHBvd2VyIGlz
IGF1dG9tYXRpY2FsbHkgdHVybmVkIG9uIChieSBIVykgd2hlbiBjYXJkDQo+ID4gPiBpcyBpbnNl
cnRlZCBhbmQgdGhlIGxpbmsgY29tZXMgdXAuIFRodXMgcHJpb3IgdG8gbGluayBzdGF0ZSBiYXNl
ZA0KPiA+ID4gaG90LXBsdWcsICJlY2hvIDEgPiBwb3dlciIgdXNlZCB0byBkbyBhIGxpdHRsZSBl
bHNlIHRoYW4gaW5pdGlhdGUgYQ0KPiA+ID4gcmVzY2FuIGZvciB0aGlzIHBhcnRpY3VsYXIgSFcu
DQo+ID4NCj4gPiA+DQo+ID4gPiA+DQo+ID4gPiA+IEkgdGhpbmsgdGhhdCBmb3IgRXhwcmVzc0Nh
cmQgYW5kIHNpbWlsYXIgZGV2aWNlcywgd2Ugd2FudCB0byB0dXJuIG9uDQo+ID4gPiA+IHRoZSBk
ZXZpY2UgYW5kIGF0dGFjaCBhIGRyaXZlciBhcyBzb29uIGFzIHRoZSBjYXJkIGlzIGluc2VydGVk
LiAgQnV0DQo+ID4gPiA+IGluIHlvdXIgY2FzZSwgSSBhc3N1bWUgd2Ugd2FudCBhIG1vZGVsIGxp
a2UgdGhhdCBpbiBUYWJsZSAyLTcgb2YgdGhlDQo+ID4gPiA+ICJQQ0kgU3RhbmRhcmQgSG90LVBs
dWcgQ29udHJvbGxlciBhbmQgU3Vic3lzdGVtIFNwZWNpZmljYXRpb24sIiByZXYNCj4gPiA+ID4g
MS4wLCBpLmUuLCAiSG90IEluc2VydGlvbiBJbml0aWF0ZWQgdmlhIFNvZnR3YXJlIFVJLiIgIFNv
IHRoZXJlIG11c3QNCj4gPiA+ID4gYmUgc29tZSB3YXkgdG8gZGlmZmVyZW50aWF0ZSBhbiBFeHBy
ZXNzQ2FyZCBzbG90IGZyb20gYSBzbG90IGxpa2UNCj4gPiA+ID4geW91cnMuDQo+ID4gPg0KPiA+
ID4gWWVzLCB0aGF0IHdvdWxkIGhlbHAgaWYgdGhlcmUgd2FzIHNvbWUgd2F5Lg0KPiA+ID4NCj4g
Pg0KPiA+IEJlc3QgcmVnYXJkcywNCj4gPiBUYWt1IEl6dW1pDQoNCg==
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-14 7:21 ` Izumi, Taku
@ 2014-02-14 7:26 ` Rajat Jain
2014-02-14 17:31 ` Bjorn Helgaas
1 sibling, 0 replies; 16+ messages in thread
From: Rajat Jain @ 2014-02-14 7:26 UTC (permalink / raw)
To: Izumi, Taku, rajatxjain, Bjorn Helgaas
Cc: linux-pci, yinghai, Guenter Roeck, Takashi Iwai
VGhhbmtzIGEgYnVuY2ggZm9yIFRlc3RpbmchDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0t
LS0NCj4gRnJvbTogSXp1bWksIFRha3UgW21haWx0bzppenVtaS50YWt1QGpwLmZ1aml0c3UuY29t
XQ0KPiBTZW50OiBUaHVyc2RheSwgRmVicnVhcnkgMTMsIDIwMTQgMTE6MjEgUE0NCj4gVG86IFJh
amF0IEphaW47IHJhamF0eGphaW5AZ21haWwuY29tOyBCam9ybiBIZWxnYWFzDQo+IENjOiBsaW51
eC1wY2lAdmdlci5rZXJuZWwub3JnOyB5aW5naGFpQGtlcm5lbC5vcmc7IEd1ZW50ZXIgUm9lY2s7
DQo+IFRha2FzaGkgSXdhaQ0KPiBTdWJqZWN0OiBSRTogW1BBVENIXSBQQ0k6IHBjaWVocDogRml4
IHRoZSBwcm9ibGVtIHRoYXQgdGhlIHByZXNlbnQgYml0DQo+IGlzIG5vdCBjbGVhcmVkIHRob3Vn
aCBzbG90IGlzIGVtcHR5DQo+IA0KPiBIaSBSYWphdCwNCj4gDQo+ID4gWytUYWthc2hpXQ0KPiA+
DQo+ID4gSGVsbG8sDQo+ID4gPg0KPiA+ID4gPiA+IEh1aCwgdGhhdCBkb2Vzbid0IHNvdW5kIGdv
b2QuICBEb2VzIHlvdXIgc2xvdCBoYXZlIGFuIGF0dGVudGlvbg0KPiA+ID4gPiA+IGJ1dHRvbj8g
IENhbiB5b3UgY29sbGVjdCB0aGUgImxzcGNpIC12dnYiIG91dHB1dCBmb3IgdGhlDQo+ID4gPiA+
ID4gRG93bnN0cmVhbSBQb3J0IGxlYWRpbmcgdG8gdGhpcyBzbG90Pw0KPiA+ID4NCj4gPiA+ICAg
IFRoZSBzbG90cyBoYXZlIG5vIEF0dGVudGlvbiBidXR0b24gYW5kIGFyZSBub3QgZm9yIEV4cHJl
c3NDYXJkLg0KPiA+ID4gICAgbHNwY2kgLXZ2diBvdXRwdXQgaXM6DQo+ID4gPg0KPiA+ID4gICAg
ICAgICBDb250cm9sOiBJL08rIE1lbSsgQnVzTWFzdGVyKyBTcGVjQ3ljbGUtIE1lbVdJTlYtIFZH
QVNub29wLQ0KPiA+ID4gUGFyRXJyKyBTdGVwcGluZy0gU0VSUisgRmFzdEIyQi0gRGlzSU5UeCsN
Cj4gPiA+ICAgICAgICAgU3RhdHVzOiBDYXArIDY2TUh6LSBVREYtIEZhc3RCMkItIFBhckVyci0g
REVWU0VMPWZhc3QNCj4gPiA+ID5UQWJvcnQtDQo+ID4gPiA8VEFib3J0LSA8TUFib3J0LSA+U0VS
Ui0gPFBFUlItIElOVHgtDQo+ID4gPiAgICAgICAgIExhdGVuY3k6IDANCj4gPiA+ICAgICAgICAg
QnVzOiBwcmltYXJ5PTJjLCBzZWNvbmRhcnk9MmQsIHN1Ym9yZGluYXRlPTJmLCBzZWMtbGF0ZW5j
eT0wDQo+ID4gPiAgICAgICAgIEkvTyBiZWhpbmQgYnJpZGdlOiAwMDAwZjAwMC0wMDAwMGZmZg0K
PiA+ID4gICAgICAgICBNZW1vcnkgYmVoaW5kIGJyaWRnZTogYjE4MDAwMDAtYjFmZmZmZmYNCj4g
PiA+ICAgICAgICAgUHJlZmV0Y2hhYmxlIG1lbW9yeSBiZWhpbmQgYnJpZGdlOiAwMDAwMDAwMGFl
ODAwMDAwLQ0KPiA+ID4gMDAwMDAwMDBhZWZmZmZmZg0KPiA+ID4gICAgICAgICBTZWNvbmRhcnkg
c3RhdHVzOiA2Nk1Iei0gRmFzdEIyQi0gUGFyRXJyLSBERVZTRUw9ZmFzdA0KPiA+ID4gPlRBYm9y
dC0NCj4gPiA+IDxUQWJvcnQtIDxNQWJvcnQtIDxTRVJSLSA8UEVSUi0NCj4gPiA+ICAgICAgICAg
QnJpZGdlQ3RsOiBQYXJpdHktIFNFUlIrIE5vSVNBLSBWR0EtIE1BYm9ydC0gPlJlc2V0LQ0KPiBG
YXN0QjJCLQ0KPiA+ID4gICAgICAgICAgICAgICAgIFByaURpc2NUbXItIFNlY0Rpc2NUbXItIERp
c2NUbXJTdGF0LSBEaXNjVG1yU0VSUkVuLQ0KPiA+ID4gICAgICAgICBDYXBhYmlsaXRpZXM6IFs0
MF0gUG93ZXIgTWFuYWdlbWVudCB2ZXJzaW9uIDMNCj4gPiA+ICAgICAgICAgICAgICAgICBGbGFn
czogUE1FQ2xrLSBEU0ktIEQxLSBEMi0gQXV4Q3VycmVudD0wbUENCj4gPiA+IFBNRShEMCssRDEt
DQo+ID4gPiAsRDItLEQzaG90KyxEM2NvbGQrKQ0KPiA+ID4gICAgICAgICAgICAgICAgIFN0YXR1
czogRDAgTm9Tb2Z0UnN0KyBQTUUtRW5hYmxlLSBEU2VsPTAgRFNjYWxlPTANCj4gUE1FLQ0KPiA+
ID4gICAgICAgICBDYXBhYmlsaXRpZXM6IFs0OF0gTVNJOiBFbmFibGUrIENvdW50PTEvOCBNYXNr
YWJsZSsgNjRiaXQrDQo+ID4gPiAgICAgICAgICAgICAgICAgQWRkcmVzczogMDAwMDAwMDBmZWUw
MDUxOCAgRGF0YTogMDAwMA0KPiA+ID4gICAgICAgICAgICAgICAgIE1hc2tpbmc6IDAwMDAwMGZl
ICBQZW5kaW5nOiAwMDAwMDAwMA0KPiA+ID4gICAgICAgICBDYXBhYmlsaXRpZXM6IFs2OF0gRXhw
cmVzcyAodjIpIERvd25zdHJlYW0gUG9ydCAoU2xvdCspLCBNU0kNCj4gMDANCj4gPiA+ICAgICAg
ICAgICAgICAgICBEZXZDYXA6IE1heFBheWxvYWQgMjA0OCBieXRlcywgUGhhbnRGdW5jIDAsIExh
dGVuY3kNCj4gPiA+IEwwcyA8NjRucywgTDEgPDF1cw0KPiA+ID4gICAgICAgICAgICAgICAgICAg
ICAgICAgRXh0VGFnLSBSQkUrIEZMUmVzZXQtDQo+ID4gPiAgICAgICAgICAgICAgICAgRGV2Q3Rs
OiBSZXBvcnQgZXJyb3JzOiBDb3JyZWN0YWJsZSsgTm9uLUZhdGFsKw0KPiA+ID4gRmF0YWwrDQo+
ID4gPiBVbnN1cHBvcnRlZC0NCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIFJseGRPcmQr
IEV4dFRhZy0gUGhhbnRGdW5jLSBBdXhQd3ItIE5vU25vb3ArDQo+ID4gPiAgICAgICAgICAgICAg
ICAgICAgICAgICBNYXhQYXlsb2FkIDEyOCBieXRlcywgTWF4UmVhZFJlcSAxMjggYnl0ZXMNCj4g
PiA+ICAgICAgICAgICAgICAgICBEZXZTdGE6IENvcnJFcnIrIFVuY29yckVyci0gRmF0YWxFcnIt
IFVuc3VwcFJlcSsNCj4gPiA+IEF1eFB3ci0NCj4gPiA+IFRyYW5zUGVuZC0NCj4gPiA+ICAgICAg
ICAgICAgICAgICBMbmtDYXA6IFBvcnQgIzEsIFNwZWVkIDhHVC9zLCBXaWR0aCB4OCwgQVNQTSBM
MSwNCj4gPiA+IExhdGVuY3kNCj4gPiA+IEwwIDw0dXMsIEwxIDw0dXMNCj4gPiA+ICAgICAgICAg
ICAgICAgICAgICAgICAgIENsb2NrUE0tIFN1cnByaXNlKyBMTEFjdFJlcCsgQndOb3QrDQo+ID4g
PiAgICAgICAgICAgICAgICAgTG5rQ3RsOiBBU1BNIERpc2FibGVkOyBEaXNhYmxlZC0gUmV0cmFp
bi0gQ29tbUNsay0NCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIEV4dFN5bmNoLSBDbG9j
a1BNLSBBdXRXaWREaXMtIEJXSW50LQ0KPiBBdXRCV0ludC0NCj4gPiA+ICAgICAgICAgICAgICAg
ICBMbmtTdGE6IFNwZWVkIDIuNUdUL3MsIFdpZHRoIHgwLCBUckVyci0gVHJhaW4tDQo+ID4gPiBT
bG90Q2xrKw0KPiA+ID4gRExBY3RpdmUtIEJXTWdtdC0gQUJXTWdtdC0NCj4gPiA+ICAgICAgICAg
ICAgICAgICBTbHRDYXA6IEF0dG5CdG4tIFB3ckN0cmwrIE1STCsgQXR0bkluZCsgUHdySW5kKw0K
PiA+ID4gSG90UGx1ZysNCj4gPiA+IFN1cnByaXNlLQ0KPiA+ID4gICAgICAgICAgICAgICAgICAg
ICAgICAgU2xvdCAjNjcsIFBvd2VyTGltaXQgMjUuMDAwVzsgSW50ZXJsb2NrLQ0KPiA+ID4gTm9D
b21wbC0NCj4gPg0KPiA+IEhtbS4uLiBJIHNlZSB0aGF0IHRoZSBTbG90IGhhcyBhIHBvd2VyIGNv
bnRyb2xsZXIuIFdoaWNoIG1lYW5zIHRoYXQNCj4gPiB0aGUgcG93ZXIgdG8gdGhlIHNsb3Qgc2hh
bGwgbm90IGJlIHR1cm5lZCBvbiBhdXRvbWF0aWNhbGx5IChieSBIVykNCj4gPiB3aGVuIHRoZSBj
YXJkIGlzIHBsdWdnZWQgaW4uIEFsc28gbWVhbmluZyB0aGF0IHRoZSBsaW5rIHdpbGwgbm90IGNv
bWUNCj4gdXAgYXV0b21hdGljYWxseSAtIHNvIHRoaXMgZG9lcyBub3Qgc2VlbSBsaWtlIHRoZSBM
aW5rIHN0YXRlIGJhc2VkDQo+IGhvdHBsdWcga2lja2luZyBpbi4NCj4gPg0KPiA+IFdoYXQgSSBz
dXNwZWN0IGlzIHRoaXMgb25lOg0KPiA+DQo+ID4gZjAyZDE4NDNkODNiICJQQ0k6IHBjaWVocDog
UmVtb3ZlIHN1cnByaXNlIGJpdCBjaGVja3MiDQo+IA0KPiAgIFlvdSBhcmUgcmlnaHQuDQo+ICAg
SW4gY2FzZSBvZiBvbWl0dGluZyBjb21pdC1mMDJkMTg0MywgaXQgd29ya2VkIGFzIGV4cGVjdGVk
Lg0KPiAgIFNsb3QgcG93ZXIgZG9lc24ndCBiZWNvbWUgT04gYXV0b21hdGljYWxseSB3aGVuIFBD
SWUgY2FyZCBpcyBpbnNlcnRlZC4NCj4gDQo+ICAgQmVzdCByZWdhcmRzLA0KPiAgIFRha3UgSXp1
bWkNCj4gDQo+ID4NCj4gPiBTaW5jZSB0aGlzIHBhdGNoIHJlbW92ZXMgKmFsbCogdGhlIHN1cnBy
aXNlIGJpdCBjaGVja3MgY2F1c2luZyBhbGwgdGhlDQo+ID4gcHJlc2VuY2UgZGV0ZWN0IGNoYW5n
ZXMgKGluY2x1ZGluZyAwLT4xKSB0byBiZSBpbml0aWF0ZSBob3RwbHVnLiBJDQo+IHRoaW5rIGl0
IG1heSBiZSB3b3J0aHdoaWxlIHRvIHRyeSBpdCBvdXQgd2hpbGUgcmVtb3ZpbmcgdGhpcyBwYXJ0
aWN1bGFyDQo+IGh1bms6DQo+ID4NCj4gPiBAQCAtNTM1LDggKzUzNSw2IEBAIHN0YXRpYyB2b2lk
IGludGVycnVwdF9ldmVudF9oYW5kbGVyKHN0cnVjdA0KPiB3b3JrX3N0cnVjdCAqd29yaykNCj4g
PiAgCQlicmVhazsNCj4gPiAgCWNhc2UgSU5UX1BSRVNFTkNFX09OOg0KPiA+ICAJY2FzZSBJTlRf
UFJFU0VOQ0VfT0ZGOg0KPiA+IC0JCWlmICghSFBfU1VQUl9STShjdHJsKSkNCj4gPiAtCQkJYnJl
YWs7DQo+ID4gIAkJY3RybF9kYmcoY3RybCwgIlN1cnByaXNlIFJlbW92YWxcbiIpOw0KPiA+ICAJ
CWhhbmRsZV9zdXJwcmlzZV9ldmVudChwX3Nsb3QpOw0KPiA+ICAJCWJyZWFrOw0KPiA+DQo+ID4g
TWF5IGJlIHdlIHNob3VsZCByZW1vdmUgdGhlIHN1cnByaXNlIGNoZWNrIGZvciBJTlRfUFJFU0VO
Q0VfT0ZGIG9ubHkNCj4gKGFuZCBsZXQgaXQgc3RheSBmb3IgSU5UX1BSRVNFV05DRV9PTik/DQo+
ID4NCj4gPiBUaGFua3MsDQo+ID4NCj4gPiBSYWphdA0KPiA+DQo+ID4NCj4gPg0KPiA+ID4gICAg
ICAgICAgICAgICAgIFNsdEN0bDogRW5hYmxlOiBBdHRuQnRuLSBQd3JGbHQtIE1STCsgUHJlc0Rl
dCsNCj4gPiA+IENtZENwbHQrDQo+ID4gPiBIUElycSsgTGlua0NoZysNCj4gPiA+ICAgICAgICAg
ICAgICAgICAgICAgICAgIENvbnRyb2w6IEF0dG5JbmQgT2ZmLCBQd3JJbmQgT2ZmLCBQb3dlcisN
Cj4gPiA+IEludGVybG9jay0NCj4gPiA+ICAgICAgICAgICAgICAgICBTbHRTdGE6IFN0YXR1czog
QXR0bkJ0bi0gUG93ZXJGbHQtIE1STC0gQ21kQ3BsdC0NCj4gPiA+IFByZXNEZXQtIEludGVybG9j
ay0NCj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIENoYW5nZWQ6IE1STC0gUHJlc0RldC0g
TGlua1N0YXRlLQ0KPiA+ID4gICAgICAgICAgICAgICAgIERldkNhcDI6IENvbXBsZXRpb24gVGlt
ZW91dDogTm90IFN1cHBvcnRlZCwNCj4gPiA+IFRpbWVvdXREaXMtLA0KPiA+ID4gTFRSKywgT0JG
RiBWaWEgbWVzc2FnZSBBUklGd2QrDQo+ID4gPiAgICAgICAgICAgICAgICAgRGV2Q3RsMjogQ29t
cGxldGlvbiBUaW1lb3V0OiA1MHVzIHRvIDUwbXMsDQo+ID4gPiBUaW1lb3V0RGlzLSwgTFRSLSwg
T0JGRiBEaXNhYmxlZCBBUklGd2QtDQo+ID4gPiAgICAgICAgICAgICAgICAgTG5rQ3RsMjogVGFy
Z2V0IExpbmsgU3BlZWQ6IDhHVC9zLCBFbnRlckNvbXBsaWFuY2UtDQo+ID4gPiBTcGVlZERpcy0s
IFNlbGVjdGFibGUgRGUtZW1waGFzaXM6IC02ZEINCj4gPiA+ICAgICAgICAgICAgICAgICAgICAg
ICAgICBUcmFuc21pdCBNYXJnaW46IE5vcm1hbCBPcGVyYXRpbmcgUmFuZ2UsDQo+ID4gPiBFbnRl
ck1vZGlmaWVkQ29tcGxpYW5jZS0gQ29tcGxpYW5jZVNPUy0NCj4gPiA+ICAgICAgICAgICAgICAg
ICAgICAgICAgICBDb21wbGlhbmNlIERlLWVtcGhhc2lzOiAtNmRCDQo+ID4gPiAgICAgICAgICAg
ICAgICAgTG5rU3RhMjogQ3VycmVudCBEZS1lbXBoYXNpcyBMZXZlbDogLTMuNWRCLA0KPiA+ID4g
RXF1YWxpemF0aW9uQ29tcGxldGUtLCBFcXVhbGl6YXRpb25QaGFzZTEtDQo+ID4gPiAgICAgICAg
ICAgICAgICAgICAgICAgICAgRXF1YWxpemF0aW9uUGhhc2UyLSwgRXF1YWxpemF0aW9uUGhhc2Uz
LSwNCj4gPiA+IExpbmtFcXVhbGl6YXRpb25SZXF1ZXN0LQ0KPiA+ID4gICAgICAgICBDYXBhYmls
aXRpZXM6IFthNF0gU3Vic3lzdGVtOiBGdWppdHN1IExpbWl0ZWQuIERldmljZSAxODA0DQo+ID4g
PiAgICAgICAgIENhcGFiaWxpdGllczogWzEwMCB2MV0gRGV2aWNlIFNlcmlhbCBOdW1iZXINCj4g
PiA+IGFhLTg3LTAwLTEwLWI1LWRmLQ0KPiA+ID4gMGUtMDANCj4gPiA+ICAgICAgICAgQ2FwYWJp
bGl0aWVzOiBbZmI0IHYxXSBBZHZhbmNlZCBFcnJvciBSZXBvcnRpbmcNCj4gPiA+ICAgICAgICAg
ICAgICAgICBVRVN0YTogIERMUC0gU0RFUy0gVExQLSBGQ1AtIENtcGx0VE8tIENtcGx0QWJydC0N
Cj4gPiA+IFVueENtcGx0LSBSeE9GLSBNYWxmVExQLSBFQ1JDLSBVbnN1cFJlcS0gQUNTVmlvbC0N
Cj4gPiA+ICAgICAgICAgICAgICAgICBVRU1zazogIERMUC0gU0RFUy0gVExQLSBGQ1AtIENtcGx0
VE8tIENtcGx0QWJydC0NCj4gPiA+IFVueENtcGx0LSBSeE9GLSBNYWxmVExQLSBFQ1JDKyBVbnN1
cFJlcSsgQUNTVmlvbC0NCj4gPiA+ICAgICAgICAgICAgICAgICBVRVN2cnQ6IERMUCsgU0RFUysg
VExQKyBGQ1ArIENtcGx0VE8tIENtcGx0QWJydCsNCj4gPiA+IFVueENtcGx0KyBSeE9GKyBNYWxm
VExQKyBFQ1JDKyBVbnN1cFJlcS0gQUNTVmlvbCsNCj4gPiA+ICAgICAgICAgICAgICAgICBDRVN0
YTogIFJ4RXJyLSBCYWRUTFAtIEJhZERMTFAtIFJvbGxvdmVyLSBUaW1lb3V0LQ0KPiA+ID4gTm9u
RmF0YWxFcnIrDQo+ID4gPiAgICAgICAgICAgICAgICAgQ0VNc2s6ICBSeEVyci0gQmFkVExQLSBC
YWRETExQLSBSb2xsb3Zlci0gVGltZW91dC0NCj4gPiA+IE5vbkZhdGFsRXJyKw0KPiA+ID4gICAg
ICAgICAgICAgICAgIEFFUkNhcDogRmlyc3QgRXJyb3IgUG9pbnRlcjogMWYsIEdlbkNhcCsgQ0dl
bkVuLQ0KPiA+ID4gQ2hrQ2FwKw0KPiA+ID4gQ2hrRW4tDQo+ID4gPiAgICAgICAgIENhcGFiaWxp
dGllczogWzEzOCB2MV0gUG93ZXIgQnVkZ2V0aW5nIDw/Pg0KPiA+ID4gICAgICAgICBDYXBhYmls
aXRpZXM6IFsxMGMgdjFdICMxOQ0KPiA+ID4gICAgICAgICBDYXBhYmlsaXRpZXM6IFsxNDggdjFd
IFZpcnR1YWwgQ2hhbm5lbA0KPiA+ID4gICAgICAgICAgICAgICAgIENhcHM6ICAgTFBFVkM9MCBS
ZWZDbGs9MTAwbnMgUEFURW50cnlCaXRzPTENCj4gPiA+ICAgICAgICAgICAgICAgICBBcmI6ICAg
IEZpeGVkLSBXUlIzMi0gV1JSNjQtIFdSUjEyOC0NCj4gPiA+ICAgICAgICAgICAgICAgICBDdHJs
OiAgIEFyYlNlbGVjdD1GaXhlZA0KPiA+ID4gICAgICAgICAgICAgICAgIFN0YXR1czogSW5Qcm9n
cmVzcy0NCj4gPiA+ICAgICAgICAgICAgICAgICBWQzA6ICAgIENhcHM6ICAgUEFUT2Zmc2V0PTAw
IE1heFRpbWVTbG90cz0xDQo+ID4gPiBSZWpTbm9vcFRyYW5zLQ0KPiA+ID4gICAgICAgICAgICAg
ICAgICAgICAgICAgQXJiOiAgICBGaXhlZCsgV1JSMzItIFdSUjY0LSBXUlIxMjgtDQo+IFRXUlIx
MjgtDQo+ID4gPiBXUlIyNTYtDQo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICBDdHJsOiAg
IEVuYWJsZSsgSUQ9MCBBcmJTZWxlY3Q9Rml4ZWQNCj4gVEMvVkM9ZmYNCj4gPiA+ICAgICAgICAg
ICAgICAgICAgICAgICAgIFN0YXR1czogTmVnb1BlbmRpbmcrIEluUHJvZ3Jlc3MtDQo+ID4gPiAg
ICAgICAgIENhcGFiaWxpdGllczogW2UwMCB2MV0gIzEyDQo+ID4gPiAgICAgICAgIENhcGFiaWxp
dGllczogW2YyNCB2MV0gQWNjZXNzIENvbnRyb2wgU2VydmljZXMNCj4gPiA+ICAgICAgICAgICAg
ICAgICBBQ1NDYXA6IFNyY1ZhbGlkKyBUcmFuc0JsaysgUmVxUmVkaXIrIENtcGx0UmVkaXIrDQo+
ID4gPiBVcHN0cmVhbUZ3ZCsgRWdyZXNzQ3RybCsgRGlyZWN0VHJhbnMrDQo+ID4gPiAgICAgICAg
ICAgICAgICAgQUNTQ3RsOiBTcmNWYWxpZC0gVHJhbnNCbGstIFJlcVJlZGlyLSBDbXBsdFJlZGly
LQ0KPiA+ID4gVXBzdHJlYW1Gd2QtIEVncmVzc0N0cmwtIERpcmVjdFRyYW5zLQ0KPiA+ID4gICAg
ICAgICBDYXBhYmlsaXRpZXM6IFtiNzAgdjFdIFZlbmRvciBTcGVjaWZpYyBJbmZvcm1hdGlvbjog
SUQ9MDAwMQ0KPiA+ID4gUmV2PTAgTGVuPTAxMCA8Pz4NCj4gPiA+ICAgICAgICAgS2VybmVsIGRy
aXZlciBpbiB1c2U6IHBjaWVwb3J0DQo+ID4gPg0KPiA+ID4NCj4gPiA+ID4gSWYgdGhlcmUgaXMg
bm8gYXR0ZW50aW9uIGJ1dHRvbiwgdGhlbiB0aGUgYmVoYXZpb3Igc2VlbiwgbWF0Y2hlcw0KPiA+
ID4gPiB3aXRoIHdoYXQgSSBleHBlY3RlZCBvZiB0aGUgY29kZS4NCj4gPiA+ID4NCj4gPiA+ID4g
U2VlbWluZ2x5LCB0aGUgSFcgZG9lcyBub3QgaGF2ZSBhIHBvd2VyIGNvbnRyb2xsZXIgKGFuZCBh
dHRlbnRpb24NCj4gPiA+ID4gYnV0dG9uKSwgdGh1cyB0aGUgcG93ZXIgaXMgYXV0b21hdGljYWxs
eSB0dXJuZWQgb24gKGJ5IEhXKSB3aGVuDQo+ID4gPiA+IGNhcmQgaXMgaW5zZXJ0ZWQgYW5kIHRo
ZSBsaW5rIGNvbWVzIHVwLiBUaHVzIHByaW9yIHRvIGxpbmsgc3RhdGUNCj4gPiA+ID4gYmFzZWQg
aG90LXBsdWcsICJlY2hvIDEgPiBwb3dlciIgdXNlZCB0byBkbyBhIGxpdHRsZSBlbHNlIHRoYW4N
Cj4gPiA+ID4gaW5pdGlhdGUgYSByZXNjYW4gZm9yIHRoaXMgcGFydGljdWxhciBIVy4NCj4gPiA+
DQo+ID4gPiA+DQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBJIHRoaW5rIHRoYXQgZm9yIEV4cHJlc3ND
YXJkIGFuZCBzaW1pbGFyIGRldmljZXMsIHdlIHdhbnQgdG8NCj4gPiA+ID4gPiB0dXJuIG9uIHRo
ZSBkZXZpY2UgYW5kIGF0dGFjaCBhIGRyaXZlciBhcyBzb29uIGFzIHRoZSBjYXJkIGlzDQo+ID4g
PiA+ID4gaW5zZXJ0ZWQuICBCdXQgaW4geW91ciBjYXNlLCBJIGFzc3VtZSB3ZSB3YW50IGEgbW9k
ZWwgbGlrZSB0aGF0DQo+ID4gPiA+ID4gaW4gVGFibGUgMi03IG9mIHRoZSAiUENJIFN0YW5kYXJk
IEhvdC1QbHVnIENvbnRyb2xsZXIgYW5kDQo+ID4gPiA+ID4gU3Vic3lzdGVtIFNwZWNpZmljYXRp
b24sIiByZXYgMS4wLCBpLmUuLCAiSG90IEluc2VydGlvbg0KPiA+ID4gPiA+IEluaXRpYXRlZCB2
aWEgU29mdHdhcmUgVUkuIiAgU28gdGhlcmUgbXVzdCBiZSBzb21lIHdheSB0bw0KPiA+ID4gPiA+
IGRpZmZlcmVudGlhdGUgYW4gRXhwcmVzc0NhcmQgc2xvdCBmcm9tIGEgc2xvdCBsaWtlIHlvdXJz
Lg0KPiA+ID4gPg0KPiA+ID4gPiBZZXMsIHRoYXQgd291bGQgaGVscCBpZiB0aGVyZSB3YXMgc29t
ZSB3YXkuDQo+ID4gPiA+DQo+ID4gPg0KPiA+ID4gQmVzdCByZWdhcmRzLA0KPiA+ID4gVGFrdSBJ
enVtaQ0KDQo=
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-14 7:21 ` Izumi, Taku
2014-02-14 7:26 ` Rajat Jain
@ 2014-02-14 17:31 ` Bjorn Helgaas
2014-02-14 19:39 ` Rajat Jain
1 sibling, 1 reply; 16+ messages in thread
From: Bjorn Helgaas @ 2014-02-14 17:31 UTC (permalink / raw)
To: Izumi, Taku
Cc: Rajat Jain, rajatxjain, linux-pci, yinghai, Guenter Roeck, Takashi Iwai
On Fri, Feb 14, 2014 at 12:21 AM, Izumi, Taku <izumi.taku@jp.fujitsu.com> wrote:
>> Hmm... I see that the Slot has a power controller. Which means that the power to the slot shall not be turned on automatically
>> (by HW) when the card is plugged in. Also meaning that the link will not come up automatically - so this does not seem
>> like the Link state based hotplug kicking in.
>>
>> What I suspect is this one:
>>
>> f02d1843d83b "PCI: pciehp: Remove surprise bit checks"
>
> You are right.
> In case of omitting comit-f02d1843, it worked as expected.
> Slot power doesn't become ON automatically when PCIe card is inserted.
OK, I dropped f02d1843d83b ("PCI: pciehp: Remove surprise bit
checks"). Thanks for testing, everybody!
I think our handling of slot capabilities and control is a bit
haphazard. It seems like we're mostly responding to things that
break, and we don't really have a coherent explanation of how things
*should* work in different configurations. I think it would be good
if somebody wrote up something for Documentation/PCI, with references
to the relevant specifications, that describes how we think things
should work. For example, I think we have at least four models:
1) ExpressCard
2) Slots with attention button
3) Slots with no button where we expect a software UI, e.g., Taku's box
4) Devices with no actual slot, no button, etc., e.g., Rajat's system
We handle these slightly differently, implicitly relying on various
capability tests scattered throughout the code. I think we should be
able to come up with a scheme that would make this more explicit and
make pciehp simpler and more consistent.
Bjorn
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-14 17:31 ` Bjorn Helgaas
@ 2014-02-14 19:39 ` Rajat Jain
2014-02-18 23:02 ` Bjorn Helgaas
2014-02-25 3:02 ` Rajat Jain
0 siblings, 2 replies; 16+ messages in thread
From: Rajat Jain @ 2014-02-14 19:39 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Izumi, Taku, Rajat Jain, linux-pci, yinghai, Guenter Roeck, Takashi Iwai
Hi Bjorn,
On Fri, Feb 14, 2014 at 9:31 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Fri, Feb 14, 2014 at 12:21 AM, Izumi, Taku <izumi.taku@jp.fujitsu.com> wrote:
>>> Hmm... I see that the Slot has a power controller. Which means that the power to the slot shall not be turned on automatically
>>> (by HW) when the card is plugged in. Also meaning that the link will not come up automatically - so this does not seem
>>> like the Link state based hotplug kicking in.
>>>
>>> What I suspect is this one:
>>>
>>> f02d1843d83b "PCI: pciehp: Remove surprise bit checks"
>>
>> You are right.
>> In case of omitting comit-f02d1843, it worked as expected.
>> Slot power doesn't become ON automatically when PCIe card is inserted.
>
> OK, I dropped f02d1843d83b ("PCI: pciehp: Remove surprise bit
> checks").
I think part of this commit was still good (The part that drops the
surprise check when a card is yanked out). That is because when a card
is yanked out, it shouldn't matter whether the surprise bit is set or
not - its gotta go.
Functionally, that scenario is already covered by my patches (because
yanking out a card will make the link go down, hence kicking off link
state based unplug) - thus no functional change. But just thought I'll
mention since you were already at this cleanup phase. (If you agree, I
can send a separate clean patch or you can use Takashi's one).
> Thanks for testing, everybody!
>
> I think our handling of slot capabilities and control is a bit
> haphazard. It seems like we're mostly responding to things that
> break, and we don't really have a coherent explanation of how things
> *should* work in different configurations. I think it would be good
> if somebody wrote up something for Documentation/PCI, with references
> to the relevant specifications, that describes how we think things
> should work.
Sure, I think I'll take a stab.
Thanks,
Rajat
> For example, I think we have at least four models:
>
> 1) ExpressCard
> 2) Slots with attention button
> 3) Slots with no button where we expect a software UI, e.g., Taku's box
> 4) Devices with no actual slot, no button, etc., e.g., Rajat's system
>
> We handle these slightly differently, implicitly relying on various
> capability tests scattered throughout the code. I think we should be
> able to come up with a scheme that would make this more explicit and
> make pciehp simpler and more consistent.
>
> Bjorn
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-14 19:39 ` Rajat Jain
@ 2014-02-18 23:02 ` Bjorn Helgaas
2014-02-19 2:54 ` Rajat Jain
2014-02-25 3:02 ` Rajat Jain
1 sibling, 1 reply; 16+ messages in thread
From: Bjorn Helgaas @ 2014-02-18 23:02 UTC (permalink / raw)
To: Rajat Jain
Cc: Izumi, Taku, Rajat Jain, linux-pci, yinghai, Guenter Roeck, Takashi Iwai
On Fri, Feb 14, 2014 at 12:39 PM, Rajat Jain <rajatxjain@gmail.com> wrote:
> Hi Bjorn,
>
> On Fri, Feb 14, 2014 at 9:31 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> On Fri, Feb 14, 2014 at 12:21 AM, Izumi, Taku <izumi.taku@jp.fujitsu.com> wrote:
>>>> Hmm... I see that the Slot has a power controller. Which means that the power to the slot shall not be turned on automatically
>>>> (by HW) when the card is plugged in. Also meaning that the link will not come up automatically - so this does not seem
>>>> like the Link state based hotplug kicking in.
>>>>
>>>> What I suspect is this one:
>>>>
>>>> f02d1843d83b "PCI: pciehp: Remove surprise bit checks"
>>>
>>> You are right.
>>> In case of omitting comit-f02d1843, it worked as expected.
>>> Slot power doesn't become ON automatically when PCIe card is inserted.
>>
>> OK, I dropped f02d1843d83b ("PCI: pciehp: Remove surprise bit
>> checks").
>
> I think part of this commit was still good (The part that drops the
> surprise check when a card is yanked out). That is because when a card
> is yanked out, it shouldn't matter whether the surprise bit is set or
> not - its gotta go.
>
> Functionally, that scenario is already covered by my patches (because
> yanking out a card will make the link go down, hence kicking off link
> state based unplug) - thus no functional change. But just thought I'll
> mention since you were already at this cleanup phase. (If you agree, I
> can send a separate clean patch or you can use Takashi's one).
That sounds reasonable. Send me a patch, if you don't mind, so it's
clear what to do here.
Bjorn
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-18 23:02 ` Bjorn Helgaas
@ 2014-02-19 2:54 ` Rajat Jain
0 siblings, 0 replies; 16+ messages in thread
From: Rajat Jain @ 2014-02-19 2:54 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Izumi, Taku, Rajat Jain, linux-pci, yinghai, Guenter Roeck, Takashi Iwai
On Tue, Feb 18, 2014 at 3:02 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Fri, Feb 14, 2014 at 12:39 PM, Rajat Jain <rajatxjain@gmail.com> wrote:
>> Hi Bjorn,
>>
>> On Fri, Feb 14, 2014 at 9:31 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>>> On Fri, Feb 14, 2014 at 12:21 AM, Izumi, Taku <izumi.taku@jp.fujitsu.com> wrote:
>>>>> Hmm... I see that the Slot has a power controller. Which means that the power to the slot shall not be turned on automatically
>>>>> (by HW) when the card is plugged in. Also meaning that the link will not come up automatically - so this does not seem
>>>>> like the Link state based hotplug kicking in.
>>>>>
>>>>> What I suspect is this one:
>>>>>
>>>>> f02d1843d83b "PCI: pciehp: Remove surprise bit checks"
>>>>
>>>> You are right.
>>>> In case of omitting comit-f02d1843, it worked as expected.
>>>> Slot power doesn't become ON automatically when PCIe card is inserted.
>>>
>>> OK, I dropped f02d1843d83b ("PCI: pciehp: Remove surprise bit
>>> checks").
>>
>> I think part of this commit was still good (The part that drops the
>> surprise check when a card is yanked out). That is because when a card
>> is yanked out, it shouldn't matter whether the surprise bit is set or
>> not - its gotta go.
>>
>> Functionally, that scenario is already covered by my patches (because
>> yanking out a card will make the link go down, hence kicking off link
>> state based unplug) - thus no functional change. But just thought I'll
>> mention since you were already at this cleanup phase. (If you agree, I
>> can send a separate clean patch or you can use Takashi's one).
>
> That sounds reasonable. Send me a patch, if you don't mind, so it's
> clear what to do here.
Just sent.
Thanks,
Rajat
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty
2014-02-14 19:39 ` Rajat Jain
2014-02-18 23:02 ` Bjorn Helgaas
@ 2014-02-25 3:02 ` Rajat Jain
1 sibling, 0 replies; 16+ messages in thread
From: Rajat Jain @ 2014-02-25 3:02 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Izumi, Taku, Rajat Jain, linux-pci, yinghai, Guenter Roeck, Takashi Iwai
Hello Bjorn,
>>
>> I think our handling of slot capabilities and control is a bit
>> haphazard. It seems like we're mostly responding to things that
>> break, and we don't really have a coherent explanation of how things
>> *should* work in different configurations. I think it would be good
>> if somebody wrote up something for Documentation/PCI, with references
>> to the relevant specifications, that describes how we think things
>> should work.
>
> Sure, I think I'll take a stab.
>
> Thanks,
>
> Rajat
>
>> For example, I think we have at least four models:
>>
>> 1) ExpressCard
>> 2) Slots with attention button
>> 3) Slots with no button where we expect a software UI, e.g., Taku's box
>> 4) Devices with no actual slot, no button, etc., e.g., Rajat's system
>>
I'm trying to come up with a write up for this. And am trying to
understand what differentiates (1) from others - from the view of use
case model of course. I briefly looked at the ExpressCard specs at
http://www.usb.org/developers/expresscard/EC_specifications/ExpressCard_2_0_FINAL.pdf
I understand that ExpressCard shall be an actual slot and of course
has a defined form factor etc, but, when I think of the _use case_
that the user is expected to follow, it shall be pretty much dependent
on the HP elements. For e.g, if there is attention button, it would
follow (2), but if link comes up automatically (no power controller
etc), then it would follow (4) etc.
Thus I think that the use cases (sequence to be followed for hotplug)
shall be more appropriately categorized based on what hot-plug
elements (button etc) are present in a system. Of course, we can give
examples ("ExpressCards are one example in this category and is
typically characterized by .. ") within those categories, while also
making references to the appropriate standards.
What do you think?
Thanks,
Rajat
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2014-02-25 3:02 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-03 7:07 [PATCH] PCI: pciehp: Fix the problem that the present bit is not cleared though slot is empty Taku Izumi
2014-02-12 0:49 ` Bjorn Helgaas
2014-02-12 8:00 ` Izumi, Taku
2014-02-12 16:56 ` Bjorn Helgaas
2014-02-12 18:11 ` Rajat Jain
2014-02-13 8:00 ` Izumi, Taku
2014-02-13 16:03 ` Rajat Jain
2014-02-13 16:37 ` Takashi Iwai
2014-02-13 17:56 ` Rajat Jain
2014-02-14 7:21 ` Izumi, Taku
2014-02-14 7:26 ` Rajat Jain
2014-02-14 17:31 ` Bjorn Helgaas
2014-02-14 19:39 ` Rajat Jain
2014-02-18 23:02 ` Bjorn Helgaas
2014-02-19 2:54 ` Rajat Jain
2014-02-25 3:02 ` Rajat Jain
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.