Coverity CIDs 1195199, 1195200: mei/pci-txe.c doesn't check pci_enable_msi() return value

* Coverity CIDs 1195199, 1195200: mei/pci-txe.c doesn't check pci_enable_msi() return value
@ 2014-04-03 16:28 Bjorn Helgaas
  0 siblings, 0 replies; only message in thread
From: Bjorn Helgaas @ 2014-04-03 16:28 UTC (permalink / raw)
  To: Tomas Winkler; +Cc: Alexander Gordeev, linux-pci

Coverity complains that mei_txe_probe() and mei_txe_pci_resume() call
pci_enable_msi() without checking the result.  They do check
indirectly, by testing pci_dev_msi_enabled(), but it would be nicer to
check the pci_enable_msi() result directly:

112        pci_enable_msi(pdev);
113
114        /* clear spurious interrupts */
115        mei_clear_interrupts(dev);
116
117        /* request and enable interrupt  */
118        if (pci_dev_msi_enabled(pdev))

These are CIDs 1195199 and 1195200.

Bjorn

^ permalink raw reply	[flat|nested] only message in thread