Re: [PATCH v3 01/15] xen: Relocate mem_access and mem_event into common.

[Tamas K Lengyel <tamas.lengyel@zentific.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2203 bytes --]

On Mon, Sep 1, 2014 at 5:06 PM, Jan Beulich <JBeulich@suse.com> wrote:

> >>> On 01.09.14 at 16:21, <tklengyel@sec.in.tum.de> wrote:
> > --- /dev/null
> > +++ b/xen/common/mem_access.c
> > @@ -0,0 +1,133 @@
> >
> +/******************************************************************************
> > + * mem_access.c
> > + *
> > + * Memory access support.
> > + *
> > + * Copyright (c) 2011 Virtuata, Inc.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> 02111-1307  USA
> > + */
> > +
> > +
> > +#include <xen/sched.h>
> > +#include <xen/guest_access.h>
> > +#include <xen/hypercall.h>
> > +#include <asm/p2m.h>
> > +#include <public/memory.h>
> > +#include <xen/mem_event.h>
> > +#include <xsm/xsm.h>
>
> I asked you on the previous round already to get this mixture of
> headers from various subdirectories cleaned up: Unless anything
> really can't be made built with properly grouped headers, please
> have all xen/, asm/, public/, xsm/, etc headers each grouped
> together.
>
> > +int prepare_ring_for_helper(
> > +    struct domain *d, unsigned long gmfn, struct page_info **_page,
> > +    void **_va)
> > +{
> > +    struct page_info *page;
> > +    p2m_type_t p2mt;
> > +    void *va;
> > +
> > +    page = get_page_from_gfn(d, gmfn, &p2mt, P2M_UNSHARE);
> > +
> > +#ifdef CONFIG_MEM_PAGING
>
> I can't spot where this and CONFIG_MEM_SHARING get defined in
> this patch.
>
> Jan


Right, they only get defined later in patch [13/15], I forgot to move them
up front.

Tamas

[-- Attachment #1.2: Type: text/html, Size: 3075 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel