r8169 Wake on Lan

r8169 Wake on Lan

[Pablo Cholaky]

Hi there:

I have a HP ENVY laptop with this RealTek, and my laptop don't have a
BIOS option to disable WOL. I'm currently using a script on start and
shutdown to disable WOL, but could you guys make a module param to
enable/disable WOL?

This freaking WOL eats a lot of battery on my laptop and my scripts
don't work when I'm using a hibernation or booting a Linux ISO per
example. I don't know really if many HP laptops have this RealTek, but
a lot of HP laptops have this annoying problem (just see on Google hp
WOL battery drain). Seems like HP is only giving a bios option to
enterprise, and for users let a OS dependent option (Windows will
disable on boot).


Thank you very much dudes ;)


-- 
Pablo Cholaky
Linux user and developer
Slash.cl Owner
Blablabla

Re: r8169 Wake on Lan

[Ben Hutchings]

On Tue, 2013-11-26 at 14:23 -0300, Pablo Cholaky wrote:
> Hi there:
> 
> I have a HP ENVY laptop with this RealTek, and my laptop don't have a
> BIOS option to disable WOL. I'm currently using a script on start and
> shutdown to disable WOL, but could you guys make a module param to
> enable/disable WOL?
[...]

Module parameters are a terrible configuration interface, particularly
for settings that really apply to individual devices.

Most distributions provide a way to run ethtool when configuring an
interface; see
<http://sources.debian.net/src/ethtool/1:3.11-1/debian/README.Debian>
and look for ETHTOOL_OPTS in
<https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Deployment_Guide/s1-networkscripts-interfaces.html>

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Re: r8169 Wake on Lan

[Francois Romieu]

Pablo Cholaky <mrwaltercool@gmail.com> :
[...]
> I have a HP ENVY laptop with this RealTek, and my laptop don't have a
> BIOS option to disable WOL. I'm currently using a script on start and
> shutdown to disable WOL, but could you guys make a module param to
> enable/disable WOL?

The kernel has to offer a standardized API. Module params are terrible
in this regard. Please forget it.

> This freaking WOL eats a lot of battery on my laptop and my scripts
> don't work when I'm using a hibernation or booting a Linux ISO per
> example.

(if a kernel change can propagate to your ISO, so can your wol
disabling scripts)

There may be something wrong wrt hibernation (real hibernation, not
runtime suspend, right ?) but I do not see how the current code could
change the WoL settings at suspend time for a downed interface.
Care to provide a short description for your hibernation use ?

The XID line included in dmesg output or plain dmesg itself will be
welcome to identify the r8169 chipset. It can make some difference in
the suspend / resume paths.

-- 
Ueimor

Re: r8169 Wake on Lan

[Pablo Cholaky]

Seems like ACPI is enabling by default WOL, I'm wrong? Or maybe a BIOS
setting, unconfigurable by user.

My dmesg of r8159

[    3.834430] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
[    3.836970] r8169 0000:02:00.0: irq 43 for MSI/MSI-X
[    3.837151] r8169 0000:02:00.0 eth0: RTL8168g/8111g at
0xffffc9000524a000, a4:5d:36:be:93:a3, XID 0c000800 IRQ 43
[    3.837154] r8169 0000:02:00.0 eth0: jumbo features [frames: 9200
bytes, tx checksumming: ko]
[   15.509384] r8169 0000:02:00.0 eth0: link down
[ 2212.203541] r8169 0000:02:00.0 eth0: link down
[33965.758196] r8169 0000:02:00.0: System wakeup enabled by ACPI
[33966.155166] r8169 0000:02:00.0: System wakeup disabled by ACPI
[33970.285568] r8169 0000:02:00.0 eth0: link down
[33991.837714] r8169 0000:02:00.0 eth0: link down
[65787.535308] r8169 0000:02:00.0 eth0: link down
[73646.418210] r8169 0000:02:00.0: System wakeup enabled by ACPI
[73646.818712] r8169 0000:02:00.0: System wakeup disabled by ACPI
[73650.971790] r8169 0000:02:00.0 eth0: link down
[81000.170579] r8169 0000:02:00.0 eth0: link down
[81777.521723] r8169 0000:02:00.0 eth0: link down
[98273.025146] r8169 0000:02:00.0 eth0: link down

If kernel parameters are ugly... a on-kernel option should be bad too?

On Tue, Nov 26, 2013 at 8:21 PM, Francois Romieu <romieu@fr.zoreil.com> wrote:
> Pablo Cholaky <mrwaltercool@gmail.com> :
> [...]
>> I have a HP ENVY laptop with this RealTek, and my laptop don't have a
>> BIOS option to disable WOL. I'm currently using a script on start and
>> shutdown to disable WOL, but could you guys make a module param to
>> enable/disable WOL?
>
> The kernel has to offer a standardized API. Module params are terrible
> in this regard. Please forget it.
>
>> This freaking WOL eats a lot of battery on my laptop and my scripts
>> don't work when I'm using a hibernation or booting a Linux ISO per
>> example.
>
> (if a kernel change can propagate to your ISO, so can your wol
> disabling scripts)
>
> There may be something wrong wrt hibernation (real hibernation, not
> runtime suspend, right ?) but I do not see how the current code could
> change the WoL settings at suspend time for a downed interface.
> Care to provide a short description for your hibernation use ?
>
> The XID line included in dmesg output or plain dmesg itself will be
> welcome to identify the r8169 chipset. It can make some difference in
> the suspend / resume paths.
>
> --
> Ueimor



-- 
Pablo Cholaky
Linux user and developer
Slash.cl Owner
Blablabla

Re: r8169 Wake on Lan

[Francois Romieu]

(please no top-posting)

Pablo Cholaky <mrwaltercool@gmail.com> :
[...]
> If kernel parameters are ugly... a on-kernel option should be bad too?

Yes.

You use runtime suspend, suspend to disk and your ethernet network device
is up, right ?

-- 
Ueimor

Re: r8169 Wake on Lan

[Pablo Cholaky]

That's the logic:

- If I turn off my PC with WOL disabled using ethtool, WOL will be
disabled (normal off, suspend to disk and suspend to RAM).

- If I turn on my PC,  WOL will always be turned on (including from
suspend to disk and suspend to RAM)

A problem with S states you think?

Re: r8169 Wake on Lan

[Pablo Cholaky]

Anupama Reddy <bn.anupama@gmail.com>
>use the ethtool to disable the WOL option

Yes, I'm doing that, but a init script will not solve suspend to disk
or RAM auto-WOL problems, I need to "remember" it, I'm doing that
right now, but I don't think it's the best solution. Do you know
another option?

Re: r8169 Wake on Lan

[Francois Romieu]

Pablo Cholaky <mrwaltercool@gmail.com> :
> That's the logic:
> 
> - If I turn off my PC with WOL disabled using ethtool, WOL will be
> disabled (normal off, suspend to disk and suspend to RAM).
> 
> - If I turn on my PC,  WOL will always be turned on (including from
> suspend to disk and suspend to RAM)

The driver suspend / resume handlers should thus save and restore the
WoL state. It isn't rocket science but I won't hack it past midnight.

Thanks.

-- 
Ueimor