* [Buildroot] [PATCH 1/1] ccache: expose control interface via 'make ccache-options'
@ 2012-06-18 3:50 Tzu-Jung Lee
2012-06-19 12:51 ` Tzu-Jung Lee
[not found] ` <CAEvN+1jCAvFYsOkbv4Rf4g7YqZJe4Ty9cwpFMiAUTTAvh7mvQg@mail.gmail.com>
0 siblings, 2 replies; 18+ messages in thread
From: Tzu-Jung Lee @ 2012-06-18 3:50 UTC (permalink / raw)
To: buildroot
usage:
# set cache limit size
make CCACHE_OPTIONS="--max-size=5G" ccache-options
# zero statistics counters
make CCACHE_OPTIONS="--zero-stats" ccache-options
Change-Id: I0162a2612a9aa4afd49f6d93c9c36dce3e0c8228
---
package/ccache/ccache.mk | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk
index d7106ee..d46fbb9 100644
--- a/package/ccache/ccache.mk
+++ b/package/ccache/ccache.mk
@@ -50,3 +50,7 @@ ccache-stats: host-ccache
$(Q)$(CCACHE) -s
endif
+ifeq ($(BR2_CCACHE),y)
+ccache-options: host-ccache
+ $(Q)$(CCACHE) $(CCACHE_OPTIONS)
+endif
--
1.7.8.6
^ permalink raw reply related [flat|nested] 18+ messages in thread* [Buildroot] [PATCH 1/1] ccache: expose control interface via 'make ccache-options' 2012-06-18 3:50 [Buildroot] [PATCH 1/1] ccache: expose control interface via 'make ccache-options' Tzu-Jung Lee @ 2012-06-19 12:51 ` Tzu-Jung Lee [not found] ` <CAEvN+1jCAvFYsOkbv4Rf4g7YqZJe4Ty9cwpFMiAUTTAvh7mvQg@mail.gmail.com> 1 sibling, 0 replies; 18+ messages in thread From: Tzu-Jung Lee @ 2012-06-19 12:51 UTC (permalink / raw) To: buildroot On Mon, Jun 18, 2012 at 11:50 AM, Tzu-Jung Lee <roylee17@gmail.com> wrote: > usage: > ? ? ? ?# set cache limit size > ? ? ? ?make CCACHE_OPTIONS="--max-size=5G" ccache-options > > ? ? ? ?# zero statistics counters > ? ? ? ?make CCACHE_OPTIONS="--zero-stats" ccache-options > > Change-Id: I0162a2612a9aa4afd49f6d93c9c36dce3e0c8228 > --- > ?package/ccache/ccache.mk | ? ?4 ++++ > ?1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk > index d7106ee..d46fbb9 100644 > --- a/package/ccache/ccache.mk > +++ b/package/ccache/ccache.mk > @@ -50,3 +50,7 @@ ccache-stats: host-ccache > ? ? ? ?$(Q)$(CCACHE) -s > ?endif > > +ifeq ($(BR2_CCACHE),y) > +ccache-options: host-ccache > + ? ? ? $(Q)$(CCACHE) $(CCACHE_OPTIONS) > +endif > -- > 1.7.8.6 > Hi Guys, Any comment on this? Regards, Roy ^ permalink raw reply [flat|nested] 18+ messages in thread
[parent not found: <CAEvN+1jCAvFYsOkbv4Rf4g7YqZJe4Ty9cwpFMiAUTTAvh7mvQg@mail.gmail.com>]
* [Buildroot] [PATCH 1/1] ccache: expose control interface via 'make ccache-options' [not found] ` <CAEvN+1jCAvFYsOkbv4Rf4g7YqZJe4Ty9cwpFMiAUTTAvh7mvQg@mail.gmail.com> @ 2013-10-07 22:09 ` Tzu-Jung Lee 2013-10-08 6:46 ` Arnout Vandecappelle 2013-10-08 7:11 ` [Buildroot] [PATCH 1/1] " Thomas Petazzoni 0 siblings, 2 replies; 18+ messages in thread From: Tzu-Jung Lee @ 2013-10-07 22:09 UTC (permalink / raw) To: buildroot # Response to patchwork cleanup of week #1 This patch provides an easy way to operate on buildroot ccache such as changing the cache limit or showing statistics. Without it, users would have to explicitly specify both the environment variable and the path of patched ccache, for example: BUILDROOT_CACHE_DIR=~/.buildroot-ccache/ $PWD/host/usr/bin/ccache -s . Thanks. Roy On Fri, Jun 22, 2012 at 7:55 PM, Tzu-Jung Lee <roylee17@gmail.com> wrote: > ---------- Forwarded message ---------- > From: Tzu-Jung Lee <roylee17@gmail.com> > Date: Mon, Jun 18, 2012 at 11:50 AM > Subject: [PATCH 1/1] ccache: expose control interface via 'make ccache-options' > To: buildroot at busybox.net > Cc: roylee17 at gmail.com, Tzu-Jung Lee <tjlee@ambarella.com> > > > usage: > # set cache limit size > make CCACHE_OPTIONS="--max-size=5G" ccache-options > > # zero statistics counters > make CCACHE_OPTIONS="--zero-stats" ccache-options > > Change-Id: I0162a2612a9aa4afd49f6d93c9c36dce3e0c8228 > --- > package/ccache/ccache.mk | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk > index d7106ee..d46fbb9 100644 > --- a/package/ccache/ccache.mk > +++ b/package/ccache/ccache.mk > @@ -50,3 +50,7 @@ ccache-stats: host-ccache > $(Q)$(CCACHE) -s > endif > > +ifeq ($(BR2_CCACHE),y) > +ccache-options: host-ccache > + $(Q)$(CCACHE) $(CCACHE_OPTIONS) > +endif > -- > 1.7.8.6 ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH 1/1] ccache: expose control interface via 'make ccache-options' 2013-10-07 22:09 ` Tzu-Jung Lee @ 2013-10-08 6:46 ` Arnout Vandecappelle 2013-10-08 21:31 ` [Buildroot] [PATCH v2] " Tzu-Jung Lee 2013-10-09 17:18 ` [Buildroot] [PATCH v3] " Tzu-Jung Lee 2013-10-08 7:11 ` [Buildroot] [PATCH 1/1] " Thomas Petazzoni 1 sibling, 2 replies; 18+ messages in thread From: Arnout Vandecappelle @ 2013-10-08 6:46 UTC (permalink / raw) To: buildroot On 10/08/13 00:09, Tzu-Jung Lee wrote: > # Response to patchwork cleanup of week #1 > > This patch provides an easy way to operate on buildroot ccache such as > changing the cache limit or showing statistics. > > Without it, users would have to explicitly specify both the environment variable > and the path of patched ccache, for example: > > BUILDROOT_CACHE_DIR=~/.buildroot-ccache/ $PWD/host/usr/bin/ccache -s > . > Thanks. > > Roy > > On Fri, Jun 22, 2012 at 7:55 PM, Tzu-Jung Lee <roylee17@gmail.com> wrote: >> ---------- Forwarded message ---------- >> From: Tzu-Jung Lee <roylee17@gmail.com> >> Date: Mon, Jun 18, 2012 at 11:50 AM >> Subject: [PATCH 1/1] ccache: expose control interface via 'make ccache-options' >> To: buildroot at busybox.net >> Cc: roylee17 at gmail.com, Tzu-Jung Lee <tjlee@ambarella.com> >> >> >> usage: >> # set cache limit size >> make CCACHE_OPTIONS="--max-size=5G" ccache-options >> >> # zero statistics counters >> make CCACHE_OPTIONS="--zero-stats" ccache-options You should add this text to the documentation in docs/manual/ccache-support.txt >> >> Change-Id: I0162a2612a9aa4afd49f6d93c9c36dce3e0c8228 Missing Signed-off-by line. Otherwise looks good to me. Regards, Arnout >> --- >> package/ccache/ccache.mk | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk >> index d7106ee..d46fbb9 100644 >> --- a/package/ccache/ccache.mk >> +++ b/package/ccache/ccache.mk >> @@ -50,3 +50,7 @@ ccache-stats: host-ccache >> $(Q)$(CCACHE) -s >> endif >> >> +ifeq ($(BR2_CCACHE),y) >> +ccache-options: host-ccache >> + $(Q)$(CCACHE) $(CCACHE_OPTIONS) >> +endif >> -- >> 1.7.8.6 > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v2] ccache: expose control interface via 'make ccache-options' 2013-10-08 6:46 ` Arnout Vandecappelle @ 2013-10-08 21:31 ` Tzu-Jung Lee 2013-10-09 6:55 ` Thomas De Schampheleire 2013-10-09 17:18 ` [Buildroot] [PATCH v3] " Tzu-Jung Lee 1 sibling, 1 reply; 18+ messages in thread From: Tzu-Jung Lee @ 2013-10-08 21:31 UTC (permalink / raw) To: buildroot usage: # set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options # zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-options Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> --- Add descriptions in the manual docs/manual/ccache-support.txt | 11 +++++++++++ package/ccache/ccache.mk | 5 +++++ 2 files changed, 16 insertions(+) diff --git a/docs/manual/ccache-support.txt b/docs/manual/ccache-support.txt index 4969180..bdb0034 100644 --- a/docs/manual/ccache-support.txt +++ b/docs/manual/ccache-support.txt @@ -23,3 +23,14 @@ remove this directory. You can get statistics on the cache (its size, number of hits, misses, etc.) by running +make ccache-stats+. + +The make target +cache-options+ and the +CCACHE_OPTIONS+ variable +provide more generic access to the ccache. For example + +----------------- +# set cache limit size +make CCACHE_OPTIONS="--max-size=5G" ccache-options + +# zero statistics counters +make CCACHE_OPTIONS="--zero-stats" ccache-options +----------------- diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk index c5e9385..663a959 100644 --- a/package/ccache/ccache.mk +++ b/package/ccache/ccache.mk @@ -45,3 +45,8 @@ ifeq ($(BR2_CCACHE),y) ccache-stats: host-ccache $(Q)$(CCACHE) -s endif + +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v2] ccache: expose control interface via 'make ccache-options' 2013-10-08 21:31 ` [Buildroot] [PATCH v2] " Tzu-Jung Lee @ 2013-10-09 6:55 ` Thomas De Schampheleire 0 siblings, 0 replies; 18+ messages in thread From: Thomas De Schampheleire @ 2013-10-09 6:55 UTC (permalink / raw) To: buildroot Hi Tzu-Jung, On Tue, Oct 8, 2013 at 11:31 PM, Tzu-Jung Lee <roylee17@gmail.com> wrote: > usage: > # set cache limit size > make CCACHE_OPTIONS="--max-size=5G" ccache-options > > # zero statistics counters > make CCACHE_OPTIONS="--zero-stats" ccache-options > > Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> > --- > Add descriptions in the manual > > docs/manual/ccache-support.txt | 11 +++++++++++ > package/ccache/ccache.mk | 5 +++++ > 2 files changed, 16 insertions(+) > > diff --git a/docs/manual/ccache-support.txt b/docs/manual/ccache-support.txt > index 4969180..bdb0034 100644 > --- a/docs/manual/ccache-support.txt > +++ b/docs/manual/ccache-support.txt > @@ -23,3 +23,14 @@ remove this directory. > > You can get statistics on the cache (its size, number of hits, > misses, etc.) by running +make ccache-stats+. > + > +The make target +cache-options+ and the +CCACHE_OPTIONS+ variable this should be ccache-options > +provide more generic access to the ccache. For example > + > +----------------- > +# set cache limit size > +make CCACHE_OPTIONS="--max-size=5G" ccache-options > + > +# zero statistics counters > +make CCACHE_OPTIONS="--zero-stats" ccache-options > +----------------- > diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk > index c5e9385..663a959 100644 > --- a/package/ccache/ccache.mk > +++ b/package/ccache/ccache.mk > @@ -45,3 +45,8 @@ ifeq ($(BR2_CCACHE),y) > ccache-stats: host-ccache > $(Q)$(CCACHE) -s > endif > + > +ifeq ($(BR2_CCACHE),y) > +ccache-options: host-ccache > + $(Q)$(CCACHE) $(CCACHE_OPTIONS) > +endif > -- Best regards, Thomas ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v3] ccache: expose control interface via 'make ccache-options' 2013-10-08 6:46 ` Arnout Vandecappelle 2013-10-08 21:31 ` [Buildroot] [PATCH v2] " Tzu-Jung Lee @ 2013-10-09 17:18 ` Tzu-Jung Lee 2013-10-10 7:12 ` Thomas Petazzoni 2013-10-10 7:59 ` Thomas De Schampheleire 1 sibling, 2 replies; 18+ messages in thread From: Tzu-Jung Lee @ 2013-10-09 17:18 UTC (permalink / raw) To: buildroot usage: # set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options # zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-options Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> --- Fix a typo of manual in v2 docs/manual/ccache-support.txt | 11 +++++++++++ package/ccache/ccache.mk | 5 +++++ 2 files changed, 16 insertions(+) diff --git a/docs/manual/ccache-support.txt b/docs/manual/ccache-support.txt index 4969180..fe06a01 100644 --- a/docs/manual/ccache-support.txt +++ b/docs/manual/ccache-support.txt @@ -23,3 +23,14 @@ remove this directory. You can get statistics on the cache (its size, number of hits, misses, etc.) by running +make ccache-stats+. + +The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable +provide more generic access to the ccache. For example + +----------------- +# set cache limit size +make CCACHE_OPTIONS="--max-size=5G" ccache-options + +# zero statistics counters +make CCACHE_OPTIONS="--zero-stats" ccache-options +----------------- diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk index c5e9385..663a959 100644 --- a/package/ccache/ccache.mk +++ b/package/ccache/ccache.mk @@ -45,3 +45,8 @@ ifeq ($(BR2_CCACHE),y) ccache-stats: host-ccache $(Q)$(CCACHE) -s endif + +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v3] ccache: expose control interface via 'make ccache-options' 2013-10-09 17:18 ` [Buildroot] [PATCH v3] " Tzu-Jung Lee @ 2013-10-10 7:12 ` Thomas Petazzoni 2013-10-10 7:59 ` Thomas De Schampheleire 1 sibling, 0 replies; 18+ messages in thread From: Thomas Petazzoni @ 2013-10-10 7:12 UTC (permalink / raw) To: buildroot Dear Tzu-Jung Lee, On Wed, 9 Oct 2013 10:18:19 -0700, Tzu-Jung Lee wrote: > usage: > # set cache limit size > make CCACHE_OPTIONS="--max-size=5G" ccache-options > > # zero statistics counters > make CCACHE_OPTIONS="--zero-stats" ccache-options > > Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> -- Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v3] ccache: expose control interface via 'make ccache-options' 2013-10-09 17:18 ` [Buildroot] [PATCH v3] " Tzu-Jung Lee 2013-10-10 7:12 ` Thomas Petazzoni @ 2013-10-10 7:59 ` Thomas De Schampheleire 2013-10-10 17:50 ` [Buildroot] [PATCH v4] " Tzu-Jung Lee 1 sibling, 1 reply; 18+ messages in thread From: Thomas De Schampheleire @ 2013-10-10 7:59 UTC (permalink / raw) To: buildroot Hi Tzu-Jung, On Wed, Oct 9, 2013 at 7:18 PM, Tzu-Jung Lee <roylee17@gmail.com> wrote: > usage: > # set cache limit size > make CCACHE_OPTIONS="--max-size=5G" ccache-options > > # zero statistics counters > make CCACHE_OPTIONS="--zero-stats" ccache-options > > Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> > --- > Fix a typo of manual in v2 > > docs/manual/ccache-support.txt | 11 +++++++++++ > package/ccache/ccache.mk | 5 +++++ > 2 files changed, 16 insertions(+) > > diff --git a/docs/manual/ccache-support.txt b/docs/manual/ccache-support.txt > index 4969180..fe06a01 100644 > --- a/docs/manual/ccache-support.txt > +++ b/docs/manual/ccache-support.txt > @@ -23,3 +23,14 @@ remove this directory. > > You can get statistics on the cache (its size, number of hits, > misses, etc.) by running +make ccache-stats+. > + > +The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable > +provide more generic access to the ccache. For example > + > +----------------- > +# set cache limit size > +make CCACHE_OPTIONS="--max-size=5G" ccache-options > + > +# zero statistics counters > +make CCACHE_OPTIONS="--zero-stats" ccache-options > +----------------- > diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk > index c5e9385..663a959 100644 > --- a/package/ccache/ccache.mk > +++ b/package/ccache/ccache.mk > @@ -45,3 +45,8 @@ ifeq ($(BR2_CCACHE),y) > ccache-stats: host-ccache > $(Q)$(CCACHE) -s > endif > + > +ifeq ($(BR2_CCACHE),y) > +ccache-options: host-ccache > + $(Q)$(CCACHE) $(CCACHE_OPTIONS) > +endif I think this 'ifeq' block can be merged with the previous one containing ccache-stats. Also, while testing I noticed the following: if you do not specify CCACHE_OPTIONS, ccache gives its help message, but it is unclear to the user that he should put those options in CCACHE_OPTIONS. Assume someone knows there is a make target ccache-options but did not read the manual. Therefore, I would suggest to add a check inside the ccache-options recipe for a non-empty CCACHE_OPTIONS and give a warning message. Something like: diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk --- a/package/ccache/ccache.mk +++ b/package/ccache/ccache.mk @@ -48,5 +48,11 @@ endif ifeq ($(BR2_CCACHE),y) ccache-options: host-ccache +ifeq ($(CCACHE_OPTIONS),) + $(Q)echo "Usage: make ccache-options CCACHE_OPTIONS=\"opts\"" + $(Q)echo "where 'opts' corresponds to one or more valid ccache options" \ + "(see ccache help text below)" + $(Q)echo +endif $(Q)$(CCACHE) $(CCACHE_OPTIONS) endif This makes the output: $ make ccache-options Usage: make ccache-options CCACHE_OPTIONS="opts" where 'opts' corresponds to one or more valid ccache options (see ccache help text below) Usage: ccache [options] ccache compiler [compiler options] compiler [compiler options] (via symbolic link) Options: -c, --cleanup delete old files and recalculate size counters (normally not needed as this is done automatically) -C, --clear clear the cache completely -F, --max-files=N set maximum number of files in cache to N (use 0 for no limit) -M, --max-size=SIZE set maximum size of cache to SIZE (use 0 for no limit; available suffixes: G, M and K; default suffix: G) -s, --show-stats show statistics summary -z, --zero-stats zero statistics counters -h, --help print this help text -V, --version print version and copyright information See also <http://ccache.samba.org>. make: *** [ccache-options] Error 1 Best regards, Thomas ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v4] ccache: expose control interface via 'make ccache-options' 2013-10-10 7:59 ` Thomas De Schampheleire @ 2013-10-10 17:50 ` Tzu-Jung Lee 2013-10-10 19:45 ` Thomas De Schampheleire 2013-10-27 9:34 ` Peter Korsgaard 0 siblings, 2 replies; 18+ messages in thread From: Tzu-Jung Lee @ 2013-10-10 17:50 UTC (permalink / raw) To: buildroot usage: # set cache limit size make CCACHE_OPTIONS="--max-size=5G" ccache-options # zero statistics counters make CCACHE_OPTIONS="--zero-stats" ccache-options Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> --- Include the useful warning message suggested by Thomas. We might need a separate patch to obsolete the ccache-stats later. docs/manual/ccache-support.txt | 11 +++++++++++ package/ccache/ccache.mk | 11 +++++++++++ 2 files changed, 22 insertions(+) diff --git a/docs/manual/ccache-support.txt b/docs/manual/ccache-support.txt index 4969180..fe06a01 100644 --- a/docs/manual/ccache-support.txt +++ b/docs/manual/ccache-support.txt @@ -23,3 +23,14 @@ remove this directory. You can get statistics on the cache (its size, number of hits, misses, etc.) by running +make ccache-stats+. + +The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable +provide more generic access to the ccache. For example + +----------------- +# set cache limit size +make CCACHE_OPTIONS="--max-size=5G" ccache-options + +# zero statistics counters +make CCACHE_OPTIONS="--zero-stats" ccache-options +----------------- diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk index c5e9385..7b6155d 100644 --- a/package/ccache/ccache.mk +++ b/package/ccache/ccache.mk @@ -45,3 +45,14 @@ ifeq ($(BR2_CCACHE),y) ccache-stats: host-ccache $(Q)$(CCACHE) -s endif + +ifeq ($(BR2_CCACHE),y) +ccache-options: host-ccache +ifeq ($(CCACHE_OPTIONS),) + $(Q)echo "Usage: make ccache-options CCACHE_OPTIONS=\"opts\"" + $(Q)echo "where 'opts' corresponds to one or more valid ccache options" \ + "(see ccache help text below)" + $(Q)echo +endif + $(Q)$(CCACHE) $(CCACHE_OPTIONS) +endif -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v4] ccache: expose control interface via 'make ccache-options' 2013-10-10 17:50 ` [Buildroot] [PATCH v4] " Tzu-Jung Lee @ 2013-10-10 19:45 ` Thomas De Schampheleire 2013-10-10 19:51 ` Tzu-Jung Lee 2013-10-27 9:34 ` Peter Korsgaard 1 sibling, 1 reply; 18+ messages in thread From: Thomas De Schampheleire @ 2013-10-10 19:45 UTC (permalink / raw) To: buildroot Hi Tzu-Jung, Tzu-Jung Lee <roylee17@gmail.com> wrote: >usage: > # set cache limit size > make CCACHE_OPTIONS="--max-size=5G" ccache-options > > # zero statistics counters > make CCACHE_OPTIONS="--zero-stats" ccache-options > >Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> >--- >Include the useful warning message suggested by Thomas. > >We might need a separate patch to obsolete the ccache-stats later. > > docs/manual/ccache-support.txt | 11 +++++++++++ > package/ccache/ccache.mk | 11 +++++++++++ > 2 files changed, 22 insertions(+) > >diff --git a/docs/manual/ccache-support.txt b/docs/manual/ccache-support.txt >index 4969180..fe06a01 100644 >--- a/docs/manual/ccache-support.txt >+++ b/docs/manual/ccache-support.txt >@@ -23,3 +23,14 @@ remove this directory. > > You can get statistics on the cache (its size, number of hits, > misses, etc.) by running +make ccache-stats+. >+ >+The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable >+provide more generic access to the ccache. For example >+ >+----------------- >+# set cache limit size >+make CCACHE_OPTIONS="--max-size=5G" ccache-options >+ >+# zero statistics counters >+make CCACHE_OPTIONS="--zero-stats" ccache-options >+----------------- >diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk >index c5e9385..7b6155d 100644 >--- a/package/ccache/ccache.mk >+++ b/package/ccache/ccache.mk >@@ -45,3 +45,14 @@ ifeq ($(BR2_CCACHE),y) > ccache-stats: host-ccache > $(Q)$(CCACHE) -s > endif >+ >+ifeq ($(BR2_CCACHE),y) >+ccache-options: host-ccache >+ifeq ($(CCACHE_OPTIONS),) >+ $(Q)echo "Usage: make ccache-options CCACHE_OPTIONS=\"opts\"" >+ $(Q)echo "where 'opts' corresponds to one or more valid ccache options" \ >+ "(see ccache help text below)" >+ $(Q)echo >+endif >+ $(Q)$(CCACHE) $(CCACHE_OPTIONS) >+endif Did you see my other comment about combining the ifeq statements of ccache-stats and ccache-options? Best regards, Thomas ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v4] ccache: expose control interface via 'make ccache-options' 2013-10-10 19:45 ` Thomas De Schampheleire @ 2013-10-10 19:51 ` Tzu-Jung Lee 2013-10-10 20:57 ` Thomas Petazzoni 0 siblings, 1 reply; 18+ messages in thread From: Tzu-Jung Lee @ 2013-10-10 19:51 UTC (permalink / raw) To: buildroot Hi Thomas, On Thu, Oct 10, 2013 at 12:45 PM, Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote: > Hi Tzu-Jung, > > Tzu-Jung Lee <roylee17@gmail.com> wrote: >>usage: >> # set cache limit size >> make CCACHE_OPTIONS="--max-size=5G" ccache-options >> >> # zero statistics counters >> make CCACHE_OPTIONS="--zero-stats" ccache-options >> >>Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> >>--- >>Include the useful warning message suggested by Thomas. >> >>We might need a separate patch to obsolete the ccache-stats later. >> >> docs/manual/ccache-support.txt | 11 +++++++++++ >> package/ccache/ccache.mk | 11 +++++++++++ >> 2 files changed, 22 insertions(+) >> >>diff --git a/docs/manual/ccache-support.txt b/docs/manual/ccache-support.txt >>index 4969180..fe06a01 100644 >>--- a/docs/manual/ccache-support.txt >>+++ b/docs/manual/ccache-support.txt >>@@ -23,3 +23,14 @@ remove this directory. >> >> You can get statistics on the cache (its size, number of hits, >> misses, etc.) by running +make ccache-stats+. >>+ >>+The make target +ccache-options+ and the +CCACHE_OPTIONS+ variable >>+provide more generic access to the ccache. For example >>+ >>+----------------- >>+# set cache limit size >>+make CCACHE_OPTIONS="--max-size=5G" ccache-options >>+ >>+# zero statistics counters >>+make CCACHE_OPTIONS="--zero-stats" ccache-options >>+----------------- >>diff --git a/package/ccache/ccache.mk b/package/ccache/ccache.mk >>index c5e9385..7b6155d 100644 >>--- a/package/ccache/ccache.mk >>+++ b/package/ccache/ccache.mk >>@@ -45,3 +45,14 @@ ifeq ($(BR2_CCACHE),y) >> ccache-stats: host-ccache >> $(Q)$(CCACHE) -s >> endif >>+ >>+ifeq ($(BR2_CCACHE),y) >>+ccache-options: host-ccache >>+ifeq ($(CCACHE_OPTIONS),) >>+ $(Q)echo "Usage: make ccache-options CCACHE_OPTIONS=\"opts\"" >>+ $(Q)echo "where 'opts' corresponds to one or more valid ccache options" \ >>+ "(see ccache help text below)" >>+ $(Q)echo >>+endif >>+ $(Q)$(CCACHE) $(CCACHE_OPTIONS) >>+endif > > Did you see my other comment about combining the ifeq statements of ccache-stats and ccache-options? Yes, but I think it probably would be better as a separate patch, which: 1. either remove the ccache-stats code & and manual section 2. or issue warning about the obsolete usage. So this patch alone don't affect those are currently using ccache-stats before they migrate to ccache-options. thanks. Roy ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v4] ccache: expose control interface via 'make ccache-options' 2013-10-10 19:51 ` Tzu-Jung Lee @ 2013-10-10 20:57 ` Thomas Petazzoni 2013-10-10 21:01 ` Tzu-Jung Lee 0 siblings, 1 reply; 18+ messages in thread From: Thomas Petazzoni @ 2013-10-10 20:57 UTC (permalink / raw) To: buildroot Dear Tzu-Jung Lee, On Thu, 10 Oct 2013 12:51:27 -0700, Tzu-Jung Lee wrote: > > Did you see my other comment about combining the ifeq statements of > > ccache-stats and ccache-options? > > Yes, but I think it probably would be better as a separate patch, > which: > > 1. either remove the ccache-stats code & and manual section > 2. or issue warning about the obsolete usage. > > So this patch alone don't affect those are currently using > ccache-stats before they migrate to ccache-options. I believe there might be a misunderstanding here. You seem to think Thomas suggested to remove ccache-stats because ccache-options now allows to do the same. But in fact, Thomas only suggested to change: """ ifeq ($(BR2_CCACHE),y) ccache-stats: ... endif ifeq ($(BR2_CCACHE),y) ccache-options: ... endif """ by """ ifeq ($(BR2_CCACHE),y) ccache-stats: ... ccache-options: ... endif """ i.e, ccache-stats continues to exist, the only difference with your implementation is that it sits under the same ifeq ($(BR2_CCACHE),y) condition. It's just a minor nit. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v4] ccache: expose control interface via 'make ccache-options' 2013-10-10 20:57 ` Thomas Petazzoni @ 2013-10-10 21:01 ` Tzu-Jung Lee 2013-10-10 21:05 ` Thomas Petazzoni 0 siblings, 1 reply; 18+ messages in thread From: Tzu-Jung Lee @ 2013-10-10 21:01 UTC (permalink / raw) To: buildroot On Thu, Oct 10, 2013 at 1:57 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Tzu-Jung Lee, > > On Thu, 10 Oct 2013 12:51:27 -0700, Tzu-Jung Lee wrote: >> > Did you see my other comment about combining the ifeq statements of >> > ccache-stats and ccache-options? >> >> Yes, but I think it probably would be better as a separate patch, >> which: >> >> 1. either remove the ccache-stats code & and manual section >> 2. or issue warning about the obsolete usage. >> >> So this patch alone don't affect those are currently using >> ccache-stats before they migrate to ccache-options. > > I believe there might be a misunderstanding here. You seem to think > Thomas suggested to remove ccache-stats because ccache-options now > allows to do the same. > > But in fact, Thomas only suggested to change: > > """ > ifeq ($(BR2_CCACHE),y) > ccache-stats: > ... > endif > > ifeq ($(BR2_CCACHE),y) > ccache-options: > ... > endif > """ > > by > > """ > ifeq ($(BR2_CCACHE),y) > ccache-stats: > ... > > ccache-options: > ... > endif > """ > > i.e, ccache-stats continues to exist, the only difference with your > implementation is that it sits under the same ifeq ($(BR2_CCACHE),y) > condition. It's just a minor nit. Oops, my bad. Could you help do the inline editing when you merge it? thanks. Roy > > Best regards, > > Thomas > -- > Thomas Petazzoni, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v4] ccache: expose control interface via 'make ccache-options' 2013-10-10 21:01 ` Tzu-Jung Lee @ 2013-10-10 21:05 ` Thomas Petazzoni 2013-10-11 4:52 ` Thomas De Schampheleire 0 siblings, 1 reply; 18+ messages in thread From: Thomas Petazzoni @ 2013-10-10 21:05 UTC (permalink / raw) To: buildroot Dear Tzu-Jung Lee, On Thu, 10 Oct 2013 14:01:40 -0700, Tzu-Jung Lee wrote: > > i.e, ccache-stats continues to exist, the only difference with your > > implementation is that it sits under the same ifeq ($(BR2_CCACHE),y) > > condition. It's just a minor nit. > > Oops, my bad. > Could you help do the inline editing when you merge it? I'm not the maintainer, so I can't merge patches. But most likely, Peter Korsgaard can do it when merging your patch. Thanks a lot for all your quick updates to this patch! Best regards, Thomas -- Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v4] ccache: expose control interface via 'make ccache-options' 2013-10-10 21:05 ` Thomas Petazzoni @ 2013-10-11 4:52 ` Thomas De Schampheleire 0 siblings, 0 replies; 18+ messages in thread From: Thomas De Schampheleire @ 2013-10-11 4:52 UTC (permalink / raw) To: buildroot Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: >Dear Tzu-Jung Lee, > >On Thu, 10 Oct 2013 14:01:40 -0700, Tzu-Jung Lee wrote: > >> > i.e, ccache-stats continues to exist, the only difference with your >> > implementation is that it sits under the same ifeq ($(BR2_CCACHE),y) >> > condition. It's just a minor nit. >> >> Oops, my bad. >> Could you help do the inline editing when you merge it? > >I'm not the maintainer, so I can't merge patches. But most likely, >Peter Korsgaard can do it when merging your patch. > >Thanks a lot for all your quick updates to this patch! Yes, I certainly agree with that! Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH v4] ccache: expose control interface via 'make ccache-options' 2013-10-10 17:50 ` [Buildroot] [PATCH v4] " Tzu-Jung Lee 2013-10-10 19:45 ` Thomas De Schampheleire @ 2013-10-27 9:34 ` Peter Korsgaard 1 sibling, 0 replies; 18+ messages in thread From: Peter Korsgaard @ 2013-10-27 9:34 UTC (permalink / raw) To: buildroot >>>>> "Tzu-Jung" == Tzu-Jung Lee <roylee17@gmail.com> writes: > usage: > # set cache limit size > make CCACHE_OPTIONS="--max-size=5G" ccache-options > # zero statistics counters > make CCACHE_OPTIONS="--zero-stats" ccache-options > Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> Committed with the redundant ifeq removed as pointed out by Thomas, thanks. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 18+ messages in thread
* [Buildroot] [PATCH 1/1] ccache: expose control interface via 'make ccache-options' 2013-10-07 22:09 ` Tzu-Jung Lee 2013-10-08 6:46 ` Arnout Vandecappelle @ 2013-10-08 7:11 ` Thomas Petazzoni 1 sibling, 0 replies; 18+ messages in thread From: Thomas Petazzoni @ 2013-10-08 7:11 UTC (permalink / raw) To: buildroot Dear Tzu-Jung Lee, On Mon, 7 Oct 2013 15:09:34 -0700, Tzu-Jung Lee wrote: > # Response to patchwork cleanup of week #1 > > This patch provides an easy way to operate on buildroot ccache such as > changing the cache limit or showing statistics. > > Without it, users would have to explicitly specify both the environment variable > and the path of patched ccache, for example: > > BUILDROOT_CACHE_DIR=~/.buildroot-ccache/ $PWD/host/usr/bin/ccache -s Well, in the case of just passing "-s", we already have the ccache-stats target. But I agree that for all other options, adding another ccache-<something> target would be impractical, so probably your proposal of CCACHE_OPTIONS makes sense. Can you respin your patch on top of the latest master, and add an update to the manual (we already have a section about ccache support, see http://buildroot.org/downloads/manual/manual.html#ccache). Thanks! Thomas -- Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2013-10-27 9:34 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-18 3:50 [Buildroot] [PATCH 1/1] ccache: expose control interface via 'make ccache-options' Tzu-Jung Lee
2012-06-19 12:51 ` Tzu-Jung Lee
[not found] ` <CAEvN+1jCAvFYsOkbv4Rf4g7YqZJe4Ty9cwpFMiAUTTAvh7mvQg@mail.gmail.com>
2013-10-07 22:09 ` Tzu-Jung Lee
2013-10-08 6:46 ` Arnout Vandecappelle
2013-10-08 21:31 ` [Buildroot] [PATCH v2] " Tzu-Jung Lee
2013-10-09 6:55 ` Thomas De Schampheleire
2013-10-09 17:18 ` [Buildroot] [PATCH v3] " Tzu-Jung Lee
2013-10-10 7:12 ` Thomas Petazzoni
2013-10-10 7:59 ` Thomas De Schampheleire
2013-10-10 17:50 ` [Buildroot] [PATCH v4] " Tzu-Jung Lee
2013-10-10 19:45 ` Thomas De Schampheleire
2013-10-10 19:51 ` Tzu-Jung Lee
2013-10-10 20:57 ` Thomas Petazzoni
2013-10-10 21:01 ` Tzu-Jung Lee
2013-10-10 21:05 ` Thomas Petazzoni
2013-10-11 4:52 ` Thomas De Schampheleire
2013-10-27 9:34 ` Peter Korsgaard
2013-10-08 7:11 ` [Buildroot] [PATCH 1/1] " Thomas Petazzoni
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.