* [PATCH] Make EEPROM a menuconfig to ease disabling it all
@ 2017-07-02 15:31 Vincent Legoll
2017-07-04 12:54 ` kbuild test robot
2017-07-04 13:00 ` Vincent Legoll
0 siblings, 2 replies; 3+ messages in thread
From: Vincent Legoll @ 2017-07-02 15:31 UTC (permalink / raw)
To: linux-kernel, gregkh, fancer.lancer; +Cc: Vincent Legoll
No need to get into the submenu to disable all EEPROM-related config entries
Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
drivers/misc/eeprom/Kconfig | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig
index de58762..0ea5290 100644
--- a/drivers/misc/eeprom/Kconfig
+++ b/drivers/misc/eeprom/Kconfig
@@ -1,8 +1,9 @@
-menu "EEPROM support"
+menuconfig EEPROM
+ tristate "EEPROM support"
config EEPROM_AT24
tristate "I2C EEPROMs / RAMs / ROMs from most vendors"
- depends on I2C && SYSFS
+ depends on EEPROM && I2C && SYSFS
select NVMEM
help
Enable this driver to get read/write support to most I2C EEPROMs
@@ -30,7 +31,7 @@ config EEPROM_AT24
config EEPROM_AT25
tristate "SPI EEPROMs from most vendors"
- depends on SPI && SYSFS
+ depends on EEPROM && SPI && SYSFS
select NVMEM
help
Enable this driver to get read/write support to most SPI EEPROMs,
@@ -42,7 +43,7 @@ config EEPROM_AT25
config EEPROM_LEGACY
tristate "Old I2C EEPROM reader"
- depends on I2C && SYSFS
+ depends on EEPROM && I2C && SYSFS
help
If you say yes here you get read-only access to the EEPROM data
available on modern memory DIMMs and Sony Vaio laptops via I2C. Such
@@ -53,7 +54,7 @@ config EEPROM_LEGACY
config EEPROM_MAX6875
tristate "Maxim MAX6874/5 power supply supervisor"
- depends on I2C
+ depends on EEPROM && I2C
help
If you say yes here you get read-only support for the user EEPROM of
the Maxim MAX6874/5 EEPROM-programmable, quad power-supply
@@ -67,6 +68,7 @@ config EEPROM_MAX6875
config EEPROM_93CX6
tristate "EEPROM 93CX6 support"
+ depends on EEPROM
help
This is a driver for the EEPROM chipsets 93c46 and 93c66.
The driver supports both read as well as write commands.
@@ -75,7 +77,7 @@ config EEPROM_93CX6
config EEPROM_93XX46
tristate "Microwire EEPROM 93XX46 support"
- depends on SPI && SYSFS
+ depends on EEPROM && SPI && SYSFS
select REGMAP
select NVMEM
help
@@ -90,7 +92,7 @@ config EEPROM_93XX46
config EEPROM_DIGSY_MTC_CFG
bool "DigsyMTC display configuration EEPROMs device"
- depends on GPIO_MPC5200 && SPI_GPIO
+ depends on EEPROM && GPIO_MPC5200 && SPI_GPIO
help
This option enables access to display configuration EEPROMs
on digsy_mtc board. You have to additionally select Microwire
@@ -102,12 +104,10 @@ config EEPROM_DIGSY_MTC_CFG
config EEPROM_IDT_89HPESX
tristate "IDT 89HPESx PCIe-swtiches EEPROM / CSR support"
- depends on I2C && SYSFS
+ depends on EEPROM && I2C && SYSFS
help
Enable this driver to get read/write access to EEPROM / CSRs
over IDT PCIe-swtich i2c-slave interface.
This driver can also be built as a module. If so, the module
will be called idt_89hpesx.
-
-endmenu
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Make EEPROM a menuconfig to ease disabling it all
2017-07-02 15:31 [PATCH] Make EEPROM a menuconfig to ease disabling it all Vincent Legoll
@ 2017-07-04 12:54 ` kbuild test robot
2017-07-04 13:00 ` Vincent Legoll
1 sibling, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2017-07-04 12:54 UTC (permalink / raw)
To: Vincent Legoll
Cc: kbuild-all, linux-kernel, gregkh, fancer.lancer, Vincent Legoll
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
Hi Vincent,
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on v4.12 next-20170704]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vincent-Legoll/Make-EEPROM-a-menuconfig-to-ease-disabling-it-all/20170704-182937
config: x86_64-allyesdebian (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
warning: (SCSI_WD719X && KS8851 && AX88796_93CX6 && ADM8211 && RT2400PCI && RT2500PCI && RT61PCI && RT2800PCI && RTL8180 && RTL8187) selects EEPROM_93CX6 which has unmet direct dependencies (EEPROM)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38806 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Make EEPROM a menuconfig to ease disabling it all
2017-07-02 15:31 [PATCH] Make EEPROM a menuconfig to ease disabling it all Vincent Legoll
2017-07-04 12:54 ` kbuild test robot
@ 2017-07-04 13:00 ` Vincent Legoll
1 sibling, 0 replies; 3+ messages in thread
From: Vincent Legoll @ 2017-07-04 13:00 UTC (permalink / raw)
To: Linux Kernel ML, Greg Kroah-Hartman, Fancer's opinion; +Cc: Vincent Legoll
Hello,
Please drop that patch, it will need to be fixed & tested more before resend
--
Vincent Legoll
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-04 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-02 15:31 [PATCH] Make EEPROM a menuconfig to ease disabling it all Vincent Legoll
2017-07-04 12:54 ` kbuild test robot
2017-07-04 13:00 ` Vincent Legoll
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.