* [Buildroot] [PATCH] package/sdl_mixer: fix build after aclocal include revamp
@ 2020-02-08 18:26 Yann E. MORIN
2020-02-08 19:03 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2020-02-08 18:26 UTC (permalink / raw)
To: buildroot
After d255b67972 (autotools: do not overwrite first include path), the
ordering of include paths has changed: the system directories are
specified with explicit options passed to autoreconf, which means that
any directory specified in the package _AUTORECONF_OPTS are no longer
first:
- in package/autoconf/autoconf.mk, we define AUTORECONF as:
AUTOCONF = $(HOST_DIR)/bin/autoconf -I "$(ACLOCAL_DIR)" -I "$(ACLOCAL_HOST_DIR)"
- in package/pkg-autotools.mk, we call AUTORECONF with:
$($(PKG)_AUTORECONF_ENV) $(AUTORECONF) $($(PKG)_AUTORECONF_OPTS)
So, the include directory specified by SDL_MIXER_AUTORECONF_OPTS is now
lagging behind the system headers, and the very issue that d255b67972
was suposed to fix in a generic way, pops up back for this specific
case.
We fix that by patching sdl_mixer so that it uses the bog-down standard
mechanisms, to specify the macro directory from within configure.in,
instead of specifying it on the command line, so that the magic
introduced by d255b67972 does happen.
Reported-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Michael Walle <michael@walle.cc>
---
.../0004-configure__set_macro_directory.patch | 34 +++++++++++++++++++
package/sdl_mixer/sdl_mixer.mk | 1 -
2 files changed, 34 insertions(+), 1 deletion(-)
create mode 100644 package/sdl_mixer/0004-configure__set_macro_directory.patch
diff --git a/package/sdl_mixer/0004-configure__set_macro_directory.patch b/package/sdl_mixer/0004-configure__set_macro_directory.patch
new file mode 100644
index 0000000000..32089efe8f
--- /dev/null
+++ b/package/sdl_mixer/0004-configure__set_macro_directory.patch
@@ -0,0 +1,34 @@
+# HG changeset patch
+# User "Yann E. MORIN" <yann.morin.1998@free.fr>
+# Date 1581183281 -3600
+# Sat Feb 08 18:34:41 2020 +0100
+# Node ID 753a1f394620056c35790a571ff5f7c248445943
+# Parent eb5f08bf9994bf5164ca68015f2e030c2c9dddcd
+configure: set macro directory
+
+Setting the macro directory in configure.in, rather than sepcifying it
+on the command line, ensures that it is properly searched in the correct
+order, and that autoreconf properly updates our macros with the newer
+system ones, if any.
+
+Fixes:
+ http://autobuild.buildroot.org/results/63a/63ae0bddb3c4436efe967c318e299047f496c5a5/build-end.log
+
+ libtool: Version mismatch error. This is libtool 2.4.6, but the
+ libtool: definition of this LT_INIT comes from libtool 2.2.6.
+ libtool: You should recreate aclocal.m4 with macros from libtool 2.4.6
+ libtool: and run autoconf again.
+
+Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
+
+diff --git a/configure.in b/configure.in
+--- a/configure.in
++++ b/configure.in
+@@ -1,6 +1,7 @@
+ dnl Process this file with autoconf to produce a configure script.
+ AC_INIT(README)
+ AC_CONFIG_AUX_DIR(build-scripts)
++AC_CONFIG_MACRO_DIR([acinclude])
+
+ dnl Set various version strings - taken gratefully from the GTk sources
+
diff --git a/package/sdl_mixer/sdl_mixer.mk b/package/sdl_mixer/sdl_mixer.mk
index ab6f7ef014..73eb821ff3 100644
--- a/package/sdl_mixer/sdl_mixer.mk
+++ b/package/sdl_mixer/sdl_mixer.mk
@@ -18,7 +18,6 @@ SDL_MIXER_DEPENDENCIES = sdl
# We're patching configure.in, so we need to autoreconf
SDL_MIXER_AUTORECONF = YES
-SDL_MIXER_AUTORECONF_OPTS = -Iacinclude
SDL_MIXER_CONF_OPTS = \
--without-x \
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/sdl_mixer: fix build after aclocal include revamp
2020-02-08 18:26 [Buildroot] [PATCH] package/sdl_mixer: fix build after aclocal include revamp Yann E. MORIN
@ 2020-02-08 19:03 ` Peter Korsgaard
2020-02-09 14:08 ` Yann E. MORIN
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2020-02-08 19:03 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> After d255b67972 (autotools: do not overwrite first include path), the
> ordering of include paths has changed: the system directories are
> specified with explicit options passed to autoreconf, which means that
> any directory specified in the package _AUTORECONF_OPTS are no longer
> first:
> - in package/autoconf/autoconf.mk, we define AUTORECONF as:
> AUTOCONF = $(HOST_DIR)/bin/autoconf -I "$(ACLOCAL_DIR)" -I "$(ACLOCAL_HOST_DIR)"
> - in package/pkg-autotools.mk, we call AUTORECONF with:
> $($(PKG)_AUTORECONF_ENV) $(AUTORECONF) $($(PKG)_AUTORECONF_OPTS)
> So, the include directory specified by SDL_MIXER_AUTORECONF_OPTS is now
> lagging behind the system headers, and the very issue that d255b67972
> was suposed to fix in a generic way, pops up back for this specific
> case.
> We fix that by patching sdl_mixer so that it uses the bog-down standard
> mechanisms, to specify the macro directory from within configure.in,
> instead of specifying it on the command line, so that the magic
> introduced by d255b67972 does happen.
> Reported-by: Peter Korsgaard <peter@korsgaard.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Michael Walle <michael@walle.cc>
> ---
> .../0004-configure__set_macro_directory.patch | 34 +++++++++++++++++++
> package/sdl_mixer/sdl_mixer.mk | 1 -
> 2 files changed, 34 insertions(+), 1 deletion(-)
> create mode 100644 package/sdl_mixer/0004-configure__set_macro_directory.patch
> diff --git a/package/sdl_mixer/0004-configure__set_macro_directory.patch b/package/sdl_mixer/0004-configure__set_macro_directory.patch
> new file mode 100644
> index 0000000000..32089efe8f
> --- /dev/null
> +++ b/package/sdl_mixer/0004-configure__set_macro_directory.patch
> @@ -0,0 +1,34 @@
> +# HG changeset patch
> +# User "Yann E. MORIN" <yann.morin.1998@free.fr>
> +# Date 1581183281 -3600
> +# Sat Feb 08 18:34:41 2020 +0100
> +# Node ID 753a1f394620056c35790a571ff5f7c248445943
> +# Parent eb5f08bf9994bf5164ca68015f2e030c2c9dddcd
> +configure: set macro directory
> +
> +Setting the macro directory in configure.in, rather than sepcifying it
specifying
Committed, thanks.
Most likely we also need to fix a number of other packages:
git grep '_AUTORECONF_OPTS ='
package/asterisk/asterisk.mk:ASTERISK_AUTORECONF_OPTS = -Iautoconf -Ithird-party -Ithird-party/pjproject -Ithird-party/jansson
package/gstreamer/gst-plugin-x170/gst-plugin-x170.mk:GST_PLUGIN_X170_AUTORECONF_OPTS = -Im4/
package/log4cpp/log4cpp.mk:LOG4CPP_AUTORECONF_OPTS = -I m4
package/sdbusplus/sdbusplus.mk:SDBUSPLUS_AUTORECONF_OPTS = --include=$(HOST_DIR)/share/autoconf-archive
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/sdl_mixer: fix build after aclocal include revamp
2020-02-08 19:03 ` Peter Korsgaard
@ 2020-02-09 14:08 ` Yann E. MORIN
2020-02-09 14:41 ` Heiko Thiery
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2020-02-09 14:08 UTC (permalink / raw)
To: buildroot
On 2020-02-08 20:03 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> > After d255b67972 (autotools: do not overwrite first include path), the
> > ordering of include paths has changed: the system directories are
> > specified with explicit options passed to autoreconf, which means that
> > any directory specified in the package _AUTORECONF_OPTS are no longer
> > first:
> Most likely we also need to fix a number of other packages:
> git grep '_AUTORECONF_OPTS ='
> package/asterisk/asterisk.mk:ASTERISK_AUTORECONF_OPTS = -Iautoconf -Ithird-party -Ithird-party/pjproject -Ithird-party/jansson
> package/gstreamer/gst-plugin-x170/gst-plugin-x170.mk:GST_PLUGIN_X170_AUTORECONF_OPTS = -Im4/
> package/log4cpp/log4cpp.mk:LOG4CPP_AUTORECONF_OPTS = -I m4
> package/sdbusplus/sdbusplus.mk:SDBUSPLUS_AUTORECONF_OPTS = --include=$(HOST_DIR)/share/autoconf-archive
gst-plugin-x170: we've removed it now.
log4cpp builds OK.
sdbusplus indeed fails, and it is not trivial to fix. I have a solution,
but it is ultimately ugly, which implies either we're in deep sh!t, or I
missed something obviously obvious (I'd bet on the latter).
Which means that libsigrok may have the same issue as sdbusplus... I'll
try to come up with something saner for bot
I did not even dare look into asterisk for now...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/sdl_mixer: fix build after aclocal include revamp
2020-02-09 14:08 ` Yann E. MORIN
@ 2020-02-09 14:41 ` Heiko Thiery
2020-02-09 14:55 ` Yann E. MORIN
0 siblings, 1 reply; 5+ messages in thread
From: Heiko Thiery @ 2020-02-09 14:41 UTC (permalink / raw)
To: buildroot
Hi,
I also realized this packages but did not have the chance for a deeper look
at it.
--
Heiko
Yann E. MORIN <yann.morin.1998@free.fr> schrieb am So., 9. Feb. 2020, 15:08:
> On 2020-02-08 20:03 +0100, Peter Korsgaard spake thusly:
> > >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> > > After d255b67972 (autotools: do not overwrite first include path), the
> > > ordering of include paths has changed: the system directories are
> > > specified with explicit options passed to autoreconf, which means that
> > > any directory specified in the package _AUTORECONF_OPTS are no longer
> > > first:
> > Most likely we also need to fix a number of other packages:
> > git grep '_AUTORECONF_OPTS ='
> > package/asterisk/asterisk.mk:ASTERISK_AUTORECONF_OPTS = -Iautoconf
> -Ithird-party -Ithird-party/pjproject -Ithird-party/jansson
> > package/gstreamer/gst-plugin-x170/gst-plugin-x170.mk:GST_PLUGIN_X170_AUTORECONF_OPTS
> = -Im4/
> > package/log4cpp/log4cpp.mk:LOG4CPP_AUTORECONF_OPTS = -I m4
> > package/sdbusplus/sdbusplus.mk:SDBUSPLUS_AUTORECONF_OPTS =
> --include=$(HOST_DIR)/share/autoconf-archive
>
> gst-plugin-x170: we've removed it now.
>
> log4cpp builds OK.
>
> sdbusplus indeed fails, and it is not trivial to fix. I have a solution,
> but it is ultimately ugly, which implies either we're in deep sh!t, or I
> missed something obviously obvious (I'd bet on the latter).
>
> Which means that libsigrok may have the same issue as sdbusplus... I'll
> try to come up with something saner for bot
>
> I did not even dare look into asterisk for now...
>
> Regards,
> Yann E. MORIN.
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___
> |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is
> no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v
> conspiracy. |
>
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200209/bad8b1bc/attachment.html>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/sdl_mixer: fix build after aclocal include revamp
2020-02-09 14:41 ` Heiko Thiery
@ 2020-02-09 14:55 ` Yann E. MORIN
0 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2020-02-09 14:55 UTC (permalink / raw)
To: buildroot
Heiko, All,
On 2020-02-09 15:41 +0100, Heiko Thiery spake thusly:
> Hi,?
> I also realized this packages but did not have the chance for a deeper look at it.
Can you avoid top-posting, please?
> --
> Heiko
> Yann E. MORIN < [1]yann.morin.1998@free.fr> schrieb am So., 9. Feb. 2020, 15:08:
>
> On 2020-02-08 20:03 +0100, Peter Korsgaard spake thusly:
> > >>>>> "Yann" == Yann E MORIN < [2]yann.morin.1998@free.fr> writes:
> >? > After d255b67972 (autotools: do not overwrite first include path), the
> >? > ordering of include paths has changed: the system directories are
> >? > specified with explicit options passed to autoreconf, which means that
> >? > any directory specified in the package _AUTORECONF_OPTS are no longer
> >? > first:
> > Most likely we also need to fix a number of other packages:
> > git grep '_AUTORECONF_OPTS ='
> > package/asterisk/asterisk.mk:ASTERISK_AUTORECONF_OPTS = -Iautoconf -Ithird-party -Ithird-party/pjproject -Ithird-party/jansson
> > package/gstreamer/gst-plugin-x170/gst-plugin-x170.mk:GST_PLUGIN_X170_AUTORECONF_OPTS = -Im4/
> > package/log4cpp/log4cpp.mk:LOG4CPP_AUTORECONF_OPTS = -I m4
> > package/sdbusplus/sdbusplus.mk:SDBUSPLUS_AUTORECONF_OPTS = --include=$(HOST_DIR)/share/autoconf-archive
>
> gst-plugin-x170: we've removed it now.
>
> log4cpp builds OK.
>
> sdbusplus indeed fails, and it is not trivial to fix. I have a solution,
> but it is ultimately ugly, which implies either we're in deep sh!t, or I
> missed something obviously obvious (I'd bet on the latter).
I have a nice patch, shiny and all, but a little bit too involved in my
opinion. Patch incoming in a moment...
> Which means that libsigrok may have the same issue as sdbusplus... I'll
> try to come up with something saner for bot
libsigrok is a false-positive: it dnow longer needs host-autoconf-archive
anymore, I'll send an clean up patch any moment now...
> I did not even dare look into asterisk for now...
(still afraid of even peekign in there...)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-09 14:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-08 18:26 [Buildroot] [PATCH] package/sdl_mixer: fix build after aclocal include revamp Yann E. MORIN
2020-02-08 19:03 ` Peter Korsgaard
2020-02-09 14:08 ` Yann E. MORIN
2020-02-09 14:41 ` Heiko Thiery
2020-02-09 14:55 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.