All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 0/2] add frr package
@ 2020-02-25  2:58 Vadim Kochan
  2020-02-25  2:58 ` [Buildroot] [PATCH v2 1/2] package/libyang: enable LYD_PRIV option for " Vadim Kochan
  2020-02-25  2:58 ` [Buildroot] [PATCH v2 2/2] package/frr: new package Vadim Kochan
  0 siblings, 2 replies; 11+ messages in thread
From: Vadim Kochan @ 2020-02-25  2:58 UTC (permalink / raw)
  To: buildroot

FRR is free software that implements and manages various IPv4 and IPv6
routing protocols. It runs on nearly all distributions of Linux and BSD
as well as Solaris and supports all modern CPU architectures.

FRR currently supports the following protocols:

    BGP
    OSPFv2
    OSPFv3
    RIPv1
    RIPv2
    RIPng
    IS-IS
    PIM-SM/MSDP
    LDP
    BFD
    Babel
    PBR
    OpenFabric
    VRRP
    EIGRP (alpha)
    NHRP (alpha)

FRR package requires LYD_PRIV option to be enabled in
libyang package, so enabled it in separate patch if
frr is selected.

Disabled some options for frr package like:

    - POSIX capabilities
    - RPKi

v2:
    1) fixed TAB indent on multiline var assignment

    2) fixed ABC ordering

    3) add missing 'depends on' from selected libs by frr

    4) directly call /usr/sbin/frrinit.sh S50frr init script
       w/o start-stop-daemon tool, frr cares of daemons stopping/
       running.

    5) Removed not-needed empty daemons *.conf files installation,
       it was taken from building instructions in frr docs, but
       really it is not required.

    6) Use 0644 mask for conf files.

    7) Enable LYD_PRIV option for libyang only if frr selected.

    8) Drop patch with rtrlib package which is needed only for
       RPKi support which is disabled by default.

    9) Add AUTORECONF for bootstrap invocation.

    10) Get rid of manual binaries target invocation. After frr.mk
        cleanup it starts to work.

    11) Install var/log/frr and /var/run/frr at runtime from init.

Vadim Kochan (2):
  package/libyang: enable LYD_PRIV option for frr package
  package/frr: new package

 DEVELOPERS                 |  1 +
 package/Config.in          |  1 +
 package/frr/Config.in      | 25 +++++++++++++
 package/frr/S50frr         | 46 +++++++++++++++++++++++
 package/frr/frr.hash       |  2 +
 package/frr/frr.mk         | 75 ++++++++++++++++++++++++++++++++++++++
 package/libyang/libyang.mk |  4 ++
 7 files changed, 154 insertions(+)
 create mode 100644 package/frr/Config.in
 create mode 100644 package/frr/S50frr
 create mode 100644 package/frr/frr.hash
 create mode 100644 package/frr/frr.mk

-- 
2.17.1

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/libyang: enable LYD_PRIV option for frr package
  2020-02-25  2:58 [Buildroot] [PATCH v2 0/2] add frr package Vadim Kochan
@ 2020-02-25  2:58 ` Vadim Kochan
  2020-02-25  8:06   ` Thomas Petazzoni
  2020-02-25  2:58 ` [Buildroot] [PATCH v2 2/2] package/frr: new package Vadim Kochan
  1 sibling, 1 reply; 11+ messages in thread
From: Vadim Kochan @ 2020-02-25  2:58 UTC (permalink / raw)
  To: buildroot

This option is required by frr package, so enable it only if frr is
selected.

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
 package/libyang/libyang.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/libyang/libyang.mk b/package/libyang/libyang.mk
index 648ffeb6a3..9d7f5df696 100644
--- a/package/libyang/libyang.mk
+++ b/package/libyang/libyang.mk
@@ -17,6 +17,10 @@ LIBYANG_CONF_OPTS = \
 	-DENABLE_VALGRIND_TESTS=OFF \
 	-DGEN_PYTHON_BINDINGS=OFF
 
+ifeq ($(BR2_PACKAGE_FRR),y)
+LIBYANG_CONF_OPTS += -DENABLE_LYD_PRIV=ON
+endif
+
 HOST_LIBYANG_CONF_OPTS = \
 	-DENABLE_VALGRIND_TESTS=OFF \
 	-DGEN_PYTHON_BINDINGS=OFF
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/frr: new package
  2020-02-25  2:58 [Buildroot] [PATCH v2 0/2] add frr package Vadim Kochan
  2020-02-25  2:58 ` [Buildroot] [PATCH v2 1/2] package/libyang: enable LYD_PRIV option for " Vadim Kochan
@ 2020-02-25  2:58 ` Vadim Kochan
  2020-02-25  8:25   ` Heiko Thiery
  2020-02-25 10:13   ` Heiko Thiery
  1 sibling, 2 replies; 11+ messages in thread
From: Vadim Kochan @ 2020-02-25  2:58 UTC (permalink / raw)
  To: buildroot

FRR is free software that implements and manages various IPv4 and IPv6
routing protocols. It runs on nearly all distributions of Linux and BSD
as well as Solaris and supports all modern CPU architectures.

FRR currently supports the following protocols:

    BGP
    OSPFv2
    OSPFv3
    RIPv1
    RIPv2
    RIPng
    IS-IS
    PIM-SM/MSDP
    LDP
    BFD
    Babel
    PBR
    OpenFabric
    VRRP
    EIGRP (alpha)
    NHRP (alpha)

Some not-needed features were disabled to minimize package dependencies:

    - POSIX capabilities
    - RPKi

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
 DEVELOPERS            |  1 +
 package/Config.in     |  1 +
 package/frr/Config.in | 25 +++++++++++++++
 package/frr/S50frr    | 46 ++++++++++++++++++++++++++
 package/frr/frr.hash  |  2 ++
 package/frr/frr.mk    | 75 +++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 150 insertions(+)
 create mode 100644 package/frr/Config.in
 create mode 100644 package/frr/S50frr
 create mode 100644 package/frr/frr.hash
 create mode 100644 package/frr/frr.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 7d3d1ca11a..95ea2254de 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2477,6 +2477,7 @@ F:	package/tstools/
 
 N:	Vadim Kochan <vadim4j@gmail.com>
 F:	package/brcm-patchram-plus/
+F:	package/frr/
 F:	package/gettext-tiny/
 F:	package/tinyssh/
 
diff --git a/package/Config.in b/package/Config.in
index dfa3f34b9d..3e6b51a745 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1998,6 +1998,7 @@ menu "Networking applications"
 	source "package/fping/Config.in"
 	source "package/freeswitch/Config.in"
 	source "package/freeswitch-mod-bcg729/Config.in"
+	source "package/frr/Config.in"
 	source "package/gerbera/Config.in"
 	source "package/gesftpserver/Config.in"
 	source "package/glorytun/Config.in"
diff --git a/package/frr/Config.in b/package/frr/Config.in
new file mode 100644
index 0000000000..c0c3bdd693
--- /dev/null
+++ b/package/frr/Config.in
@@ -0,0 +1,25 @@
+config BR2_PACKAGE_FRR
+	bool "frr"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_STATIC_LIBS # libyang
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_PACKAGE_BASH # init
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # json-c
+	select BR2_PACKAGE_C_ARES
+	select BR2_PACKAGE_LIBYANG
+	select BR2_PACKAGE_LIBNL
+	select BR2_PACKAGE_READLINE
+	select BR2_PACKAGE_JSON_C
+	help
+	  The FRRouting Protocol Suite.
+
+	  FRR is free software that implements and manages various IPv4 and
+	  IPv6 routing protocols.
+
+	  https://frrouting.org
+
+comment "frr needs BASH, threads, dynamic library"
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on BR2_USE_MMU
+	depends on !BR2_PACKAGE_BASH || !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_STATIC_LIBS
diff --git a/package/frr/S50frr b/package/frr/S50frr
new file mode 100644
index 0000000000..0c128353e9
--- /dev/null
+++ b/package/frr/S50frr
@@ -0,0 +1,46 @@
+#!/bin/sh
+
+DAEMON="frr"
+
+[ -r "/etc/default/$DAEMON" ] && . "/etc/default/$DAEMON"
+
+start() {
+	install -m 755 -o frr -g frr -d /var/run/frr
+	install -m 755 -o frr -g frr -d /var/log/frr
+
+	printf 'Starting %s: ' "$DAEMON"
+	/usr/sbin/frrinit.sh start
+	status=$?
+	if [ "$status" -eq 0 ]; then
+		echo "OK"
+	else
+		echo "FAIL"
+	fi
+	return "$status"
+}
+
+stop() {
+	printf 'Stopping %s: ' "$DAEMON"
+	/usr/sbin/frrinit.sh stop
+	status=$?
+	if [ "$status" -eq 0 ]; then
+		echo "OK"
+	else
+		echo "FAIL"
+	fi
+	return "$status"
+}
+
+restart() {
+	stop
+	sleep 1
+	start
+}
+
+case "$1" in
+	start|stop|restart)
+		"$1";;
+	*)
+		echo "Usage: $0 {start|stop|restart}"
+		exit 1
+esac
diff --git a/package/frr/frr.hash b/package/frr/frr.hash
new file mode 100644
index 0000000000..7d9ff7ea04
--- /dev/null
+++ b/package/frr/frr.hash
@@ -0,0 +1,2 @@
+sha256 c209ed66a0331221649b8c21dc8c6704ce1696e2017ef4d48f8c2ac6b1fa01b7  frr-7.3.tar.gz
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/frr/frr.mk b/package/frr/frr.mk
new file mode 100644
index 0000000000..448aa56690
--- /dev/null
+++ b/package/frr/frr.mk
@@ -0,0 +1,75 @@
+################################################################################
+#
+# frr
+#
+################################################################################
+
+FRR_VERSION = 7.3
+FRR_SOURCE = frr-$(FRR_VERSION).tar.gz
+FRR_SITE = https://github.com/FRRouting/frr/archive
+FRR_LICENSE = GPL-2.0
+FRR_LICENSE_FILES = COPYING
+FRR_AUTORECONF = YES
+
+FRR_DEPENDENCIES = host-frr readline json-c \
+	libyang libnl c-ares
+
+HOST_FRR_DEPENDENCIES = host-flex host-bison host-python
+
+FRR_CONF_OPTS = --with-clippy=$(HOST_DIR)/bin/clippy \
+	--sysconfdir=/etc/frr \
+	--localstatedir=/var/run/frr \
+	--with-moduledir=/usr/lib/frr/modules \
+	--enable-configfile-mask=0640 \
+	--enable-logfile-mask=0640 \
+	--enable-multipath=256 \
+	--disable-ospfclient \
+	--enable-shell-access \
+	--enable-user=frr \
+	--enable-group=frr \
+	--enable-vty-group=frrvty \
+	--disable-exampledir \
+	--disable-capabilities \
+	--enable-fpm
+
+HOST_FRR_CONF_OPTS = --enable-clippy-only
+
+define FRR_RUN_BOOTSTRAP
+	(cd $(@D) && PATH=$(BR_PATH) ./bootstrap.sh)
+endef
+FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
+HOST_FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
+
+define HOST_FRR_INSTALL_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/lib/clippy $(HOST_DIR)/bin/clippy
+endef
+
+define FRR_INSTALL_CONFIG_FILES
+	$(INSTALL) -d -m 0755 $(TARGET_DIR)/etc/frr
+
+	$(foreach f,daemons daemons.conf frr.conf vtysh.conf support_bundle_commands.conf,\
+		$(INSTALL) -D -m 0640 $(@D)/tools/etc/frr/$(f) \
+		$(TARGET_DIR)/etc/frr/$(f)
+	)
+endef
+FRR_POST_INSTALL_TARGET_HOOKS += FRR_INSTALL_CONFIG_FILES
+
+define FRR_PERMISSIONS
+	/etc/frr/daemons f 640 frr frr - - - - -
+	/etc/frr/daemons.conf f 640 frr frr - - - - -
+	/etc/frr/frr.conf f 640 frr frr - - - - -
+	/etc/frr/vtysh.conf f 640 frr frrvty - - - - -
+	/etc/frr/support_bundle_commands.conf f 640 frr frr
+endef
+
+define FRR_USERS
+	frr -1 frr -1 * /var/run/frr - frrvty FRR user priv
+endef
+
+define FRR_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 755 $(FRR_PKGDIR)/S50frr \
+		$(TARGET_DIR)/etc/init.d/S50frr
+endef
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/libyang: enable LYD_PRIV option for frr package
  2020-02-25  2:58 ` [Buildroot] [PATCH v2 1/2] package/libyang: enable LYD_PRIV option for " Vadim Kochan
@ 2020-02-25  8:06   ` Thomas Petazzoni
  0 siblings, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2020-02-25  8:06 UTC (permalink / raw)
  To: buildroot

On Tue, 25 Feb 2020 04:58:49 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:

> This option is required by frr package, so enable it only if frr is
> selected.
> 
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
>  package/libyang/libyang.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/libyang/libyang.mk b/package/libyang/libyang.mk
> index 648ffeb6a3..9d7f5df696 100644
> --- a/package/libyang/libyang.mk
> +++ b/package/libyang/libyang.mk
> @@ -17,6 +17,10 @@ LIBYANG_CONF_OPTS = \
>  	-DENABLE_VALGRIND_TESTS=OFF \
>  	-DGEN_PYTHON_BINDINGS=OFF
>  
> +ifeq ($(BR2_PACKAGE_FRR),y)

We normally don't look at which reverse dependencies are enabled to
enable features in a dependent package. We do the opposite: look at
which of our dependencies are available to enable features.

What is the size increase of enabling this option? If it is
significant, we want to introduce a BR2_PACKAGE_LIBYANG_LYD_PRIV
sub-option, and select it from the frr package.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/frr: new package
  2020-02-25  2:58 ` [Buildroot] [PATCH v2 2/2] package/frr: new package Vadim Kochan
@ 2020-02-25  8:25   ` Heiko Thiery
  2020-02-25 11:47     ` Vadim Kochan
  2020-02-25 10:13   ` Heiko Thiery
  1 sibling, 1 reply; 11+ messages in thread
From: Heiko Thiery @ 2020-02-25  8:25 UTC (permalink / raw)
  To: buildroot

Hi Vadim and all,

Am Di., 25. Feb. 2020 um 03:59 Uhr schrieb Vadim Kochan <vadim4j@gmail.com>:
>
> FRR is free software that implements and manages various IPv4 and IPv6
> routing protocols. It runs on nearly all distributions of Linux and BSD
> as well as Solaris and supports all modern CPU architectures.
>
> FRR currently supports the following protocols:
>
>     BGP
>     OSPFv2
>     OSPFv3
>     RIPv1
>     RIPv2
>     RIPng
>     IS-IS
>     PIM-SM/MSDP
>     LDP
>     BFD
>     Babel
>     PBR
>     OpenFabric
>     VRRP
>     EIGRP (alpha)
>     NHRP (alpha)
>
> Some not-needed features were disabled to minimize package dependencies:
>
>     - POSIX capabilities
>     - RPKi
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
>  DEVELOPERS            |  1 +
>  package/Config.in     |  1 +
>  package/frr/Config.in | 25 +++++++++++++++
>  package/frr/S50frr    | 46 ++++++++++++++++++++++++++
>  package/frr/frr.hash  |  2 ++
>  package/frr/frr.mk    | 75 +++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 150 insertions(+)
>  create mode 100644 package/frr/Config.in
>  create mode 100644 package/frr/S50frr
>  create mode 100644 package/frr/frr.hash
>  create mode 100644 package/frr/frr.mk
>

[SNIP]

> diff --git a/package/frr/frr.mk b/package/frr/frr.mk
> new file mode 100644
> index 0000000000..448aa56690
> --- /dev/null
> +++ b/package/frr/frr.mk
> @@ -0,0 +1,75 @@
> +################################################################################
> +#
> +# frr
> +#
> +################################################################################
> +
> +FRR_VERSION = 7.3
> +FRR_SOURCE = frr-$(FRR_VERSION).tar.gz

You can remove FRR_SOURCE because it is not needed. Buildroot will
automatically set this to "frr-$(FRR_VERSION).tar.gz".

> +FRR_SITE = https://github.com/FRRouting/frr/archive
> +FRR_LICENSE = GPL-2.0
> +FRR_LICENSE_FILES = COPYING
> +FRR_AUTORECONF = YES
> +
> +FRR_DEPENDENCIES = host-frr readline json-c \
> +       libyang libnl c-ares
> +
> +HOST_FRR_DEPENDENCIES = host-flex host-bison host-python
> +
> +FRR_CONF_OPTS = --with-clippy=$(HOST_DIR)/bin/clippy \
> +       --sysconfdir=/etc/frr \
> +       --localstatedir=/var/run/frr \
> +       --with-moduledir=/usr/lib/frr/modules \
> +       --enable-configfile-mask=0640 \
> +       --enable-logfile-mask=0640 \
> +       --enable-multipath=256 \
> +       --disable-ospfclient \
> +       --enable-shell-access \
> +       --enable-user=frr \
> +       --enable-group=frr \
> +       --enable-vty-group=frrvty \
> +       --disable-exampledir \
> +       --disable-capabilities \
> +       --enable-fpm
> +
> +HOST_FRR_CONF_OPTS = --enable-clippy-only
> +
> +define FRR_RUN_BOOTSTRAP
> +       (cd $(@D) && PATH=$(BR_PATH) ./bootstrap.sh)
> +endef
> +FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
> +HOST_FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP

Do we realy need to call the bootstrap.sh? The only thing done here is
to call "autoreconf -i". This is automatically called by buildroot
when setting "FRR_AUTORECONF = YES".

@@ -34,12 +33,6 @@ FRR_CONF_OPTS = --with-clippy=$(HOST_DIR)/bin/clippy \

 HOST_FRR_CONF_OPTS = --enable-clippy-only

-define FRR_RUN_BOOTSTRAP
-       (cd $(@D) && PATH=$(BR_PATH) ./bootstrap.sh)
-endef
-FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
-HOST_FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
-
 define HOST_FRR_INSTALL_CMDS
        $(INSTALL) -D -m 0755 $(@D)/lib/clippy $(HOST_DIR)/bin/clippy
 endef


> +
> +define HOST_FRR_INSTALL_CMDS
> +       $(INSTALL) -D -m 0755 $(@D)/lib/clippy $(HOST_DIR)/bin/clippy
> +endef
> +
> +define FRR_INSTALL_CONFIG_FILES
> +       $(INSTALL) -d -m 0755 $(TARGET_DIR)/etc/frr
> +
> +       $(foreach f,daemons daemons.conf frr.conf vtysh.conf support_bundle_commands.conf,\
> +               $(INSTALL) -D -m 0640 $(@D)/tools/etc/frr/$(f) \
> +               $(TARGET_DIR)/etc/frr/$(f)
> +       )
> +endef
> +FRR_POST_INSTALL_TARGET_HOOKS += FRR_INSTALL_CONFIG_FILES
> +
> +define FRR_PERMISSIONS
> +       /etc/frr/daemons f 640 frr frr - - - - -
> +       /etc/frr/daemons.conf f 640 frr frr - - - - -
> +       /etc/frr/frr.conf f 640 frr frr - - - - -
> +       /etc/frr/vtysh.conf f 640 frr frrvty - - - - -
> +       /etc/frr/support_bundle_commands.conf f 640 frr frr
> +endef
> +
> +define FRR_USERS
> +       frr -1 frr -1 * /var/run/frr - frrvty FRR user priv
> +endef
> +
> +define FRR_INSTALL_INIT_SYSV
> +       $(INSTALL) -D -m 755 $(FRR_PKGDIR)/S50frr \
> +               $(TARGET_DIR)/etc/init.d/S50frr
> +endef
> +
> +$(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> --
> 2.17.1
>

Also some warnings from "utils/check-package package/frr/*":

package/frr/Config.in:16: help text: <tab><2 spaces><62 chars>
(http://nightly.buildroot.org/#writing-rules-config-in)
package/frr/frr.mk:8: remove default value of _SOURCE variable
(http://nightly.buildroot.org/#generic-package-reference)
102 lines processed
2 warnings generated

BR
--
Heiko

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/frr: new package
  2020-02-25  2:58 ` [Buildroot] [PATCH v2 2/2] package/frr: new package Vadim Kochan
  2020-02-25  8:25   ` Heiko Thiery
@ 2020-02-25 10:13   ` Heiko Thiery
  2020-02-25 11:46     ` Vadim Kochan
  1 sibling, 1 reply; 11+ messages in thread
From: Heiko Thiery @ 2020-02-25 10:13 UTC (permalink / raw)
  To: buildroot

Hi Vadim and all,

Am Di., 25. Feb. 2020 um 03:59 Uhr schrieb Vadim Kochan <vadim4j@gmail.com>:
>
> FRR is free software that implements and manages various IPv4 and IPv6
> routing protocols. It runs on nearly all distributions of Linux and BSD
> as well as Solaris and supports all modern CPU architectures.
>
> FRR currently supports the following protocols:
>
>     BGP
>     OSPFv2
>     OSPFv3
>     RIPv1
>     RIPv2
>     RIPng
>     IS-IS
>     PIM-SM/MSDP
>     LDP
>     BFD
>     Babel
>     PBR
>     OpenFabric
>     VRRP
>     EIGRP (alpha)
>     NHRP (alpha)
>
> Some not-needed features were disabled to minimize package dependencies:
>
>     - POSIX capabilities
>     - RPKi
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---

[SNIP]

> diff --git a/package/frr/frr.mk b/package/frr/frr.mk
> new file mode 100644
> index 0000000000..448aa56690
> --- /dev/null
> +++ b/package/frr/frr.mk
> @@ -0,0 +1,75 @@
> +################################################################################
> +#
> +# frr
> +#
> +################################################################################
> +
> +FRR_VERSION = 7.3
> +FRR_SOURCE = frr-$(FRR_VERSION).tar.gz
> +FRR_SITE = https://github.com/FRRouting/frr/archive
> +FRR_LICENSE = GPL-2.0
> +FRR_LICENSE_FILES = COPYING
> +FRR_AUTORECONF = YES
> +
> +FRR_DEPENDENCIES = host-frr readline json-c \
> +       libyang libnl c-ares
> +
> +HOST_FRR_DEPENDENCIES = host-flex host-bison host-python
> +
> +FRR_CONF_OPTS = --with-clippy=$(HOST_DIR)/bin/clippy \
> +       --sysconfdir=/etc/frr \
> +       --localstatedir=/var/run/frr \
> +       --with-moduledir=/usr/lib/frr/modules \
> +       --enable-configfile-mask=0640 \
> +       --enable-logfile-mask=0640 \
> +       --enable-multipath=256 \
> +       --disable-ospfclient \
> +       --enable-shell-access \
> +       --enable-user=frr \
> +       --enable-group=frr \
> +       --enable-vty-group=frrvty \
> +       --disable-exampledir \
> +       --disable-capabilities \
> +       --enable-fpm
> +
> +HOST_FRR_CONF_OPTS = --enable-clippy-only
> +
> +define FRR_RUN_BOOTSTRAP
> +       (cd $(@D) && PATH=$(BR_PATH) ./bootstrap.sh)
> +endef
> +FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
> +HOST_FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
> +
> +define HOST_FRR_INSTALL_CMDS
> +       $(INSTALL) -D -m 0755 $(@D)/lib/clippy $(HOST_DIR)/bin/clippy
> +endef
> +
> +define FRR_INSTALL_CONFIG_FILES
> +       $(INSTALL) -d -m 0755 $(TARGET_DIR)/etc/frr
> +
> +       $(foreach f,daemons daemons.conf frr.conf vtysh.conf support_bundle_commands.conf,\
> +               $(INSTALL) -D -m 0640 $(@D)/tools/etc/frr/$(f) \
> +               $(TARGET_DIR)/etc/frr/$(f)
> +       )
> +endef
> +FRR_POST_INSTALL_TARGET_HOOKS += FRR_INSTALL_CONFIG_FILES
> +
> +define FRR_PERMISSIONS
> +       /etc/frr/daemons f 640 frr frr - - - - -
> +       /etc/frr/daemons.conf f 640 frr frr - - - - -
> +       /etc/frr/frr.conf f 640 frr frr - - - - -
> +       /etc/frr/vtysh.conf f 640 frr frrvty - - - - -
> +       /etc/frr/support_bundle_commands.conf f 640 frr frr
> +endef
> +
> +define FRR_USERS
> +       frr -1 frr -1 * /var/run/frr - frrvty FRR user priv
> +endef
> +
> +define FRR_INSTALL_INIT_SYSV
> +       $(INSTALL) -D -m 755 $(FRR_PKGDIR)/S50frr \
> +               $(TARGET_DIR)/etc/init.d/S50frr
> +endef
> +
> +$(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> --
> 2.17.1
>

I see that thei install step installs examples in a directory where (I
think) it never should install stuff! It is the targetno directory.

 /usr/bin/install -c -m 644 zebra/zebra.conf.sample
bgpd/bgpd.conf.sample bgpd/bgpd.conf.sample2 bgpd/bgpd.conf.vnc.sample
ripd/ripd.conf.sample ripngd/ripngd.conf.sample
ospfd/ospfd.conf.sample ospf6d/ospf6d.conf.sample
isisd/isisd.conf.sample isisd/fabricd.conf.sample
ldpd/ldpd.conf.sample babeld/babeld.conf.sample
eigrpd/eigrpd.conf.sample pimd/pimd.conf.sample pbrd/pbrd.conf.sample
staticd/staticd.conf.sample bfdd/bfdd.conf.sample
vtysh/vtysh.conf.sample
'/home/hthiery/sources/mainline/buildroot/output/targetno'


I cannot see how it is possible to properly disable the install of
examples. I see that you already have set the option
--disable-exampledir. But this seems not to be enought, or it is
broken.

--
Heiko

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/frr: new package
  2020-02-25 10:13   ` Heiko Thiery
@ 2020-02-25 11:46     ` Vadim Kochan
  2020-02-25 12:39       ` Heiko Thiery
  0 siblings, 1 reply; 11+ messages in thread
From: Vadim Kochan @ 2020-02-25 11:46 UTC (permalink / raw)
  To: buildroot

Hi Heiko,

On Tue, Feb 25, 2020 at 12:13 PM Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> Hi Vadim and all,
>
> Am Di., 25. Feb. 2020 um 03:59 Uhr schrieb Vadim Kochan <vadim4j@gmail.com>:
> >
> > FRR is free software that implements and manages various IPv4 and IPv6
> > routing protocols. It runs on nearly all distributions of Linux and BSD
> > as well as Solaris and supports all modern CPU architectures.
> >
> > FRR currently supports the following protocols:
> >
> >     BGP
> >     OSPFv2
> >     OSPFv3
> >     RIPv1
> >     RIPv2
> >     RIPng
> >     IS-IS
> >     PIM-SM/MSDP
> >     LDP
> >     BFD
> >     Babel
> >     PBR
> >     OpenFabric
> >     VRRP
> >     EIGRP (alpha)
> >     NHRP (alpha)
> >
> > Some not-needed features were disabled to minimize package dependencies:
> >
> >     - POSIX capabilities
> >     - RPKi
> >
> > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> > ---
>
> [SNIP]
>
> > diff --git a/package/frr/frr.mk b/package/frr/frr.mk
> > new file mode 100644
> > index 0000000000..448aa56690
> > --- /dev/null
> > +++ b/package/frr/frr.mk
> > @@ -0,0 +1,75 @@
> > +################################################################################
> > +#
> > +# frr
> > +#
> > +################################################################################
> > +
> > +FRR_VERSION = 7.3
> > +FRR_SOURCE = frr-$(FRR_VERSION).tar.gz
> > +FRR_SITE = https://github.com/FRRouting/frr/archive
> > +FRR_LICENSE = GPL-2.0
> > +FRR_LICENSE_FILES = COPYING
> > +FRR_AUTORECONF = YES
> > +
> > +FRR_DEPENDENCIES = host-frr readline json-c \
> > +       libyang libnl c-ares
> > +
> > +HOST_FRR_DEPENDENCIES = host-flex host-bison host-python
> > +
> > +FRR_CONF_OPTS = --with-clippy=$(HOST_DIR)/bin/clippy \
> > +       --sysconfdir=/etc/frr \
> > +       --localstatedir=/var/run/frr \
> > +       --with-moduledir=/usr/lib/frr/modules \
> > +       --enable-configfile-mask=0640 \
> > +       --enable-logfile-mask=0640 \
> > +       --enable-multipath=256 \
> > +       --disable-ospfclient \
> > +       --enable-shell-access \
> > +       --enable-user=frr \
> > +       --enable-group=frr \
> > +       --enable-vty-group=frrvty \
> > +       --disable-exampledir \
> > +       --disable-capabilities \
> > +       --enable-fpm
> > +
> > +HOST_FRR_CONF_OPTS = --enable-clippy-only
> > +
> > +define FRR_RUN_BOOTSTRAP
> > +       (cd $(@D) && PATH=$(BR_PATH) ./bootstrap.sh)
> > +endef
> > +FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
> > +HOST_FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
> > +
> > +define HOST_FRR_INSTALL_CMDS
> > +       $(INSTALL) -D -m 0755 $(@D)/lib/clippy $(HOST_DIR)/bin/clippy
> > +endef
> > +
> > +define FRR_INSTALL_CONFIG_FILES
> > +       $(INSTALL) -d -m 0755 $(TARGET_DIR)/etc/frr
> > +
> > +       $(foreach f,daemons daemons.conf frr.conf vtysh.conf support_bundle_commands.conf,\
> > +               $(INSTALL) -D -m 0640 $(@D)/tools/etc/frr/$(f) \
> > +               $(TARGET_DIR)/etc/frr/$(f)
> > +       )
> > +endef
> > +FRR_POST_INSTALL_TARGET_HOOKS += FRR_INSTALL_CONFIG_FILES
> > +
> > +define FRR_PERMISSIONS
> > +       /etc/frr/daemons f 640 frr frr - - - - -
> > +       /etc/frr/daemons.conf f 640 frr frr - - - - -
> > +       /etc/frr/frr.conf f 640 frr frr - - - - -
> > +       /etc/frr/vtysh.conf f 640 frr frrvty - - - - -
> > +       /etc/frr/support_bundle_commands.conf f 640 frr frr
> > +endef
> > +
> > +define FRR_USERS
> > +       frr -1 frr -1 * /var/run/frr - frrvty FRR user priv
> > +endef
> > +
> > +define FRR_INSTALL_INIT_SYSV
> > +       $(INSTALL) -D -m 755 $(FRR_PKGDIR)/S50frr \
> > +               $(TARGET_DIR)/etc/init.d/S50frr
> > +endef
> > +
> > +$(eval $(autotools-package))
> > +$(eval $(host-autotools-package))
> > --
> > 2.17.1
> >
>
> I see that thei install step installs examples in a directory where (I
> think) it never should install stuff! It is the targetno directory.
>
>  /usr/bin/install -c -m 644 zebra/zebra.conf.sample
> bgpd/bgpd.conf.sample bgpd/bgpd.conf.sample2 bgpd/bgpd.conf.vnc.sample
> ripd/ripd.conf.sample ripngd/ripngd.conf.sample
> ospfd/ospfd.conf.sample ospf6d/ospf6d.conf.sample
> isisd/isisd.conf.sample isisd/fabricd.conf.sample
> ldpd/ldpd.conf.sample babeld/babeld.conf.sample
> eigrpd/eigrpd.conf.sample pimd/pimd.conf.sample pbrd/pbrd.conf.sample
> staticd/staticd.conf.sample bfdd/bfdd.conf.sample
> vtysh/vtysh.conf.sample
> '/home/hthiery/sources/mainline/buildroot/output/targetno'
>
>
> I cannot see how it is possible to properly disable the install of
> examples. I see that you already have set the option
> --disable-exampledir. But this seems not to be enought, or it is
> broken.

Wow! Nice catch, I did not realize this, so there are like at least 2 options ?
1) remove it in hook
2) patch the frr build scripts (which looks like more safer?)

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/frr: new package
  2020-02-25  8:25   ` Heiko Thiery
@ 2020-02-25 11:47     ` Vadim Kochan
  0 siblings, 0 replies; 11+ messages in thread
From: Vadim Kochan @ 2020-02-25 11:47 UTC (permalink / raw)
  To: buildroot

On Tue, Feb 25, 2020 at 10:26 AM Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> Hi Vadim and all,
>
> Am Di., 25. Feb. 2020 um 03:59 Uhr schrieb Vadim Kochan <vadim4j@gmail.com>:
> >
> > FRR is free software that implements and manages various IPv4 and IPv6
> > routing protocols. It runs on nearly all distributions of Linux and BSD
> > as well as Solaris and supports all modern CPU architectures.
> >
> > FRR currently supports the following protocols:
> >
> >     BGP
> >     OSPFv2
> >     OSPFv3
> >     RIPv1
> >     RIPv2
> >     RIPng
> >     IS-IS
> >     PIM-SM/MSDP
> >     LDP
> >     BFD
> >     Babel
> >     PBR
> >     OpenFabric
> >     VRRP
> >     EIGRP (alpha)
> >     NHRP (alpha)
> >
> > Some not-needed features were disabled to minimize package dependencies:
> >
> >     - POSIX capabilities
> >     - RPKi
> >
> > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> > ---
> >  DEVELOPERS            |  1 +
> >  package/Config.in     |  1 +
> >  package/frr/Config.in | 25 +++++++++++++++
> >  package/frr/S50frr    | 46 ++++++++++++++++++++++++++
> >  package/frr/frr.hash  |  2 ++
> >  package/frr/frr.mk    | 75 +++++++++++++++++++++++++++++++++++++++++++
> >  6 files changed, 150 insertions(+)
> >  create mode 100644 package/frr/Config.in
> >  create mode 100644 package/frr/S50frr
> >  create mode 100644 package/frr/frr.hash
> >  create mode 100644 package/frr/frr.mk
> >
>
> [SNIP]
>
> > diff --git a/package/frr/frr.mk b/package/frr/frr.mk
> > new file mode 100644
> > index 0000000000..448aa56690
> > --- /dev/null
> > +++ b/package/frr/frr.mk
> > @@ -0,0 +1,75 @@
> > +################################################################################
> > +#
> > +# frr
> > +#
> > +################################################################################
> > +
> > +FRR_VERSION = 7.3
> > +FRR_SOURCE = frr-$(FRR_VERSION).tar.gz
>
> You can remove FRR_SOURCE because it is not needed. Buildroot will
> automatically set this to "frr-$(FRR_VERSION).tar.gz".
>
> > +FRR_SITE = https://github.com/FRRouting/frr/archive
> > +FRR_LICENSE = GPL-2.0
> > +FRR_LICENSE_FILES = COPYING
> > +FRR_AUTORECONF = YES
> > +
> > +FRR_DEPENDENCIES = host-frr readline json-c \
> > +       libyang libnl c-ares
> > +
> > +HOST_FRR_DEPENDENCIES = host-flex host-bison host-python
> > +
> > +FRR_CONF_OPTS = --with-clippy=$(HOST_DIR)/bin/clippy \
> > +       --sysconfdir=/etc/frr \
> > +       --localstatedir=/var/run/frr \
> > +       --with-moduledir=/usr/lib/frr/modules \
> > +       --enable-configfile-mask=0640 \
> > +       --enable-logfile-mask=0640 \
> > +       --enable-multipath=256 \
> > +       --disable-ospfclient \
> > +       --enable-shell-access \
> > +       --enable-user=frr \
> > +       --enable-group=frr \
> > +       --enable-vty-group=frrvty \
> > +       --disable-exampledir \
> > +       --disable-capabilities \
> > +       --enable-fpm
> > +
> > +HOST_FRR_CONF_OPTS = --enable-clippy-only
> > +
> > +define FRR_RUN_BOOTSTRAP
> > +       (cd $(@D) && PATH=$(BR_PATH) ./bootstrap.sh)
> > +endef
> > +FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
> > +HOST_FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
>
> Do we realy need to call the bootstrap.sh? The only thing done here is
> to call "autoreconf -i". This is automatically called by buildroot
> when setting "FRR_AUTORECONF = YES".
>
> @@ -34,12 +33,6 @@ FRR_CONF_OPTS = --with-clippy=$(HOST_DIR)/bin/clippy \
>
>  HOST_FRR_CONF_OPTS = --enable-clippy-only
>
> -define FRR_RUN_BOOTSTRAP
> -       (cd $(@D) && PATH=$(BR_PATH) ./bootstrap.sh)
> -endef
> -FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
> -HOST_FRR_PRE_CONFIGURE_HOOKS += FRR_RUN_BOOTSTRAP
> -
>  define HOST_FRR_INSTALL_CMDS
>         $(INSTALL) -D -m 0755 $(@D)/lib/clippy $(HOST_DIR)/bin/clippy
>  endef
>
>
[SNIP]
...
Thanks! all your suggestions works!
...
[SNIP]
> > +
> > +$(eval $(autotools-package))
> > +$(eval $(host-autotools-package))
> > --
> > 2.17.1
> >
>
> Also some warnings from "utils/check-package package/frr/*":
>
> package/frr/Config.in:16: help text: <tab><2 spaces><62 chars>
> (http://nightly.buildroot.org/#writing-rules-config-in)
> package/frr/frr.mk:8: remove default value of _SOURCE variable
> (http://nightly.buildroot.org/#generic-package-reference)
> 102 lines processed
> 2 warnings generated
>
> BR
> --
> Heiko

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/frr: new package
  2020-02-25 11:46     ` Vadim Kochan
@ 2020-02-25 12:39       ` Heiko Thiery
  2020-02-25 15:37         ` Vadim Kochan
  0 siblings, 1 reply; 11+ messages in thread
From: Heiko Thiery @ 2020-02-25 12:39 UTC (permalink / raw)
  To: buildroot

Hi Vadim and all,

> >
> > I see that thei install step installs examples in a directory where (I
> > think) it never should install stuff! It is the targetno directory.
> >
> >  /usr/bin/install -c -m 644 zebra/zebra.conf.sample
> > bgpd/bgpd.conf.sample bgpd/bgpd.conf.sample2 bgpd/bgpd.conf.vnc.sample
> > ripd/ripd.conf.sample ripngd/ripngd.conf.sample
> > ospfd/ospfd.conf.sample ospf6d/ospf6d.conf.sample
> > isisd/isisd.conf.sample isisd/fabricd.conf.sample
> > ldpd/ldpd.conf.sample babeld/babeld.conf.sample
> > eigrpd/eigrpd.conf.sample pimd/pimd.conf.sample pbrd/pbrd.conf.sample
> > staticd/staticd.conf.sample bfdd/bfdd.conf.sample
> > vtysh/vtysh.conf.sample
> > '/home/hthiery/sources/mainline/buildroot/output/targetno'
> >
> >
> > I cannot see how it is possible to properly disable the install of
> > examples. I see that you already have set the option
> > --disable-exampledir. But this seems not to be enought, or it is
> > broken.
>
> Wow! Nice catch, I did not realize this, so there are like at least 2 options ?
> 1) remove it in hook
> 2) patch the frr build scripts (which looks like more safer?)

I think reporting that upstream and patching would be the best solution.

--
Heiko

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/frr: new package
  2020-02-25 12:39       ` Heiko Thiery
@ 2020-02-25 15:37         ` Vadim Kochan
  2020-02-25 15:38           ` Vadim Kochan
  0 siblings, 1 reply; 11+ messages in thread
From: Vadim Kochan @ 2020-02-25 15:37 UTC (permalink / raw)
  To: buildroot

On Tue, Feb 25, 2020 at 2:39 PM Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> Hi Vadim and all,
>
> > >
> > > I see that thei install step installs examples in a directory where (I
> > > think) it never should install stuff! It is the targetno directory.
> > >
> > >  /usr/bin/install -c -m 644 zebra/zebra.conf.sample
> > > bgpd/bgpd.conf.sample bgpd/bgpd.conf.sample2 bgpd/bgpd.conf.vnc.sample
> > > ripd/ripd.conf.sample ripngd/ripngd.conf.sample
> > > ospfd/ospfd.conf.sample ospf6d/ospf6d.conf.sample
> > > isisd/isisd.conf.sample isisd/fabricd.conf.sample
> > > ldpd/ldpd.conf.sample babeld/babeld.conf.sample
> > > eigrpd/eigrpd.conf.sample pimd/pimd.conf.sample pbrd/pbrd.conf.sample
> > > staticd/staticd.conf.sample bfdd/bfdd.conf.sample
> > > vtysh/vtysh.conf.sample
> > > '/home/hthiery/sources/mainline/buildroot/output/targetno'
> > >
> > >
> > > I cannot see how it is possible to properly disable the install of
> > > examples. I see that you already have set the option
> > > --disable-exampledir. But this seems not to be enought, or it is
> > > broken.
> >
> > Wow! Nice catch, I did not realize this, so there are like at least 2 options ?
> > 1) remove it in hook
> > 2) patch the frr build scripts (which looks like more safer?)
>
> I think reporting that upstream and patching would be the best solution.
>
Hm, problem is that this --enable-exampledir is used as bool option to specify
alternative path for installing config samples, and because I set it
to "--disable-exampledir"
then this value is set to "no" and eventually is appended to DESTDIR
which is $(TARGET_DIR),
which is evaluated to .../targetno.

But is this a problem if config samples will be installed to
$(TARGET_DIR)/etc/frr (which is default
if to remove --disable-exampledir) ?

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/frr: new package
  2020-02-25 15:37         ` Vadim Kochan
@ 2020-02-25 15:38           ` Vadim Kochan
  0 siblings, 0 replies; 11+ messages in thread
From: Vadim Kochan @ 2020-02-25 15:38 UTC (permalink / raw)
  To: buildroot

On Tue, Feb 25, 2020 at 5:37 PM Vadim Kochan <vadim4j@gmail.com> wrote:
>
> On Tue, Feb 25, 2020 at 2:39 PM Heiko Thiery <heiko.thiery@gmail.com> wrote:
> >
> > Hi Vadim and all,
> >
> > > >
> > > > I see that thei install step installs examples in a directory where (I
> > > > think) it never should install stuff! It is the targetno directory.
> > > >
> > > >  /usr/bin/install -c -m 644 zebra/zebra.conf.sample
> > > > bgpd/bgpd.conf.sample bgpd/bgpd.conf.sample2 bgpd/bgpd.conf.vnc.sample
> > > > ripd/ripd.conf.sample ripngd/ripngd.conf.sample
> > > > ospfd/ospfd.conf.sample ospf6d/ospf6d.conf.sample
> > > > isisd/isisd.conf.sample isisd/fabricd.conf.sample
> > > > ldpd/ldpd.conf.sample babeld/babeld.conf.sample
> > > > eigrpd/eigrpd.conf.sample pimd/pimd.conf.sample pbrd/pbrd.conf.sample
> > > > staticd/staticd.conf.sample bfdd/bfdd.conf.sample
> > > > vtysh/vtysh.conf.sample
> > > > '/home/hthiery/sources/mainline/buildroot/output/targetno'
> > > >
> > > >
> > > > I cannot see how it is possible to properly disable the install of
> > > > examples. I see that you already have set the option
> > > > --disable-exampledir. But this seems not to be enought, or it is
> > > > broken.
> > >
> > > Wow! Nice catch, I did not realize this, so there are like at least 2 options ?
> > > 1) remove it in hook
> > > 2) patch the frr build scripts (which looks like more safer?)
> >
> > I think reporting that upstream and patching would be the best solution.
> >
> Hm, problem is that this --enable-exampledir is used as bool option to specify
> alternative path for installing config samples, and because I set it
> to "--disable-exampledir"
> then this value is set to "no" and eventually is appended to DESTDIR
> which is $(TARGET_DIR),
> which is evaluated to .../targetno.
>
> But is this a problem if config samples will be installed to
> $(TARGET_DIR)/etc/frr (which is default
> if to remove --disable-exampledir) ?

Actually I can remove them in POST_INSTALL hook )

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-02-25 15:38 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-25  2:58 [Buildroot] [PATCH v2 0/2] add frr package Vadim Kochan
2020-02-25  2:58 ` [Buildroot] [PATCH v2 1/2] package/libyang: enable LYD_PRIV option for " Vadim Kochan
2020-02-25  8:06   ` Thomas Petazzoni
2020-02-25  2:58 ` [Buildroot] [PATCH v2 2/2] package/frr: new package Vadim Kochan
2020-02-25  8:25   ` Heiko Thiery
2020-02-25 11:47     ` Vadim Kochan
2020-02-25 10:13   ` Heiko Thiery
2020-02-25 11:46     ` Vadim Kochan
2020-02-25 12:39       ` Heiko Thiery
2020-02-25 15:37         ` Vadim Kochan
2020-02-25 15:38           ` Vadim Kochan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.