All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Thiery <heiko.thiery@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs
Date: Thu, 24 Feb 2022 13:10:52 +0100	[thread overview]
Message-ID: <CAEyMn7ZqypVn14dEa8eWWuUthRqwHqXg35X6hhFE9v7vRkCTxA@mail.gmail.com> (raw)
In-Reply-To: <20220224103030.2040048-1-michael@walle.cc>

HI,

Am Do., 24. Feb. 2022 um 11:30 Uhr schrieb Michael Walle <michael@walle.cc>:
>
> Use the power signal names as given in the schematics of the reference
> board.
>
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Heiko Thiery <heiko.thiery@gmail.com>

> ---
> Changes since v1:
>  - swap buck1 and buck2
>
>  arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> index b4225cfcb6d9..2b685c0c7eeb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> @@ -41,7 +41,7 @@ pmic: pmic@25 {
>
>                 regulators {
>                         buck1: BUCK1{
> -                               regulator-name = "BUCK1";
> +                               regulator-name = "VDD_SOC";
>                                 regulator-min-microvolt = <600000>;
>                                 regulator-max-microvolt = <2187500>;
>                                 regulator-boot-on;
> @@ -50,7 +50,7 @@ buck1: BUCK1{
>                         };
>
>                         buck2: BUCK2 {
> -                               regulator-name = "BUCK2";
> +                               regulator-name = "VDD_ARM_0V9";
>                                 regulator-min-microvolt = <600000>;
>                                 regulator-max-microvolt = <2187500>;
>                                 regulator-boot-on;
> @@ -61,7 +61,7 @@ buck2: BUCK2 {
>                         };
>
>                         buck4: BUCK4{
> -                               regulator-name = "BUCK4";
> +                               regulator-name = "VDD_3V3";
>                                 regulator-min-microvolt = <600000>;
>                                 regulator-max-microvolt = <3400000>;
>                                 regulator-boot-on;
> @@ -69,7 +69,7 @@ buck4: BUCK4{
>                         };
>
>                         buck5: BUCK5{
> -                               regulator-name = "BUCK5";
> +                               regulator-name = "VDD_1V8";
>                                 regulator-min-microvolt = <600000>;
>                                 regulator-max-microvolt = <3400000>;
>                                 regulator-boot-on;
> @@ -77,7 +77,7 @@ buck5: BUCK5{
>                         };
>
>                         buck6: BUCK6 {
> -                               regulator-name = "BUCK6";
> +                               regulator-name = "NVCC_DRAM_1V1";
>                                 regulator-min-microvolt = <600000>;
>                                 regulator-max-microvolt = <3400000>;
>                                 regulator-boot-on;
> @@ -85,7 +85,7 @@ buck6: BUCK6 {
>                         };
>
>                         ldo1: LDO1 {
> -                               regulator-name = "LDO1";
> +                               regulator-name = "NVCC_SNVS_1V8";
>                                 regulator-min-microvolt = <1600000>;
>                                 regulator-max-microvolt = <3300000>;
>                                 regulator-boot-on;
> @@ -93,7 +93,7 @@ ldo1: LDO1 {
>                         };
>
>                         ldo2: LDO2 {
> -                               regulator-name = "LDO2";
> +                               regulator-name = "VDD_SNVS_0V8";
>                                 regulator-min-microvolt = <800000>;
>                                 regulator-max-microvolt = <1150000>;
>                                 regulator-boot-on;
> @@ -101,7 +101,7 @@ ldo2: LDO2 {
>                         };
>
>                         ldo3: LDO3 {
> -                               regulator-name = "LDO3";
> +                               regulator-name = "VDDA_1V8";
>                                 regulator-min-microvolt = <800000>;
>                                 regulator-max-microvolt = <3300000>;
>                                 regulator-boot-on;
> @@ -109,7 +109,7 @@ ldo3: LDO3 {
>                         };
>
>                         ldo4: LDO4 {
> -                               regulator-name = "LDO4";
> +                               regulator-name = "VDD_PHY_1V2";
>                                 regulator-min-microvolt = <800000>;
>                                 regulator-max-microvolt = <3300000>;
>                                 regulator-boot-on;
> @@ -117,7 +117,7 @@ ldo4: LDO4 {
>                         };
>
>                         ldo5: LDO5 {
> -                               regulator-name = "LDO5";
> +                               regulator-name = "NVCC_SD2";
>                                 regulator-min-microvolt = <1800000>;
>                                 regulator-max-microvolt = <3300000>;
>                                 regulator-boot-on;
> --
> 2.30.2
>

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Thiery <heiko.thiery@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	 Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,  Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs
Date: Thu, 24 Feb 2022 13:10:52 +0100	[thread overview]
Message-ID: <CAEyMn7ZqypVn14dEa8eWWuUthRqwHqXg35X6hhFE9v7vRkCTxA@mail.gmail.com> (raw)
In-Reply-To: <20220224103030.2040048-1-michael@walle.cc>

HI,

Am Do., 24. Feb. 2022 um 11:30 Uhr schrieb Michael Walle <michael@walle.cc>:
>
> Use the power signal names as given in the schematics of the reference
> board.
>
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Heiko Thiery <heiko.thiery@gmail.com>

> ---
> Changes since v1:
>  - swap buck1 and buck2
>
>  arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> index b4225cfcb6d9..2b685c0c7eeb 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> @@ -41,7 +41,7 @@ pmic: pmic@25 {
>
>                 regulators {
>                         buck1: BUCK1{
> -                               regulator-name = "BUCK1";
> +                               regulator-name = "VDD_SOC";
>                                 regulator-min-microvolt = <600000>;
>                                 regulator-max-microvolt = <2187500>;
>                                 regulator-boot-on;
> @@ -50,7 +50,7 @@ buck1: BUCK1{
>                         };
>
>                         buck2: BUCK2 {
> -                               regulator-name = "BUCK2";
> +                               regulator-name = "VDD_ARM_0V9";
>                                 regulator-min-microvolt = <600000>;
>                                 regulator-max-microvolt = <2187500>;
>                                 regulator-boot-on;
> @@ -61,7 +61,7 @@ buck2: BUCK2 {
>                         };
>
>                         buck4: BUCK4{
> -                               regulator-name = "BUCK4";
> +                               regulator-name = "VDD_3V3";
>                                 regulator-min-microvolt = <600000>;
>                                 regulator-max-microvolt = <3400000>;
>                                 regulator-boot-on;
> @@ -69,7 +69,7 @@ buck4: BUCK4{
>                         };
>
>                         buck5: BUCK5{
> -                               regulator-name = "BUCK5";
> +                               regulator-name = "VDD_1V8";
>                                 regulator-min-microvolt = <600000>;
>                                 regulator-max-microvolt = <3400000>;
>                                 regulator-boot-on;
> @@ -77,7 +77,7 @@ buck5: BUCK5{
>                         };
>
>                         buck6: BUCK6 {
> -                               regulator-name = "BUCK6";
> +                               regulator-name = "NVCC_DRAM_1V1";
>                                 regulator-min-microvolt = <600000>;
>                                 regulator-max-microvolt = <3400000>;
>                                 regulator-boot-on;
> @@ -85,7 +85,7 @@ buck6: BUCK6 {
>                         };
>
>                         ldo1: LDO1 {
> -                               regulator-name = "LDO1";
> +                               regulator-name = "NVCC_SNVS_1V8";
>                                 regulator-min-microvolt = <1600000>;
>                                 regulator-max-microvolt = <3300000>;
>                                 regulator-boot-on;
> @@ -93,7 +93,7 @@ ldo1: LDO1 {
>                         };
>
>                         ldo2: LDO2 {
> -                               regulator-name = "LDO2";
> +                               regulator-name = "VDD_SNVS_0V8";
>                                 regulator-min-microvolt = <800000>;
>                                 regulator-max-microvolt = <1150000>;
>                                 regulator-boot-on;
> @@ -101,7 +101,7 @@ ldo2: LDO2 {
>                         };
>
>                         ldo3: LDO3 {
> -                               regulator-name = "LDO3";
> +                               regulator-name = "VDDA_1V8";
>                                 regulator-min-microvolt = <800000>;
>                                 regulator-max-microvolt = <3300000>;
>                                 regulator-boot-on;
> @@ -109,7 +109,7 @@ ldo3: LDO3 {
>                         };
>
>                         ldo4: LDO4 {
> -                               regulator-name = "LDO4";
> +                               regulator-name = "VDD_PHY_1V2";
>                                 regulator-min-microvolt = <800000>;
>                                 regulator-max-microvolt = <3300000>;
>                                 regulator-boot-on;
> @@ -117,7 +117,7 @@ ldo4: LDO4 {
>                         };
>
>                         ldo5: LDO5 {
> -                               regulator-name = "LDO5";
> +                               regulator-name = "NVCC_SD2";
>                                 regulator-min-microvolt = <1800000>;
>                                 regulator-max-microvolt = <3300000>;
>                                 regulator-boot-on;
> --
> 2.30.2
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-02-24 12:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 10:30 [PATCH v2 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Michael Walle
2022-02-24 10:30 ` Michael Walle
2022-02-24 10:30 ` [PATCH v2 2/2] arm64: dts: imx8mn-evk: fix the min/max voltages of the PMIC Michael Walle
2022-02-24 10:30   ` Michael Walle
2022-02-24 12:09   ` Heiko Thiery
2022-02-24 12:09     ` Heiko Thiery
2022-02-24 12:10 ` Heiko Thiery [this message]
2022-02-24 12:10   ` [PATCH v2 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Heiko Thiery
2022-02-26 12:58 ` Fabio Estevam
2022-02-26 12:58   ` Fabio Estevam
2022-03-14  7:30 ` Michael Walle
2022-03-14  7:30   ` Michael Walle
2022-04-06 13:20 ` Shawn Guo
2022-04-06 13:20   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEyMn7ZqypVn14dEa8eWWuUthRqwHqXg35X6hhFE9v7vRkCTxA@mail.gmail.com \
    --to=heiko.thiery@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.