All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Thiery <heiko.thiery@gmail.com>
To: Wolfgang Denk <wd@denx.de>
Cc: u-boot@lists.denx.de, Stefano Babic <sbabic@denx.de>,
	 Fabio Estevam <festevam@gmail.com>,
	Michael Walle <michael@walle.cc>, Simon Glass <sjg@chromium.org>
Subject: Re: [RFC 0/2] Do not stop with an error when mkimage fails
Date: Thu, 11 Nov 2021 14:54:19 +0100	[thread overview]
Message-ID: <CAEyMn7b4eM2P+tkHuiFxp2V0aoVBBYfhHc24Gdq5D5D3qPQEyA@mail.gmail.com> (raw)
In-Reply-To: <1288986.1636633445@gemini.denx.de>

Hi Wolfgang,

Am Do., 11. Nov. 2021 um 13:24 Uhr schrieb Wolfgang Denk <wd@denx.de>:
>
> Dear Heiko,
>
> In message <CAEyMn7Y7t63GwPLNd-CSZiHanE_UmpOReYS1cFAz8sq0M=EYmA@mail.gmail.com> you wrote:
> >
> > > Sorry, but this makes no sense to me.  If there is an error, it
> > > should be reported and - if possible - handled.  If this is not
> > > possible, then the correct thing is to abort.  Ignoring errors and
> > > trying to continue is always the worst thing to do.
> >
> > The only reason I want to introduce this is because I want to have my
> > imx8mq board built by CI. This board needs an external HDMI firmware
> > which is used by mkimage. But because this firmware is not available
> > in the CI build, it comes to the abort. With other boards it is also
> > so that in the CI external blobs are not available and these make
> > nevertheless without error a binman run. In this case only a warning
> > is output.
> >
> > I know this is not a perfect solution but I don't know how to get my
> > board merged without doing this kind of workaround for the U-Boot CI.
>
> It's not only not a perfect solution, it is the intentional
> introduction of a bug, and thus totally unacceptable.
>
> If there is a file missing in the CI, then add/create it there.
>
> But do remove necessary error handling which would cause hard to
> detec failures when for normal use.

I understand your attitude and am meanwhile also of this opinion. The
idea with the creation of dummy files I also had. I think we should go
in this direction. Everything else would probably be connected with
bigger changes.

-- 
Heiko

      reply	other threads:[~2021-11-11 13:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04 18:52 [RFC 0/2] Do not stop with an error when mkimage fails Heiko Thiery
2021-11-04 18:52 ` [RFC 1/2] patman: introduce RunException Heiko Thiery
2021-11-05  2:02   ` Simon Glass
2021-11-04 18:52 ` [RFC 2/2] binman: catch RunException for mkimage runtime failure Heiko Thiery
2021-11-05  2:02   ` Simon Glass
2021-11-05  7:49     ` Heiko Thiery
2021-11-05 16:12       ` Simon Glass
2021-11-04 19:12 ` [RFC 0/2] Do not stop with an error when mkimage fails Wolfgang Denk
2021-11-04 19:31   ` Heiko Thiery
2021-11-07 14:48     ` Wolfgang Denk
2021-11-09 19:21       ` Heiko Thiery
2021-11-09 19:42         ` Tom Rini
2021-11-10  0:18           ` Rasmus Villemoes
2021-11-10  0:26             ` Rasmus Villemoes
2021-11-10  1:37               ` Tom Rini
2021-11-10  8:28                 ` Michael Walle
2021-11-10 16:31                   ` Simon Glass
2021-11-11 12:29               ` Wolfgang Denk
2021-11-10  0:58           ` Simon Glass
2021-11-11 12:27           ` Wolfgang Denk
2021-11-11 15:04             ` Tom Rini
2021-11-11 12:24         ` Wolfgang Denk
2021-11-11 13:54           ` Heiko Thiery [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEyMn7b4eM2P+tkHuiFxp2V0aoVBBYfhHc24Gdq5D5D3qPQEyA@mail.gmail.com \
    --to=heiko.thiery@gmail.com \
    --cc=festevam@gmail.com \
    --cc=michael@walle.cc \
    --cc=sbabic@denx.de \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.