All of lore.kernel.org
 help / color / mirror / Atom feed
* Bug fix for ata.c
@ 2012-04-16 19:24 Bean
  2012-04-18 21:21 ` Vladimir 'φ-coder/phcoder' Serbinenko
  2012-04-20 20:52 ` Phillip Susi
  0 siblings, 2 replies; 3+ messages in thread
From: Bean @ 2012-04-16 19:24 UTC (permalink / raw)
  To: The development of GRUB 2

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Hi everyone,

This is a bug in the grub_ata_strncpy function. (main trunk r4220)

-- 
Bean

[-- Attachment #2: ata.diff --]
[-- Type: application/octet-stream, Size: 296 bytes --]

=== modified file 'grub-core/disk/ata.c'
--- grub-core/disk/ata.c	2012-01-30 11:26:11 +0000
+++ grub-core/disk/ata.c	2012-04-16 19:15:05 +0000
@@ -35,7 +35,7 @@
 
   for (i = 0; i < len / 2; i++)
     *(dst16++) = grub_be_to_cpu16 (*(src16++));
-  dst16[i] = 0;
+  *dst16 = 0;
 }
 
 static void


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bug fix for ata.c
  2012-04-16 19:24 Bug fix for ata.c Bean
@ 2012-04-18 21:21 ` Vladimir 'φ-coder/phcoder' Serbinenko
  2012-04-20 20:52 ` Phillip Susi
  1 sibling, 0 replies; 3+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2012-04-18 21:21 UTC (permalink / raw)
  To: grub-devel

[-- Attachment #1: Type: text/plain, Size: 95 bytes --]

Welcome back.
Committed, thanks.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bug fix for ata.c
  2012-04-16 19:24 Bug fix for ata.c Bean
  2012-04-18 21:21 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2012-04-20 20:52 ` Phillip Susi
  1 sibling, 0 replies; 3+ messages in thread
From: Phillip Susi @ 2012-04-20 20:52 UTC (permalink / raw)
  To: The development of GNU GRUB; +Cc: Bean

Your mail client appears to be buggy:  it doesn't specify a User-Agent: 
header identifying what it is, and it set the mime type for the patch to 
application/octet-stream, causing it to be treated as a binary file and 
not viewable with the email.

On 4/16/2012 3:24 PM, Bean wrote:
> Hi everyone,
>
> This is a bug in the grub_ata_strncpy function. (main trunk r4220)
>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-20 20:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-16 19:24 Bug fix for ata.c Bean
2012-04-18 21:21 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-04-20 20:52 ` Phillip Susi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.