* [PATCH] runqemu/mips: adjust runqemu script to support mipsel machine
@ 2012-07-11 7:05 Dennis Lan
2012-07-12 3:08 ` Dennis.Yxun
0 siblings, 1 reply; 4+ messages in thread
From: Dennis Lan @ 2012-07-11 7:05 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Dennis Lan <dennis.yxun@gmail.com>
---
scripts/runqemu | 5 ++++-
scripts/runqemu-internal | 9 +++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/scripts/runqemu b/scripts/runqemu
index 8d149a2..650d1df 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -94,7 +94,7 @@ KVM_ENABLED="no"
while true; do
arg=${1}
case "$arg" in
- "qemux86" | "qemux86-64" | "qemuarm" | "qemumips" | "qemumips64" | "qemush4" | "qemuppc")
+ "qemux86" | "qemux86-64" | "qemuarm" | "qemumips" | "qemumipsel" | "qemumips64" | "qemush4" | "qemuppc")
[ -z "$MACHINE" ] && MACHINE=$arg || \
error "conflicting MACHINE types [$MACHINE] and [$arg]"
;;
@@ -245,6 +245,9 @@ QEMUARM_DEFAULT_FSTYPE=ext3
QEMUMIPS_DEFAULT_KERNEL=vmlinux-qemumips.bin
QEMUMIPS_DEFAULT_FSTYPE=ext3
+QEMUMIPSEL_DEFAULT_KERNEL=vmlinux-qemumipsel.bin
+QEMUMIPSEL_DEFAULT_FSTYPE=ext3
+
QEMUMIPS64_DEFAULT_KERNEL=vmlinux-qemumips64.bin
QEMUMIPS64_DEFAULT_FSTYPE=ext3
diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
index 041464d..bdf1a37 100755
--- a/scripts/runqemu-internal
+++ b/scripts/runqemu-internal
@@ -236,6 +236,7 @@ fi
case "$MACHINE" in
"qemuarm") ;;
"qemumips") ;;
+ "qemumipsel") ;;
"qemumips64") ;;
"qemush4") ;;
"qemuppc") ;;
@@ -375,12 +376,8 @@ if [ "$MACHINE" = "spitz" ]; then
fi
fi
-if [ "$MACHINE" = "qemumips" -o "$MACHINE" = "qemumips64" ]; then
- if [ "$MACHINE" = "qemumips64" ]; then
- QEMU=qemu-system-mips64
- else
- QEMU=qemu-system-mips
- fi
+if [ "$MACHINE" = "qemumips" -o "$MACHINE" = "qemumipsel" -o "$MACHINE" = "qemumips64" ]; then
+ QEMU=${MACHINE/qemu/qemu-system-}
MACHINE_SUBTYPE=malta
QEMU_UI_OPTIONS="-vga cirrus $QEMU_UI_OPTIONS"
if [ "$FSTYPE" = "ext3" -o "$FSTYPE" = "btrfs" ]; then
--
1.7.9.rc2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] runqemu/mips: adjust runqemu script to support mipsel machine
2012-07-11 7:05 [PATCH] runqemu/mips: adjust runqemu script to support mipsel machine Dennis Lan
@ 2012-07-12 3:08 ` Dennis.Yxun
2012-07-12 9:46 ` Paul Eggleton
0 siblings, 1 reply; 4+ messages in thread
From: Dennis.Yxun @ 2012-07-12 3:08 UTC (permalink / raw)
To: openembedded-core
On Wed, Jul 11, 2012 at 3:05 PM, Dennis Lan <dennis.yxun@gmail.com> wrote:
> Signed-off-by: Dennis Lan <dennis.yxun@gmail.com>
> ---
> scripts/runqemu | 5 ++++-
> scripts/runqemu-internal | 9 +++------
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 8d149a2..650d1df 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -94,7 +94,7 @@ KVM_ENABLED="no"
> while true; do
> arg=${1}
> case "$arg" in
> - "qemux86" | "qemux86-64" | "qemuarm" | "qemumips" | "qemumips64" | "qemush4" | "qemuppc")
> + "qemux86" | "qemux86-64" | "qemuarm" | "qemumips" | "qemumipsel" | "qemumips64" | "qemush4" | "qemuppc")
> [ -z "$MACHINE" ] && MACHINE=$arg || \
> error "conflicting MACHINE types [$MACHINE] and [$arg]"
> ;;
> @@ -245,6 +245,9 @@ QEMUARM_DEFAULT_FSTYPE=ext3
> QEMUMIPS_DEFAULT_KERNEL=vmlinux-qemumips.bin
> QEMUMIPS_DEFAULT_FSTYPE=ext3
>
> +QEMUMIPSEL_DEFAULT_KERNEL=vmlinux-qemumipsel.bin
> +QEMUMIPSEL_DEFAULT_FSTYPE=ext3
> +
> QEMUMIPS64_DEFAULT_KERNEL=vmlinux-qemumips64.bin
> QEMUMIPS64_DEFAULT_FSTYPE=ext3
>
> diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
> index 041464d..bdf1a37 100755
> --- a/scripts/runqemu-internal
> +++ b/scripts/runqemu-internal
> @@ -236,6 +236,7 @@ fi
> case "$MACHINE" in
> "qemuarm") ;;
> "qemumips") ;;
> + "qemumipsel") ;;
> "qemumips64") ;;
> "qemush4") ;;
> "qemuppc") ;;
> @@ -375,12 +376,8 @@ if [ "$MACHINE" = "spitz" ]; then
> fi
> fi
>
> -if [ "$MACHINE" = "qemumips" -o "$MACHINE" = "qemumips64" ]; then
> - if [ "$MACHINE" = "qemumips64" ]; then
> - QEMU=qemu-system-mips64
> - else
> - QEMU=qemu-system-mips
> - fi
> +if [ "$MACHINE" = "qemumips" -o "$MACHINE" = "qemumipsel" -o "$MACHINE" = "qemumips64" ]; then
> + QEMU=${MACHINE/qemu/qemu-system-}
> MACHINE_SUBTYPE=malta
> QEMU_UI_OPTIONS="-vga cirrus $QEMU_UI_OPTIONS"
> if [ "$FSTYPE" = "ext3" -o "$FSTYPE" = "btrfs" ]; then
> --
> 1.7.9.rc2
>
hi all:
any comment? suggestion or rejection?
Dennis
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] runqemu/mips: adjust runqemu script to support mipsel machine
2012-07-12 3:08 ` Dennis.Yxun
@ 2012-07-12 9:46 ` Paul Eggleton
2012-07-12 10:00 ` Dennis.Yxun
0 siblings, 1 reply; 4+ messages in thread
From: Paul Eggleton @ 2012-07-12 9:46 UTC (permalink / raw)
To: Dennis.Yxun; +Cc: openembedded-core
On Thursday 12 July 2012 11:08:40 Dennis.Yxun wrote:
> On Wed, Jul 11, 2012 at 3:05 PM, Dennis Lan <dennis.yxun@gmail.com> wrote:
> > -if [ "$MACHINE" = "qemumips" -o "$MACHINE" = "qemumips64" ]; then
> > - if [ "$MACHINE" = "qemumips64" ]; then
> > - QEMU=qemu-system-mips64
> > - else
> > - QEMU=qemu-system-mips
> > - fi
> > +if [ "$MACHINE" = "qemumips" -o "$MACHINE" = "qemumipsel" -o "$MACHINE" = "qemumips64" ]; then
> > + QEMU=${MACHINE/qemu/qemu-system-}
Unfortunately substitution like this is a bashism (i.e. does not work in
purely POSIX-compliant shells such as dash). Can you rework this?
Thanks,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] runqemu/mips: adjust runqemu script to support mipsel machine
2012-07-12 9:46 ` Paul Eggleton
@ 2012-07-12 10:00 ` Dennis.Yxun
0 siblings, 0 replies; 4+ messages in thread
From: Dennis.Yxun @ 2012-07-12 10:00 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On Thu, Jul 12, 2012 at 5:46 PM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Thursday 12 July 2012 11:08:40 Dennis.Yxun wrote:
>> On Wed, Jul 11, 2012 at 3:05 PM, Dennis Lan <dennis.yxun@gmail.com> wrote:
>> > -if [ "$MACHINE" = "qemumips" -o "$MACHINE" = "qemumips64" ]; then
>> > - if [ "$MACHINE" = "qemumips64" ]; then
>> > - QEMU=qemu-system-mips64
>> > - else
>> > - QEMU=qemu-system-mips
>> > - fi
>> > +if [ "$MACHINE" = "qemumips" -o "$MACHINE" = "qemumipsel" -o "$MACHINE" = "qemumips64" ]; then
>> > + QEMU=${MACHINE/qemu/qemu-system-}
>
> Unfortunately substitution like this is a bashism (i.e. does not work in
> purely POSIX-compliant shells such as dash). Can you rework this?
>
> Thanks,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
re-sent with patch v2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-12 10:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-11 7:05 [PATCH] runqemu/mips: adjust runqemu script to support mipsel machine Dennis Lan
2012-07-12 3:08 ` Dennis.Yxun
2012-07-12 9:46 ` Paul Eggleton
2012-07-12 10:00 ` Dennis.Yxun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.