* [PATCH lttng-modules] Fix: Add kernel configuration for lttng clock plugin
@ 2016-07-22 7:46 Anders Wallin
0 siblings, 0 replies; 7+ messages in thread
From: Anders Wallin @ 2016-07-22 7:46 UTC (permalink / raw)
To: lttng-dev
Only one lttng clock plugin can be used when building the lttng-modules
in the kernel. To make it possible to use a custom clock plugin it must
be possible to unconfigure the test clock plugin
Signed-off-by: Anders Wallin <wallinux@gmail.com>
---
Kconfig | 2 ++
Makefile | 6 +++---
tests/Kbuild | 2 +-
tests/Kconfig | 6 ++++++
4 files changed, 12 insertions(+), 4 deletions(-)
create mode 100644 tests/Kconfig
diff --git a/Kconfig b/Kconfig
index 6b4ad68..c350b9b 100644
--- a/Kconfig
+++ b/Kconfig
@@ -10,3 +10,5 @@ config LTTNG
the Linux kernel image, choose Y.
If unsure, say N.
+
+source "lttng/tests/Kconfig"
diff --git a/Makefile b/Makefile
index c2b1213..8602649 100644
--- a/Makefile
+++ b/Makefile
@@ -107,15 +107,15 @@ CFLAGS = $(EXTCFLAGS)
default: modules
modules:
- $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules
+ $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules
modules_install:
- $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules_install
+ $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules_install
clean:
$(MAKE) -C $(KERNELDIR) M=$(PWD) clean
%.i: %.c
- $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m $@
+ $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m $@
endif # KERNELRELEASE
diff --git a/tests/Kbuild b/tests/Kbuild
index 5e49007..aabb8e2 100644
--- a/tests/Kbuild
+++ b/tests/Kbuild
@@ -7,7 +7,7 @@ ccflags-y += -I$(TOP_LTTNG_MODULES_DIR)
obj-$(CONFIG_LTTNG) += lttng-test.o
lttng-test-objs := probes/lttng-test.o
-obj-$(CONFIG_LTTNG) += lttng-clock-plugin-test.o
+obj-$(CONFIG_LTTNG_CLOCK_PLUGIN_TEST) += lttng-clock-plugin-test.o
lttng-clock-plugin-test-objs := clock-plugin/lttng-clock-plugin-test.o
# vim:syntax=make
diff --git a/tests/Kconfig b/tests/Kconfig
new file mode 100644
index 0000000..250791c
--- /dev/null
+++ b/tests/Kconfig
@@ -0,0 +1,6 @@
+config LTTNG_CLOCK_PLUGIN_TEST
+ tristate "Use Test plugin as trace clock"
+ depends on LTTNG
+ help
+ Use the Test clock as trace clock. This plugin freezes the
+ time with 1 KHz for regression test
--
2.9.2
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH lttng-modules] Fix: Add kernel configuration for lttng clock plugin
[not found] <20160722141047.29101-1-wallinux@gmail.com>
@ 2016-07-22 14:40 ` Mathieu Desnoyers
0 siblings, 0 replies; 7+ messages in thread
From: Mathieu Desnoyers @ 2016-07-22 14:40 UTC (permalink / raw)
To: Anders Wallin; +Cc: lttng-dev
Merged into lttng-modules master and stable-2.8, thanks!
Mathieu
----- On Jul 22, 2016, at 10:10 AM, Anders Wallin wallinux@gmail.com wrote:
> Only one lttng clock plugin can be used when building the lttng-modules
> in the kernel. To make it possible to use a custom clock plugin it must
> be possible to unconfigure the test clock plugin
>
> Signed-off-by: Anders Wallin <wallinux@gmail.com>
> ---
> Kconfig | 2 ++
> Makefile | 6 +++---
> tests/Kbuild | 2 +-
> tests/Kconfig | 8 ++++++++
> 4 files changed, 14 insertions(+), 4 deletions(-)
> create mode 100644 tests/Kconfig
>
> diff --git a/Kconfig b/Kconfig
> index 6b4ad68..c350b9b 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -10,3 +10,5 @@ config LTTNG
> the Linux kernel image, choose Y.
>
> If unsure, say N.
> +
> +source "lttng/tests/Kconfig"
> diff --git a/Makefile b/Makefile
> index c2b1213..8602649 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -107,15 +107,15 @@ CFLAGS = $(EXTCFLAGS)
> default: modules
>
> modules:
> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules
> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules
>
> modules_install:
> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules_install
> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules_install
>
> clean:
> $(MAKE) -C $(KERNELDIR) M=$(PWD) clean
>
> %.i: %.c
> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m $@
> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m $@
>
> endif # KERNELRELEASE
> diff --git a/tests/Kbuild b/tests/Kbuild
> index 5e49007..aabb8e2 100644
> --- a/tests/Kbuild
> +++ b/tests/Kbuild
> @@ -7,7 +7,7 @@ ccflags-y += -I$(TOP_LTTNG_MODULES_DIR)
> obj-$(CONFIG_LTTNG) += lttng-test.o
> lttng-test-objs := probes/lttng-test.o
>
> -obj-$(CONFIG_LTTNG) += lttng-clock-plugin-test.o
> +obj-$(CONFIG_LTTNG_CLOCK_PLUGIN_TEST) += lttng-clock-plugin-test.o
> lttng-clock-plugin-test-objs := clock-plugin/lttng-clock-plugin-test.o
>
> # vim:syntax=make
> diff --git a/tests/Kconfig b/tests/Kconfig
> new file mode 100644
> index 0000000..b1ab663
> --- /dev/null
> +++ b/tests/Kconfig
> @@ -0,0 +1,8 @@
> +config LTTNG_CLOCK_PLUGIN_TEST
> + tristate "Use Test plugin as trace clock"
> + depends on LTTNG
> + help
> + Use the test clock as trace clock. This plugin freezes the
> + time with 1 KHz for regression test.
> + It's recommended to build this as a module to work with the
> + lttng-tools test suite.
> --
> 2.9.2
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH lttng-modules] Fix: Add kernel configuration for lttng clock plugin
[not found] <CAF2baFcE=fs=8xGwNvjHqhR0_JYNHVYyKqEng-eakGv=E6mwyw@mail.gmail.com>
@ 2016-07-22 14:26 ` Mathieu Desnoyers
0 siblings, 0 replies; 7+ messages in thread
From: Mathieu Desnoyers @ 2016-07-22 14:26 UTC (permalink / raw)
To: Anders Wallin; +Cc: lttng-dev
----- On Jul 22, 2016, at 10:10 AM, Anders Wallin wallinux@gmail.com wrote:
> On Fri, Jul 22, 2016 at 2:40 PM, Mathieu Desnoyers
> <mathieu.desnoyers@efficios.com> wrote:
>>
>>
>> ----- On Jul 22, 2016, at 8:26 AM, Mathieu Desnoyers
>> mathieu.desnoyers@efficios.com wrote:
>>
>>> ----- On Jul 22, 2016, at 3:46 AM, Anders Wallin wallinux@gmail.com wrote:
>>>
>>>> Only one lttng clock plugin can be used when building the lttng-modules
>>>> in the kernel. To make it possible to use a custom clock plugin it must
>>>> be possible to unconfigure the test clock plugin
>>>
>>> Good idea. Same problem with tabs turned into spaces. Check your
>>> mail client and resubmit please.
>>>
>>> One more comment below,
>>
>> One more comment:
>>
>> If many clock plugins are built into the kernel, we could choose
>> which clock plugin we effectively use through a kernel boot cmd
>> line parameter, e.g. lttng_clock_plugin=test-clock
>
> I think that's an excellent idea, I can create a new patch for that
> but it's gonna be when I get back from vacation.
Great! Can you re-spin your two fixes with corrected tabs first ?
I'll then await your patch implementing the boot cmd line parameter
after you return from vacation.
Thanks!
Mathieu
>
>>
>> Thoughts ?
>>
>> Thanks,
>>
>> Mathieu
>>
>>>
>>>>
>>>> Signed-off-by: Anders Wallin <wallinux@gmail.com>
>>>> ---
>>>> Kconfig | 2 ++
>>>> Makefile | 6 +++---
>>>> tests/Kbuild | 2 +-
>>>> tests/Kconfig | 6 ++++++
>>>> 4 files changed, 12 insertions(+), 4 deletions(-)
>>>> create mode 100644 tests/Kconfig
>>>>
>>>> diff --git a/Kconfig b/Kconfig
>>>> index 6b4ad68..c350b9b 100644
>>>> --- a/Kconfig
>>>> +++ b/Kconfig
>>>> @@ -10,3 +10,5 @@ config LTTNG
>>>> the Linux kernel image, choose Y.
>>>>
>>>> If unsure, say N.
>>>> +
>>>> +source "lttng/tests/Kconfig"
>>>> diff --git a/Makefile b/Makefile
>>>> index c2b1213..8602649 100644
>>>> --- a/Makefile
>>>> +++ b/Makefile
>>>> @@ -107,15 +107,15 @@ CFLAGS = $(EXTCFLAGS)
>>>> default: modules
>>>>
>>>> modules:
>>>> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules
>>>> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
>>>> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules
>>>>
>>>> modules_install:
>>>> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules_install
>>>> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
>>>> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules_install
>>>>
>>>> clean:
>>>> $(MAKE) -C $(KERNELDIR) M=$(PWD) clean
>>>>
>>>> %.i: %.c
>>>> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m $@
>>>> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
>>>> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m $@
>>>>
>>>> endif # KERNELRELEASE
>>>> diff --git a/tests/Kbuild b/tests/Kbuild
>>>> index 5e49007..aabb8e2 100644
>>>> --- a/tests/Kbuild
>>>> +++ b/tests/Kbuild
>>>> @@ -7,7 +7,7 @@ ccflags-y += -I$(TOP_LTTNG_MODULES_DIR)
>>>> obj-$(CONFIG_LTTNG) += lttng-test.o
>>>> lttng-test-objs := probes/lttng-test.o
>>>>
>>>> -obj-$(CONFIG_LTTNG) += lttng-clock-plugin-test.o
>>>> +obj-$(CONFIG_LTTNG_CLOCK_PLUGIN_TEST) += lttng-clock-plugin-test.o
>>>> lttng-clock-plugin-test-objs := clock-plugin/lttng-clock-plugin-test.o
>>>>
>>>> # vim:syntax=make
>>>> diff --git a/tests/Kconfig b/tests/Kconfig
>>>> new file mode 100644
>>>> index 0000000..250791c
>>>> --- /dev/null
>>>> +++ b/tests/Kconfig
>>>> @@ -0,0 +1,6 @@
>>>> +config LTTNG_CLOCK_PLUGIN_TEST
>>>> + tristate "Use Test plugin as trace clock"
>>>> + depends on LTTNG
>>>> + help
>>>> + Use the Test clock as trace clock. This plugin freezes the
>>>
>>> Test -> test
>>>
>>>> + time with 1 KHz for regression test
>>>
>>> Add "." at the end of sentence.
>>>
>>> We could also recommend to build it as a module in this help text, since
>>> this is what is expected by the lttng-tools test suite.
>>>
>>> Thanks,
>>>
>>> Mathieu
>>>
>>>>
>>>> --
>>>> 2.9.2
>>>> _______________________________________________
>>>> lttng-dev mailing list
>>>> lttng-dev@lists.lttng.org
>>>> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>>>
>>> --
>>> Mathieu Desnoyers
>>> EfficiOS Inc.
>>> http://www.efficios.com
>>> _______________________________________________
>>> lttng-dev mailing list
>>> lttng-dev@lists.lttng.org
>>> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>>
>> --
>> Mathieu Desnoyers
>> EfficiOS Inc.
> > http://www.efficios.com
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH lttng-modules] Fix: Add kernel configuration for lttng clock plugin
@ 2016-07-22 14:10 Anders Wallin
0 siblings, 0 replies; 7+ messages in thread
From: Anders Wallin @ 2016-07-22 14:10 UTC (permalink / raw)
To: lttng-dev
Only one lttng clock plugin can be used when building the lttng-modules
in the kernel. To make it possible to use a custom clock plugin it must
be possible to unconfigure the test clock plugin
Signed-off-by: Anders Wallin <wallinux@gmail.com>
---
Kconfig | 2 ++
Makefile | 6 +++---
tests/Kbuild | 2 +-
tests/Kconfig | 8 ++++++++
4 files changed, 14 insertions(+), 4 deletions(-)
create mode 100644 tests/Kconfig
diff --git a/Kconfig b/Kconfig
index 6b4ad68..c350b9b 100644
--- a/Kconfig
+++ b/Kconfig
@@ -10,3 +10,5 @@ config LTTNG
the Linux kernel image, choose Y.
If unsure, say N.
+
+source "lttng/tests/Kconfig"
diff --git a/Makefile b/Makefile
index c2b1213..8602649 100644
--- a/Makefile
+++ b/Makefile
@@ -107,15 +107,15 @@ CFLAGS = $(EXTCFLAGS)
default: modules
modules:
- $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules
+ $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules
modules_install:
- $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules_install
+ $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules_install
clean:
$(MAKE) -C $(KERNELDIR) M=$(PWD) clean
%.i: %.c
- $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m $@
+ $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m $@
endif # KERNELRELEASE
diff --git a/tests/Kbuild b/tests/Kbuild
index 5e49007..aabb8e2 100644
--- a/tests/Kbuild
+++ b/tests/Kbuild
@@ -7,7 +7,7 @@ ccflags-y += -I$(TOP_LTTNG_MODULES_DIR)
obj-$(CONFIG_LTTNG) += lttng-test.o
lttng-test-objs := probes/lttng-test.o
-obj-$(CONFIG_LTTNG) += lttng-clock-plugin-test.o
+obj-$(CONFIG_LTTNG_CLOCK_PLUGIN_TEST) += lttng-clock-plugin-test.o
lttng-clock-plugin-test-objs := clock-plugin/lttng-clock-plugin-test.o
# vim:syntax=make
diff --git a/tests/Kconfig b/tests/Kconfig
new file mode 100644
index 0000000..b1ab663
--- /dev/null
+++ b/tests/Kconfig
@@ -0,0 +1,8 @@
+config LTTNG_CLOCK_PLUGIN_TEST
+ tristate "Use Test plugin as trace clock"
+ depends on LTTNG
+ help
+ Use the test clock as trace clock. This plugin freezes the
+ time with 1 KHz for regression test.
+ It's recommended to build this as a module to work with the
+ lttng-tools test suite.
--
2.9.2
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH lttng-modules] Fix: Add kernel configuration for lttng clock plugin
@ 2016-07-22 14:10 Anders Wallin
0 siblings, 0 replies; 7+ messages in thread
From: Anders Wallin @ 2016-07-22 14:10 UTC (permalink / raw)
To: Mathieu Desnoyers; +Cc: lttng-dev
On Fri, Jul 22, 2016 at 2:40 PM, Mathieu Desnoyers
<mathieu.desnoyers@efficios.com> wrote:
>
>
> ----- On Jul 22, 2016, at 8:26 AM, Mathieu Desnoyers mathieu.desnoyers@efficios.com wrote:
>
>> ----- On Jul 22, 2016, at 3:46 AM, Anders Wallin wallinux@gmail.com wrote:
>>
>>> Only one lttng clock plugin can be used when building the lttng-modules
>>> in the kernel. To make it possible to use a custom clock plugin it must
>>> be possible to unconfigure the test clock plugin
>>
>> Good idea. Same problem with tabs turned into spaces. Check your
>> mail client and resubmit please.
>>
>> One more comment below,
>
> One more comment:
>
> If many clock plugins are built into the kernel, we could choose
> which clock plugin we effectively use through a kernel boot cmd
> line parameter, e.g. lttng_clock_plugin=test-clock
I think that's an excellent idea, I can create a new patch for that
but it's gonna be when I get back from vacation.
>
> Thoughts ?
>
> Thanks,
>
> Mathieu
>
>>
>>>
>>> Signed-off-by: Anders Wallin <wallinux@gmail.com>
>>> ---
>>> Kconfig | 2 ++
>>> Makefile | 6 +++---
>>> tests/Kbuild | 2 +-
>>> tests/Kconfig | 6 ++++++
>>> 4 files changed, 12 insertions(+), 4 deletions(-)
>>> create mode 100644 tests/Kconfig
>>>
>>> diff --git a/Kconfig b/Kconfig
>>> index 6b4ad68..c350b9b 100644
>>> --- a/Kconfig
>>> +++ b/Kconfig
>>> @@ -10,3 +10,5 @@ config LTTNG
>>> the Linux kernel image, choose Y.
>>>
>>> If unsure, say N.
>>> +
>>> +source "lttng/tests/Kconfig"
>>> diff --git a/Makefile b/Makefile
>>> index c2b1213..8602649 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -107,15 +107,15 @@ CFLAGS = $(EXTCFLAGS)
>>> default: modules
>>>
>>> modules:
>>> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules
>>> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
>>> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules
>>>
>>> modules_install:
>>> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules_install
>>> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
>>> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules_install
>>>
>>> clean:
>>> $(MAKE) -C $(KERNELDIR) M=$(PWD) clean
>>>
>>> %.i: %.c
>>> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m $@
>>> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
>>> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m $@
>>>
>>> endif # KERNELRELEASE
>>> diff --git a/tests/Kbuild b/tests/Kbuild
>>> index 5e49007..aabb8e2 100644
>>> --- a/tests/Kbuild
>>> +++ b/tests/Kbuild
>>> @@ -7,7 +7,7 @@ ccflags-y += -I$(TOP_LTTNG_MODULES_DIR)
>>> obj-$(CONFIG_LTTNG) += lttng-test.o
>>> lttng-test-objs := probes/lttng-test.o
>>>
>>> -obj-$(CONFIG_LTTNG) += lttng-clock-plugin-test.o
>>> +obj-$(CONFIG_LTTNG_CLOCK_PLUGIN_TEST) += lttng-clock-plugin-test.o
>>> lttng-clock-plugin-test-objs := clock-plugin/lttng-clock-plugin-test.o
>>>
>>> # vim:syntax=make
>>> diff --git a/tests/Kconfig b/tests/Kconfig
>>> new file mode 100644
>>> index 0000000..250791c
>>> --- /dev/null
>>> +++ b/tests/Kconfig
>>> @@ -0,0 +1,6 @@
>>> +config LTTNG_CLOCK_PLUGIN_TEST
>>> + tristate "Use Test plugin as trace clock"
>>> + depends on LTTNG
>>> + help
>>> + Use the Test clock as trace clock. This plugin freezes the
>>
>> Test -> test
>>
>>> + time with 1 KHz for regression test
>>
>> Add "." at the end of sentence.
>>
>> We could also recommend to build it as a module in this help text, since
>> this is what is expected by the lttng-tools test suite.
>>
>> Thanks,
>>
>> Mathieu
>>
>>>
>>> --
>>> 2.9.2
>>> _______________________________________________
>>> lttng-dev mailing list
>>> lttng-dev@lists.lttng.org
>>> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>>
>> --
>> Mathieu Desnoyers
>> EfficiOS Inc.
>> http://www.efficios.com
>> _______________________________________________
>> lttng-dev mailing list
>> lttng-dev@lists.lttng.org
>> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH lttng-modules] Fix: Add kernel configuration for lttng clock plugin
[not found] ` <508726121.78252.1469190413029.JavaMail.zimbra@efficios.com>
@ 2016-07-22 12:40 ` Mathieu Desnoyers
0 siblings, 0 replies; 7+ messages in thread
From: Mathieu Desnoyers @ 2016-07-22 12:40 UTC (permalink / raw)
To: Anders Wallin; +Cc: lttng-dev
----- On Jul 22, 2016, at 8:26 AM, Mathieu Desnoyers mathieu.desnoyers@efficios.com wrote:
> ----- On Jul 22, 2016, at 3:46 AM, Anders Wallin wallinux@gmail.com wrote:
>
>> Only one lttng clock plugin can be used when building the lttng-modules
>> in the kernel. To make it possible to use a custom clock plugin it must
>> be possible to unconfigure the test clock plugin
>
> Good idea. Same problem with tabs turned into spaces. Check your
> mail client and resubmit please.
>
> One more comment below,
One more comment:
If many clock plugins are built into the kernel, we could choose
which clock plugin we effectively use through a kernel boot cmd
line parameter, e.g. lttng_clock_plugin=test-clock
Thoughts ?
Thanks,
Mathieu
>
>>
>> Signed-off-by: Anders Wallin <wallinux@gmail.com>
>> ---
>> Kconfig | 2 ++
>> Makefile | 6 +++---
>> tests/Kbuild | 2 +-
>> tests/Kconfig | 6 ++++++
>> 4 files changed, 12 insertions(+), 4 deletions(-)
>> create mode 100644 tests/Kconfig
>>
>> diff --git a/Kconfig b/Kconfig
>> index 6b4ad68..c350b9b 100644
>> --- a/Kconfig
>> +++ b/Kconfig
>> @@ -10,3 +10,5 @@ config LTTNG
>> the Linux kernel image, choose Y.
>>
>> If unsure, say N.
>> +
>> +source "lttng/tests/Kconfig"
>> diff --git a/Makefile b/Makefile
>> index c2b1213..8602649 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -107,15 +107,15 @@ CFLAGS = $(EXTCFLAGS)
>> default: modules
>>
>> modules:
>> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules
>> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
>> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules
>>
>> modules_install:
>> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules_install
>> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
>> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules_install
>>
>> clean:
>> $(MAKE) -C $(KERNELDIR) M=$(PWD) clean
>>
>> %.i: %.c
>> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m $@
>> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
>> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m $@
>>
>> endif # KERNELRELEASE
>> diff --git a/tests/Kbuild b/tests/Kbuild
>> index 5e49007..aabb8e2 100644
>> --- a/tests/Kbuild
>> +++ b/tests/Kbuild
>> @@ -7,7 +7,7 @@ ccflags-y += -I$(TOP_LTTNG_MODULES_DIR)
>> obj-$(CONFIG_LTTNG) += lttng-test.o
>> lttng-test-objs := probes/lttng-test.o
>>
>> -obj-$(CONFIG_LTTNG) += lttng-clock-plugin-test.o
>> +obj-$(CONFIG_LTTNG_CLOCK_PLUGIN_TEST) += lttng-clock-plugin-test.o
>> lttng-clock-plugin-test-objs := clock-plugin/lttng-clock-plugin-test.o
>>
>> # vim:syntax=make
>> diff --git a/tests/Kconfig b/tests/Kconfig
>> new file mode 100644
>> index 0000000..250791c
>> --- /dev/null
>> +++ b/tests/Kconfig
>> @@ -0,0 +1,6 @@
>> +config LTTNG_CLOCK_PLUGIN_TEST
>> + tristate "Use Test plugin as trace clock"
>> + depends on LTTNG
>> + help
>> + Use the Test clock as trace clock. This plugin freezes the
>
> Test -> test
>
>> + time with 1 KHz for regression test
>
> Add "." at the end of sentence.
>
> We could also recommend to build it as a module in this help text, since
> this is what is expected by the lttng-tools test suite.
>
> Thanks,
>
> Mathieu
>
>>
>> --
>> 2.9.2
>> _______________________________________________
>> lttng-dev mailing list
>> lttng-dev@lists.lttng.org
>> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH lttng-modules] Fix: Add kernel configuration for lttng clock plugin
[not found] <CAF2baFdgQy5JUFH3yJTMeS-xrNjBK-VTX1B7m0RNA4HwUB503Q@mail.gmail.com>
@ 2016-07-22 12:26 ` Mathieu Desnoyers
[not found] ` <508726121.78252.1469190413029.JavaMail.zimbra@efficios.com>
1 sibling, 0 replies; 7+ messages in thread
From: Mathieu Desnoyers @ 2016-07-22 12:26 UTC (permalink / raw)
To: Anders Wallin; +Cc: lttng-dev
----- On Jul 22, 2016, at 3:46 AM, Anders Wallin wallinux@gmail.com wrote:
> Only one lttng clock plugin can be used when building the lttng-modules
> in the kernel. To make it possible to use a custom clock plugin it must
> be possible to unconfigure the test clock plugin
Good idea. Same problem with tabs turned into spaces. Check your
mail client and resubmit please.
One more comment below,
>
> Signed-off-by: Anders Wallin <wallinux@gmail.com>
> ---
> Kconfig | 2 ++
> Makefile | 6 +++---
> tests/Kbuild | 2 +-
> tests/Kconfig | 6 ++++++
> 4 files changed, 12 insertions(+), 4 deletions(-)
> create mode 100644 tests/Kconfig
>
> diff --git a/Kconfig b/Kconfig
> index 6b4ad68..c350b9b 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -10,3 +10,5 @@ config LTTNG
> the Linux kernel image, choose Y.
>
> If unsure, say N.
> +
> +source "lttng/tests/Kconfig"
> diff --git a/Makefile b/Makefile
> index c2b1213..8602649 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -107,15 +107,15 @@ CFLAGS = $(EXTCFLAGS)
> default: modules
>
> modules:
> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules
> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules
>
> modules_install:
> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m modules_install
> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m modules_install
>
> clean:
> $(MAKE) -C $(KERNELDIR) M=$(PWD) clean
>
> %.i: %.c
> - $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m $@
> + $(MAKE) -C $(KERNELDIR) M=$(PWD) CONFIG_LTTNG=m
> CONFIG_LTTNG_CLOCK_PLUGIN_TEST=m $@
>
> endif # KERNELRELEASE
> diff --git a/tests/Kbuild b/tests/Kbuild
> index 5e49007..aabb8e2 100644
> --- a/tests/Kbuild
> +++ b/tests/Kbuild
> @@ -7,7 +7,7 @@ ccflags-y += -I$(TOP_LTTNG_MODULES_DIR)
> obj-$(CONFIG_LTTNG) += lttng-test.o
> lttng-test-objs := probes/lttng-test.o
>
> -obj-$(CONFIG_LTTNG) += lttng-clock-plugin-test.o
> +obj-$(CONFIG_LTTNG_CLOCK_PLUGIN_TEST) += lttng-clock-plugin-test.o
> lttng-clock-plugin-test-objs := clock-plugin/lttng-clock-plugin-test.o
>
> # vim:syntax=make
> diff --git a/tests/Kconfig b/tests/Kconfig
> new file mode 100644
> index 0000000..250791c
> --- /dev/null
> +++ b/tests/Kconfig
> @@ -0,0 +1,6 @@
> +config LTTNG_CLOCK_PLUGIN_TEST
> + tristate "Use Test plugin as trace clock"
> + depends on LTTNG
> + help
> + Use the Test clock as trace clock. This plugin freezes the
Test -> test
> + time with 1 KHz for regression test
Add "." at the end of sentence.
We could also recommend to build it as a module in this help text, since
this is what is expected by the lttng-tools test suite.
Thanks,
Mathieu
>
> --
> 2.9.2
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-07-22 14:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-22 7:46 [PATCH lttng-modules] Fix: Add kernel configuration for lttng clock plugin Anders Wallin
[not found] <CAF2baFdgQy5JUFH3yJTMeS-xrNjBK-VTX1B7m0RNA4HwUB503Q@mail.gmail.com>
2016-07-22 12:26 ` Mathieu Desnoyers
[not found] ` <508726121.78252.1469190413029.JavaMail.zimbra@efficios.com>
2016-07-22 12:40 ` Mathieu Desnoyers
2016-07-22 14:10 Anders Wallin
2016-07-22 14:10 Anders Wallin
[not found] <CAF2baFcE=fs=8xGwNvjHqhR0_JYNHVYyKqEng-eakGv=E6mwyw@mail.gmail.com>
2016-07-22 14:26 ` Mathieu Desnoyers
[not found] <20160722141047.29101-1-wallinux@gmail.com>
2016-07-22 14:40 ` Mathieu Desnoyers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.