All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Inki Dae <inki.dae@samsung.com>,
	airlied@linux.ie, sw0312.kim@samsung.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.
Date: Thu, 1 Sep 2011 20:08:14 -0500	[thread overview]
Message-ID: <CAF6AEGuSpsZ_LFWOk2fSR5=cqmFMf7iH+y_En5hpu+7iF4EecQ@mail.gmail.com> (raw)
In-Reply-To: <CAH9JG2Xh6oWOOg85KEf+Di4aVS4Zd_O3LfaWKZ1ig7A6pffgEA@mail.gmail.com>

On Thu, Sep 1, 2011 at 8:02 PM, Kyungmin Park <kmpark@infradead.org> wrote:
>>> Just thinking hypothetically.. what if some future device had two hdmi
>>> controllers.  Then you'd want two instances of the same display
>>> object.
>>>
>>> Although it seems this API is just internal to the DRM driver (which I
>>> had not realized earlier), so it should be pretty easy to change later
>>> if needed.
>>>
>>
>> You are right. I guess we should consider multiple instances to display
>> object because the Exynos hardware has two display controllers and also each
>> display controller needs one display panel with sharing same driver. thank
>> you for your pointing. :)
>
> Two HDMI and two FIMD is different. even though exynos4 supports the
> two display controller. it has only one HDMI port and now there's no
> device to use it. Of course if new device uses it. it will support it.
> I mena currently make it simple and make it TODO list.

yeah.. since it is just an API internal to the driver, and not
external (as I initially mistakenly thought), I don't think it is an
immediate issue.  It should be easy enough to change later if you, for
example, later had hw w/ two HDMI ports.

BR,
-R

> Thank you,
> Kyungmin Park

WARNING: multiple messages have this Message-ID (diff)
From: robdclark@gmail.com (Rob Clark)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.
Date: Thu, 1 Sep 2011 20:08:14 -0500	[thread overview]
Message-ID: <CAF6AEGuSpsZ_LFWOk2fSR5=cqmFMf7iH+y_En5hpu+7iF4EecQ@mail.gmail.com> (raw)
In-Reply-To: <CAH9JG2Xh6oWOOg85KEf+Di4aVS4Zd_O3LfaWKZ1ig7A6pffgEA@mail.gmail.com>

On Thu, Sep 1, 2011 at 8:02 PM, Kyungmin Park <kmpark@infradead.org> wrote:
>>> Just thinking hypothetically.. what if some future device had two hdmi
>>> controllers. ?Then you'd want two instances of the same display
>>> object.
>>>
>>> Although it seems this API is just internal to the DRM driver (which I
>>> had not realized earlier), so it should be pretty easy to change later
>>> if needed.
>>>
>>
>> You are right. I guess we should consider multiple instances to display
>> object because the Exynos hardware has two display controllers and also each
>> display controller needs one display panel with sharing same driver. thank
>> you for your pointing. :)
>
> Two HDMI and two FIMD is different. even though exynos4 supports the
> two display controller. it has only one HDMI port and now there's no
> device to use it. Of course if new device uses it. it will support it.
> I mena currently make it simple and make it TODO list.

yeah.. since it is just an API internal to the driver, and not
external (as I initially mistakenly thought), I don't think it is an
immediate issue.  It should be easy enough to change later if you, for
example, later had hw w/ two HDMI ports.

BR,
-R

> Thank you,
> Kyungmin Park

WARNING: multiple messages have this Message-ID (diff)
From: Rob Clark <robdclark@gmail.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: airlied@linux.ie, sw0312.kim@samsung.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Inki Dae <inki.dae@samsung.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210.
Date: Thu, 1 Sep 2011 20:08:14 -0500	[thread overview]
Message-ID: <CAF6AEGuSpsZ_LFWOk2fSR5=cqmFMf7iH+y_En5hpu+7iF4EecQ@mail.gmail.com> (raw)
In-Reply-To: <CAH9JG2Xh6oWOOg85KEf+Di4aVS4Zd_O3LfaWKZ1ig7A6pffgEA@mail.gmail.com>

On Thu, Sep 1, 2011 at 8:02 PM, Kyungmin Park <kmpark@infradead.org> wrote:
>>> Just thinking hypothetically.. what if some future device had two hdmi
>>> controllers.  Then you'd want two instances of the same display
>>> object.
>>>
>>> Although it seems this API is just internal to the DRM driver (which I
>>> had not realized earlier), so it should be pretty easy to change later
>>> if needed.
>>>
>>
>> You are right. I guess we should consider multiple instances to display
>> object because the Exynos hardware has two display controllers and also each
>> display controller needs one display panel with sharing same driver. thank
>> you for your pointing. :)
>
> Two HDMI and two FIMD is different. even though exynos4 supports the
> two display controller. it has only one HDMI port and now there's no
> device to use it. Of course if new device uses it. it will support it.
> I mena currently make it simple and make it TODO list.

yeah.. since it is just an API internal to the driver, and not
external (as I initially mistakenly thought), I don't think it is an
immediate issue.  It should be easy enough to change later if you, for
example, later had hw w/ two HDMI ports.

BR,
-R

> Thank you,
> Kyungmin Park

  reply	other threads:[~2011-09-02  1:08 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26 11:47 [RFC][PATCH v3] DRM: add DRM Driver for Samsung SoC EXYNOS4210 Inki Dae
2011-08-26 11:47 ` Inki Dae
2011-08-31  1:57 ` Rob Clark
2011-08-31  1:57   ` Rob Clark
2011-08-31  1:57   ` Rob Clark
2011-08-31  2:06   ` Konrad Rzeszutek Wilk
2011-08-31  2:06     ` Konrad Rzeszutek Wilk
2011-08-31  7:33     ` Inki Dae
2011-08-31  7:33       ` Inki Dae
2011-08-31  7:33       ` Inki Dae
2011-08-31  2:28   ` Joonyoung Shim
2011-08-31  2:28     ` Joonyoung Shim
2011-08-31  2:28     ` Joonyoung Shim
2011-08-31  6:51   ` Inki Dae
2011-08-31  6:51     ` Inki Dae
2011-08-31  6:51     ` Inki Dae
2011-08-31 16:02     ` Rob Clark
2011-08-31 16:02       ` Rob Clark
2011-09-01 13:06       ` Inki Dae
2011-09-01 13:06         ` Inki Dae
2011-09-01 13:06         ` Inki Dae
2011-09-02  1:02         ` Kyungmin Park
2011-09-02  1:02           ` Kyungmin Park
2011-09-02  1:02           ` Kyungmin Park
2011-09-02  1:08           ` Rob Clark [this message]
2011-09-02  1:08             ` Rob Clark
2011-09-02  1:08             ` Rob Clark
2011-09-02  1:18         ` Rob Clark
2011-09-02  1:18           ` Rob Clark
2011-09-02  1:18           ` Rob Clark
2011-09-02 12:00           ` Inki Dae
2011-09-02 12:00             ` Inki Dae
2011-09-02 12:00             ` Inki Dae
2011-08-31  8:38 ` Thomas Hellstrom
2011-08-31  8:38   ` Thomas Hellstrom
2011-09-01  3:57   ` Inki Dae
2011-09-01  3:57     ` Inki Dae
2011-09-01  3:57     ` Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF6AEGuSpsZ_LFWOk2fSR5=cqmFMf7iH+y_En5hpu+7iF4EecQ@mail.gmail.com' \
    --to=robdclark@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=kmpark@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.