All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Rob Clark <robclark@freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 5/6] freedreno: set automake options to include subdir-objects
Date: Fri, 30 Aug 2013 11:19:10 -0400	[thread overview]
Message-ID: <CAF6AEGvaAq0yKEtRm-7enPJ1=Rwt_J4FA09nF9DhhLE3PM=8UA@mail.gmail.com> (raw)
In-Reply-To: <1377808314-30699-6-git-send-email-emil.l.velikov@gmail.com>

On Thu, Aug 29, 2013 at 4:31 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> Handles automake complains about lack of forward-compatibility, due to the
> source files in the kgsl and msm backends/folders.
>
> Cc: Rob Clark <robclark@freedesktop.org>
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>

I've tested these two (this and 4/6).. they seem to work fine for me,
although I won't claim to be an automake guru, so couldn't actually
tell you if they are the "right" fixes.  I wouldn't mind a reviewed-by
from someone who does know automake better, but if no one speaks up
and says otherwise, I will apply/push them.

BR,
-R

> ---
>
> I'm suspecting that the warning is caused as Archlinux always keeps track
> with latest releases, whereas other distributions prefer to use a more
> tested software
>
> automake 1.14
> autoconf 2.69
> ---
>
>  freedreno/Makefile.am | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/freedreno/Makefile.am b/freedreno/Makefile.am
> index ec7e359..7903e5b 100644
> --- a/freedreno/Makefile.am
> +++ b/freedreno/Makefile.am
> @@ -1,3 +1,5 @@
> +AUTOMAKE_OPTIONS=subdir-objects
> +
>  AM_CFLAGS = \
>         $(WARN_CFLAGS) \
>         -I$(top_srcdir) \
> --
> 1.8.4
>

  reply	other threads:[~2013-08-30 15:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1377808314-30699-1-git-send-email-emil.l.velikov@gmail.com>
2013-08-29 20:31 ` [PATCH 1/6] tests/drmstat: remove the test Emil Velikov
2013-08-29 20:31 ` [PATCH 2/6] tests/*version: add missing string.h header Emil Velikov
2013-08-30 15:23   ` Rob Clark
2013-08-29 20:31 ` [PATCH 3/6] tests/modetest: silence compiler warning about uninitialised variables Emil Velikov
2013-08-30 15:21   ` Rob Clark
2013-08-29 20:31 ` [PATCH 4/6] freedreno: use local drm.h over the system one Emil Velikov
2013-08-29 20:31 ` [PATCH 5/6] freedreno: set automake options to include subdir-objects Emil Velikov
2013-08-30 15:19   ` Rob Clark [this message]
2013-08-29 20:31 ` [PATCH 6/6] intel: Update package name and description in libdrm_intel.pc Emil Velikov
2013-08-30 16:00   ` Damien Lespiau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF6AEGvaAq0yKEtRm-7enPJ1=Rwt_J4FA09nF9DhhLE3PM=8UA@mail.gmail.com' \
    --to=robdclark@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=robclark@freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.