From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
syzbot <syzbot+fee64147a25aecd48055@syzkaller.appspotmail.com>,
David Miller <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
linux-sctp@vger.kernel.org,
Network Development <netdev@vger.kernel.org>,
Neil Horman <nhorman@tuxdriver.com>,
syzkaller-bugs@googlegroups.com,
Vlad Yasevich <vyasevich@gmail.com>
Subject: Re: general protection fault in skb_segment
Date: Sun, 31 Dec 2017 10:17:32 +0100 [thread overview]
Message-ID: <CAF=yD-LRz1pWKRhtbOSbBwa7ZMVLPoDtkKRXumzT4xEK3fUh3g@mail.gmail.com> (raw)
In-Reply-To: <CADvbK_d0_486KX-wtfQa=0aVGv0mtaFs4JeMTbv6n+aMWqU3hg@mail.gmail.com>
>> and with the reproducer, got:
>> [ 54.255469] Bogus gso_type: 7
>> [ 54.258801] Bogus gso_size: 63464
>> [ 54.262532] ------------[ cut here ]------------
>> [ 54.267703] syz0: caps=(0x00000800000058c1, 0x0000000000000000) len=32 data_len=0 gso_size=63464 gso_type=7 ip_summed0
>> [ 54.279777] WARNING: CPU: 1 PID: 13005 at /root/linux/net/core/dev.c:2600 skb_warn_bad_offload+0xd6/0xec
> I couldn't reproduce this call trace on net-next, maybe it's been fixed by:
> commit 8d74e9f88d65af8bb2e095aff506aa6eac755ada
> Author: Willem de Bruijn <willemb@google.com>
> Date: Tue Dec 12 11:39:04 2017 -0500
>
> net: avoid skb_warn_bad_offload on IS_ERR
Yes, I forgot to mention that that has been fixed in net-next.
It does not address the crash, but does suppress the gratuitous
warning once we make segmentation return with error for bad
packets like these.
WARNING: multiple messages have this Message-ID (diff)
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
syzbot <syzbot+fee64147a25aecd48055@syzkaller.appspotmail.com>,
David Miller <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
linux-sctp@vger.kernel.org,
Network Development <netdev@vger.kernel.org>,
Neil Horman <nhorman@tuxdriver.com>,
syzkaller-bugs@googlegroups.com,
Vlad Yasevich <vyasevich@gmail.com>
Subject: Re: general protection fault in skb_segment
Date: Sun, 31 Dec 2017 09:17:32 +0000 [thread overview]
Message-ID: <CAF=yD-LRz1pWKRhtbOSbBwa7ZMVLPoDtkKRXumzT4xEK3fUh3g@mail.gmail.com> (raw)
In-Reply-To: <CADvbK_d0_486KX-wtfQa=0aVGv0mtaFs4JeMTbv6n+aMWqU3hg@mail.gmail.com>
>> and with the reproducer, got:
>> [ 54.255469] Bogus gso_type: 7
>> [ 54.258801] Bogus gso_size: 63464
>> [ 54.262532] ------------[ cut here ]------------
>> [ 54.267703] syz0: caps=(0x00000800000058c1, 0x0000000000000000) len2 data_len=0 gso_sizec464 gso_type=7 ip_summed0
>> [ 54.279777] WARNING: CPU: 1 PID: 13005 at /root/linux/net/core/dev.c:2600 skb_warn_bad_offload+0xd6/0xec
> I couldn't reproduce this call trace on net-next, maybe it's been fixed by:
> commit 8d74e9f88d65af8bb2e095aff506aa6eac755ada
> Author: Willem de Bruijn <willemb@google.com>
> Date: Tue Dec 12 11:39:04 2017 -0500
>
> net: avoid skb_warn_bad_offload on IS_ERR
Yes, I forgot to mention that that has been fixed in net-next.
It does not address the crash, but does suppress the gratuitous
warning once we make segmentation return with error for bad
packets like these.
next prev parent reply other threads:[~2017-12-31 9:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 17:58 general protection fault in skb_segment syzbot
2017-12-30 7:42 ` Willem de Bruijn
2017-12-30 7:42 ` Willem de Bruijn
2017-12-30 11:54 ` Willem de Bruijn
2017-12-30 11:54 ` Willem de Bruijn
2017-12-30 13:51 ` Xin Long
2017-12-30 13:51 ` Xin Long
2017-12-31 0:52 ` Marcelo Ricardo Leitner
2017-12-31 0:52 ` Marcelo Ricardo Leitner
2017-12-31 2:25 ` Marcelo Ricardo Leitner
2017-12-31 2:25 ` Marcelo Ricardo Leitner
2017-12-31 8:41 ` Xin Long
2017-12-31 8:41 ` Xin Long
2017-12-31 9:17 ` Willem de Bruijn [this message]
2017-12-31 9:17 ` Willem de Bruijn
2017-12-31 9:52 ` Willem de Bruijn
2017-12-31 9:52 ` Willem de Bruijn
2018-01-02 15:48 ` Willem de Bruijn
2018-01-02 15:48 ` Willem de Bruijn
2018-01-02 17:23 ` Willem de Bruijn
2018-01-02 17:23 ` Willem de Bruijn
2018-01-16 20:32 ` Willem de Bruijn
2018-01-16 20:32 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-LRz1pWKRhtbOSbBwa7ZMVLPoDtkKRXumzT4xEK3fUh3g@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=syzbot+fee64147a25aecd48055@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.