All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sumit Garg" <sumit.garg@linaro.org>
To: meta-arm@lists.yoctoproject.org
Cc: Denys Dmytriyenko <denys@ti.com>
Subject: Re: [meta-arm] [PATCH 2/4] external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES
Date: Thu, 30 Apr 2020 15:32:17 +0530	[thread overview]
Message-ID: <CAFA6WYMqhFL5AgeOECMB73gikOGY_HxMOHkXz0sBfm_9uqCvUg@mail.gmail.com> (raw)
In-Reply-To: <1588219828-34791-2-git-send-email-denis@denix.org>

On Thu, 30 Apr 2020 at 09:40, Denys Dmytriyenko <denis@denix.org> wrote:
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> There's no need to directly provide binutils-cross-${TARGET_ARCH}, as the
> PROVIDES list already contains virtual/${TARGET_PREFIX}binutils and correct
> PREFERRED_PROVIDER is set in the corresponding tcmode-external-arm.inc file:
>
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}binutils = "external-arm-toolchain"
>
> Similar to the compiler:
>
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc = "external-arm-toolchain"
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}gcc-initial = "external-arm-toolchain"
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}g++ = "external-arm-toolchain"
>
> And similar to glibc:
>
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}libc-for-gcc = "external-arm-toolchain"
> PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}compilerlibs = "external-arm-toolchain"
>
> There shouldn't be any direct dependency on binutils-cross-${TARGET_ARCH}. And
> if there is, it needs to be fixed to depend on virtual/${TARGET_PREFIX}binutils
>
> During 8.x upgrade there was an attempt to clean it up:
>
> https://git.linaro.org/openembedded/meta-linaro.git/commit/meta-linaro-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb?id=a8ce3dc47f3be9f98abc6ac98a849f918386cf9f
>
> But unfortunately, it got re-added back w/o reasoning:
>
> https://git.linaro.org/openembedded/meta-linaro.git/commit/?id=bb04bc8c67fd032fe04c47b2163ea5fa6b2ffa86
>
> Also, while at it, fix indentation for glibc-mtrace in PROVIDES list.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  .../recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb  | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> index ddd3aff..33d6c35 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> @@ -15,14 +15,13 @@ PROVIDES += "\
>         virtual/${TARGET_PREFIX}g++ \
>         virtual/${TARGET_PREFIX}gcc-initial \
>         virtual/${TARGET_PREFIX}binutils \
> -        binutils-cross-${TARGET_ARCH} \
>         virtual/${TARGET_PREFIX}libc-for-gcc \
>         virtual/${TARGET_PREFIX}compilerlibs \
>         virtual/libc \
>         virtual/libintl \
>         virtual/libiconv \
>         virtual/crypt \
> -        glibc-mtrace \
> +       glibc-mtrace \
>         glibc-thread-db \
>         glibc \
>         libc-mtrace \
> --
> 2.7.4
>
> 

  reply	other threads:[~2020-04-30 10:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30  4:10 [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Denys Dmytriyenko
2020-04-30  4:10 ` [PATCH 2/4] external-arm-toolchain: drop unnecessary binutils-cross-${TARGET_ARCH} in PROVIDES Denys Dmytriyenko
2020-04-30 10:02   ` Sumit Garg [this message]
2020-05-01  6:47     ` [meta-arm] " Diego Sueiro
2020-04-30  4:10 ` [PATCH 3/4] external-arm-toolchain: add INHIBIT_AUTOTOOLS_DEPS Denys Dmytriyenko
2020-04-30 10:24   ` [meta-arm] " Sumit Garg
2020-04-30 20:37     ` Denys Dmytriyenko
2020-04-30  4:10 ` [PATCH 4/4] external-arm-toolchain: drop unnecessary RDEPENDS on bash Denys Dmytriyenko
2020-04-30 10:41   ` [meta-arm] " Sumit Garg
2020-05-01  6:50     ` Diego Sueiro
2020-04-30  9:51 ` [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments Sumit Garg
2020-05-01  6:46 ` Diego Sueiro
2020-05-01 14:03   ` Jon Mason
2020-05-01 17:47     ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFA6WYMqhFL5AgeOECMB73gikOGY_HxMOHkXz0sBfm_9uqCvUg@mail.gmail.com \
    --to=sumit.garg@linaro.org \
    --cc=denys@ti.com \
    --cc=meta-arm@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.