Re: [meta-arm] [PATCH 4/4] external-arm-toolchain: drop unnecessary RDEPENDS on bash

["Sumit Garg" <sumit.garg@linaro.org>]

On Thu, 30 Apr 2020 at 09:40, Denys Dmytriyenko <denis@denix.org> wrote:
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> The 2 scripts that still have /bin/bash shebang are ldd and tzselect. But
> it seems upstream had fixed all bashisms in those scripts in recent years
> and OE-Core versions of those scripts use /bin/sh already.
>
> Dropping these unnecessary RDEPENDS on bash actually significantly prunes
> dependency tree for simple BSP builds like u-boot, etc.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  .../external-arm-toolchain/external-arm-toolchain.bb                 | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> index adb2fdd..af75e6a 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> @@ -114,6 +114,8 @@ do_install() {
>         rm -rf ${D}${bindir}/gdbserver
>         sed -i -e 's#/arm/tools/gnu/bash/4.2/rhe6-x86_64##' ${D}${bindir}/tzselect
>         sed -i -e 's#/arm/tools/gnu/bash/4.2/rhe6-x86_64##' ${D}${bindir}/ldd
> +       sed -i -e 's#/bin/bash#/bin/sh#' ${D}${bindir}/tzselect
> +       sed -i -e 's#/bin/bash#/bin/sh#' ${D}${bindir}/ldd
>
>         cp ${CP_ARGS} ${EXTERNAL_TOOLCHAIN}/lib/gcc/${EAT_TARGET_SYS}/${EAT_VER_GCC}/crt*.o ${D}${libdir}/${EAT_TARGET_SYS}/${EAT_VER_GCC}/
>
> @@ -421,9 +423,6 @@ FILES_libsegfault = "${base_libdir}/libSegFault*"
>  FILES_catchsegv = "${bindir}/catchsegv"
>  RDEPENDS_catchsegv = "libsegfault"
>
> -RDEPENDS_ldd = "bash"
> -RDEPENDS_tzcode = "bash"
> -
>  # From libgfortran.inc:
>
>  FILES_libgfortran = "${libdir}/libgfortran.so.*"
> --
> 2.7.4
>
>