* [PATCH] external-arm-sdk-toolchain: Fix parsing error with INCOMPATIBLE_LICENSE
@ 2021-05-11 15:28 Joshua Watt
2021-05-12 4:44 ` [meta-arm] " Sumit Garg
0 siblings, 1 reply; 2+ messages in thread
From: Joshua Watt @ 2021-05-11 15:28 UTC (permalink / raw)
To: meta-arm; +Cc: Timothy Mertz, Joshua Watt
From: Timothy Mertz <timothy.mertz@garmin.com>
This change defines EAD_GDB_LICENSE and EAT_BFD_LICENSE in license.inc
and is required by external-arm-sdk-toolchain.
This change fixes parsing error that occurs when INCOMPATIBLE_LICENSE =
"GPLv3".
Signed-off-by: Timothy Mertz <timothy.mertz@garmin.com>
Signed-off-by: Joshua Watt <Joshua.Watt@garmin.com>
---
.../external-arm-toolchain/external-arm-sdk-toolchain.bb | 2 ++
.../recipes-devtools/external-arm-toolchain/license.inc | 2 ++
2 files changed, 4 insertions(+)
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-sdk-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-sdk-toolchain.bb
index 3f12b4d..59957ff 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-sdk-toolchain.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-sdk-toolchain.bb
@@ -1,5 +1,7 @@
inherit cross-canadian
+require license.inc
+
PN = "external-arm-sdk-toolchain-${TARGET_ARCH}"
BPN = "external-arm-sdk-toolchain"
PV = "${EAT_VER_MAIN}"
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/license.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/license.inc
index b6ee42c..6e3d039 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/license.inc
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/license.inc
@@ -1,6 +1,8 @@
LICENSE = "GPL-3.0-with-GCC-exception & GPLv3 & GPLv2 & LGPLv3 & LGPLv2.1 & LGPLv2"
+EAT_BFD_LICENSE = "GPL-3.0"
EAT_GCC_LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
+EAT_GDB_LICENSE = "GPL-3.0"
EAT_LIBC_LICENSE = "GPLv2 & LGPLv2.1"
LICENSE_${PN} = "${EAT_LIBC_LICENSE}"
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [meta-arm] [PATCH] external-arm-sdk-toolchain: Fix parsing error with INCOMPATIBLE_LICENSE
2021-05-11 15:28 [PATCH] external-arm-sdk-toolchain: Fix parsing error with INCOMPATIBLE_LICENSE Joshua Watt
@ 2021-05-12 4:44 ` Sumit Garg
0 siblings, 0 replies; 2+ messages in thread
From: Sumit Garg @ 2021-05-12 4:44 UTC (permalink / raw)
To: Joshua.Watt; +Cc: meta-arm, Timothy Mertz
On Tue, 11 May 2021 at 20:58, Joshua Watt via lists.yoctoproject.org
<Joshua.Watt=garmin.com@lists.yoctoproject.org> wrote:
>
> From: Timothy Mertz <timothy.mertz@garmin.com>
>
> This change defines EAD_GDB_LICENSE and EAT_BFD_LICENSE in license.inc
> and is required by external-arm-sdk-toolchain.
>
> This change fixes parsing error that occurs when INCOMPATIBLE_LICENSE =
> "GPLv3".
>
So the parser isn't able to pick up license variables defined here [1]?
> Signed-off-by: Timothy Mertz <timothy.mertz@garmin.com>
> Signed-off-by: Joshua Watt <Joshua.Watt@garmin.com>
> ---
> .../external-arm-toolchain/external-arm-sdk-toolchain.bb | 2 ++
> .../recipes-devtools/external-arm-toolchain/license.inc | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-sdk-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-sdk-toolchain.bb
> index 3f12b4d..59957ff 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-sdk-toolchain.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-sdk-toolchain.bb
> @@ -1,5 +1,7 @@
> inherit cross-canadian
>
> +require license.inc
> +
If we are using license.inc then we should remove redundant override
for overall license in this recipe:
LICENSE = "${EAT_LICENSE}"
> PN = "external-arm-sdk-toolchain-${TARGET_ARCH}"
> BPN = "external-arm-sdk-toolchain"
> PV = "${EAT_VER_MAIN}"
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/license.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/license.inc
> index b6ee42c..6e3d039 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/license.inc
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/license.inc
> @@ -1,6 +1,8 @@
> LICENSE = "GPL-3.0-with-GCC-exception & GPLv3 & GPLv2 & LGPLv3 & LGPLv2.1 & LGPLv2"
>
> +EAT_BFD_LICENSE = "GPL-3.0"
> EAT_GCC_LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> +EAT_GDB_LICENSE = "GPL-3.0"
> EAT_LIBC_LICENSE = "GPLv2 & LGPLv2.1"
>
Now the license variables defined here [1] become redundant, so we can
remove them.
[1] https://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/tree/meta-arm-toolchain/conf/distro/include/external-arm-toolchain-versions.inc#n143
-Sumit
> LICENSE_${PN} = "${EAT_LIBC_LICENSE}"
> --
> 2.31.1
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-12 4:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 15:28 [PATCH] external-arm-sdk-toolchain: Fix parsing error with INCOMPATIBLE_LICENSE Joshua Watt
2021-05-12 4:44 ` [meta-arm] " Sumit Garg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.