* [LTP] [PATCH] [COMMITTED] syscalls/syncfs: Fix compilation
@ 2019-02-25 15:49 Cyril Hrubis
2019-02-26 9:04 ` Sumit Garg
0 siblings, 1 reply; 2+ messages in thread
From: Cyril Hrubis @ 2019-02-25 15:49 UTC (permalink / raw)
To: ltp
The lapi/syncfs.h calls tst_syscall() which in turn uses tst_brk and
TCONF, which is undefined until we include tst_test.h.
This commit just swaps the tst_test.h and lapi/syncfs.h includes so that
tst_test.h is included first, which fixed compilation on older
distributions. This is a quick fix, cleaner solution may be done later
on as a part of https://github.com/linux-test-project/ltp/issues/506.
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
testcases/kernel/syscalls/syncfs/syncfs01.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/syncfs/syncfs01.c b/testcases/kernel/syscalls/syncfs/syncfs01.c
index 2210da617..051a19ea6 100644
--- a/testcases/kernel/syscalls/syncfs/syncfs01.c
+++ b/testcases/kernel/syscalls/syncfs/syncfs01.c
@@ -16,8 +16,8 @@
#include <stdlib.h>
#include <stdio.h>
#include <sys/types.h>
-#include "lapi/syncfs.h"
#include "tst_test.h"
+#include "lapi/syncfs.h"
#include "check_syncfs.h"
#define MNTPOINT "mnt_point"
--
2.19.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [LTP] [PATCH] [COMMITTED] syscalls/syncfs: Fix compilation
2019-02-25 15:49 [LTP] [PATCH] [COMMITTED] syscalls/syncfs: Fix compilation Cyril Hrubis
@ 2019-02-26 9:04 ` Sumit Garg
0 siblings, 0 replies; 2+ messages in thread
From: Sumit Garg @ 2019-02-26 9:04 UTC (permalink / raw)
To: ltp
On Mon, 25 Feb 2019 at 21:19, Cyril Hrubis <chrubis@suse.cz> wrote:
>
> The lapi/syncfs.h calls tst_syscall() which in turn uses tst_brk and
> TCONF, which is undefined until we include tst_test.h.
>
> This commit just swaps the tst_test.h and lapi/syncfs.h includes so that
> tst_test.h is included first, which fixed compilation on older
> distributions. This is a quick fix, cleaner solution may be done later
> on as a part of https://github.com/linux-test-project/ltp/issues/506.
>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
> testcases/kernel/syscalls/syncfs/syncfs01.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for this fix.
-Sumit
>
> diff --git a/testcases/kernel/syscalls/syncfs/syncfs01.c b/testcases/kernel/syscalls/syncfs/syncfs01.c
> index 2210da617..051a19ea6 100644
> --- a/testcases/kernel/syscalls/syncfs/syncfs01.c
> +++ b/testcases/kernel/syscalls/syncfs/syncfs01.c
> @@ -16,8 +16,8 @@
> #include <stdlib.h>
> #include <stdio.h>
> #include <sys/types.h>
> -#include "lapi/syncfs.h"
> #include "tst_test.h"
> +#include "lapi/syncfs.h"
> #include "check_syncfs.h"
>
> #define MNTPOINT "mnt_point"
> --
> 2.19.2
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-26 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-25 15:49 [LTP] [PATCH] [COMMITTED] syscalls/syncfs: Fix compilation Cyril Hrubis
2019-02-26 9:04 ` Sumit Garg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.