From: Sumit Garg <sumit.garg@linaro.org> To: Jarkko Sakkinen <jarkko@kernel.org> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Mimi Zohar <zohar@linux.ibm.com>, James Bottomley <jejb@linux.ibm.com>, David Howells <dhowells@redhat.com>, Jens Wiklander <jens.wiklander@linaro.org>, Jonathan Corbet <corbet@lwn.net>, James Morris <jmorris@namei.org>, "Serge E. Hallyn" <serge@hallyn.com>, Casey Schaufler <casey@schaufler-ca.com>, Janne Karhunen <janne.karhunen@gmail.com>, Daniel Thompson <daniel.thompson@linaro.org>, Markus Wamser <Markus.Wamser@mixed-mode.de>, Luke Hinds <lhinds@redhat.com>, "open list:ASYMMETRIC KEYS" <keyrings@vger.kernel.org>, linux-integrity@vger.kernel.org, "open list:SECURITY SUBSYSTEM" <linux-security-module@vger.kernel.org>, Linux Doc Mailing List <linux-doc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, op-tee@lists.trustedfirmware.org Subject: Re: [PATCH v8 0/4] Introduce TEE based Trusted Keys support Date: Fri, 6 Nov 2020 15:02:41 +0530 [thread overview] Message-ID: <CAFA6WYPetvod-Wov2n_L5TL771j+-kt+_csyWYT-uM=haEKMZQ@mail.gmail.com> (raw) In-Reply-To: <20201105050736.GA702944@kernel.org> On Thu, 5 Nov 2020 at 10:37, Jarkko Sakkinen <jarkko@kernel.org> wrote: > > On Tue, Nov 03, 2020 at 09:31:42PM +0530, Sumit Garg wrote: > > Add support for TEE based trusted keys where TEE provides the functionality > > to seal and unseal trusted keys using hardware unique key. Also, this is > > an alternative in case platform doesn't possess a TPM device. > > > > This patch-set has been tested with OP-TEE based early TA which is already > > merged in upstream [1]. > > Is the new RPI400 computer a platform that can be used for testing > patch sets like this? I've been looking for a while something ARM64 > based with similar convenience as Intel NUC's, and on the surface > this new RPI product looks great for kernel testing purposes. Here [1] is the list of supported versions of Raspberry Pi in OP-TEE. The easiest approach would be to pick up a supported version or else do an OP-TEE port for an unsupported one (which should involve minimal effort). [1] https://optee.readthedocs.io/en/latest/building/devices/rpi3.html#what-versions-of-raspberry-pi-will-work -Sumit > > /Jarkko > > > > > [1] https://github.com/OP-TEE/optee_os/commit/f86ab8e7e0de869dfa25ca05a37ee070d7e5b86b > > > > Changes in v8: > > 1. Added static calls support instead of indirect calls. > > 2. Documented trusted keys source module parameter. > > 3. Refined patch #1 commit message discription. > > 4. Addressed misc. comments on patch #2. > > 5. Added myself as Trusted Keys co-maintainer instead. > > 6. Rebased to latest tpmdd master. > > > > Changes in v7: > > 1. Added a trusted.source module parameter in order to enforce user's > > choice in case a particular platform posses both TPM and TEE. > > 2. Refine commit description for patch #1. > > > > Changes in v6: > > 1. Revert back to dynamic detection of trust source. > > 2. Drop author mention from trusted_core.c and trusted_tpm1.c files. > > 3. Rebased to latest tpmdd/master. > > > > Changes in v5: > > 1. Drop dynamic detection of trust source and use compile time flags > > instead. > > 2. Rename trusted_common.c -> trusted_core.c. > > 3. Rename callback: cleanup() -> exit(). > > 4. Drop "tk" acronym. > > 5. Other misc. comments. > > 6. Added review tags for patch #3 and #4. > > > > Changes in v4: > > 1. Pushed independent TEE features separately: > > - Part of recent TEE PR: https://lkml.org/lkml/2020/5/4/1062 > > 2. Updated trusted-encrypted doc with TEE as a new trust source. > > 3. Rebased onto latest tpmdd/master. > > > > Changes in v3: > > 1. Update patch #2 to support registration of multiple kernel pages. > > 2. Incoporate dependency patch #4 in this patch-set: > > https://patchwork.kernel.org/patch/11091435/ > > > > Changes in v2: > > 1. Add reviewed-by tags for patch #1 and #2. > > 2. Incorporate comments from Jens for patch #3. > > 3. Switch to use generic trusted keys framework. > > > > Sumit Garg (4): > > KEYS: trusted: Add generic trusted keys framework > > KEYS: trusted: Introduce TEE based Trusted Keys > > doc: trusted-encrypted: updates with TEE as a new trust source > > MAINTAINERS: Add myself as Trusted Keys co-maintainer > > > > Documentation/admin-guide/kernel-parameters.txt | 12 + > > Documentation/security/keys/trusted-encrypted.rst | 203 +++++++++++-- > > MAINTAINERS | 2 + > > include/keys/trusted-type.h | 47 +++ > > include/keys/trusted_tee.h | 55 ++++ > > include/keys/trusted_tpm.h | 17 +- > > security/keys/trusted-keys/Makefile | 2 + > > security/keys/trusted-keys/trusted_core.c | 354 ++++++++++++++++++++++ > > security/keys/trusted-keys/trusted_tee.c | 278 +++++++++++++++++ > > security/keys/trusted-keys/trusted_tpm1.c | 336 ++++---------------- > > 10 files changed, 979 insertions(+), 327 deletions(-) > > create mode 100644 include/keys/trusted_tee.h > > create mode 100644 security/keys/trusted-keys/trusted_core.c > > create mode 100644 security/keys/trusted-keys/trusted_tee.c > > > > -- > > 2.7.4 > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Garg <sumit.garg@linaro.org> To: Jarkko Sakkinen <jarkko@kernel.org> Cc: "open list:SECURITY SUBSYSTEM" <linux-security-module@vger.kernel.org>, Daniel Thompson <daniel.thompson@linaro.org>, op-tee@lists.trustedfirmware.org, Jonathan Corbet <corbet@lwn.net>, James Bottomley <jejb@linux.ibm.com>, Janne Karhunen <janne.karhunen@gmail.com>, Linux Doc Mailing List <linux-doc@vger.kernel.org>, James Morris <jmorris@namei.org>, Mimi Zohar <zohar@linux.ibm.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, David Howells <dhowells@redhat.com>, Luke Hinds <lhinds@redhat.com>, "open list:ASYMMETRIC KEYS" <keyrings@vger.kernel.org>, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Markus Wamser <Markus.Wamser@mixed-mode.de>, Casey Schaufler <casey@schaufler-ca.com>, linux-integrity@vger.kernel.org, Jens Wiklander <jens.wiklander@linaro.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, "Serge E. Hallyn" <serge@hallyn.com> Subject: Re: [PATCH v8 0/4] Introduce TEE based Trusted Keys support Date: Fri, 6 Nov 2020 15:02:41 +0530 [thread overview] Message-ID: <CAFA6WYPetvod-Wov2n_L5TL771j+-kt+_csyWYT-uM=haEKMZQ@mail.gmail.com> (raw) In-Reply-To: <20201105050736.GA702944@kernel.org> On Thu, 5 Nov 2020 at 10:37, Jarkko Sakkinen <jarkko@kernel.org> wrote: > > On Tue, Nov 03, 2020 at 09:31:42PM +0530, Sumit Garg wrote: > > Add support for TEE based trusted keys where TEE provides the functionality > > to seal and unseal trusted keys using hardware unique key. Also, this is > > an alternative in case platform doesn't possess a TPM device. > > > > This patch-set has been tested with OP-TEE based early TA which is already > > merged in upstream [1]. > > Is the new RPI400 computer a platform that can be used for testing > patch sets like this? I've been looking for a while something ARM64 > based with similar convenience as Intel NUC's, and on the surface > this new RPI product looks great for kernel testing purposes. Here [1] is the list of supported versions of Raspberry Pi in OP-TEE. The easiest approach would be to pick up a supported version or else do an OP-TEE port for an unsupported one (which should involve minimal effort). [1] https://optee.readthedocs.io/en/latest/building/devices/rpi3.html#what-versions-of-raspberry-pi-will-work -Sumit > > /Jarkko > > > > > [1] https://github.com/OP-TEE/optee_os/commit/f86ab8e7e0de869dfa25ca05a37ee070d7e5b86b > > > > Changes in v8: > > 1. Added static calls support instead of indirect calls. > > 2. Documented trusted keys source module parameter. > > 3. Refined patch #1 commit message discription. > > 4. Addressed misc. comments on patch #2. > > 5. Added myself as Trusted Keys co-maintainer instead. > > 6. Rebased to latest tpmdd master. > > > > Changes in v7: > > 1. Added a trusted.source module parameter in order to enforce user's > > choice in case a particular platform posses both TPM and TEE. > > 2. Refine commit description for patch #1. > > > > Changes in v6: > > 1. Revert back to dynamic detection of trust source. > > 2. Drop author mention from trusted_core.c and trusted_tpm1.c files. > > 3. Rebased to latest tpmdd/master. > > > > Changes in v5: > > 1. Drop dynamic detection of trust source and use compile time flags > > instead. > > 2. Rename trusted_common.c -> trusted_core.c. > > 3. Rename callback: cleanup() -> exit(). > > 4. Drop "tk" acronym. > > 5. Other misc. comments. > > 6. Added review tags for patch #3 and #4. > > > > Changes in v4: > > 1. Pushed independent TEE features separately: > > - Part of recent TEE PR: https://lkml.org/lkml/2020/5/4/1062 > > 2. Updated trusted-encrypted doc with TEE as a new trust source. > > 3. Rebased onto latest tpmdd/master. > > > > Changes in v3: > > 1. Update patch #2 to support registration of multiple kernel pages. > > 2. Incoporate dependency patch #4 in this patch-set: > > https://patchwork.kernel.org/patch/11091435/ > > > > Changes in v2: > > 1. Add reviewed-by tags for patch #1 and #2. > > 2. Incorporate comments from Jens for patch #3. > > 3. Switch to use generic trusted keys framework. > > > > Sumit Garg (4): > > KEYS: trusted: Add generic trusted keys framework > > KEYS: trusted: Introduce TEE based Trusted Keys > > doc: trusted-encrypted: updates with TEE as a new trust source > > MAINTAINERS: Add myself as Trusted Keys co-maintainer > > > > Documentation/admin-guide/kernel-parameters.txt | 12 + > > Documentation/security/keys/trusted-encrypted.rst | 203 +++++++++++-- > > MAINTAINERS | 2 + > > include/keys/trusted-type.h | 47 +++ > > include/keys/trusted_tee.h | 55 ++++ > > include/keys/trusted_tpm.h | 17 +- > > security/keys/trusted-keys/Makefile | 2 + > > security/keys/trusted-keys/trusted_core.c | 354 ++++++++++++++++++++++ > > security/keys/trusted-keys/trusted_tee.c | 278 +++++++++++++++++ > > security/keys/trusted-keys/trusted_tpm1.c | 336 ++++---------------- > > 10 files changed, 979 insertions(+), 327 deletions(-) > > create mode 100644 include/keys/trusted_tee.h > > create mode 100644 security/keys/trusted-keys/trusted_core.c > > create mode 100644 security/keys/trusted-keys/trusted_tee.c > > > > -- > > 2.7.4 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-06 9:32 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-03 16:01 [PATCH v8 0/4] Introduce TEE based Trusted Keys support Sumit Garg 2020-11-03 16:01 ` Sumit Garg 2020-11-03 16:01 ` [PATCH v8 1/4] KEYS: trusted: Add generic trusted keys framework Sumit Garg 2020-11-03 16:01 ` Sumit Garg 2020-11-24 3:42 ` Jarkko Sakkinen 2020-11-24 3:42 ` Jarkko Sakkinen 2021-02-15 13:13 ` Sumit Garg 2021-02-15 13:13 ` Sumit Garg 2021-02-10 17:00 ` Jarkko Sakkinen 2021-02-10 17:00 ` Jarkko Sakkinen 2021-02-11 10:34 ` Ahmad Fatoum 2021-02-11 10:34 ` Ahmad Fatoum 2021-02-12 12:22 ` Jarkko Sakkinen 2021-02-12 12:22 ` Jarkko Sakkinen 2021-02-15 13:15 ` Sumit Garg 2021-02-15 13:15 ` Sumit Garg 2020-11-03 16:01 ` [PATCH v8 2/4] KEYS: trusted: Introduce TEE based Trusted Keys Sumit Garg 2020-11-03 16:01 ` Sumit Garg 2020-11-04 3:19 ` kernel test robot 2020-11-04 7:56 ` Sumit Garg 2020-11-24 3:46 ` Jarkko Sakkinen 2020-11-24 3:46 ` Jarkko Sakkinen 2021-01-11 16:35 ` Jarkko Sakkinen 2021-01-11 16:35 ` Jarkko Sakkinen 2021-01-13 11:17 ` Sumit Garg 2021-01-13 11:17 ` Sumit Garg 2021-01-14 2:05 ` Jarkko Sakkinen 2021-01-14 2:05 ` Jarkko Sakkinen 2021-01-15 6:02 ` Sumit Garg 2021-01-15 6:02 ` Sumit Garg 2021-01-19 10:30 ` Jarkko Sakkinen 2021-01-19 10:30 ` Jarkko Sakkinen 2021-01-20 1:31 ` Jarkko Sakkinen 2021-01-20 1:31 ` Jarkko Sakkinen 2021-01-20 7:23 ` Sumit Garg 2021-01-20 7:23 ` Sumit Garg 2021-01-21 0:01 ` Jarkko Sakkinen 2021-01-21 0:01 ` Jarkko Sakkinen [not found] ` <01000177223f74d3-1eef7685-4a19-40d2-ace6-d4cd7f35579d-000000@email.amazonses.com> 2021-01-21 8:44 ` Jerome Forissier 2021-01-21 8:44 ` Jerome Forissier 2021-01-21 15:07 ` Jarkko Sakkinen 2021-01-21 15:07 ` Jarkko Sakkinen 2021-01-21 15:24 ` Jarkko Sakkinen 2021-01-21 15:24 ` Jarkko Sakkinen 2021-01-21 16:23 ` Jerome Forissier 2021-01-21 16:23 ` Jerome Forissier 2021-01-22 18:12 ` Jarkko Sakkinen 2021-01-22 18:12 ` Jarkko Sakkinen 2021-01-25 9:17 ` Sumit Garg 2021-01-27 17:14 ` Jarkko Sakkinen 2021-01-27 17:14 ` Jarkko Sakkinen 2021-01-27 17:19 ` Jarkko Sakkinen 2021-01-27 17:19 ` Jarkko Sakkinen 2021-02-04 0:05 ` Jarkko Sakkinen 2021-02-04 0:05 ` Jarkko Sakkinen 2021-02-11 23:34 ` Jarkko Sakkinen 2021-02-11 23:34 ` Jarkko Sakkinen 2021-02-11 23:35 ` Jarkko Sakkinen 2021-02-11 23:35 ` Jarkko Sakkinen 2021-02-15 13:07 ` Sumit Garg 2021-02-15 13:07 ` Sumit Garg 2021-02-16 7:29 ` Jarkko Sakkinen 2021-02-16 7:29 ` Jarkko Sakkinen 2021-02-22 7:15 ` Sumit Garg 2021-02-22 7:15 ` Sumit Garg 2021-02-24 16:58 ` Jarkko Sakkinen 2021-02-24 16:58 ` Jarkko Sakkinen 2021-01-20 13:36 ` Ahmad Fatoum 2021-01-20 13:36 ` Ahmad Fatoum 2020-11-03 16:01 ` [PATCH v8 3/4] doc: trusted-encrypted: updates with TEE as a new trust source Sumit Garg 2020-11-03 16:01 ` Sumit Garg 2020-12-02 19:34 ` gmail Elaine Palmer 2020-12-02 19:34 ` gmail Elaine Palmer 2020-12-04 15:30 ` Jarkko Sakkinen 2020-12-04 15:30 ` Jarkko Sakkinen 2020-12-08 15:02 ` Mimi Zohar 2020-12-08 15:02 ` Mimi Zohar 2020-12-08 17:49 ` Jarkko Sakkinen 2020-12-08 17:49 ` Jarkko Sakkinen 2020-12-09 16:50 ` Mimi Zohar 2020-12-09 16:50 ` Mimi Zohar 2020-12-11 10:36 ` Jarkko Sakkinen 2020-12-11 10:36 ` Jarkko Sakkinen 2020-12-11 15:29 ` Mimi Zohar 2020-12-11 15:29 ` Mimi Zohar 2020-12-06 18:51 ` Randy Dunlap 2020-12-06 18:51 ` Randy Dunlap 2020-12-08 15:55 ` Mimi Zohar 2020-12-08 15:55 ` Mimi Zohar 2020-12-08 17:07 ` Mimi Zohar 2020-12-08 17:07 ` Mimi Zohar 2020-11-03 16:01 ` [PATCH v8 4/4] MAINTAINERS: Add myself as Trusted Keys co-maintainer Sumit Garg 2020-11-03 16:01 ` Sumit Garg 2020-11-24 3:46 ` Jarkko Sakkinen 2020-11-24 3:46 ` Jarkko Sakkinen 2020-11-05 5:07 ` [PATCH v8 0/4] Introduce TEE based Trusted Keys support Jarkko Sakkinen 2020-11-05 5:07 ` Jarkko Sakkinen 2020-11-06 9:32 ` Sumit Garg [this message] 2020-11-06 9:32 ` Sumit Garg 2020-11-06 14:52 ` Jarkko Sakkinen 2020-11-06 14:52 ` Jarkko Sakkinen 2020-12-04 5:16 ` Jarkko Sakkinen 2020-12-04 5:16 ` Jarkko Sakkinen 2020-12-08 11:51 ` Sumit Garg 2020-12-08 11:51 ` Sumit Garg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFA6WYPetvod-Wov2n_L5TL771j+-kt+_csyWYT-uM=haEKMZQ@mail.gmail.com' \ --to=sumit.garg@linaro.org \ --cc=Markus.Wamser@mixed-mode.de \ --cc=casey@schaufler-ca.com \ --cc=corbet@lwn.net \ --cc=daniel.thompson@linaro.org \ --cc=dhowells@redhat.com \ --cc=janne.karhunen@gmail.com \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=jarkko@kernel.org \ --cc=jejb@linux.ibm.com \ --cc=jens.wiklander@linaro.org \ --cc=jmorris@namei.org \ --cc=keyrings@vger.kernel.org \ --cc=lhinds@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=op-tee@lists.trustedfirmware.org \ --cc=serge@hallyn.com \ --cc=zohar@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.