All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i386: elf: Fix -Wunused-but-set-variable compilation warning
@ 2015-02-12  8:34 Ameya Palande
  2015-02-17 18:52 ` Ameya Palande
  2015-02-25  4:40 ` Simon Horman
  0 siblings, 2 replies; 3+ messages in thread
From: Ameya Palande @ 2015-02-12  8:34 UTC (permalink / raw)
  To: kexec; +Cc: Simon Horman, Ameya Palande

kexec/arch/i386/kexec-elf-x86.c:97:6: warning: variable
‘modified_cmdline_len’ set but not used [-Wunused-but-set-variable]
  int modified_cmdline_len;

Signed-off-by: Ameya Palande <2ameya@gmail.com>
---
 kexec/arch/i386/kexec-elf-x86.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/kexec/arch/i386/kexec-elf-x86.c b/kexec/arch/i386/kexec-elf-x86.c
index d0f9838..de00dcb 100644
--- a/kexec/arch/i386/kexec-elf-x86.c
+++ b/kexec/arch/i386/kexec-elf-x86.c
@@ -94,7 +94,6 @@ int elf_x86_load(int argc, char **argv, const char *buf, off_t len,
 	char *error_msg = NULL;
 	int result;
 	int command_line_len;
-	int modified_cmdline_len;
 	const char *ramdisk;
 	unsigned long entry, max_addr;
 	int arg_style;
@@ -123,7 +122,6 @@ int elf_x86_load(int argc, char **argv, const char *buf, off_t len,
 	 * Parse the command line arguments
 	 */
 	arg_style = ARG_STYLE_ELF;
-	modified_cmdline_len = 0;
 	ramdisk = 0;
 	result = 0;
 	while((opt = getopt_long(argc, argv, short_options, options, 0)) != -1) {
@@ -180,7 +178,6 @@ int elf_x86_load(int argc, char **argv, const char *buf, off_t len,
 						COMMAND_LINE_SIZE);
 			modified_cmdline[COMMAND_LINE_SIZE - 1] = '\0';
 		}
-		modified_cmdline_len = strlen(modified_cmdline);
 	}
 
 	/* Load the ELF executable */
-- 
1.8.3.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] i386: elf: Fix -Wunused-but-set-variable compilation warning
  2015-02-12  8:34 [PATCH] i386: elf: Fix -Wunused-but-set-variable compilation warning Ameya Palande
@ 2015-02-17 18:52 ` Ameya Palande
  2015-02-25  4:40 ` Simon Horman
  1 sibling, 0 replies; 3+ messages in thread
From: Ameya Palande @ 2015-02-17 18:52 UTC (permalink / raw)
  To: kexec; +Cc: Simon Horman

On Thu, Feb 12, 2015 at 12:34 AM, Ameya Palande <2ameya@gmail.com> wrote:
> kexec/arch/i386/kexec-elf-x86.c:97:6: warning: variable
> ‘modified_cmdline_len’ set but not used [-Wunused-but-set-variable]
>   int modified_cmdline_len;
>
> Signed-off-by: Ameya Palande <2ameya@gmail.com>

Any update?

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i386: elf: Fix -Wunused-but-set-variable compilation warning
  2015-02-12  8:34 [PATCH] i386: elf: Fix -Wunused-but-set-variable compilation warning Ameya Palande
  2015-02-17 18:52 ` Ameya Palande
@ 2015-02-25  4:40 ` Simon Horman
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2015-02-25  4:40 UTC (permalink / raw)
  To: Ameya Palande; +Cc: kexec

On Thu, Feb 12, 2015 at 12:34:26AM -0800, Ameya Palande wrote:
> kexec/arch/i386/kexec-elf-x86.c:97:6: warning: variable
> ‘modified_cmdline_len’ set but not used [-Wunused-but-set-variable]
>   int modified_cmdline_len;
> 
> Signed-off-by: Ameya Palande <2ameya@gmail.com>

Thanks, applied.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-25  4:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-12  8:34 [PATCH] i386: elf: Fix -Wunused-but-set-variable compilation warning Ameya Palande
2015-02-17 18:52 ` Ameya Palande
2015-02-25  4:40 ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.