From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] mmc: meson-mx-sdhc: Set MANUAL_STOP for multi-block SDIO commands
Date: Tue, 14 Dec 2021 19:35:30 +0100 [thread overview]
Message-ID: <CAFBinCAD1guDgrFW5Y3H7YBMKFFiDK92AzyoxnDoAPRsPV8xwQ@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFq4Q2M=MimXAERtBy+UY79NwLQs8afGWvvXatOrP_LB7w@mail.gmail.com>
Hi Ulf,
On Tue, Dec 14, 2021 at 2:21 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
[...]
> > +
>
> Maybe add a comment to explain a bit about this workaround here?
sure, I'll add a paragraph for v2 because this workaround/fix is not obvious
> > + manual_stop = cmd->data->blocks > 1 &&
> > + (cmd->opcode == SD_IO_RW_DIRECT ||
>
> SD_IO_RW_DIRECT doesn't have cmd->data, so checking for that command
> doesn't make sense.
This also means that you found a bug in the vendor driver :-)
I'll drop SD_IO_RW_DIRECT, do another round of testing and then send
an updated version.
Thank you for taking a closer look!
Best regards,
Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] mmc: meson-mx-sdhc: Set MANUAL_STOP for multi-block SDIO commands
Date: Tue, 14 Dec 2021 19:35:30 +0100 [thread overview]
Message-ID: <CAFBinCAD1guDgrFW5Y3H7YBMKFFiDK92AzyoxnDoAPRsPV8xwQ@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFq4Q2M=MimXAERtBy+UY79NwLQs8afGWvvXatOrP_LB7w@mail.gmail.com>
Hi Ulf,
On Tue, Dec 14, 2021 at 2:21 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
[...]
> > +
>
> Maybe add a comment to explain a bit about this workaround here?
sure, I'll add a paragraph for v2 because this workaround/fix is not obvious
> > + manual_stop = cmd->data->blocks > 1 &&
> > + (cmd->opcode == SD_IO_RW_DIRECT ||
>
> SD_IO_RW_DIRECT doesn't have cmd->data, so checking for that command
> doesn't make sense.
This also means that you found a bug in the vendor driver :-)
I'll drop SD_IO_RW_DIRECT, do another round of testing and then send
an updated version.
Thank you for taking a closer look!
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] mmc: meson-mx-sdhc: Set MANUAL_STOP for multi-block SDIO commands
Date: Tue, 14 Dec 2021 19:35:30 +0100 [thread overview]
Message-ID: <CAFBinCAD1guDgrFW5Y3H7YBMKFFiDK92AzyoxnDoAPRsPV8xwQ@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFq4Q2M=MimXAERtBy+UY79NwLQs8afGWvvXatOrP_LB7w@mail.gmail.com>
Hi Ulf,
On Tue, Dec 14, 2021 at 2:21 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
[...]
> > +
>
> Maybe add a comment to explain a bit about this workaround here?
sure, I'll add a paragraph for v2 because this workaround/fix is not obvious
> > + manual_stop = cmd->data->blocks > 1 &&
> > + (cmd->opcode == SD_IO_RW_DIRECT ||
>
> SD_IO_RW_DIRECT doesn't have cmd->data, so checking for that command
> doesn't make sense.
This also means that you found a bug in the vendor driver :-)
I'll drop SD_IO_RW_DIRECT, do another round of testing and then send
an updated version.
Thank you for taking a closer look!
Best regards,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-14 18:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 14:59 [PATCH v1 0/2] mmc: meson-mx-sdhc: two fixes Martin Blumenstingl
2021-12-12 14:59 ` Martin Blumenstingl
2021-12-12 14:59 ` Martin Blumenstingl
2021-12-12 14:59 ` [PATCH v1 1/2] mmc: meson-mx-sdhc: Set MANUAL_STOP for multi-block SDIO commands Martin Blumenstingl
2021-12-12 14:59 ` Martin Blumenstingl
2021-12-12 14:59 ` Martin Blumenstingl
2021-12-14 13:20 ` Ulf Hansson
2021-12-14 13:20 ` Ulf Hansson
2021-12-14 13:20 ` Ulf Hansson
2021-12-14 18:35 ` Martin Blumenstingl [this message]
2021-12-14 18:35 ` Martin Blumenstingl
2021-12-14 18:35 ` Martin Blumenstingl
2021-12-12 14:59 ` [PATCH v1 2/2] mmc: meson-mx-sdhc: Drop unused MESON_SDHC_NUM_BUILTIN_CLKS macro Martin Blumenstingl
2021-12-12 14:59 ` Martin Blumenstingl
2021-12-12 14:59 ` Martin Blumenstingl
2021-12-13 13:01 ` [PATCH v1 0/2] mmc: meson-mx-sdhc: two fixes Ulf Hansson
2021-12-13 13:01 ` Ulf Hansson
2021-12-13 13:01 ` Ulf Hansson
2021-12-13 19:35 ` Martin Blumenstingl
2021-12-13 19:35 ` Martin Blumenstingl
2021-12-13 19:35 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCAD1guDgrFW5Y3H7YBMKFFiDK92AzyoxnDoAPRsPV8xwQ@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.