From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe()
Date: Mon, 27 Sep 2021 22:09:47 +0200 [thread overview]
Message-ID: <CAFBinCAatVy_9abUJ7A6frbsOqDqAzVe9oDJODOS5MC7aCcDVg@mail.gmail.com> (raw)
In-Reply-To: <20210927081426.762-6-caihuoqing@baidu.com>
Hello,
first of all: thanks for this patch!
On Mon, Sep 27, 2021 at 10:15 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
[...]
> + if (IS_ERR(priv->clkin))
> + return dev_err_probe(&pdev->dev,
> + PTR_ERR(priv->clkin),
Is there any specific reason why you put PTR_ERR() on a separate line?
it would still fit into the line above and be below the old 80 chars
per line limit.
For priv->vref you already have it the way I am suggesting there.
[...]
> + if (IS_ERR(priv->core_clk))
> + return dev_err_probe(&pdev->dev,
> + PTR_ERR(priv->core_clk),
the same question as above applies here as well
Best regards,
Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe()
Date: Mon, 27 Sep 2021 22:09:47 +0200 [thread overview]
Message-ID: <CAFBinCAatVy_9abUJ7A6frbsOqDqAzVe9oDJODOS5MC7aCcDVg@mail.gmail.com> (raw)
In-Reply-To: <20210927081426.762-6-caihuoqing@baidu.com>
Hello,
first of all: thanks for this patch!
On Mon, Sep 27, 2021 at 10:15 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
[...]
> + if (IS_ERR(priv->clkin))
> + return dev_err_probe(&pdev->dev,
> + PTR_ERR(priv->clkin),
Is there any specific reason why you put PTR_ERR() on a separate line?
it would still fit into the line above and be below the old 80 chars
per line limit.
For priv->vref you already have it the way I am suggesting there.
[...]
> + if (IS_ERR(priv->core_clk))
> + return dev_err_probe(&pdev->dev,
> + PTR_ERR(priv->core_clk),
the same question as above applies here as well
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe()
Date: Mon, 27 Sep 2021 22:09:47 +0200 [thread overview]
Message-ID: <CAFBinCAatVy_9abUJ7A6frbsOqDqAzVe9oDJODOS5MC7aCcDVg@mail.gmail.com> (raw)
In-Reply-To: <20210927081426.762-6-caihuoqing@baidu.com>
Hello,
first of all: thanks for this patch!
On Mon, Sep 27, 2021 at 10:15 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
[...]
> + if (IS_ERR(priv->clkin))
> + return dev_err_probe(&pdev->dev,
> + PTR_ERR(priv->clkin),
Is there any specific reason why you put PTR_ERR() on a separate line?
it would still fit into the line above and be below the old 80 chars
per line limit.
For priv->vref you already have it the way I am suggesting there.
[...]
> + if (IS_ERR(priv->core_clk))
> + return dev_err_probe(&pdev->dev,
> + PTR_ERR(priv->core_clk),
the same question as above applies here as well
Best regards,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-27 20:10 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 8:14 [PATCH 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` [PATCH 2/9] iio: adc: imx7d_adc: " Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` [PATCH 3/9] iio: adc: lpc18xx_adc: " Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` [PATCH 4/9] iio: adc: max1118: " Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` [PATCH 5/9] iio: adc: max1241: " Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` [PATCH 6/9] iio: adc: meson_saradc: " Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 20:09 ` Martin Blumenstingl [this message]
2021-09-27 20:09 ` Martin Blumenstingl
2021-09-27 20:09 ` Martin Blumenstingl
2021-09-28 2:49 ` Cai Huoqing
2021-09-28 2:49 ` Cai Huoqing
2021-09-28 2:49 ` Cai Huoqing
2021-09-27 8:14 ` [PATCH 7/9] iio: adc: qcom-pm8xxx-xoadc: " Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` [PATCH 8/9] iio: adc: rockchip_saradc: " Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` [PATCH 9/9] iio: adc: ti-ads7950: " Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
2021-09-27 8:14 ` Cai Huoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCAatVy_9abUJ7A6frbsOqDqAzVe9oDJODOS5MC7aCcDVg@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=caihuoqing@baidu.com \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.