* [PATCHv2 0/3] Fix the pwm regulator supply properties
@ 2021-07-05 11:23 ` Anand Moon
0 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Rob Herring, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, devicetree
Changes PWM supply properties help fix internal link of PWM to
main 5V supply as per the shematics.
PATCHv1 below
[0] https://lore.kernel.org/linux-amlogic/CANAwSgRD9_B7f5UjPrxeL+x-eMMc2MAG3tXLQw36x0ho+ba_Uw@mail.gmail.com/T/#t
Thanks
-Anand
Anand Moon (3):
ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
arch/arm/boot/dts/meson8b-ec100.dts | 4 ++--
arch/arm/boot/dts/meson8b-mxq.dts | 4 +++-
arch/arm/boot/dts/meson8b-odroidc1.dts | 4 ++--
3 files changed, 7 insertions(+), 5 deletions(-)
--
2.32.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCHv2 0/3] Fix the pwm regulator supply properties
@ 2021-07-05 11:23 ` Anand Moon
0 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Rob Herring, Neil Armstrong, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, devicetree
Changes PWM supply properties help fix internal link of PWM to
main 5V supply as per the shematics.
PATCHv1 below
[0] https://lore.kernel.org/linux-amlogic/CANAwSgRD9_B7f5UjPrxeL+x-eMMc2MAG3tXLQw36x0ho+ba_Uw@mail.gmail.com/T/#t
Thanks
-Anand
Anand Moon (3):
ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
arch/arm/boot/dts/meson8b-ec100.dts | 4 ++--
arch/arm/boot/dts/meson8b-mxq.dts | 4 +++-
arch/arm/boot/dts/meson8b-odroidc1.dts | 4 ++--
3 files changed, 7 insertions(+), 5 deletions(-)
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
2021-07-05 11:23 ` Anand Moon
(?)
@ 2021-07-05 11:23 ` Anand Moon
-1 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Martin Blumenstingl, Rob Herring, Neil Armstrong,
Kevin Hilman, Jerome Brunet, devicetree
After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[ 7.117184] VCCK: supplied by regulator-dummy
[ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[ 7.118498] VDDEE: will resolve supply early: pwm
[ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[ 7.118553] VDDEE: supplied by regulator-dummy
[ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V1 - Fix the commit subject and commit message
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index c440ef94e082..04356bc639fa 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -131,7 +131,7 @@ vcck: regulator-vcck {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&p5v0>;
+ pwm-supply = <&p5v0>;
pwms = <&pwm_cd 0 12218 0>;
pwm-dutycycle-range = <91 0>;
@@ -163,7 +163,7 @@ vddee: regulator-vddee {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&p5v0>;
+ pwm-supply = <&p5v0>;
pwms = <&pwm_cd 1 12218 0>;
pwm-dutycycle-range = <91 0>;
--
2.32.0
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
@ 2021-07-05 11:23 ` Anand Moon
0 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Martin Blumenstingl, Rob Herring, Neil Armstrong,
Kevin Hilman, Jerome Brunet, devicetree
After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[ 7.117184] VCCK: supplied by regulator-dummy
[ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[ 7.118498] VDDEE: will resolve supply early: pwm
[ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[ 7.118553] VDDEE: supplied by regulator-dummy
[ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V1 - Fix the commit subject and commit message
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index c440ef94e082..04356bc639fa 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -131,7 +131,7 @@ vcck: regulator-vcck {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&p5v0>;
+ pwm-supply = <&p5v0>;
pwms = <&pwm_cd 0 12218 0>;
pwm-dutycycle-range = <91 0>;
@@ -163,7 +163,7 @@ vddee: regulator-vddee {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&p5v0>;
+ pwm-supply = <&p5v0>;
pwms = <&pwm_cd 1 12218 0>;
pwm-dutycycle-range = <91 0>;
--
2.32.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
@ 2021-07-05 11:23 ` Anand Moon
0 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Martin Blumenstingl, Rob Herring, Neil Armstrong,
Kevin Hilman, Jerome Brunet, devicetree
After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[ 7.117184] VCCK: supplied by regulator-dummy
[ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[ 7.118498] VDDEE: will resolve supply early: pwm
[ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[ 7.118553] VDDEE: supplied by regulator-dummy
[ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V1 - Fix the commit subject and commit message
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index c440ef94e082..04356bc639fa 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -131,7 +131,7 @@ vcck: regulator-vcck {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&p5v0>;
+ pwm-supply = <&p5v0>;
pwms = <&pwm_cd 0 12218 0>;
pwm-dutycycle-range = <91 0>;
@@ -163,7 +163,7 @@ vddee: regulator-vddee {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&p5v0>;
+ pwm-supply = <&p5v0>;
pwms = <&pwm_cd 1 12218 0>;
pwm-dutycycle-range = <91 0>;
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
2021-07-05 11:23 ` Anand Moon
(?)
@ 2021-07-08 12:58 ` Martin Blumenstingl
-1 siblings, 0 replies; 27+ messages in thread
From: Martin Blumenstingl @ 2021-07-08 12:58 UTC (permalink / raw)
To: Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Neil Armstrong, Kevin Hilman, Jerome Brunet, devicetree
On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
I think there's a typo here: observer -> observe
maybe Kevin or Neil can fix this up (in this and the following two
patches) while applying the patch so you don't have to re-spin a v3
> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
> instead of dummy regulator.
>
> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
> [ 7.117184] VCCK: supplied by regulator-dummy
> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
> [ 7.118498] VDDEE: will resolve supply early: pwm
> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
> [ 7.118553] VDDEE: supplied by regulator-dummy
> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>
> Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
> Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
>
> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
@ 2021-07-08 12:58 ` Martin Blumenstingl
0 siblings, 0 replies; 27+ messages in thread
From: Martin Blumenstingl @ 2021-07-08 12:58 UTC (permalink / raw)
To: Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Neil Armstrong, Kevin Hilman, Jerome Brunet, devicetree
On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
I think there's a typo here: observer -> observe
maybe Kevin or Neil can fix this up (in this and the following two
patches) while applying the patch so you don't have to re-spin a v3
> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
> instead of dummy regulator.
>
> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
> [ 7.117184] VCCK: supplied by regulator-dummy
> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
> [ 7.118498] VDDEE: will resolve supply early: pwm
> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
> [ 7.118553] VDDEE: supplied by regulator-dummy
> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>
> Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
> Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
>
> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
@ 2021-07-08 12:58 ` Martin Blumenstingl
0 siblings, 0 replies; 27+ messages in thread
From: Martin Blumenstingl @ 2021-07-08 12:58 UTC (permalink / raw)
To: Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Neil Armstrong, Kevin Hilman, Jerome Brunet, devicetree
On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
I think there's a typo here: observer -> observe
maybe Kevin or Neil can fix this up (in this and the following two
patches) while applying the patch so you don't have to re-spin a v3
> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
> instead of dummy regulator.
>
> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
> [ 7.117184] VCCK: supplied by regulator-dummy
> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
> [ 7.118498] VDDEE: will resolve supply early: pwm
> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
> [ 7.118553] VDDEE: supplied by regulator-dummy
> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>
> Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
> Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
>
> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
2021-07-08 12:58 ` Martin Blumenstingl
(?)
@ 2021-07-26 8:06 ` Neil Armstrong
-1 siblings, 0 replies; 27+ messages in thread
From: Neil Armstrong @ 2021-07-26 8:06 UTC (permalink / raw)
To: Martin Blumenstingl, Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Kevin Hilman, Jerome Brunet, devicetree
Hi,
On 08/07/2021 14:58, Martin Blumenstingl wrote:
> On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>>
>> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> I think there's a typo here: observer -> observe
> maybe Kevin or Neil can fix this up (in this and the following two
> patches) while applying the patch so you don't have to re-spin a v3
Fixed while applying !
>
>> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
>> instead of dummy regulator.
>>
>> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
>> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
>> [ 7.117184] VCCK: supplied by regulator-dummy
>> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
>> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
>> [ 7.118498] VDDEE: will resolve supply early: pwm
>> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
>> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
>> [ 7.118553] VDDEE: supplied by regulator-dummy
>> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>>
>> Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
>> Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
>>
>> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
Neil
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
@ 2021-07-26 8:06 ` Neil Armstrong
0 siblings, 0 replies; 27+ messages in thread
From: Neil Armstrong @ 2021-07-26 8:06 UTC (permalink / raw)
To: Martin Blumenstingl, Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Kevin Hilman, Jerome Brunet, devicetree
Hi,
On 08/07/2021 14:58, Martin Blumenstingl wrote:
> On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>>
>> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> I think there's a typo here: observer -> observe
> maybe Kevin or Neil can fix this up (in this and the following two
> patches) while applying the patch so you don't have to re-spin a v3
Fixed while applying !
>
>> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
>> instead of dummy regulator.
>>
>> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
>> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
>> [ 7.117184] VCCK: supplied by regulator-dummy
>> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
>> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
>> [ 7.118498] VDDEE: will resolve supply early: pwm
>> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
>> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
>> [ 7.118553] VDDEE: supplied by regulator-dummy
>> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>>
>> Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
>> Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
>>
>> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
@ 2021-07-26 8:06 ` Neil Armstrong
0 siblings, 0 replies; 27+ messages in thread
From: Neil Armstrong @ 2021-07-26 8:06 UTC (permalink / raw)
To: Martin Blumenstingl, Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Kevin Hilman, Jerome Brunet, devicetree
Hi,
On 08/07/2021 14:58, Martin Blumenstingl wrote:
> On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>>
>> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> I think there's a typo here: observer -> observe
> maybe Kevin or Neil can fix this up (in this and the following two
> patches) while applying the patch so you don't have to re-spin a v3
Fixed while applying !
>
>> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
>> instead of dummy regulator.
>>
>> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
>> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
>> [ 7.117184] VCCK: supplied by regulator-dummy
>> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
>> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
>> [ 7.118498] VDDEE: will resolve supply early: pwm
>> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
>> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
>> [ 7.118553] VDDEE: supplied by regulator-dummy
>> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>>
>> Fixes: 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
>> Fixes: 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")
>>
>> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCHv2 2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
2021-07-05 11:23 ` Anand Moon
(?)
@ 2021-07-05 11:23 ` Anand Moon
-1 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Martin Blumenstingl, Rob Herring, Neil Armstrong,
Kevin Hilman, Jerome Brunet, devicetree
After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.
Add missing pwm-supply for regulator-vcck regulator node.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[ 7.117184] VCCK: supplied by regulator-dummy
[ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[ 7.118498] VDDEE: will resolve supply early: pwm
[ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[ 7.118553] VDDEE: supplied by regulator-dummy
[ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Fixes: dee51cd0d2e8 ("ARM: dts: meson8b: mxq: add the VDDEE regulator")
Fixes: d94f60e3dfa0 ("ARM: dts: meson8b: mxq: improve support for the TRONFY MXQ S805")
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V1 - New patch in this series
---
arch/arm/boot/dts/meson8b-mxq.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/meson8b-mxq.dts b/arch/arm/boot/dts/meson8b-mxq.dts
index f3937d55472d..7adedd3258c3 100644
--- a/arch/arm/boot/dts/meson8b-mxq.dts
+++ b/arch/arm/boot/dts/meson8b-mxq.dts
@@ -34,6 +34,8 @@ vcck: regulator-vcck {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
+ pwm-supply = <&vcc_5v>;
+
pwms = <&pwm_cd 0 1148 0>;
pwm-dutycycle-range = <100 0>;
@@ -79,7 +81,7 @@ vddee: regulator-vddee {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&vcc_5v>;
+ pwm-supply = <&vcc_5v>;
pwms = <&pwm_cd 1 1148 0>;
pwm-dutycycle-range = <100 0>;
--
2.32.0
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCHv2 2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
@ 2021-07-05 11:23 ` Anand Moon
0 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Martin Blumenstingl, Rob Herring, Neil Armstrong,
Kevin Hilman, Jerome Brunet, devicetree
After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.
Add missing pwm-supply for regulator-vcck regulator node.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[ 7.117184] VCCK: supplied by regulator-dummy
[ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[ 7.118498] VDDEE: will resolve supply early: pwm
[ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[ 7.118553] VDDEE: supplied by regulator-dummy
[ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Fixes: dee51cd0d2e8 ("ARM: dts: meson8b: mxq: add the VDDEE regulator")
Fixes: d94f60e3dfa0 ("ARM: dts: meson8b: mxq: improve support for the TRONFY MXQ S805")
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V1 - New patch in this series
---
arch/arm/boot/dts/meson8b-mxq.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/meson8b-mxq.dts b/arch/arm/boot/dts/meson8b-mxq.dts
index f3937d55472d..7adedd3258c3 100644
--- a/arch/arm/boot/dts/meson8b-mxq.dts
+++ b/arch/arm/boot/dts/meson8b-mxq.dts
@@ -34,6 +34,8 @@ vcck: regulator-vcck {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
+ pwm-supply = <&vcc_5v>;
+
pwms = <&pwm_cd 0 1148 0>;
pwm-dutycycle-range = <100 0>;
@@ -79,7 +81,7 @@ vddee: regulator-vddee {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&vcc_5v>;
+ pwm-supply = <&vcc_5v>;
pwms = <&pwm_cd 1 1148 0>;
pwm-dutycycle-range = <100 0>;
--
2.32.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCHv2 2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
@ 2021-07-05 11:23 ` Anand Moon
0 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Martin Blumenstingl, Rob Herring, Neil Armstrong,
Kevin Hilman, Jerome Brunet, devicetree
After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.
Add missing pwm-supply for regulator-vcck regulator node.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[ 7.117184] VCCK: supplied by regulator-dummy
[ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[ 7.118498] VDDEE: will resolve supply early: pwm
[ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[ 7.118553] VDDEE: supplied by regulator-dummy
[ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Fixes: dee51cd0d2e8 ("ARM: dts: meson8b: mxq: add the VDDEE regulator")
Fixes: d94f60e3dfa0 ("ARM: dts: meson8b: mxq: improve support for the TRONFY MXQ S805")
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V1 - New patch in this series
---
arch/arm/boot/dts/meson8b-mxq.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/meson8b-mxq.dts b/arch/arm/boot/dts/meson8b-mxq.dts
index f3937d55472d..7adedd3258c3 100644
--- a/arch/arm/boot/dts/meson8b-mxq.dts
+++ b/arch/arm/boot/dts/meson8b-mxq.dts
@@ -34,6 +34,8 @@ vcck: regulator-vcck {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
+ pwm-supply = <&vcc_5v>;
+
pwms = <&pwm_cd 0 1148 0>;
pwm-dutycycle-range = <100 0>;
@@ -79,7 +81,7 @@ vddee: regulator-vddee {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&vcc_5v>;
+ pwm-supply = <&vcc_5v>;
pwms = <&pwm_cd 1 1148 0>;
pwm-dutycycle-range = <100 0>;
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCHv2 2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
2021-07-05 11:23 ` Anand Moon
(?)
@ 2021-07-08 12:58 ` Martin Blumenstingl
-1 siblings, 0 replies; 27+ messages in thread
From: Martin Blumenstingl @ 2021-07-08 12:58 UTC (permalink / raw)
To: Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Neil Armstrong, Kevin Hilman, Jerome Brunet, devicetree
On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
> instead of dummy regulator.
> Add missing pwm-supply for regulator-vcck regulator node.
>
> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
> [ 7.117184] VCCK: supplied by regulator-dummy
> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
> [ 7.118498] VDDEE: will resolve supply early: pwm
> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
> [ 7.118553] VDDEE: supplied by regulator-dummy
> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>
> Fixes: dee51cd0d2e8 ("ARM: dts: meson8b: mxq: add the VDDEE regulator")
> Fixes: d94f60e3dfa0 ("ARM: dts: meson8b: mxq: improve support for the TRONFY MXQ S805")
>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
@ 2021-07-08 12:58 ` Martin Blumenstingl
0 siblings, 0 replies; 27+ messages in thread
From: Martin Blumenstingl @ 2021-07-08 12:58 UTC (permalink / raw)
To: Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Neil Armstrong, Kevin Hilman, Jerome Brunet, devicetree
On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
> instead of dummy regulator.
> Add missing pwm-supply for regulator-vcck regulator node.
>
> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
> [ 7.117184] VCCK: supplied by regulator-dummy
> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
> [ 7.118498] VDDEE: will resolve supply early: pwm
> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
> [ 7.118553] VDDEE: supplied by regulator-dummy
> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>
> Fixes: dee51cd0d2e8 ("ARM: dts: meson8b: mxq: add the VDDEE regulator")
> Fixes: d94f60e3dfa0 ("ARM: dts: meson8b: mxq: improve support for the TRONFY MXQ S805")
>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
@ 2021-07-08 12:58 ` Martin Blumenstingl
0 siblings, 0 replies; 27+ messages in thread
From: Martin Blumenstingl @ 2021-07-08 12:58 UTC (permalink / raw)
To: Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Neil Armstrong, Kevin Hilman, Jerome Brunet, devicetree
On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
> instead of dummy regulator.
> Add missing pwm-supply for regulator-vcck regulator node.
>
> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
> [ 7.117184] VCCK: supplied by regulator-dummy
> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
> [ 7.118498] VDDEE: will resolve supply early: pwm
> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
> [ 7.118553] VDDEE: supplied by regulator-dummy
> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>
> Fixes: dee51cd0d2e8 ("ARM: dts: meson8b: mxq: add the VDDEE regulator")
> Fixes: d94f60e3dfa0 ("ARM: dts: meson8b: mxq: improve support for the TRONFY MXQ S805")
>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCHv2 3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
2021-07-05 11:23 ` Anand Moon
(?)
@ 2021-07-05 11:23 ` Anand Moon
-1 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Martin Blumenstingl, Rob Herring, Neil Armstrong,
Kevin Hilman, Jerome Brunet, devicetree
After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[ 7.117184] VCCK: supplied by regulator-dummy
[ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[ 7.118498] VDDEE: will resolve supply early: pwm
[ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[ 7.118553] VDDEE: supplied by regulator-dummy
[ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Fixes: 087a1d8b4e4c ("ARM: dts: meson8b: ec100: add the VDDEE regulator")
Fixes: 3e7db1c1b7a3 ("ARM: dts: meson8b: ec100: improve the description of the regulators")
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V1 - New patch in this series
---
arch/arm/boot/dts/meson8b-ec100.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/meson8b-ec100.dts b/arch/arm/boot/dts/meson8b-ec100.dts
index 8e48ccc6b634..7e8ddc6f1252 100644
--- a/arch/arm/boot/dts/meson8b-ec100.dts
+++ b/arch/arm/boot/dts/meson8b-ec100.dts
@@ -148,7 +148,7 @@ vcck: regulator-vcck {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&vcc_5v>;
+ pwm-supply = <&vcc_5v>;
pwms = <&pwm_cd 0 1148 0>;
pwm-dutycycle-range = <100 0>;
@@ -232,7 +232,7 @@ vddee: regulator-vddee {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&vcc_5v>;
+ pwm-supply = <&vcc_5v>;
pwms = <&pwm_cd 1 1148 0>;
pwm-dutycycle-range = <100 0>;
--
2.32.0
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCHv2 3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
@ 2021-07-05 11:23 ` Anand Moon
0 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Martin Blumenstingl, Rob Herring, Neil Armstrong,
Kevin Hilman, Jerome Brunet, devicetree
After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[ 7.117184] VCCK: supplied by regulator-dummy
[ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[ 7.118498] VDDEE: will resolve supply early: pwm
[ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[ 7.118553] VDDEE: supplied by regulator-dummy
[ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Fixes: 087a1d8b4e4c ("ARM: dts: meson8b: ec100: add the VDDEE regulator")
Fixes: 3e7db1c1b7a3 ("ARM: dts: meson8b: ec100: improve the description of the regulators")
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V1 - New patch in this series
---
arch/arm/boot/dts/meson8b-ec100.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/meson8b-ec100.dts b/arch/arm/boot/dts/meson8b-ec100.dts
index 8e48ccc6b634..7e8ddc6f1252 100644
--- a/arch/arm/boot/dts/meson8b-ec100.dts
+++ b/arch/arm/boot/dts/meson8b-ec100.dts
@@ -148,7 +148,7 @@ vcck: regulator-vcck {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&vcc_5v>;
+ pwm-supply = <&vcc_5v>;
pwms = <&pwm_cd 0 1148 0>;
pwm-dutycycle-range = <100 0>;
@@ -232,7 +232,7 @@ vddee: regulator-vddee {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&vcc_5v>;
+ pwm-supply = <&vcc_5v>;
pwms = <&pwm_cd 1 1148 0>;
pwm-dutycycle-range = <100 0>;
--
2.32.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCHv2 3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
@ 2021-07-05 11:23 ` Anand Moon
0 siblings, 0 replies; 27+ messages in thread
From: Anand Moon @ 2021-07-05 11:23 UTC (permalink / raw)
To: linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Anand Moon, Martin Blumenstingl, Rob Herring, Neil Armstrong,
Kevin Hilman, Jerome Brunet, devicetree
After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[ 7.117184] VCCK: supplied by regulator-dummy
[ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[ 7.118498] VDDEE: will resolve supply early: pwm
[ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[ 7.118553] VDDEE: supplied by regulator-dummy
[ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Fixes: 087a1d8b4e4c ("ARM: dts: meson8b: ec100: add the VDDEE regulator")
Fixes: 3e7db1c1b7a3 ("ARM: dts: meson8b: ec100: improve the description of the regulators")
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V1 - New patch in this series
---
arch/arm/boot/dts/meson8b-ec100.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/meson8b-ec100.dts b/arch/arm/boot/dts/meson8b-ec100.dts
index 8e48ccc6b634..7e8ddc6f1252 100644
--- a/arch/arm/boot/dts/meson8b-ec100.dts
+++ b/arch/arm/boot/dts/meson8b-ec100.dts
@@ -148,7 +148,7 @@ vcck: regulator-vcck {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&vcc_5v>;
+ pwm-supply = <&vcc_5v>;
pwms = <&pwm_cd 0 1148 0>;
pwm-dutycycle-range = <100 0>;
@@ -232,7 +232,7 @@ vddee: regulator-vddee {
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;
- vin-supply = <&vcc_5v>;
+ pwm-supply = <&vcc_5v>;
pwms = <&pwm_cd 1 1148 0>;
pwm-dutycycle-range = <100 0>;
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCHv2 3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
2021-07-05 11:23 ` Anand Moon
(?)
@ 2021-07-08 12:58 ` Martin Blumenstingl
-1 siblings, 0 replies; 27+ messages in thread
From: Martin Blumenstingl @ 2021-07-08 12:58 UTC (permalink / raw)
To: Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Neil Armstrong, Kevin Hilman, Jerome Brunet, devicetree
On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
> instead of dummy regulator.
>
> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
> [ 7.117184] VCCK: supplied by regulator-dummy
> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
> [ 7.118498] VDDEE: will resolve supply early: pwm
> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
> [ 7.118553] VDDEE: supplied by regulator-dummy
> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>
> Fixes: 087a1d8b4e4c ("ARM: dts: meson8b: ec100: add the VDDEE regulator")
> Fixes: 3e7db1c1b7a3 ("ARM: dts: meson8b: ec100: improve the description of the regulators")
>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
@ 2021-07-08 12:58 ` Martin Blumenstingl
0 siblings, 0 replies; 27+ messages in thread
From: Martin Blumenstingl @ 2021-07-08 12:58 UTC (permalink / raw)
To: Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Neil Armstrong, Kevin Hilman, Jerome Brunet, devicetree
On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
> instead of dummy regulator.
>
> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
> [ 7.117184] VCCK: supplied by regulator-dummy
> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
> [ 7.118498] VDDEE: will resolve supply early: pwm
> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
> [ 7.118553] VDDEE: supplied by regulator-dummy
> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>
> Fixes: 087a1d8b4e4c ("ARM: dts: meson8b: ec100: add the VDDEE regulator")
> Fixes: 3e7db1c1b7a3 ("ARM: dts: meson8b: ec100: improve the description of the regulators")
>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
@ 2021-07-08 12:58 ` Martin Blumenstingl
0 siblings, 0 replies; 27+ messages in thread
From: Martin Blumenstingl @ 2021-07-08 12:58 UTC (permalink / raw)
To: Anand Moon
Cc: linux-arm-kernel, linux-amlogic, linux-kernel, Rob Herring,
Neil Armstrong, Kevin Hilman, Jerome Brunet, devicetree
On Mon, Jul 5, 2021 at 1:25 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs.
> Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
> instead of dummy regulator.
>
> [ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
> [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
> [ 7.117184] VCCK: supplied by regulator-dummy
> [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
> [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
> [ 7.118498] VDDEE: will resolve supply early: pwm
> [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
> [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
> [ 7.118553] VDDEE: supplied by regulator-dummy
> [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
>
> Fixes: 087a1d8b4e4c ("ARM: dts: meson8b: ec100: add the VDDEE regulator")
> Fixes: 3e7db1c1b7a3 ("ARM: dts: meson8b: ec100: improve the description of the regulators")
>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCHv2 0/3] Fix the pwm regulator supply properties
2021-07-05 11:23 ` Anand Moon
(?)
@ 2021-07-26 8:12 ` Neil Armstrong
-1 siblings, 0 replies; 27+ messages in thread
From: Neil Armstrong @ 2021-07-26 8:12 UTC (permalink / raw)
To: linux-amlogic, linux-arm-kernel, Anand Moon, linux-kernel
Cc: Neil Armstrong, Rob Herring, Jerome Brunet, Martin Blumenstingl,
devicetree, Kevin Hilman
Hi,
On Mon, 5 Jul 2021 11:23:52 +0000, Anand Moon wrote:
> Changes PWM supply properties help fix internal link of PWM to
> main 5V supply as per the shematics.
>
> PATCHv1 below
> [0] https://lore.kernel.org/linux-amlogic/CANAwSgRD9_B7f5UjPrxeL+x-eMMc2MAG3tXLQw36x0ho+ba_Uw@mail.gmail.com/T/#t
>
> Thanks
> -Anand
>
> [...]
Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (for-next)
[1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
https://git.kernel.org/amlogic/c/876228e9f935f19c7afc7ba394d17e2ec9143b65
[2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
https://git.kernel.org/amlogic/c/632062e540becbbcb067523ec8bcadb1239d9578
[3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
https://git.kernel.org/amlogic/c/72ccc373b064ae3ac0c5b5f2306069b60ca118df
--
Neil
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 0/3] Fix the pwm regulator supply properties
@ 2021-07-26 8:12 ` Neil Armstrong
0 siblings, 0 replies; 27+ messages in thread
From: Neil Armstrong @ 2021-07-26 8:12 UTC (permalink / raw)
To: linux-amlogic, linux-arm-kernel, Anand Moon, linux-kernel
Cc: Neil Armstrong, Rob Herring, Jerome Brunet, Martin Blumenstingl,
devicetree, Kevin Hilman
Hi,
On Mon, 5 Jul 2021 11:23:52 +0000, Anand Moon wrote:
> Changes PWM supply properties help fix internal link of PWM to
> main 5V supply as per the shematics.
>
> PATCHv1 below
> [0] https://lore.kernel.org/linux-amlogic/CANAwSgRD9_B7f5UjPrxeL+x-eMMc2MAG3tXLQw36x0ho+ba_Uw@mail.gmail.com/T/#t
>
> Thanks
> -Anand
>
> [...]
Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (for-next)
[1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
https://git.kernel.org/amlogic/c/876228e9f935f19c7afc7ba394d17e2ec9143b65
[2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
https://git.kernel.org/amlogic/c/632062e540becbbcb067523ec8bcadb1239d9578
[3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
https://git.kernel.org/amlogic/c/72ccc373b064ae3ac0c5b5f2306069b60ca118df
--
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCHv2 0/3] Fix the pwm regulator supply properties
@ 2021-07-26 8:12 ` Neil Armstrong
0 siblings, 0 replies; 27+ messages in thread
From: Neil Armstrong @ 2021-07-26 8:12 UTC (permalink / raw)
To: linux-amlogic, linux-arm-kernel, Anand Moon, linux-kernel
Cc: Neil Armstrong, Rob Herring, Jerome Brunet, Martin Blumenstingl,
devicetree, Kevin Hilman
Hi,
On Mon, 5 Jul 2021 11:23:52 +0000, Anand Moon wrote:
> Changes PWM supply properties help fix internal link of PWM to
> main 5V supply as per the shematics.
>
> PATCHv1 below
> [0] https://lore.kernel.org/linux-amlogic/CANAwSgRD9_B7f5UjPrxeL+x-eMMc2MAG3tXLQw36x0ho+ba_Uw@mail.gmail.com/T/#t
>
> Thanks
> -Anand
>
> [...]
Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (for-next)
[1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
https://git.kernel.org/amlogic/c/876228e9f935f19c7afc7ba394d17e2ec9143b65
[2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
https://git.kernel.org/amlogic/c/632062e540becbbcb067523ec8bcadb1239d9578
[3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
https://git.kernel.org/amlogic/c/72ccc373b064ae3ac0c5b5f2306069b60ca118df
--
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 27+ messages in thread