From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: khilman@baylibre.com, robh+dt@kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
jbrunet@baylibre.com, christianshewitt@gmail.com,
jian.hu@amlogic.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] arm64: dts: meson: g12a: x96-max: fix PHY deassert timing requirements
Date: Sat, 5 Dec 2020 14:14:39 +0100 [thread overview]
Message-ID: <CAFBinCBnqHkpQ79PVfCqJPbC3qj6v6T-HsJehffYzfaDTPxUgw@mail.gmail.com> (raw)
In-Reply-To: <83c1a57cb99c04dc31098166f0c26073de5e7709.1606828668.git.stefan@agner.ch>
On Tue, Dec 1, 2020 at 2:21 PM Stefan Agner <stefan@agner.ch> wrote:
>
> According to the datasheet (Rev. 1.9) the RTL8211F requires at least
> 72ms "for internal circuits settling time" before accessing the PHY
> egisters. On similar boards with the same PHY this fixes an issue where
> Ethernet link would not come up when using ip link set down/up.
>
> Fixes: ed5e8f689154 ("arm64: dts: meson: g12a: x96-max: fix the Ethernet PHY reset line")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
with the "registers" typo above fixed:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: devicetree@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
khilman@baylibre.com, christianshewitt@gmail.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
jian.hu@amlogic.com, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH v2 4/5] arm64: dts: meson: g12a: x96-max: fix PHY deassert timing requirements
Date: Sat, 5 Dec 2020 14:14:39 +0100 [thread overview]
Message-ID: <CAFBinCBnqHkpQ79PVfCqJPbC3qj6v6T-HsJehffYzfaDTPxUgw@mail.gmail.com> (raw)
In-Reply-To: <83c1a57cb99c04dc31098166f0c26073de5e7709.1606828668.git.stefan@agner.ch>
On Tue, Dec 1, 2020 at 2:21 PM Stefan Agner <stefan@agner.ch> wrote:
>
> According to the datasheet (Rev. 1.9) the RTL8211F requires at least
> 72ms "for internal circuits settling time" before accessing the PHY
> egisters. On similar boards with the same PHY this fixes an issue where
> Ethernet link would not come up when using ip link set down/up.
>
> Fixes: ed5e8f689154 ("arm64: dts: meson: g12a: x96-max: fix the Ethernet PHY reset line")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
with the "registers" typo above fixed:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: devicetree@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
khilman@baylibre.com, christianshewitt@gmail.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
jian.hu@amlogic.com, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH v2 4/5] arm64: dts: meson: g12a: x96-max: fix PHY deassert timing requirements
Date: Sat, 5 Dec 2020 14:14:39 +0100 [thread overview]
Message-ID: <CAFBinCBnqHkpQ79PVfCqJPbC3qj6v6T-HsJehffYzfaDTPxUgw@mail.gmail.com> (raw)
In-Reply-To: <83c1a57cb99c04dc31098166f0c26073de5e7709.1606828668.git.stefan@agner.ch>
On Tue, Dec 1, 2020 at 2:21 PM Stefan Agner <stefan@agner.ch> wrote:
>
> According to the datasheet (Rev. 1.9) the RTL8211F requires at least
> 72ms "for internal circuits settling time" before accessing the PHY
> egisters. On similar boards with the same PHY this fixes an issue where
> Ethernet link would not come up when using ip link set down/up.
>
> Fixes: ed5e8f689154 ("arm64: dts: meson: g12a: x96-max: fix the Ethernet PHY reset line")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
with the "registers" typo above fixed:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-12-05 18:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 13:21 [PATCH v2 1/5] arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements Stefan Agner
2020-12-01 13:21 ` Stefan Agner
2020-12-01 13:21 ` Stefan Agner
2020-12-01 13:21 ` [PATCH v2 2/5] arm64: dts: meson: " Stefan Agner
2020-12-01 13:21 ` Stefan Agner
2020-12-01 13:21 ` Stefan Agner
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-01 13:21 ` [PATCH v2 3/5] ARM: " Stefan Agner
2020-12-01 13:21 ` Stefan Agner
2020-12-01 13:21 ` Stefan Agner
2020-12-05 13:04 ` Martin Blumenstingl
2020-12-05 13:04 ` Martin Blumenstingl
2020-12-05 13:04 ` Martin Blumenstingl
2020-12-07 17:53 ` Stefan Agner
2020-12-07 17:53 ` Stefan Agner
2020-12-07 17:53 ` Stefan Agner
2020-12-01 13:21 ` [PATCH v2 4/5] arm64: dts: meson: g12a: x96-max: " Stefan Agner
2020-12-01 13:21 ` Stefan Agner
2020-12-01 13:21 ` Stefan Agner
2020-12-05 13:14 ` Martin Blumenstingl [this message]
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-01 13:21 ` [PATCH v2 5/5] arm64: dts: meson: g12b: w400: " Stefan Agner
2020-12-01 13:21 ` Stefan Agner
2020-12-01 13:21 ` Stefan Agner
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-05 13:14 ` [PATCH v2 1/5] arm64: dts: meson: g12b: odroid-n2: " Martin Blumenstingl
2020-12-05 13:14 ` Martin Blumenstingl
2020-12-05 13:14 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCBnqHkpQ79PVfCqJPbC3qj6v6T-HsJehffYzfaDTPxUgw@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.