From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: khilman@baylibre.com Cc: Neil Armstrong <narmstrong@baylibre.com>, jbrunet@baylibre.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, carlo@caione.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 3/3] ARM: dts: meson: switch the clock controller to the HHI register area Date: Fri, 30 Nov 2018 23:45:51 +0100 [thread overview] Message-ID: <CAFBinCCH2AOV0nJBzEdE9=rfb7d=L-Uni2gZkfdLAbLg+GkiPw@mail.gmail.com> (raw) In-Reply-To: <7h4lby5nky.fsf@baylibre.com> Hi Kevin, On Fri, Nov 30, 2018 at 9:15 PM Kevin Hilman <khilman@baylibre.com> wrote: > > Kevin Hilman <khilman@baylibre.com> writes: > > > Neil Armstrong <narmstrong@baylibre.com> writes: > > > >> On 28/10/2018 13:08, Martin Blumenstingl wrote: > >>> The clock controller on Meson8/Meson8m2 and Meson8b is part of a > >>> register region called "HHI". This register area contains more > >>> functionality than just a clock controller: > >>> - the clock controller > >>> - some reset controller bits > >>> - temperature sensor calibration data (on Meson8b and Meson8m2 only) > >>> - HDMI controller > >>> > >>> Allow access to this HHI register area as "system controller". Also > >>> migrate the Meson8 and Meson8b clock controllers to this new node. > >>> > >>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > >>> Acked-by: Neil Armstrong <narmstrong@baylibre.com> > >>> --- > >>> arch/arm/boot/dts/meson.dtsi | 7 +++++++ > >>> arch/arm/boot/dts/meson8.dtsi | 15 ++++++++------- > >>> arch/arm/boot/dts/meson8b.dtsi | 15 ++++++++------- > >>> 3 files changed, 23 insertions(+), 14 deletions(-) > >>> > >>> diff --git a/arch/arm/boot/dts/meson.dtsi b/arch/arm/boot/dts/meson.dtsi > >>> index 0d9faf1a51ea..ad903d1a2cb6 100644 > >>> --- a/arch/arm/boot/dts/meson.dtsi > >>> +++ b/arch/arm/boot/dts/meson.dtsi > >> > >> [...] > >> > >>> > >>> +&hhi { > >>> + clkc: clock-controller { > >>> + compatible = "amlogic,meson8-clkc"; > >>> + #clock-cells = <1>; > >>> + #reset-cells = <1>; > >>> + }; > >>> +}; > >>> + > >>> &hwrng { > >>> compatible = "amlogic,meson8b-rng", "amlogic,meson-rng"; > >>> clocks = <&clkc CLKID_RNG0>; > >>> > >> > >> Kevin, > >> > >> I didn't apply this one, but it can wait another cycle I think. > > > > OK, I'll take that one through my dt branch. > > > > I don't see any obvious dependency on the clock patches, > > ... and a quick boot test shows I was wrong, and should've (re)read > Martin's cover letter a couple more times. :) yes, there's a hard dependency on the clock patches > I think it's best to leave this one until the next cycle when all the > deps are merged. I have this on my "resend this for the next development cycle" list Regards Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: khilman@baylibre.com Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Neil Armstrong <narmstrong@baylibre.com>, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, carlo@caione.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, jbrunet@baylibre.com Subject: Re: [PATCH v2 3/3] ARM: dts: meson: switch the clock controller to the HHI register area Date: Fri, 30 Nov 2018 23:45:51 +0100 [thread overview] Message-ID: <CAFBinCCH2AOV0nJBzEdE9=rfb7d=L-Uni2gZkfdLAbLg+GkiPw@mail.gmail.com> (raw) In-Reply-To: <7h4lby5nky.fsf@baylibre.com> Hi Kevin, On Fri, Nov 30, 2018 at 9:15 PM Kevin Hilman <khilman@baylibre.com> wrote: > > Kevin Hilman <khilman@baylibre.com> writes: > > > Neil Armstrong <narmstrong@baylibre.com> writes: > > > >> On 28/10/2018 13:08, Martin Blumenstingl wrote: > >>> The clock controller on Meson8/Meson8m2 and Meson8b is part of a > >>> register region called "HHI". This register area contains more > >>> functionality than just a clock controller: > >>> - the clock controller > >>> - some reset controller bits > >>> - temperature sensor calibration data (on Meson8b and Meson8m2 only) > >>> - HDMI controller > >>> > >>> Allow access to this HHI register area as "system controller". Also > >>> migrate the Meson8 and Meson8b clock controllers to this new node. > >>> > >>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > >>> Acked-by: Neil Armstrong <narmstrong@baylibre.com> > >>> --- > >>> arch/arm/boot/dts/meson.dtsi | 7 +++++++ > >>> arch/arm/boot/dts/meson8.dtsi | 15 ++++++++------- > >>> arch/arm/boot/dts/meson8b.dtsi | 15 ++++++++------- > >>> 3 files changed, 23 insertions(+), 14 deletions(-) > >>> > >>> diff --git a/arch/arm/boot/dts/meson.dtsi b/arch/arm/boot/dts/meson.dtsi > >>> index 0d9faf1a51ea..ad903d1a2cb6 100644 > >>> --- a/arch/arm/boot/dts/meson.dtsi > >>> +++ b/arch/arm/boot/dts/meson.dtsi > >> > >> [...] > >> > >>> > >>> +&hhi { > >>> + clkc: clock-controller { > >>> + compatible = "amlogic,meson8-clkc"; > >>> + #clock-cells = <1>; > >>> + #reset-cells = <1>; > >>> + }; > >>> +}; > >>> + > >>> &hwrng { > >>> compatible = "amlogic,meson8b-rng", "amlogic,meson-rng"; > >>> clocks = <&clkc CLKID_RNG0>; > >>> > >> > >> Kevin, > >> > >> I didn't apply this one, but it can wait another cycle I think. > > > > OK, I'll take that one through my dt branch. > > > > I don't see any obvious dependency on the clock patches, > > ... and a quick boot test shows I was wrong, and should've (re)read > Martin's cover letter a couple more times. :) yes, there's a hard dependency on the clock patches > I think it's best to leave this one until the next cycle when all the > deps are merged. I have this on my "resend this for the next development cycle" list Regards Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2018-11-30 22:45 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-28 12:08 [PATCH v2 0/3] Meson8/Meson8b: introduce a HHI syscon node Martin Blumenstingl 2018-10-28 12:08 ` Martin Blumenstingl 2018-10-28 12:08 ` [PATCH v2 1/3] dt-bindings: clock: meson8b: use the registers from the HHI syscon Martin Blumenstingl 2018-10-28 12:08 ` Martin Blumenstingl 2018-10-28 12:08 ` [PATCH v2 2/3] clk: meson: meson8b: use the HHI syscon if available Martin Blumenstingl 2018-10-28 12:08 ` Martin Blumenstingl 2018-10-28 12:08 ` [PATCH v2 3/3] ARM: dts: meson: switch the clock controller to the HHI register area Martin Blumenstingl 2018-10-28 12:08 ` Martin Blumenstingl 2018-11-30 10:18 ` Neil Armstrong 2018-11-30 10:18 ` Neil Armstrong 2018-11-30 18:15 ` Kevin Hilman 2018-11-30 18:15 ` Kevin Hilman 2018-11-30 20:15 ` Kevin Hilman 2018-11-30 20:15 ` Kevin Hilman 2018-11-30 22:45 ` Martin Blumenstingl [this message] 2018-11-30 22:45 ` Martin Blumenstingl 2018-10-30 22:13 ` [PATCH v2 0/3] Meson8/Meson8b: introduce a HHI syscon node Rob Herring 2018-10-30 22:13 ` Rob Herring 2018-11-01 10:10 ` Martin Blumenstingl 2018-11-01 10:10 ` Martin Blumenstingl 2018-11-01 10:20 ` Chen-Yu Tsai 2018-11-01 10:20 ` Chen-Yu Tsai 2018-11-08 14:42 ` Neil Armstrong 2018-11-08 14:42 ` Neil Armstrong 2018-11-30 10:04 ` Neil Armstrong 2018-11-30 10:04 ` Neil Armstrong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFBinCCH2AOV0nJBzEdE9=rfb7d=L-Uni2gZkfdLAbLg+GkiPw@mail.gmail.com' \ --to=martin.blumenstingl@googlemail.com \ --cc=carlo@caione.org \ --cc=devicetree@vger.kernel.org \ --cc=jbrunet@baylibre.com \ --cc=khilman@baylibre.com \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mturquette@baylibre.com \ --cc=narmstrong@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.