From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: khilman@baylibre.com, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] arm64: dts: meson-axg-s400: enable USB OTG
Date: Tue, 15 Sep 2020 22:05:34 +0200 [thread overview]
Message-ID: <CAFBinCDH8sAqvaDJ=0iZ86fw30Y7Xos0vaRw6v8ECADqeJNn7Q@mail.gmail.com> (raw)
In-Reply-To: <20200909160409.8678-6-narmstrong@baylibre.com>
Hi Neil,
On Wed, Sep 9, 2020 at 6:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
[...]
> +&usb {
> + status = "okay";
> + dr_mode = "otg";
> + vbus-supply = <&usb_pwr>;
> +};
> +
> +&usb2_phy1 {
> + phy-supply = <&vcc_5v>;
out of curiosity: why do we need this phy-supply here?
isn't the usb_pwr regulator as vbus-supply above enough?
Best regards,
Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: khilman@baylibre.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 5/5] arm64: dts: meson-axg-s400: enable USB OTG
Date: Tue, 15 Sep 2020 22:05:34 +0200 [thread overview]
Message-ID: <CAFBinCDH8sAqvaDJ=0iZ86fw30Y7Xos0vaRw6v8ECADqeJNn7Q@mail.gmail.com> (raw)
In-Reply-To: <20200909160409.8678-6-narmstrong@baylibre.com>
Hi Neil,
On Wed, Sep 9, 2020 at 6:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
[...]
> +&usb {
> + status = "okay";
> + dr_mode = "otg";
> + vbus-supply = <&usb_pwr>;
> +};
> +
> +&usb2_phy1 {
> + phy-supply = <&vcc_5v>;
out of curiosity: why do we need this phy-supply here?
isn't the usb_pwr regulator as vbus-supply above enough?
Best regards,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: khilman@baylibre.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 5/5] arm64: dts: meson-axg-s400: enable USB OTG
Date: Tue, 15 Sep 2020 22:05:34 +0200 [thread overview]
Message-ID: <CAFBinCDH8sAqvaDJ=0iZ86fw30Y7Xos0vaRw6v8ECADqeJNn7Q@mail.gmail.com> (raw)
In-Reply-To: <20200909160409.8678-6-narmstrong@baylibre.com>
Hi Neil,
On Wed, Sep 9, 2020 at 6:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
[...]
> +&usb {
> + status = "okay";
> + dr_mode = "otg";
> + vbus-supply = <&usb_pwr>;
> +};
> +
> +&usb2_phy1 {
> + phy-supply = <&vcc_5v>;
out of curiosity: why do we need this phy-supply here?
isn't the usb_pwr regulator as vbus-supply above enough?
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-09-15 20:06 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 16:04 [PATCH 0/5] usb: dwc-meson-g12a: Add support for USB on S400 board Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-09 16:04 ` [PATCH 1/5] phy: amlogic: phy-meson-gxl-usb2: keep ID pull-up even in Host mode Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-15 19:53 ` Martin Blumenstingl
2020-09-15 19:53 ` Martin Blumenstingl
2020-09-15 19:53 ` Martin Blumenstingl
2020-09-09 16:04 ` [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG Families USB Glue Bindings Neil Armstrong
2020-09-09 16:04 ` [PATCH 2/5] dt-bindings: usb: amlogic, meson-g12a-usb-ctrl: " Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-15 17:32 ` Rob Herring
2020-09-15 17:32 ` Rob Herring
2020-09-15 17:32 ` Rob Herring
2020-09-15 19:56 ` [PATCH 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: " Martin Blumenstingl
2020-09-15 19:56 ` Martin Blumenstingl
2020-09-15 19:56 ` Martin Blumenstingl
2020-09-09 16:04 ` [PATCH 3/5] usb: dwc-meson-g12a: Add support for USB on AXG SoCs Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-15 19:59 ` Martin Blumenstingl
2020-09-15 19:59 ` Martin Blumenstingl
2020-09-15 19:59 ` Martin Blumenstingl
2020-09-16 7:11 ` Neil Armstrong
2020-09-16 7:11 ` Neil Armstrong
2020-09-16 7:11 ` Neil Armstrong
2020-09-09 16:04 ` [PATCH 4/5] arm64: dts: meson-axg: add USB nodes Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-15 20:04 ` Martin Blumenstingl
2020-09-15 20:04 ` Martin Blumenstingl
2020-09-15 20:04 ` Martin Blumenstingl
2020-09-16 7:10 ` Neil Armstrong
2020-09-16 7:10 ` Neil Armstrong
2020-09-16 7:10 ` Neil Armstrong
2020-09-09 16:04 ` [PATCH 5/5] arm64: dts: meson-axg-s400: enable USB OTG Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-09 16:04 ` Neil Armstrong
2020-09-15 20:05 ` Martin Blumenstingl [this message]
2020-09-15 20:05 ` Martin Blumenstingl
2020-09-15 20:05 ` Martin Blumenstingl
2020-09-16 7:09 ` Neil Armstrong
2020-09-16 7:09 ` Neil Armstrong
2020-09-16 7:09 ` Neil Armstrong
2020-09-14 17:57 ` [PATCH 0/5] usb: dwc-meson-g12a: Add support for USB on S400 board Kevin Hilman
2020-09-14 17:57 ` Kevin Hilman
2020-09-14 17:57 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCDH8sAqvaDJ=0iZ86fw30Y7Xos0vaRw6v8ECADqeJNn7Q@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.