All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oded Gabbay <oded.gabbay@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-arm-kernel@lists.infradead.org,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	Tomer Tayar <ttayar@habana.ai>
Subject: Re: [PATCH 10/20] misc: habanalabs: gaudi: gaudi_security: Repair incorrectly named function arg
Date: Mon, 29 Jun 2020 18:02:24 +0300	[thread overview]
Message-ID: <CAFCwf11L35U4u-C+rKijJbPNc9VowFOaKWKzx=ZNY4cN=EkyBg@mail.gmail.com> (raw)
In-Reply-To: <20200629140442.1043957-11-lee.jones@linaro.org>

On Mon, Jun 29, 2020 at 5:04 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> audi_pb_set_block()'s argument 'base' was incorrectly named 'block' in
gaudi_pb_set_block()'s

> its function header.
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Function parameter or member 'base' not described in 'gaudi_pb_set_block'
>  drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Excess function parameter 'block' description in 'gaudi_pb_set_block'
>
> Cc: Oded Gabbay <oded.gabbay@gmail.com>
> Cc: Tomer Tayar <ttayar@habana.ai>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/misc/habanalabs/gaudi/gaudi_security.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/gaudi/gaudi_security.c b/drivers/misc/habanalabs/gaudi/gaudi_security.c
> index 6a351e31fa6af..abdd5ed8f2cf6 100644
> --- a/drivers/misc/habanalabs/gaudi/gaudi_security.c
> +++ b/drivers/misc/habanalabs/gaudi/gaudi_security.c
> @@ -447,8 +447,7 @@ static u64 gaudi_rr_hbw_mask_high_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
>   * gaudi_set_block_as_protected - set the given block as protected
>   *
>   * @hdev: pointer to hl_device structure
> - * @block: block base address
> - *
> + * @base: block base address
>   */
>  static void gaudi_pb_set_block(struct hl_device *hdev, u64 base)
>  {
> --
> 2.25.1
>
With the above fix, This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>

WARNING: multiple messages have this Message-ID (diff)
From: Oded Gabbay <oded.gabbay@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tomer Tayar <ttayar@habana.ai>,
	linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 10/20] misc: habanalabs: gaudi: gaudi_security: Repair incorrectly named function arg
Date: Mon, 29 Jun 2020 18:02:24 +0300	[thread overview]
Message-ID: <CAFCwf11L35U4u-C+rKijJbPNc9VowFOaKWKzx=ZNY4cN=EkyBg@mail.gmail.com> (raw)
In-Reply-To: <20200629140442.1043957-11-lee.jones@linaro.org>

On Mon, Jun 29, 2020 at 5:04 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> audi_pb_set_block()'s argument 'base' was incorrectly named 'block' in
gaudi_pb_set_block()'s

> its function header.
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Function parameter or member 'base' not described in 'gaudi_pb_set_block'
>  drivers/misc/habanalabs/gaudi/gaudi_security.c:454: warning: Excess function parameter 'block' description in 'gaudi_pb_set_block'
>
> Cc: Oded Gabbay <oded.gabbay@gmail.com>
> Cc: Tomer Tayar <ttayar@habana.ai>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/misc/habanalabs/gaudi/gaudi_security.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/gaudi/gaudi_security.c b/drivers/misc/habanalabs/gaudi/gaudi_security.c
> index 6a351e31fa6af..abdd5ed8f2cf6 100644
> --- a/drivers/misc/habanalabs/gaudi/gaudi_security.c
> +++ b/drivers/misc/habanalabs/gaudi/gaudi_security.c
> @@ -447,8 +447,7 @@ static u64 gaudi_rr_hbw_mask_high_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
>   * gaudi_set_block_as_protected - set the given block as protected
>   *
>   * @hdev: pointer to hl_device structure
> - * @block: block base address
> - *
> + * @base: block base address
>   */
>  static void gaudi_pb_set_block(struct hl_device *hdev, u64 base)
>  {
> --
> 2.25.1
>
With the above fix, This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-06-29 21:29 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 14:04 [PATCH 00/20] Fix a bunch more W=1 warnings in Misc Lee Jones
2020-06-29 14:04 ` Lee Jones
2020-06-29 14:04 ` [PATCH 01/20] misc: pti: Repair kerneldoc formatting issues Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 14:04 ` [PATCH 02/20] misc: pti: Remove unparsable empty line in function header Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 14:04 ` [PATCH 03/20] misc: habanalabs: firmware_if: Add missing 'fw_name' and 'dst' entries to " Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 14:57   ` Oded Gabbay
2020-06-29 14:57     ` Oded Gabbay
2020-06-29 14:04 ` [PATCH 04/20] misc: habanalabs: pci: Fix a variety of kerneldoc issues Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 14:58   ` Oded Gabbay
2020-06-29 14:58     ` Oded Gabbay
2020-06-29 14:04 ` [PATCH 05/20] misc: habanalabs: irq: Repair kerneldoc formatting issues Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 14:59   ` Oded Gabbay
2020-06-29 14:59     ` Oded Gabbay
2020-06-29 14:04 ` [PATCH 06/20] misc: habanalabs: goya: Omit pointless check ensuring addr is >=0 Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 15:00   ` Oded Gabbay
2020-06-29 15:00     ` Oded Gabbay
2020-06-29 14:04 ` [PATCH 07/20] misc: habanalabs: pci: Scrub documentation for non-present function argument Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 15:00   ` Oded Gabbay
2020-06-29 15:00     ` Oded Gabbay
2020-06-29 14:04 ` [PATCH 08/20] misc: habanalabs: goya: goya_coresight: Remove set but unused variable 'val' Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 15:01   ` Oded Gabbay
2020-06-29 15:01     ` Oded Gabbay
2020-06-29 14:04 ` [PATCH 09/20] misc: habanalabs: gaudi: Remove ill placed asterisk from kerneldoc header Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 15:01   ` Oded Gabbay
2020-06-29 15:01     ` Oded Gabbay
2020-06-29 14:04 ` [PATCH 10/20] misc: habanalabs: gaudi: gaudi_security: Repair incorrectly named function arg Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 15:02   ` Oded Gabbay [this message]
2020-06-29 15:02     ` Oded Gabbay
2020-06-29 16:23   ` [PATCH v2 " Lee Jones
2020-06-29 16:23     ` Lee Jones
2020-06-29 14:04 ` [PATCH 11/20] misc: enclosure: Fix some kerneldoc anomalies Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 14:04 ` [PATCH 12/20] misc: lattice-ecp3-config: Remove set but clearly unused variable 'ret' Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 14:04 ` [PATCH 13/20] misc: pch_phub: Provide descriptions for 'chip' argument Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 14:04 ` [PATCH 14/20] misc: pch_phub: Remove superfluous descriptions to non-existent args 'offset_address' Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 14:04 ` [PATCH 15/20] misc: enclosure: Update enclosure_remove_device() documentation to match reality Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-29 14:04 ` [PATCH 16/20] misc: genwqe: card_base: Remove set but unused variable 'rc' Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-30  7:17   ` haver
2020-06-30  7:17     ` haver
2020-06-30  7:42     ` Lee Jones
2020-06-30  7:42       ` Lee Jones
2020-06-30  8:03       ` haver
2020-06-30  8:03         ` haver
2020-06-30  8:12         ` Lee Jones
2020-06-30  8:12           ` Lee Jones
2020-06-29 14:04 ` [PATCH 17/20] misc: genwqe: card_base: Do not pass unused argument 'fatal_err' Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-30  7:35   ` haver
2020-06-30  7:35     ` haver
2020-06-30  9:10     ` Lee Jones
2020-06-30  9:10       ` Lee Jones
2020-06-30  9:54       ` haver
2020-06-30  9:54         ` haver
2020-06-30 14:00         ` Lee Jones
2020-06-30 14:00           ` Lee Jones
2020-06-29 14:04 ` [PATCH 18/20] misc: genwqe: card_base: Whole host of kerneldoc fixes Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-30  7:24   ` haver
2020-06-30  7:24     ` haver
2020-06-29 14:04 ` [PATCH 19/20] misc: genwqe: card_dev: " Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-30  7:25   ` haver
2020-06-30  7:25     ` haver
2020-06-29 14:04 ` [PATCH 20/20] misc: genwqe: card_utils: Whole a plethora of documentation issues Lee Jones
2020-06-29 14:04   ` Lee Jones
2020-06-30  7:26   ` haver
2020-06-30  7:26     ` haver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFCwf11L35U4u-C+rKijJbPNc9VowFOaKWKzx=ZNY4cN=EkyBg@mail.gmail.com' \
    --to=oded.gabbay@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ttayar@habana.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.