* [PATCH] habanalabs: fix double assignment in MMU V1
@ 2022-11-29 11:52 Marco Pagani
2022-12-01 10:31 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Marco Pagani @ 2022-11-29 11:52 UTC (permalink / raw)
To: Oded Gabbay, Arnd Bergmann, Greg Kroah-Hartman,
Nathan Chancellor, Nick Desaulniers, Tom Rix
Cc: Marco Pagani, linux-kernel, llvm
Removing double assignment of the hop2_pte_addr
variable in dram_default_mapping_fini().
Dead store reported by clang-analyzer.
Signed-off-by: Marco Pagani <marpagan@redhat.com>
---
drivers/misc/habanalabs/common/mmu/mmu_v1.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
index 8a40de4a4761..d925dc4dd097 100644
--- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c
+++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
@@ -344,7 +344,6 @@ static void dram_default_mapping_fini(struct hl_ctx *ctx)
}
}
- hop2_pte_addr = hop2_addr;
hop2_pte_addr = hop2_addr;
for (i = 0 ; i < num_of_hop3 ; i++) {
clear_pte(ctx, hop2_pte_addr);
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] habanalabs: fix double assignment in MMU V1
2022-11-29 11:52 [PATCH] habanalabs: fix double assignment in MMU V1 Marco Pagani
@ 2022-12-01 10:31 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2022-12-01 10:31 UTC (permalink / raw)
To: Marco Pagani
Cc: Arnd Bergmann, Greg Kroah-Hartman, Nathan Chancellor,
Nick Desaulniers, Tom Rix, linux-kernel, llvm
On Tue, Nov 29, 2022 at 1:52 PM Marco Pagani <marpagan@redhat.com> wrote:
>
> Removing double assignment of the hop2_pte_addr
> variable in dram_default_mapping_fini().
>
> Dead store reported by clang-analyzer.
>
> Signed-off-by: Marco Pagani <marpagan@redhat.com>
> ---
> drivers/misc/habanalabs/common/mmu/mmu_v1.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> index 8a40de4a4761..d925dc4dd097 100644
> --- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> +++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> @@ -344,7 +344,6 @@ static void dram_default_mapping_fini(struct hl_ctx *ctx)
> }
> }
>
> - hop2_pte_addr = hop2_addr;
> hop2_pte_addr = hop2_addr;
> for (i = 0 ; i < num_of_hop3 ; i++) {
> clear_pte(ctx, hop2_pte_addr);
> --
> 2.38.1
>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next.
Thanks,
Oded
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-01 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-29 11:52 [PATCH] habanalabs: fix double assignment in MMU V1 Marco Pagani
2022-12-01 10:31 ` Oded Gabbay
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.