* [PATCH -next] misc/habanalabs: adjust Kconfig to fix build errors
@ 2019-02-26 16:42 Randy Dunlap
2019-02-26 20:59 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2019-02-26 16:42 UTC (permalink / raw)
To: LKML, Greg Kroah-Hartman, Arnd Bergmann; +Cc: Oded Gabbay
From: Randy Dunlap <rdunlap@infradead.org>
Several places in the habanalabs driver use gen_alloc functions,
so select GENERIC_ALLOCATOR to make those functions available.
Fixes these build errors:
ERROR: "gen_pool_alloc" [drivers/misc/habanalabs/habanalabs.ko] undefined!
ERROR: "gen_pool_add_virt" [drivers/misc/habanalabs/habanalabs.ko] undefined!
ERROR: "gen_pool_destroy" [drivers/misc/habanalabs/habanalabs.ko] undefined!
ERROR: "gen_pool_create" [drivers/misc/habanalabs/habanalabs.ko] undefined!
ERROR: "gen_pool_free" [drivers/misc/habanalabs/habanalabs.ko] undefined!
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Oded Gabbay <oded.gabbay@gmail.com>
---
drivers/misc/habanalabs/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20190226.orig/drivers/misc/habanalabs/Kconfig
+++ linux-next-20190226/drivers/misc/habanalabs/Kconfig
@@ -6,6 +6,7 @@ config HABANA_AI
tristate "HabanaAI accelerators (habanalabs)"
depends on PCI
select FRAME_VECTOR
+ select GENERIC_ALLOCATOR
help
Enables PCIe card driver for Habana's AI Processors (AIP) that are
designed to accelerate Deep Learning inference and training workloads.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] misc/habanalabs: adjust Kconfig to fix build errors
2019-02-26 16:42 [PATCH -next] misc/habanalabs: adjust Kconfig to fix build errors Randy Dunlap
@ 2019-02-26 20:59 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2019-02-26 20:59 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, Greg Kroah-Hartman, Arnd Bergmann
On Tue, Feb 26, 2019 at 6:42 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Several places in the habanalabs driver use gen_alloc functions,
> so select GENERIC_ALLOCATOR to make those functions available.
>
> Fixes these build errors:
>
> ERROR: "gen_pool_alloc" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_add_virt" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_destroy" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_create" [drivers/misc/habanalabs/habanalabs.ko] undefined!
> ERROR: "gen_pool_free" [drivers/misc/habanalabs/habanalabs.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Oded Gabbay <oded.gabbay@gmail.com>
> ---
> drivers/misc/habanalabs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20190226.orig/drivers/misc/habanalabs/Kconfig
> +++ linux-next-20190226/drivers/misc/habanalabs/Kconfig
> @@ -6,6 +6,7 @@ config HABANA_AI
> tristate "HabanaAI accelerators (habanalabs)"
> depends on PCI
> select FRAME_VECTOR
> + select GENERIC_ALLOCATOR
> help
> Enables PCIe card driver for Habana's AI Processors (AIP) that are
> designed to accelerate Deep Learning inference and training workloads.
>
>
Thanks for catching that.
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-26 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 16:42 [PATCH -next] misc/habanalabs: adjust Kconfig to fix build errors Randy Dunlap
2019-02-26 20:59 ` Oded Gabbay
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.