All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] accel/habanalabs: add missing debugfs function stubs
@ 2023-09-27  7:21 ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-09-27  7:21 UTC (permalink / raw)
  To: Oded Gabbay, Tomer Tayar
  Cc: Arnd Bergmann, Ofir Bitton, Stanislaw Gruszka, Ohad Sharabi,
	Dafna Hirschfeld, farah kassabri, dri-devel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Two function stubs were removed in an earlier commit but are now needed
again:

drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
drivers/accel/habanalabs/common/device.c:2231:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'drm_debugfs_dev_init'? [-Werror=implicit-function-declaration]
 2231 |         rc = hl_debugfs_device_init(hdev);
drivers/accel/habanalabs/common/device.c:2367:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
 2367 |         hl_debugfs_device_fini(hdev);
      |         ^~~~~~~~~~~~~~~~~~~~~~

Fixes: 3b9abb4fa642e ("accel/habanalabs: expose debugfs files later")
Fixes: 09fe78d2e4421 ("accel/habanalabs: register compute device as an accel device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
index 2a3acdbf91714..1655c101c7052 100644
--- a/drivers/accel/habanalabs/common/habanalabs.h
+++ b/drivers/accel/habanalabs/common/habanalabs.h
@@ -4041,6 +4041,15 @@ void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data,
 
 #else
 
+static inline int hl_debugfs_device_init(struct hl_device *hdev)
+{
+	return 0;
+}
+
+static inline void hl_debugfs_device_fini(struct hl_device *hdev)
+{
+}
+
 static inline void hl_debugfs_add_device(struct hl_device *hdev)
 {
 }
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] accel/habanalabs: add missing debugfs function stubs
@ 2023-09-27  7:21 ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-09-27  7:21 UTC (permalink / raw)
  To: Oded Gabbay, Tomer Tayar
  Cc: Ohad Sharabi, Arnd Bergmann, linux-kernel, dri-devel,
	Dafna Hirschfeld, Stanislaw Gruszka, Ofir Bitton, farah kassabri

From: Arnd Bergmann <arnd@arndb.de>

Two function stubs were removed in an earlier commit but are now needed
again:

drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
drivers/accel/habanalabs/common/device.c:2231:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'drm_debugfs_dev_init'? [-Werror=implicit-function-declaration]
 2231 |         rc = hl_debugfs_device_init(hdev);
drivers/accel/habanalabs/common/device.c:2367:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
 2367 |         hl_debugfs_device_fini(hdev);
      |         ^~~~~~~~~~~~~~~~~~~~~~

Fixes: 3b9abb4fa642e ("accel/habanalabs: expose debugfs files later")
Fixes: 09fe78d2e4421 ("accel/habanalabs: register compute device as an accel device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
index 2a3acdbf91714..1655c101c7052 100644
--- a/drivers/accel/habanalabs/common/habanalabs.h
+++ b/drivers/accel/habanalabs/common/habanalabs.h
@@ -4041,6 +4041,15 @@ void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data,
 
 #else
 
+static inline int hl_debugfs_device_init(struct hl_device *hdev)
+{
+	return 0;
+}
+
+static inline void hl_debugfs_device_fini(struct hl_device *hdev)
+{
+}
+
 static inline void hl_debugfs_add_device(struct hl_device *hdev)
 {
 }
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] accel/habanalabs: add missing debugfs function stubs
  2023-09-27  7:21 ` Arnd Bergmann
@ 2023-09-28  8:04   ` Oded Gabbay
  -1 siblings, 0 replies; 4+ messages in thread
From: Oded Gabbay @ 2023-09-28  8:04 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Tomer Tayar, Arnd Bergmann, Ofir Bitton, Stanislaw Gruszka,
	Ohad Sharabi, Dafna Hirschfeld, farah kassabri, dri-devel,
	linux-kernel

On Wed, Sep 27, 2023 at 10:22 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Two function stubs were removed in an earlier commit but are now needed
> again:
>
> drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> drivers/accel/habanalabs/common/device.c:2231:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'drm_debugfs_dev_init'? [-Werror=implicit-function-declaration]
>  2231 |         rc = hl_debugfs_device_init(hdev);
> drivers/accel/habanalabs/common/device.c:2367:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
>  2367 |         hl_debugfs_device_fini(hdev);
>       |         ^~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 3b9abb4fa642e ("accel/habanalabs: expose debugfs files later")
> Fixes: 09fe78d2e4421 ("accel/habanalabs: register compute device as an accel device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> index 2a3acdbf91714..1655c101c7052 100644
> --- a/drivers/accel/habanalabs/common/habanalabs.h
> +++ b/drivers/accel/habanalabs/common/habanalabs.h
> @@ -4041,6 +4041,15 @@ void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data,
>
>  #else
>
> +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> +{
> +       return 0;
> +}
> +
> +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> +{
> +}
> +
>  static inline void hl_debugfs_add_device(struct hl_device *hdev)
>  {
>  }
> --
> 2.39.2
>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next
Thanks,
Oded

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] accel/habanalabs: add missing debugfs function stubs
@ 2023-09-28  8:04   ` Oded Gabbay
  0 siblings, 0 replies; 4+ messages in thread
From: Oded Gabbay @ 2023-09-28  8:04 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Ohad Sharabi, Arnd Bergmann, linux-kernel, dri-devel,
	Dafna Hirschfeld, Stanislaw Gruszka, Tomer Tayar, Ofir Bitton,
	farah kassabri

On Wed, Sep 27, 2023 at 10:22 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Two function stubs were removed in an earlier commit but are now needed
> again:
>
> drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> drivers/accel/habanalabs/common/device.c:2231:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'drm_debugfs_dev_init'? [-Werror=implicit-function-declaration]
>  2231 |         rc = hl_debugfs_device_init(hdev);
> drivers/accel/habanalabs/common/device.c:2367:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
>  2367 |         hl_debugfs_device_fini(hdev);
>       |         ^~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 3b9abb4fa642e ("accel/habanalabs: expose debugfs files later")
> Fixes: 09fe78d2e4421 ("accel/habanalabs: register compute device as an accel device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> index 2a3acdbf91714..1655c101c7052 100644
> --- a/drivers/accel/habanalabs/common/habanalabs.h
> +++ b/drivers/accel/habanalabs/common/habanalabs.h
> @@ -4041,6 +4041,15 @@ void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data,
>
>  #else
>
> +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> +{
> +       return 0;
> +}
> +
> +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> +{
> +}
> +
>  static inline void hl_debugfs_add_device(struct hl_device *hdev)
>  {
>  }
> --
> 2.39.2
>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Applied to -next
Thanks,
Oded

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-28  8:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-27  7:21 [PATCH] accel/habanalabs: add missing debugfs function stubs Arnd Bergmann
2023-09-27  7:21 ` Arnd Bergmann
2023-09-28  8:04 ` Oded Gabbay
2023-09-28  8:04   ` Oded Gabbay

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.