* [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds
@ 2018-04-26 14:02 Peter Maydell
2018-04-26 14:19 ` Thomas Huth
0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2018-04-26 14:02 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Thomas Huth, Paolo Bonzini, Philippe Mathieu-Daudé
checkpatch reminds us that statics shouldn't be zero-initialized:
ERROR: do not initialise statics to 0 or NULL
#35: FILE: vl.c:157:
+static int num_serial_hds = 0;
ERROR: do not initialise statics to 0 or NULL
#36: FILE: vl.c:158:
+static Chardev **serial_hds = NULL;
I forgot to fix this in 6af2692e86f9fdfb3d; do so now.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I wouldn't bother with this except that I forgot to fold
it in when applying the serial-limits patchset.
vl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 616956adf1..6d8b869dad 100644
--- a/vl.c
+++ b/vl.c
@@ -154,8 +154,8 @@ QEMUClockType rtc_clock;
int vga_interface_type = VGA_NONE;
static DisplayOptions dpy;
int no_frame;
-static int num_serial_hds = 0;
-static Chardev **serial_hds = NULL;
+static int num_serial_hds;
+static Chardev **serial_hds;
Chardev *parallel_hds[MAX_PARALLEL_PORTS];
Chardev *virtcon_hds[MAX_VIRTIO_CONSOLES];
Chardev *sclp_hds[MAX_SCLP_CONSOLES];
--
2.17.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds
2018-04-26 14:02 [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds Peter Maydell
@ 2018-04-26 14:19 ` Thomas Huth
2018-05-29 15:25 ` Peter Maydell
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2018-04-26 14:19 UTC (permalink / raw)
To: Peter Maydell, qemu-devel, qemu-trivial
Cc: Paolo Bonzini, Philippe Mathieu-Daudé
On 26.04.2018 16:02, Peter Maydell wrote:
> checkpatch reminds us that statics shouldn't be zero-initialized:
>
> ERROR: do not initialise statics to 0 or NULL
> #35: FILE: vl.c:157:
> +static int num_serial_hds = 0;
>
> ERROR: do not initialise statics to 0 or NULL
> #36: FILE: vl.c:158:
> +static Chardev **serial_hds = NULL;
>
> I forgot to fix this in 6af2692e86f9fdfb3d; do so now.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I wouldn't bother with this except that I forgot to fold
> it in when applying the serial-limits patchset.
>
> vl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 616956adf1..6d8b869dad 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -154,8 +154,8 @@ QEMUClockType rtc_clock;
> int vga_interface_type = VGA_NONE;
> static DisplayOptions dpy;
> int no_frame;
> -static int num_serial_hds = 0;
> -static Chardev **serial_hds = NULL;
> +static int num_serial_hds;
> +static Chardev **serial_hds;
> Chardev *parallel_hds[MAX_PARALLEL_PORTS];
> Chardev *virtcon_hds[MAX_VIRTIO_CONSOLES];
> Chardev *sclp_hds[MAX_SCLP_CONSOLES];
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds
2018-04-26 14:19 ` Thomas Huth
@ 2018-05-29 15:25 ` Peter Maydell
2018-06-11 13:56 ` Peter Maydell
0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2018-05-29 15:25 UTC (permalink / raw)
To: Thomas Huth
Cc: QEMU Developers, QEMU Trivial, Paolo Bonzini,
Philippe Mathieu-Daudé
Ping for application via qemu-trivial?
thanks
-- PMM
On 26 April 2018 at 15:19, Thomas Huth <thuth@redhat.com> wrote:
> On 26.04.2018 16:02, Peter Maydell wrote:
>> checkpatch reminds us that statics shouldn't be zero-initialized:
>>
>> ERROR: do not initialise statics to 0 or NULL
>> #35: FILE: vl.c:157:
>> +static int num_serial_hds = 0;
>>
>> ERROR: do not initialise statics to 0 or NULL
>> #36: FILE: vl.c:158:
>> +static Chardev **serial_hds = NULL;
>>
>> I forgot to fix this in 6af2692e86f9fdfb3d; do so now.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> I wouldn't bother with this except that I forgot to fold
>> it in when applying the serial-limits patchset.
>>
>> vl.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index 616956adf1..6d8b869dad 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -154,8 +154,8 @@ QEMUClockType rtc_clock;
>> int vga_interface_type = VGA_NONE;
>> static DisplayOptions dpy;
>> int no_frame;
>> -static int num_serial_hds = 0;
>> -static Chardev **serial_hds = NULL;
>> +static int num_serial_hds;
>> +static Chardev **serial_hds;
>> Chardev *parallel_hds[MAX_PARALLEL_PORTS];
>> Chardev *virtcon_hds[MAX_VIRTIO_CONSOLES];
>> Chardev *sclp_hds[MAX_SCLP_CONSOLES];
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds
2018-05-29 15:25 ` Peter Maydell
@ 2018-06-11 13:56 ` Peter Maydell
2018-06-22 12:58 ` Peter Maydell
0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2018-06-11 13:56 UTC (permalink / raw)
To: Thomas Huth
Cc: QEMU Developers, QEMU Trivial, Paolo Bonzini,
Philippe Mathieu-Daudé
Ping^2 for qemu-trivial?
thanks
-- PMM
On 29 May 2018 at 16:25, Peter Maydell <peter.maydell@linaro.org> wrote:
> Ping for application via qemu-trivial?
>
> thanks
> -- PMM
>
> On 26 April 2018 at 15:19, Thomas Huth <thuth@redhat.com> wrote:
>> On 26.04.2018 16:02, Peter Maydell wrote:
>>> checkpatch reminds us that statics shouldn't be zero-initialized:
>>>
>>> ERROR: do not initialise statics to 0 or NULL
>>> #35: FILE: vl.c:157:
>>> +static int num_serial_hds = 0;
>>>
>>> ERROR: do not initialise statics to 0 or NULL
>>> #36: FILE: vl.c:158:
>>> +static Chardev **serial_hds = NULL;
>>>
>>> I forgot to fix this in 6af2692e86f9fdfb3d; do so now.
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>> ---
>>> I wouldn't bother with this except that I forgot to fold
>>> it in when applying the serial-limits patchset.
>>>
>>> vl.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/vl.c b/vl.c
>>> index 616956adf1..6d8b869dad 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -154,8 +154,8 @@ QEMUClockType rtc_clock;
>>> int vga_interface_type = VGA_NONE;
>>> static DisplayOptions dpy;
>>> int no_frame;
>>> -static int num_serial_hds = 0;
>>> -static Chardev **serial_hds = NULL;
>>> +static int num_serial_hds;
>>> +static Chardev **serial_hds;
>>> Chardev *parallel_hds[MAX_PARALLEL_PORTS];
>>> Chardev *virtcon_hds[MAX_VIRTIO_CONSOLES];
>>> Chardev *sclp_hds[MAX_SCLP_CONSOLES];
>>>
>>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds
2018-06-11 13:56 ` Peter Maydell
@ 2018-06-22 12:58 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2018-06-22 12:58 UTC (permalink / raw)
To: Thomas Huth
Cc: QEMU Developers, QEMU Trivial, Paolo Bonzini,
Philippe Mathieu-Daudé
On 11 June 2018 at 14:56, Peter Maydell <peter.maydell@linaro.org> wrote:
> Ping^2 for qemu-trivial?
Gave up and threw it into the latest target-arm pullreq :-)
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-22 12:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 14:02 [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds Peter Maydell
2018-04-26 14:19 ` Thomas Huth
2018-05-29 15:25 ` Peter Maydell
2018-06-11 13:56 ` Peter Maydell
2018-06-22 12:58 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.