[Qemu-devel] [PULL] TCG queued patch

[Qemu-devel] [PULL] TCG queued patch

[Richard Henderson]

Only one this week.  Pranith didn't mention which compiler version,
but I can imagine gcc7 or clang warning of such a thing.


r~


The following changes since commit e7c83a885f865128ae3cf1946f8cb538b63cbfba:

  vhost-user: delay vhost_user_stop (2017-02-28 19:11:15 +0000)

are available in the git repository at:

  git://github.com/rth7680/qemu.git tags/pull-tcg-20170301

for you to fetch changes up to dc1eccd661ada3b746ca4438e444993c36a0f04f:

  aarch64: Change ext type to TCGType to fix warnings (2017-03-01 08:28:06 +1100)

----------------------------------------------------------------
Queued TCG patch

----------------------------------------------------------------
Pranith Kumar (1):
      aarch64: Change ext type to TCGType to fix warnings

 tcg/aarch64/tcg-target.inc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[Qemu-devel] [PULL] aarch64: Change ext type to TCGType to fix warnings

[Richard Henderson]

From: Pranith Kumar <bobby.prani@gmail.com>

To fix the following warnings:

In file included from /users/pranith/qemu/tcg/tcg.c:255:
/users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:879:24: warning: implicit conversion from enumeration type 'TCGMemOp' (aka 'enum TCGMemOp') to different enumeration type 'TCGType' (aka 'enum TCGType')
      [-Wenum-conversion]
        tcg_out_cmp(s, ext, a, b, b_const);
        ~~~~~~~~~~~    ^~~
/users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:893:36: warning: implicit conversion from enumeration type 'TCGMemOp' (aka 'enum TCGMemOp') to different enumeration type 'TCGType' (aka 'enum TCGType')
      [-Wenum-conversion]
        tcg_out_insn(s, 3201, CBZ, ext, a, offset);
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
/users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:389:65: note: expanded from macro 'tcg_out_insn'
    glue(tcg_out_insn_,FMT)(S, glue(glue(glue(I,FMT),_),OP), ## __VA_ARGS__)
                                                                ^
/users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:895:37: warning: implicit conversion from enumeration type 'TCGMemOp' (aka 'enum TCGMemOp') to different enumeration type 'TCGType' (aka 'enum TCGType')
      [-Wenum-conversion]
        tcg_out_insn(s, 3201, CBNZ, ext, a, offset);
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
/users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:389:65: note: expanded from macro 'tcg_out_insn'
    glue(tcg_out_insn_,FMT)(S, glue(glue(glue(I,FMT),_),OP), ## __VA_ARGS__)
                                                                ^
/users/pranith/qemu/tcg/aarch64/tcg-target.inc.c:1610:27: warning: implicit conversion from enumeration type 'TCGType' (aka 'enum TCGType') to different enumeration type 'TCGMemOp' (aka 'enum TCGMemOp')
      [-Wenum-conversion]
        tcg_out_brcond(s, ext, a2, a0, a1, const_args[1], arg_label(args[3]));
        ~~~~~~~~~~~~~~    ^~~

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Message-Id: <20170217154311.13920-1-bobby.prani@gmail.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 tcg/aarch64/tcg-target.inc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c
index 6d227a5..290de6d 100644
--- a/tcg/aarch64/tcg-target.inc.c
+++ b/tcg/aarch64/tcg-target.inc.c
@@ -866,7 +866,7 @@ static inline void tcg_out_goto_label(TCGContext *s, TCGLabel *l)
     }
 }
 
-static void tcg_out_brcond(TCGContext *s, TCGMemOp ext, TCGCond c, TCGArg a,
+static void tcg_out_brcond(TCGContext *s, TCGType ext, TCGCond c, TCGArg a,
                            TCGArg b, bool b_const, TCGLabel *l)
 {
     intptr_t offset;
@@ -937,7 +937,7 @@ static void tcg_out_addsubi(TCGContext *s, int ext, TCGReg rd,
     }
 }
 
-static inline void tcg_out_addsub2(TCGContext *s, int ext, TCGReg rl,
+static inline void tcg_out_addsub2(TCGContext *s, TCGType ext, TCGReg rl,
                                    TCGReg rh, TCGReg al, TCGReg ah,
                                    tcg_target_long bl, tcg_target_long bh,
                                    bool const_bl, bool const_bh, bool sub)
-- 
2.9.3

Re: [Qemu-devel] [PULL] TCG queued patch

[Pranith Kumar]

On Tue, Feb 28, 2017 at 4:33 PM, Richard Henderson <rth@twiddle.net> wrote:
> Only one this week.  Pranith didn't mention which compiler version,
> but I can imagine gcc7 or clang warning of such a thing.
>

I apologize for missing this information in the patch. The warning was
from clang master.

Thanks,
--
Pranith

Re: [Qemu-devel] [PULL] TCG queued patch

[Peter Maydell]

On 28 February 2017 at 21:33, Richard Henderson <rth@twiddle.net> wrote:
> Only one this week.  Pranith didn't mention which compiler version,
> but I can imagine gcc7 or clang warning of such a thing.
>
>
> r~
>
>
> The following changes since commit e7c83a885f865128ae3cf1946f8cb538b63cbfba:
>
>   vhost-user: delay vhost_user_stop (2017-02-28 19:11:15 +0000)
>
> are available in the git repository at:
>
>   git://github.com/rth7680/qemu.git tags/pull-tcg-20170301
>
> for you to fetch changes up to dc1eccd661ada3b746ca4438e444993c36a0f04f:
>
>   aarch64: Change ext type to TCGType to fix warnings (2017-03-01 08:28:06 +1100)
>
> ----------------------------------------------------------------
> Queued TCG patch
>
> ----------------------------------------------------------------
> Pranith Kumar (1):
>       aarch64: Change ext type to TCGType to fix warnings
>
>  tcg/aarch64/tcg-target.inc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL] tcg queued patch

[Peter Maydell]

On 26 April 2017 at 18:30, Richard Henderson <rth@twiddle.net> wrote:
> Fixes a tcg_error when building with clang on some hosts.
>
>
> r~
>
>
> The following changes since commit 51b9d495f2a99c65c9e524c8f6fe283ebfabae1d:
>
>   Revert "COLO-compare: Optimize tcp compare trace event" (2017-04-26 16:19:27 +0100)
>
> are available in the git repository at:
>
>   git://github.com/rth7680/qemu.git tags/pull-tcg-20170426
>
> for you to fetch changes up to 79b1af906245558c30e0a5faf26cb52b63f83cce:
>
>   tcg: Initialize return value after exit_atomic (2017-04-26 19:26:11 +0200)
>
> ----------------------------------------------------------------
> Fix for exit_atomic tcg opcode paths
>
> ----------------------------------------------------------------
> Richard Henderson (1):
>       tcg: Initialize return value after exit_atomic
>
>  tcg/tcg-op.c | 6 ++++++
>  1 file changed, 6 insertions(+)


Applied, thanks.

-- PMM

[Qemu-devel] [PULL] tcg queued patch

[Richard Henderson]

Fixes a tcg_error when building with clang on some hosts.


r~


The following changes since commit 51b9d495f2a99c65c9e524c8f6fe283ebfabae1d:

  Revert "COLO-compare: Optimize tcp compare trace event" (2017-04-26 16:19:27 +0100)

are available in the git repository at:

  git://github.com/rth7680/qemu.git tags/pull-tcg-20170426

for you to fetch changes up to 79b1af906245558c30e0a5faf26cb52b63f83cce:

  tcg: Initialize return value after exit_atomic (2017-04-26 19:26:11 +0200)

----------------------------------------------------------------
Fix for exit_atomic tcg opcode paths

----------------------------------------------------------------
Richard Henderson (1):
      tcg: Initialize return value after exit_atomic

 tcg/tcg-op.c | 6 ++++++
 1 file changed, 6 insertions(+)