[PATCH 1/1] hw: virt: consider hw_compat_6_0

[PATCH 1/1] hw: virt: consider hw_compat_6_0

[Heinrich Schuchardt]

virt-6.0 must consider hw_compat_6_0.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 hw/arm/virt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 840758666d..8bc3b408fe 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2764,6 +2764,8 @@ DEFINE_VIRT_MACHINE_AS_LATEST(6, 1)

 static void virt_machine_6_0_options(MachineClass *mc)
 {
+    virt_machine_6_1_options(mc);
+    compat_props_add(mc->compat_props, hw_compat_6_0, hw_compat_6_0_len);
 }
 DEFINE_VIRT_MACHINE(6, 0)

--
2.30.2

Re: [PATCH 1/1] hw: virt: consider hw_compat_6_0

[Cornelia Huck]

On Thu, Jun 10 2021, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:

> virt-6.0 must consider hw_compat_6_0.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  hw/arm/virt.c | 2 ++
>  1 file changed, 2 insertions(+)

Oops, forgot that hunk.

Fixes: da7e13c00b59 ("hw: add compat machines for 6.1")

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

Re: [PATCH 1/1] hw: virt: consider hw_compat_6_0

[Peter Maydell]

On Fri, 11 Jun 2021 at 08:32, Cornelia Huck <cohuck@redhat.com> wrote:
>
> On Thu, Jun 10 2021, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> > virt-6.0 must consider hw_compat_6_0.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > ---
> >  hw/arm/virt.c | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Oops, forgot that hunk.
>
> Fixes: da7e13c00b59 ("hw: add compat machines for 6.1")
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>



Applied to target-arm.next, thanks.

-- PMM

Re: [PATCH 1/1] hw: virt: consider hw_compat_6_0

[Heinrich Schuchardt]

On 6/14/21 5:35 PM, Peter Maydell wrote:
> On Fri, 11 Jun 2021 at 08:32, Cornelia Huck <cohuck@redhat.com> wrote:
>>
>> On Thu, Jun 10 2021, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>>
>>> virt-6.0 must consider hw_compat_6_0.
>>>
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>> ---
>>>   hw/arm/virt.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>
>> Oops, forgot that hunk.
>>
>> Fixes: da7e13c00b59 ("hw: add compat machines for 6.1")
>>
>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>
>
>
> Applied to target-arm.next, thanks.

Thanks for accepting the patch.

File MAINTAINERS does not indicate for section "Virt" where the relevant
git repository is located.

I assume that you relate to
https://git.linaro.org/people/pmaydell/qemu-arm.git
But I can't find the patch there. Do you still have to push?

Please, add 'T:' entries in MAINTAINERS for the sub-systems that you
maintain.

Best regards

Heinrich

>
> -- PMM
>

Re: [PATCH 1/1] hw: virt: consider hw_compat_6_0

[Peter Maydell]

On Mon, 14 Jun 2021 at 17:25, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> File MAINTAINERS does not indicate for section "Virt" where the relevant
> git repository is located.
>
> I assume that you relate to
> https://git.linaro.org/people/pmaydell/qemu-arm.git
> But I can't find the patch there. Do you still have to push?
>
> Please, add 'T:' entries in MAINTAINERS for the sub-systems that you
> maintain.

I don't maintain the target-arm tree like that. I accumulate
patches locally, and only push the git branch to a publicly
visible location at the point where I've finalised what's going
in my next pullrequest and I'm sending out the pullreq emails.
So providing a T: location would be of no use to anybody, as the
tree would always be stale.

-- PMM