All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Johannes S <johannes.stoelp@googlemail.com>
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
	"Johannes Stölp" <johannes.stoelp@gmail.com>,
	"Eric Blake" <eblake@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v0] kvm: unsigned datatype in ioctl wrapper
Date: Mon, 30 Aug 2021 21:14:28 +0100	[thread overview]
Message-ID: <CAFEAcA-PSg6puCy95bskoFzq1a0F60O43cAkz=k73SXLZxO0nQ@mail.gmail.com> (raw)
In-Reply-To: <CAMnW+q_6Vd0os7AEVVyM30m1kzev_3j8MWusXV1kp6jmUmRqcg@mail.gmail.com>

On Mon, 30 Aug 2021 at 20:37, Johannes S <johannes.stoelp@googlemail.com> wrote:
> In my opinion we should use 'unsigned' data types here for the ioctl
> request in the ioctl wrappers or would you prefer to keep the ioctl
> wrapper definition as is today? What is you opinion?

I think I would vote for following the type used by the ioctl()
function as declared in the headers for both Linux and the BSDs,
and using 'unsigned long'.
(We should change KVMState::irq_set_ioctl too, to match.)

-- PMM


  reply	other threads:[~2021-08-30 20:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 19:39 [PATCH v0] kvm: unsigned datatype in ioctl wrapper johannst
2021-08-13 17:39 ` Johannes Stoelp
2021-08-29 20:19   ` Johannes Stoelp
2021-08-29 21:09 ` Peter Maydell
2021-08-30 15:47   ` Eric Blake
2021-08-30 17:33     ` Peter Maydell
2021-08-30 18:50       ` Ed Maste
2021-08-30 19:37       ` Johannes S
2021-08-30 20:14         ` Peter Maydell [this message]
2021-09-01 20:23           ` Johannes S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-PSg6puCy95bskoFzq1a0F60O43cAkz=k73SXLZxO0nQ@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=eblake@redhat.com \
    --cc=johannes.stoelp@gmail.com \
    --cc=johannes.stoelp@googlemail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.