Re: [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue

Re: [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue

[Peter Maydell]

On 25 April 2017 at 14:18, Kamil Rytarowski <n54@gmx.com> wrote:
> Appease pkgsrc and use portable shell variable comparison.
> This switches "==" to "=". It should not be a functional change.
>
> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
> ---

Thanks for this patch; it's an easy bug to let slip in
if your /bin/sh happens to be bash.

PS: you forgot to cc qemu-devel@ on this patch.

>  scripts/qemu-binfmt-conf.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
> index 0f1aa63872..8afc3eb5bb 100755
> --- a/scripts/qemu-binfmt-conf.sh
> +++ b/scripts/qemu-binfmt-conf.sh
> @@ -284,12 +284,12 @@ while true ; do
>          shift
>          # check given cpu is in the supported CPU list
>          for cpu in ${qemu_target_list} ; do
> -            if [ "$cpu" == "$1" ] ; then
> +            if [ "$cpu" = "$1" ] ; then
>                  break
>              fi
>          done
>
> -        if [ "$cpu" == "$1" ] ; then
> +        if [ "$cpu" = "$1" ] ; then
>              qemu_target_list="$1"
>          else
>              echo "ERROR: unknown CPU \"$1\"" 1>&2
> --
> 2.12.2

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Re: [Qemu-devel] [Qemu-trivial] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue

[Kamil Rytarowski]

[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]

On 25.04.2017 15:33, Peter Maydell wrote:
> On 25 April 2017 at 14:18, Kamil Rytarowski <n54@gmx.com> wrote:
>> Appease pkgsrc and use portable shell variable comparison.
>> This switches "==" to "=". It should not be a functional change.
>>
>> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
>> ---
> 
> Thanks for this patch; it's an easy bug to let slip in
> if your /bin/sh happens to be bash.
> 
> PS: you forgot to cc qemu-devel@ on this patch.
> 

I assumed that qemu-trivial@ don't need to go to qemu-devel@. Thank you
for pointing it out.

>>  scripts/qemu-binfmt-conf.sh | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
>> index 0f1aa63872..8afc3eb5bb 100755
>> --- a/scripts/qemu-binfmt-conf.sh
>> +++ b/scripts/qemu-binfmt-conf.sh
>> @@ -284,12 +284,12 @@ while true ; do
>>          shift
>>          # check given cpu is in the supported CPU list
>>          for cpu in ${qemu_target_list} ; do
>> -            if [ "$cpu" == "$1" ] ; then
>> +            if [ "$cpu" = "$1" ] ; then
>>                  break
>>              fi
>>          done
>>
>> -        if [ "$cpu" == "$1" ] ; then
>> +        if [ "$cpu" = "$1" ] ; then
>>              qemu_target_list="$1"
>>          else
>>              echo "ERROR: unknown CPU \"$1\"" 1>&2
>> --
>> 2.12.2
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> thanks
> -- PMM
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [Qemu-trivial] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

On 04/25/2017 08:50 AM, Kamil Rytarowski wrote:
> On 25.04.2017 15:33, Peter Maydell wrote:
>> On 25 April 2017 at 14:18, Kamil Rytarowski <n54@gmx.com> wrote:
>>> Appease pkgsrc and use portable shell variable comparison.
>>> This switches "==" to "=". It should not be a functional change.
>>>
>>> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
>>> ---
>>
>> Thanks for this patch; it's an easy bug to let slip in
>> if your /bin/sh happens to be bash.
>>
>> PS: you forgot to cc qemu-devel@ on this patch.
>>
> 
> I assumed that qemu-trivial@ don't need to go to qemu-devel@. Thank you
> for pointing it out.

ALL patches need to go to qemu-devel (so we have a one-stop-shop for all
pending patches), but some patches need to additionally go to secondary
lists for catching the attention of the right maintainers.

scripts/get_maintainer.pl is your friend, and it should always list
qemu-devel in its answer.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [Qemu-trivial] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue

[Laurent Vivier]

On 25/04/2017 15:33, Peter Maydell wrote:
> On 25 April 2017 at 14:18, Kamil Rytarowski <n54@gmx.com> wrote:
>> Appease pkgsrc and use portable shell variable comparison.
>> This switches "==" to "=". It should not be a functional change.
>>
>> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
>> ---
> 
> Thanks for this patch; it's an easy bug to let slip in
> if your /bin/sh happens to be bash.
> 
> PS: you forgot to cc qemu-devel@ on this patch.
> 
>>  scripts/qemu-binfmt-conf.sh | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
>> index 0f1aa63872..8afc3eb5bb 100755
>> --- a/scripts/qemu-binfmt-conf.sh
>> +++ b/scripts/qemu-binfmt-conf.sh
>> @@ -284,12 +284,12 @@ while true ; do
>>          shift
>>          # check given cpu is in the supported CPU list
>>          for cpu in ${qemu_target_list} ; do
>> -            if [ "$cpu" == "$1" ] ; then
>> +            if [ "$cpu" = "$1" ] ; then
>>                  break
>>              fi
>>          done
>>
>> -        if [ "$cpu" == "$1" ] ; then
>> +        if [ "$cpu" = "$1" ] ; then
>>              qemu_target_list="$1"
>>          else
>>              echo "ERROR: unknown CPU \"$1\"" 1>&2
>> --
>> 2.12.2
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

Re: [Qemu-devel] [PATCH] scripts/qemu-binfmt-conf.sh: Fix shell portability issue

[Michael Tokarev]

25.04.2017 16:18, Kamil Rytarowski wrote:
> Appease pkgsrc and use portable shell variable comparison.
> This switches "==" to "=". It should not be a functional change.

Applied to -trivial, thanks!

/mjt

> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
> ---
>  scripts/qemu-binfmt-conf.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
> index 0f1aa63872..8afc3eb5bb 100755
> --- a/scripts/qemu-binfmt-conf.sh
> +++ b/scripts/qemu-binfmt-conf.sh
> @@ -284,12 +284,12 @@ while true ; do
>          shift
>          # check given cpu is in the supported CPU list
>          for cpu in ${qemu_target_list} ; do
> -            if [ "$cpu" == "$1" ] ; then
> +            if [ "$cpu" = "$1" ] ; then
>                  break
>              fi
>          done
>  
> -        if [ "$cpu" == "$1" ] ; then
> +        if [ "$cpu" = "$1" ] ; then
>              qemu_target_list="$1"
>          else
>              echo "ERROR: unknown CPU \"$1\"" 1>&2
>