All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL v2 00/32] pc, pci, virtio: new features, cleanups, fixes
Date: Wed, 15 Jun 2016 16:11:30 +0100	[thread overview]
Message-ID: <CAFEAcA-YZzidOD456=efnbdq+hiTavyRykY35E12GoTb_s3Xpg@mail.gmail.com> (raw)
In-Reply-To: <20160614225933-mutt-send-email-mst@redhat.com>

On 14 June 2016 at 20:59, Michael S. Tsirkin <mst@redhat.com> wrote:
> changes from v1:
>     - fixed up build on 32 bit
>     - fixed up build on old glibc
>
> Peter, I could not reproduce the issue with noipmi that
> you reported. Could it be a merge artifact?
> I rebased to latest master to help avoid these.

No, this still fails on every machine and config I test on.

I suggest you just fix this to use the stub machinery
which we already know works, rather than trying to
debug whatever's going wrong with what you're trying.

Also, format string issues:

/home/petmay01/qemu/hw/acpi/nvdimm.c: In function 'nvdimm_rw_label_data_check':
/home/petmay01/qemu/hw/acpi/nvdimm.c:568:9: error: format '%lx'
expects argument of type 'long unsigned int', but arg
ument 4 has type 'uint64_t' [-Werror=format=]
         nvdimm_debug("position %#x is beyond label data (len = %#lx).\n",
         ^

thanks
-- PMM

  reply	other threads:[~2016-06-15 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 19:59 [Qemu-devel] [PULL v2 00/32] pc, pci, virtio: new features, cleanups, fixes Michael S. Tsirkin
2016-06-15 15:11 ` Peter Maydell [this message]
2016-06-17  0:31   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-YZzidOD456=efnbdq+hiTavyRykY35E12GoTb_s3Xpg@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.