[Qemu-devel] [PULL v2 00/32] pc, pci, virtio: new features, cleanups, fixes

[Qemu-devel] [PULL v2 00/32] pc, pci, virtio: new features, cleanups, fixes

[Michael S. Tsirkin]

changes from v1:
    - fixed up build on 32 bit
    - fixed up build on old glibc

Peter, I could not reproduce the issue with noipmi that
you reported. Could it be a merge artifact?
I rebased to latest master to help avoid these.

The following changes since commit c02d7030c3c538312c7f464cb79b72c29a20df74:

  virtio: move bi-endian target support to a single location (2016-06-07 15:39:28 +0300)

are available in the git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

for you to fetch changes up to a7169339256cfa1fa6e021ca48617a40e3c0e717:

  MAINTAINERS: add Marcel to PCI (2016-06-14 21:47:47 +0300)

----------------------------------------------------------------
pc, pci, virtio: new features, cleanups, fixes

This includes ipmi smbios tables.
Beginning of reconnect support for vhost-user.
NVDIMM label support.
Misc cleanups and fixes.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Cao jin (3):
      pci core: assert ENOSPC when add capability
      fix some coding style problems
      msi_init: change return value to 0 on success

Corey Minyard (4):
      smbios: Move table build tools into an include file.
      ipmi: Add SMBIOS table entry
      acpi: Add IPMI table entries
      bios: Add tests for the IPMI ACPI and SMBIOS entries

Marc-André Lureau (8):
      tests/vhost-user-bridge: add client mode
      tests/vhost-user-bridge: workaround stale vring base
      vhost-user: disconnect on start failure
      vhost-net: do not crash if backend is not present
      vhost-net: save & restore vhost-user acked features
      vhost-net: save & restore vring enable state
      tests: append i386 tests
      test: start vhost-user reconnect test

Michael S. Tsirkin (1):
      MAINTAINERS: add Marcel to PCI

Peter Xu (1):
      pci: fix pci_requester_id()

Tetsuya Mukawa (2):
      vhost-user: add ability to know vhost-user backend disconnection
      qemu-char: add qemu_chr_disconnect to close a fd accepted by listen fd

Xiao Guangrong (13):
      pc-dimm: introduce get_vmstate_memory_region callback
      nvdimm: support nvdimm label
      acpi: add aml_object_type
      acpi: add aml_call5
      nvdimm acpi: set HDLE properly
      nvdimm acpi: save arg3 of _DSM method
      nvdimm acpi: check UUID
      nvdimm acpi: abstract the operations for root & nvdimm devices
      nvdimm acpi: check revision
      nvdimm acpi: support Get Namespace Label Size function
      nvdimm acpi: support Get Namespace Label Data function
      nvdimm acpi: support Set Namespace Label Data function
      docs: add NVDIMM ACPI documentation

 hw/smbios/smbios_build.h             |  87 ++++++++
 include/hw/acpi/aml-build.h          |   3 +
 include/hw/acpi/ipmi.h               |  22 ++
 include/hw/mem/nvdimm.h              |  55 ++++-
 include/hw/mem/pc-dimm.h             |   5 +-
 include/hw/pci/pci.h                 |  26 ++-
 include/hw/smbios/ipmi.h             |  15 ++
 include/net/net.h                    |   1 +
 include/net/vhost-user.h             |   1 +
 include/net/vhost_net.h              |   3 +
 include/sysemu/char.h                |   7 +
 hw/acpi/aml-build.c                  |  22 ++
 hw/acpi/ipmi.c                       | 105 +++++++++
 hw/acpi/noipmi.c                     |  14 ++
 hw/acpi/nvdimm.c                     | 400 ++++++++++++++++++++++++++++++++---
 hw/i386/acpi-build.c                 |  12 ++
 hw/i386/kvm/pci-assign.c             |   2 +-
 hw/mem/nvdimm.c                      | 132 ++++++++++++
 hw/mem/pc-dimm.c                     |  14 +-
 hw/net/vhost_net.c                   |  45 +++-
 hw/net/vmxnet3.c                     |   2 +-
 hw/pci-bridge/ioh3420.c              |   7 +-
 hw/pci-bridge/pci_bridge_dev.c       |   4 +
 hw/pci-bridge/xio3130_downstream.c   |   6 +-
 hw/pci-bridge/xio3130_upstream.c     |   3 +
 hw/pci/msi.c                         |  18 +-
 hw/pci/pci.c                         |  82 ++++++-
 hw/smbios/no_smbios_type_38.c        |  14 ++
 hw/smbios/smbios.c                   |  72 +------
 hw/smbios/smbios_type_38.c           | 117 ++++++++++
 net/vhost-user.c                     |  32 ++-
 qemu-char.c                          |   8 +
 tests/bios-tables-test.c             |  60 +++++-
 tests/vhost-user-bridge.c            |  51 +++--
 tests/vhost-user-test.c              | 136 ++++++++++--
 MAINTAINERS                          |   1 +
 docs/specs/acpi_nvdimm.txt           | 132 ++++++++++++
 hw/acpi/Makefile.objs                |   2 +
 hw/smbios/Makefile.objs              |   2 +
 tests/Makefile                       |   2 +-
 tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 0 -> 5575 bytes
 tests/acpi-test-data/q35/DSDT.ipmibt | Bin 0 -> 8340 bytes
 42 files changed, 1571 insertions(+), 151 deletions(-)
 create mode 100644 hw/smbios/smbios_build.h
 create mode 100644 include/hw/acpi/ipmi.h
 create mode 100644 include/hw/smbios/ipmi.h
 create mode 100644 hw/acpi/ipmi.c
 create mode 100644 hw/acpi/noipmi.c
 create mode 100644 hw/smbios/no_smbios_type_38.c
 create mode 100644 hw/smbios/smbios_type_38.c
 create mode 100644 docs/specs/acpi_nvdimm.txt
 create mode 100644 tests/acpi-test-data/pc/DSDT.ipmikcs
 create mode 100644 tests/acpi-test-data/q35/DSDT.ipmibt

Re: [Qemu-devel] [PULL v2 00/32] pc, pci, virtio: new features, cleanups, fixes

[Peter Maydell]

On 14 June 2016 at 20:59, Michael S. Tsirkin <mst@redhat.com> wrote:
> changes from v1:
>     - fixed up build on 32 bit
>     - fixed up build on old glibc
>
> Peter, I could not reproduce the issue with noipmi that
> you reported. Could it be a merge artifact?
> I rebased to latest master to help avoid these.

No, this still fails on every machine and config I test on.

I suggest you just fix this to use the stub machinery
which we already know works, rather than trying to
debug whatever's going wrong with what you're trying.

Also, format string issues:

/home/petmay01/qemu/hw/acpi/nvdimm.c: In function 'nvdimm_rw_label_data_check':
/home/petmay01/qemu/hw/acpi/nvdimm.c:568:9: error: format '%lx'
expects argument of type 'long unsigned int', but arg
ument 4 has type 'uint64_t' [-Werror=format=]
         nvdimm_debug("position %#x is beyond label data (len = %#lx).\n",
         ^

thanks
-- PMM

Re: [Qemu-devel] [PULL v2 00/32] pc, pci, virtio: new features, cleanups, fixes

[Michael S. Tsirkin]

On Wed, Jun 15, 2016 at 04:11:30PM +0100, Peter Maydell wrote:
> On 14 June 2016 at 20:59, Michael S. Tsirkin <mst@redhat.com> wrote:
> > changes from v1:
> >     - fixed up build on 32 bit
> >     - fixed up build on old glibc
> >
> > Peter, I could not reproduce the issue with noipmi that
> > you reported. Could it be a merge artifact?
> > I rebased to latest master to help avoid these.
> 
> No, this still fails on every machine and config I test on.
> 
> I suggest you just fix this to use the stub machinery
> which we already know works, rather than trying to
> debug whatever's going wrong with what you're trying.
> 
> Also, format string issues:
> 
> /home/petmay01/qemu/hw/acpi/nvdimm.c: In function 'nvdimm_rw_label_data_check':
> /home/petmay01/qemu/hw/acpi/nvdimm.c:568:9: error: format '%lx'
> expects argument of type 'long unsigned int', but arg
> ument 4 has type 'uint64_t' [-Werror=format=]
>          nvdimm_debug("position %#x is beyond label data (len = %#lx).\n",
>          ^
> 
> thanks
> -- PMM

I dropped these patchsets from pull request for now.
Submitters, pls fix it up and resubmit.

Thanks!

-- 
MST