[Qemu-devel] [PATCH] hw/char/cmsdk-apb-uart.c: Accept more input after character read

[Qemu-devel] [PATCH] hw/char/cmsdk-apb-uart.c: Accept more input after character read

[Patrick Oppenlander]

The character frontend needs to be notified that the uart receive buffer
is empty and ready to handle another character.

Previously, the uart only worked correctly when receiving one character
at a time.

Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
---
 hw/char/cmsdk-apb-uart.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/char/cmsdk-apb-uart.c b/hw/char/cmsdk-apb-uart.c
index 9c0929d8a2..ddfbb25c24 100644
--- a/hw/char/cmsdk-apb-uart.c
+++ b/hw/char/cmsdk-apb-uart.c
@@ -157,6 +157,7 @@ static uint64_t uart_read(void *opaque, hwaddr
offset, unsigned size)
         r = s->rxbuf;
         s->state &= ~R_STATE_RXFULL_MASK;
         cmsdk_apb_uart_update(s);
+        qemu_chr_fe_accept_input(&s->chr);
         break;
     case A_STATE:
         r = s->state;
-- 
2.17.0

Re: [Qemu-devel] [PATCH] hw/char/cmsdk-apb-uart.c: Accept more input after character read

[Peter Maydell]

On 20 April 2018 at 00:50, Patrick Oppenlander
<patrick.oppenlander@gmail.com> wrote:
> The character frontend needs to be notified that the uart receive buffer
> is empty and ready to handle another character.
>
> Previously, the uart only worked correctly when receiving one character
> at a time.
>
> Signed-off-by: Patrick Oppenlander <patrick.oppenlander@gmail.com>
> ---
>  hw/char/cmsdk-apb-uart.c | 1 +
>  1 file changed, 1 insertion(+)

Oops. Thanks for the patch, applied to target-arm.next.

-- PMM