All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines
@ 2018-01-30 13:10 BALATON Zoltan
  2018-01-30 13:19 ` Peter Maydell
  2018-01-30 19:49 ` David Gibson
  0 siblings, 2 replies; 5+ messages in thread
From: BALATON Zoltan @ 2018-01-30 13:10 UTC (permalink / raw)
  To: qemu-devel, qemu-trivial; +Cc: David Gibson

This matches what other files do for qemu includes

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/ide/sii3112.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c
index 17aa930..e3896c6 100644
--- a/hw/ide/sii3112.c
+++ b/hw/ide/sii3112.c
@@ -12,8 +12,8 @@
  * http://wiki.osdev.org/User:Quok/Silicon_Image_Datasheets
  */
 
-#include <qemu/osdep.h>
-#include <hw/ide/pci.h>
+#include "qemu/osdep.h"
+#include "hw/ide/pci.h"
 #include "trace.h"
 
 #define TYPE_SII3112_PCI "sii3112"
-- 
2.7.6

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines
  2018-01-30 13:10 [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines BALATON Zoltan
@ 2018-01-30 13:19 ` Peter Maydell
  2018-01-30 19:49 ` David Gibson
  1 sibling, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2018-01-30 13:19 UTC (permalink / raw)
  To: BALATON Zoltan; +Cc: QEMU Developers, QEMU Trivial, David Gibson

On 30 January 2018 at 13:10, BALATON Zoltan <balaton@eik.bme.hu> wrote:
> This matches what other files do for qemu includes
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines
  2018-01-30 13:10 [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines BALATON Zoltan
  2018-01-30 13:19 ` Peter Maydell
@ 2018-01-30 19:49 ` David Gibson
  2018-02-01 11:51   ` BALATON Zoltan
  1 sibling, 1 reply; 5+ messages in thread
From: David Gibson @ 2018-01-30 19:49 UTC (permalink / raw)
  To: BALATON Zoltan; +Cc: qemu-devel, qemu-trivial

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]

On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote:
> This matches what other files do for qemu includes
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Applied, thanks.

> ---
>  hw/ide/sii3112.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c
> index 17aa930..e3896c6 100644
> --- a/hw/ide/sii3112.c
> +++ b/hw/ide/sii3112.c
> @@ -12,8 +12,8 @@
>   * http://wiki.osdev.org/User:Quok/Silicon_Image_Datasheets
>   */
>  
> -#include <qemu/osdep.h>
> -#include <hw/ide/pci.h>
> +#include "qemu/osdep.h"
> +#include "hw/ide/pci.h"
>  #include "trace.h"
>  
>  #define TYPE_SII3112_PCI "sii3112"

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines
  2018-01-30 19:49 ` David Gibson
@ 2018-02-01 11:51   ` BALATON Zoltan
  2018-02-08 23:29     ` David Gibson
  0 siblings, 1 reply; 5+ messages in thread
From: BALATON Zoltan @ 2018-02-01 11:51 UTC (permalink / raw)
  To: David Gibson; +Cc: qemu-devel, qemu-trivial

On Wed, 31 Jan 2018, David Gibson wrote:
> On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote:
>> This matches what other files do for qemu includes
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>
> Applied, thanks.

Thanks but Markus instead included this in his cleanup patches here:
http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg00075.html
so you can drop this from your tree now.

Regards,
BALATON Zoltan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines
  2018-02-01 11:51   ` BALATON Zoltan
@ 2018-02-08 23:29     ` David Gibson
  0 siblings, 0 replies; 5+ messages in thread
From: David Gibson @ 2018-02-08 23:29 UTC (permalink / raw)
  To: BALATON Zoltan; +Cc: qemu-devel, qemu-trivial

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

On Thu, Feb 01, 2018 at 12:51:04PM +0100, BALATON Zoltan wrote:
> On Wed, 31 Jan 2018, David Gibson wrote:
> > On Tue, Jan 30, 2018 at 02:10:10PM +0100, BALATON Zoltan wrote:
> > > This matches what other files do for qemu includes
> > > 
> > > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> > 
> > Applied, thanks.
> 
> Thanks but Markus instead included this in his cleanup patches here:
> http://lists.nongnu.org/archive/html/qemu-devel/2018-02/msg00075.html
> so you can drop this from your tree now.

Ok, done.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-02-08 23:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-30 13:10 [Qemu-devel] [PATCH] sii3112: Change angle brackets to quotes in #include lines BALATON Zoltan
2018-01-30 13:19 ` Peter Maydell
2018-01-30 19:49 ` David Gibson
2018-02-01 11:51   ` BALATON Zoltan
2018-02-08 23:29     ` David Gibson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.